204669 2019-11-28 02:03:29 -0800 [GStreamer] Simplify GL display/context ref handling 2021-04-14 09:23:25 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 204624 1 pnormand webkit-unassigned annulen calvaris cgarcia eric.carlson ews-watchlist glenn gustavo gyuyoung.kim jbedard jer.noble menard philipj ryuan.choi sergio vjaquez oldest_to_newest 1593979 0 pnormand 2019-11-28 02:03:29 -0800 +++ This bug was initially created as a clone of Bug #204624 +++ > Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:151 > + // The floating ref removal support was added in https://bugzilla.gnome.org/show_bug.cgi?id=743062. > + bool shouldAdoptRef = webkitGstCheckVersion(1, 14, 0); I think we could simplify the code by adding adoptGLRef() or something like that, similar to ensureGRef, that only accepts GstGLDisplay org GstGLContext and adopts the returned ref or not depending on the GST version. 1593981 1 pnormand 2019-11-28 02:04:10 -0800 > Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:252 > +#if GST_CHECK_VERSION(1, 12, 0) > + gst_structure_set(structure, "context", GST_TYPE_GL_CONTEXT, priv->glContext.get(), nullptr); > +#else > + gst_structure_set(structure, "context", GST_GL_TYPE_CONTEXT, priv->glContext.get(), nullptr); > +#endif Follow up or not, I think we could #define this above and have just one line here. 1750156 2 pnormand 2021-04-14 09:23:25 -0700 Since we now require at least gst 1.14 this is no longer a concern.