204661 2019-11-27 19:54:18 -0800 [WebKit] Fix compilation warnings for MSVC 2019-12-05 18:01:22 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham cdumez cgarcia don.olmstead ews-watchlist pvollan ross.kirsling webkit-bug-importer wilander oldest_to_newest 1593948 0 fujii 2019-11-27 19:54:18 -0800 [WebKit] Fix compilation warnings for MSVC > WebKit\NetworkProcess\Classifier\WebResourceLoadStatisticsTelemetry.cpp(285) : warning C4715: 'WebKit::makeDescription': not all control paths return a value > WebKit\NetworkProcess\cache\NetworkCacheIOChannelCurl.cpp(50) : warning C4701: potentially uninitialized local variable 'mode' used > WebKit\NetworkProcess\Classifier\ResourceLoadStatisticsDatabaseStore.cpp(946) : warning C4715: 'WebKit::makeStatisticQuery': not all control paths return a value > WebKit\NetworkProcess\Classifier\ResourceLoadStatisticsDatabaseStore.cpp(896) : warning C4701: potentially uninitialized local variable 'median' used > WebKit\NetworkProcess\Classifier\ResourceLoadStatisticsDatabaseStore.cpp(755) : warning C4715: 'WebKit::buildQueryStartAndEnd': not all control paths return a value > WebKit\NetworkProcess/NetworkResourceLoader.cpp(594): warning C4245: 'argument': conversion from 'int' to 'size_t', signed/unsigned mismatch > WebKit\NetworkProcess\NetworkResourceLoader.cpp(345) : warning C4701: potentially uninitialized local variable 'code' used > WebKit\UIProcess/WebURLSchemeTask.cpp(137): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied > WebKit\UIProcess/WebURLSchemeTask.cpp(137): note: while calling the constructor 'IPC::SharedBufferDataReference::SharedBufferDataReference(const WebCore::SharedBuffer &)' > WebKit\Platform\IPC\SharedBufferDataReference.h(37): note: see declaration of 'IPC::SharedBufferDataReference::SharedBufferDataReference' > WebKit\UIProcess\WebPageProxy.cpp(7231) : warning C4701: potentially uninitialized local variable 'error' used > WebKit\Shared\API\c\WKSharedAPICast.h(863) : warning C4701: potentially uninitialized local variable 'wkType' used > WebKit\WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp(87): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied > WebKit\WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp(87): note: while calling the constructor 'IPC::SharedBufferDataReference::SharedBufferDataReference(const WebCore::SharedBuffer &)' > WebKit\Platform\IPC\SharedBufferDataReference.h(37): note: see declaration of 'IPC::SharedBufferDataReference::SharedBufferDataReference' > WebKit\WebProcess/WebCoreSupport/WebEditorClient.cpp(167): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied > WebKit\WebProcess/WebCoreSupport/WebEditorClient.cpp(167): note: while calling the constructor 'IPC::SharedBufferDataReference::SharedBufferDataReference(const WebCore::SharedBuffer &)' > WebKit\Platform\IPC\SharedBufferDataReference.h(37): note: see declaration of 'IPC::SharedBufferDataReference::SharedBufferDataReference' 1593953 1 384436 fujii 2019-11-27 20:27:34 -0800 Created attachment 384436 Patch 1595662 2 fujii 2019-12-04 17:41:40 -0800 review? 1595663 3 384436 wilander 2019-12-04 17:46:35 -0800 Comment on attachment 384436 Patch The ITP related changes (the ones under NetworkProcess/Classifier/) look fine. 1596141 4 384436 fujii 2019-12-05 18:00:03 -0800 Comment on attachment 384436 Patch Clearing flags on attachment: 384436 Committed r253195: <https://trac.webkit.org/changeset/253195> 1596142 5 fujii 2019-12-05 18:00:06 -0800 All reviewed patches have been landed. Closing bug. 1596143 6 webkit-bug-importer 2019-12-05 18:01:22 -0800 <rdar://problem/57684914> 384436 2019-11-27 20:27:34 -0800 2019-12-05 18:00:03 -0800 Patch bug-204661-20191128132732.patch text/plain 9857 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyOTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDliZTU3OTZjYWQ3NjYzYTVh OWY0OTgwZDA0MmQ2YWUyZjM4MjFiYmYuLmRjMjkwNDljMGVlOGZkODc5NGFkZGZmYzJkZjMxOGI1 Yzc1YjU3YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTktMTEtMjcgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dlYktpdF0gRml4 IGNvbXBpbGF0aW9uIHdhcm5pbmdzIGZvciBNU1ZDCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ2NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBiZWhhdmlvciBjaGFuZ2VzLgorCisgICAgICAgICog TmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VT dG9yZS5jcHA6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9XZWJSZXNvdXJj ZUxvYWRTdGF0aXN0aWNzVGVsZW1ldHJ5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6bWFrZURlc2Ny aXB0aW9uKToKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIu Y3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmNsZWFudXApOgor ICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZUlPQ2hhbm5lbEN1cmwu Y3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OklPQ2hhbm5lbDo6SU9DaGFubmVs KToKKyAgICAgICAgKiBTaGFyZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0Lmg6CisgICAgICAgIChX ZWJLaXQ6OnRvQVBJKToKKyAgICAgICAgKFdlYktpdDo6dG9EaWFnbm9zdGljTG9nZ2luZ1Jlc3Vs dFR5cGUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJVUkxTY2hlbWVUYXNrLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViVVJMU2NoZW1lVGFzazo6ZGlkUmVjZWl2ZURhdGEpOgorICAgICAgICAq IFdlYlByb2Nlc3MvU3RvcmFnZS9XZWJTZXJ2aWNlV29ya2VyRmV0Y2hUYXNrQ2xpZW50LmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViU2VydmljZVdvcmtlckZldGNoVGFza0NsaWVudDo6ZGlkUmVj ZWl2ZURhdGEpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9y Q2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRWRpdG9yQ2xpZW50OjpyZWdpc3RlckF0 dGFjaG1lbnRJZGVudGlmaWVyKToKKwogMjAxOS0xMS0yNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBu b3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV2ViSW5zcGVjdG9yXSBVc2UgQ1N0 cmluZyB0byBzdG9yZSBleHBvcnRlZCBkYXRhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3Rv cmUuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNl TG9hZFN0YXRpc3RpY3NEYXRhYmFzZVN0b3JlLmNwcAppbmRleCBjYzIwZGE3ODA3YzQ4OTc2YTgx MTNlMjVhNTBmZGVhOGNmYTY5OWQ5Li4wOTUwYTIwNDAzZjZjODRiMDc0N2RlN2VmMDI4ZGJhZmZk MzcyYmIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZp ZXIvUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0 YWJhc2VTdG9yZS5jcHAKQEAgLTc5Nyw2ICs3OTcsNyBAQCBzdGF0aWMgc3RkOjpwYWlyPFN0cmlu Z1ZpZXcsIFN0cmluZ1ZpZXc+IGJ1aWxkUXVlcnlTdGFydEFuZEVuZChQcmV2YWxlbnRSZXNvdXJj ZQogICAgICAgICBMT0dfRVJST1IoIlJlc291cmNlTG9hZFN0YXRpc3RpY3NEYXRhYmFzZVN0b3Jl OjptYWtlTWVkaWFuV2l0aG91dFVJUXVlcnkgd2FzIGNhbGxlZCBmb3IgYW4gaW5jb3JyZWN0IHN0 YXRpc3RpYywgdW5kZXRlcm1pbmVkIHF1ZXJ5IGJlaGF2aW9yIHdpbGwgcmVzdWx0LiIpOwogICAg ICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0KKyAgICByZXR1cm4geyB9 OwogfQogCiBzdGF0aWMgU1FMaXRlU3RhdGVtZW50IG1ha2VNZWRpYW5XaXRob3V0VUlRdWVyeShT UUxpdGVEYXRhYmFzZSYgZGF0YWJhc2UsIFByZXZhbGVudFJlc291cmNlRGF0YWJhc2VUZWxlbWV0 cnk6OlN0YXRpc3RpYyBzdGF0aXN0aWMpCkBAIC05MjMsNyArOTI0LDcgQEAgc3RhdGljIHVuc2ln bmVkIGdldE1lZGlhbk9mUHJldmFsZW50UmVzb3VyY2VXaXRob3V0VXNlckludGVyYWN0aW9uKFNR TGl0ZURhdGFiYXMKICAgICBpZiAobnVtYmVyT2ZQcmV2YWxlbnRSZXNvdXJjZXNXaXRob3V0VUkg PCBidWNrZXRTaXplKQogICAgICAgICByZXR1cm4gMDsKIAotICAgIHVuc2lnbmVkIG1lZGlhbjsK KyAgICB1bnNpZ25lZCBtZWRpYW4gPSAwOwogICAgIFNRTGl0ZVN0YXRlbWVudCBnZXRNZWRpYW5T dGF0aXN0aWMgPSBtYWtlTWVkaWFuV2l0aG91dFVJUXVlcnkoZGF0YWJhc2UsIHN0YXRpc3RpYyk7 CiAKICAgICBpZiAoZ2V0TWVkaWFuU3RhdGlzdGljLnByZXBhcmUoKSA9PSBTUUxJVEVfT0spIHsK QEAgLTk4OCw2ICs5ODksOCBAQCBzdGF0aWMgdW5zaWduZWQgbWFrZVN0YXRpc3RpY1F1ZXJ5KFNR TGl0ZURhdGFiYXNlJiBkYXRhYmFzZSwgUHJldmFsZW50UmVzb3VyY2VEYQogICAgIGNhc2UgUHJl dmFsZW50UmVzb3VyY2VEYXRhYmFzZVRlbGVtZXRyeTo6U3RhdGlzdGljOjpNZWRpYW5UaW1lc0Fj Y2Vzc2VkRHVlVG9TdG9yYWdlQWNjZXNzQVBJV2l0aG91dFVJOgogICAgICAgICByZXR1cm4gZ2V0 TWVkaWFuT2ZQcmV2YWxlbnRSZXNvdXJjZVdpdGhvdXRVc2VySW50ZXJhY3Rpb24oZGF0YWJhc2Us IGJ1Y2tldFNpemUsIHN0YXRpc3RpYywgdG90YWxXaXRob3V0VUkpOwogICAgIH0KKyAgICBBU1NF UlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gMDsKIH0KIAogdW5zaWduZWQgUmVzb3VyY2VM b2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmU6OmdldE51bWJlck9mUHJldmFsZW50UmVzb3VyY2Vz V2l0aG91dFVJKCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvQ2xhc3NpZmllci9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGVsZW1ldHJ5LmNwcCBiL1Nv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9XZWJSZXNvdXJjZUxvYWRTdGF0 aXN0aWNzVGVsZW1ldHJ5LmNwcAppbmRleCBiOWU5ZjVlZmZkYWE5MTJjMzA2YWQyNGUxZDVhNmQ1 MWViODQxYTc5Li5hYWVhMjQ3MjhiMzlhYjI3NTAxMGFjY2RiMWExNTU3OTNjMGRlYzQ4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvV2ViUmVzb3Vy Y2VMb2FkU3RhdGlzdGljc1RlbGVtZXRyeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9DbGFzc2lmaWVyL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NUZWxlbWV0cnkuY3Bw CkBAIC0yODIsNiArMjgyLDggQEAgc3RhdGljIFN0cmluZ1ZpZXcgbWFrZURlc2NyaXB0aW9uKFBy ZXZhbGVudFJlc291cmNlRGF0YWJhc2VUZWxlbWV0cnk6OlN0YXRpc3RpYwogICAgIGNhc2UgUHJl dmFsZW50UmVzb3VyY2VEYXRhYmFzZVRlbGVtZXRyeTo6U3RhdGlzdGljOjpNZWRpYW5UaW1lc0Fj Y2Vzc2VkRHVlVG9TdG9yYWdlQWNjZXNzQVBJV2l0aG91dFVJOgogICAgICAgICByZXR1cm4gIk51 bWJlck9mVGltZXNBY2Nlc3NlZEFzRmlyc3RQYXJ0eUR1ZVRvU3RvcmFnZUFjY2Vzc0FQSSI7CiAg ICAgfQorICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiB7IH07CiB9CiAKIHN0 YXRpYyB2b2lkIGRhdGFiYXNlU3VibWl0VG9wTGlzdHMoY29uc3QgUHJldmFsZW50UmVzb3VyY2VE YXRhYmFzZVRlbGVtZXRyeSYgdGVsZW1ldHJ5LCBjb25zdCBXZWJSZXNvdXJjZUxvYWRTdGF0aXN0 aWNzU3RvcmUmIHN0b3JlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwCmluZGV4IDQyMDg2YTAzNmY0ZGZhNTJmNzlmYmU5 ODJlMzg5Y2M5YjhlOGM0ZDMuLmI2YWVjNWI2NDg1MTVmZjlhZmU2MDYyYWE3YzJlNjNhZWZkNWU1 NjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291 cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtS ZXNvdXJjZUxvYWRlci5jcHAKQEAgLTMyNyw3ICszMjcsNyBAQCB2b2lkIE5ldHdvcmtSZXNvdXJj ZUxvYWRlcjo6Y2xlYW51cChMb2FkUmVzdWx0IHJlc3VsdCkKIHsKICAgICBBU1NFUlQoUnVuTG9v cDo6aXNNYWluKCkpOwogCi0gICAgTmV0d29ya0FjdGl2aXR5VHJhY2tlcjo6Q29tcGxldGlvbkNv ZGUgY29kZTsKKyAgICBOZXR3b3JrQWN0aXZpdHlUcmFja2VyOjpDb21wbGV0aW9uQ29kZSBjb2Rl IHsgfTsKICAgICBzd2l0Y2ggKHJlc3VsdCkgewogICAgIGNhc2UgTG9hZFJlc3VsdDo6VW5rbm93 bjoKICAgICAgICAgY29kZSA9IE5ldHdvcmtBY3Rpdml0eVRyYWNrZXI6OkNvbXBsZXRpb25Db2Rl OjpVbmRlZmluZWQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2Nh Y2hlL05ldHdvcmtDYWNoZUlPQ2hhbm5lbEN1cmwuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVJT0NoYW5uZWxDdXJsLmNwcAppbmRleCBmM2M4Zjkz ZjAwYmU0NTRhMzNiZmU4MTg3ZDUzNmU2ZTE4YmExN2FkLi4wM2VlMWIwODdkZmNlN2M5Yjg5YmJm MzM3MjliOWVjMDQ1YWE5MWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL2NhY2hlL05ldHdvcmtDYWNoZUlPQ2hhbm5lbEN1cmwuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlSU9DaGFubmVsQ3VybC5jcHAKQEAg LTM1LDcgKzM1LDcgQEAgSU9DaGFubmVsOjpJT0NoYW5uZWwoY29uc3QgU3RyaW5nJiBmaWxlUGF0 aCwgVHlwZSB0eXBlKQogICAgIDogbV9wYXRoKGZpbGVQYXRoKQogICAgICwgbV90eXBlKHR5cGUp CiB7Ci0gICAgRmlsZVN5c3RlbTo6RmlsZU9wZW5Nb2RlIG1vZGU7CisgICAgRmlsZVN5c3RlbTo6 RmlsZU9wZW5Nb2RlIG1vZGUgeyB9OwogICAgIHN3aXRjaCAodHlwZSkgewogICAgIGNhc2UgVHlw ZTo6UmVhZDoKICAgICAgICAgbW9kZSA9IEZpbGVTeXN0ZW06OkZpbGVPcGVuTW9kZTo6UmVhZDsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2FzdC5o IGIvU291cmNlL1dlYktpdC9TaGFyZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0LmgKaW5kZXggMThj Y2ViMjExYjI2MzFhZGY3YWRiOGE0NzQ0M2VkNDllMzg2ZWYzMC4uYTUzNmI2YTJjZGY1MDFkMGIx M2VkMGU1ZThkNTk1MGEyNzEyYzBhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQv QVBJL2MvV0tTaGFyZWRBUElDYXN0LmgKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvQVBJL2Mv V0tTaGFyZWRBUElDYXN0LmgKQEAgLTg0Niw3ICs4NDYsNyBAQCBpbmxpbmUgU2FtZURvY3VtZW50 TmF2aWdhdGlvblR5cGUgdG9TYW1lRG9jdW1lbnROYXZpZ2F0aW9uVHlwZShXS1NhbWVEb2N1bWVu dE5hdgogCiBpbmxpbmUgV0tEaWFnbm9zdGljTG9nZ2luZ1Jlc3VsdFR5cGUgdG9BUEkoV2ViQ29y ZTo6RGlhZ25vc3RpY0xvZ2dpbmdSZXN1bHRUeXBlIHR5cGUpCiB7Ci0gICAgV0tEaWFnbm9zdGlj TG9nZ2luZ1Jlc3VsdFR5cGUgd2tUeXBlOworICAgIFdLRGlhZ25vc3RpY0xvZ2dpbmdSZXN1bHRU eXBlIHdrVHlwZSB7IH07CiAKICAgICBzd2l0Y2ggKHR5cGUpIHsKICAgICBjYXNlIFdlYkNvcmU6 OkRpYWdub3N0aWNMb2dnaW5nUmVzdWx0UGFzczoKQEAgLTg2NSw3ICs4NjUsNyBAQCBpbmxpbmUg V0tEaWFnbm9zdGljTG9nZ2luZ1Jlc3VsdFR5cGUgdG9BUEkoV2ViQ29yZTo6RGlhZ25vc3RpY0xv Z2dpbmdSZXN1bHRUeXBlCiAKIGlubGluZSBXZWJDb3JlOjpEaWFnbm9zdGljTG9nZ2luZ1Jlc3Vs dFR5cGUgdG9EaWFnbm9zdGljTG9nZ2luZ1Jlc3VsdFR5cGUoV0tEaWFnbm9zdGljTG9nZ2luZ1Jl c3VsdFR5cGUgd2tUeXBlKQogewotICAgIFdlYkNvcmU6OkRpYWdub3N0aWNMb2dnaW5nUmVzdWx0 VHlwZSB0eXBlOworICAgIFdlYkNvcmU6OkRpYWdub3N0aWNMb2dnaW5nUmVzdWx0VHlwZSB0eXBl IHsgfTsKIAogICAgIHN3aXRjaCAod2tUeXBlKSB7CiAgICAgY2FzZSBrV0tEaWFnbm9zdGljTG9n Z2luZ1Jlc3VsdFBhc3M6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApp bmRleCA4MWI2NWM2ZTJkYjFkODAxYjdjM2U1Njc1MTY3NWFhZjZjNzhmZDc4Li4wNjc2MjRiOGQ5 YTZjYTc2YzhjMGEyOWJmNTJkZTA4ZmJjZTNiMzEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAKQEAgLTcyMTYsNyArNzIxNiw3IEBAIHZvaWQgV2ViUGFnZVByb3h5 OjpyZXNldFN0YXRlKFJlc2V0U3RhdGVSZWFzb24gcmVzZXRTdGF0ZVJlYXNvbikKICAgICBtX2Vk aXRhYmxlSW1hZ2VDb250cm9sbGVyID0gbnVsbHB0cjsKICNlbmRpZgogCi0gICAgQ2FsbGJhY2tC YXNlOjpFcnJvciBlcnJvcjsKKyAgICBDYWxsYmFja0Jhc2U6OkVycm9yIGVycm9yIHsgfTsKICAg ICBzd2l0Y2ggKHJlc2V0U3RhdGVSZWFzb24pIHsKICAgICBjYXNlIFJlc2V0U3RhdGVSZWFzb246 Ok5hdmlnYXRpb25Td2FwOgogICAgICAgICBGQUxMVEhST1VHSDsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlVSTFNjaGVtZVRhc2suY3BwIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2ViVVJMU2NoZW1lVGFzay5jcHAKaW5kZXggMjdhM2RiNTRmOWIxMmRlMWI3OTc0 MzMwZjI1YzY3YTI0NjI5YjdiNy4uZGI4YjJhOThmYjQ4MjRjYjk2N2IyZjZlMzJjMmZjYTQ0MzU0 NDE3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViVVJMU2NoZW1lVGFz ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViVVJMU2NoZW1lVGFzay5jcHAK QEAgLTEzNCw3ICsxMzQsNyBAQCBhdXRvIFdlYlVSTFNjaGVtZVRhc2s6OmRpZFJlY2VpdmVEYXRh KFJlZjxTaGFyZWRCdWZmZXI+JiYgYnVmZmVyKSAtPiBFeGNlcHRpb25UeQogICAgICAgICByZXR1 cm4gRXhjZXB0aW9uVHlwZTo6Tm9uZTsKICAgICB9CiAKLSAgICBtX3Byb2Nlc3MtPnNlbmQoTWVz c2FnZXM6OldlYlBhZ2U6OlVSTFNjaGVtZVRhc2tEaWRSZWNlaXZlRGF0YShtX3VybFNjaGVtZUhh bmRsZXItPmlkZW50aWZpZXIoKSwgbV9pZGVudGlmaWVyLCB7IGJ1ZmZlciB9KSwgbV93ZWJQYWdl SUQpOworICAgIG1fcHJvY2Vzcy0+c2VuZChNZXNzYWdlczo6V2ViUGFnZTo6VVJMU2NoZW1lVGFz a0RpZFJlY2VpdmVEYXRhKG1fdXJsU2NoZW1lSGFuZGxlci0+aWRlbnRpZmllcigpLCBtX2lkZW50 aWZpZXIsIGJ1ZmZlci5nZXQoKSksIG1fd2ViUGFnZUlEKTsKICAgICByZXR1cm4gRXhjZXB0aW9u VHlwZTo6Tm9uZTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1N0 b3JhZ2UvV2ViU2VydmljZVdvcmtlckZldGNoVGFza0NsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvU3RvcmFnZS9XZWJTZXJ2aWNlV29ya2VyRmV0Y2hUYXNrQ2xpZW50LmNwcApp bmRleCAyNjQ0YzljMWQxMmI2Y2QwMWQ1NjY5OWQxMzJiYzJlZjRjNjM2YTE5Li4zNGU4NmMxMWUy NDg2YzdhMTYwMzZkN2I0NjhmYjc4ZDI3NThmZDYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvU3RvcmFnZS9XZWJTZXJ2aWNlV29ya2VyRmV0Y2hUYXNrQ2xpZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvU3RvcmFnZS9XZWJTZXJ2aWNlV29ya2VyRmV0 Y2hUYXNrQ2xpZW50LmNwcApAQCAtODQsNyArODQsNyBAQCB2b2lkIFdlYlNlcnZpY2VXb3JrZXJG ZXRjaFRhc2tDbGllbnQ6OmRpZFJlY2VpdmVEYXRhKFJlZjxTaGFyZWRCdWZmZXI+JiYgYnVmZmVy KQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgbV9jb25uZWN0aW9uLT5zZW5kKE1lc3Nh Z2VzOjpTZXJ2aWNlV29ya2VyRmV0Y2hUYXNrOjpEaWRSZWNlaXZlRGF0YSB7IHsgYnVmZmVyIH0s IHN0YXRpY19jYXN0PGludDY0X3Q+KGJ1ZmZlci0+c2l6ZSgpKSB9LCBtX2ZldGNoSWRlbnRpZmll cik7CisgICAgbV9jb25uZWN0aW9uLT5zZW5kKE1lc3NhZ2VzOjpTZXJ2aWNlV29ya2VyRmV0Y2hU YXNrOjpEaWRSZWNlaXZlRGF0YSB7IGJ1ZmZlci5nZXQoKSwgc3RhdGljX2Nhc3Q8aW50NjRfdD4o YnVmZmVyLT5zaXplKCkpIH0sIG1fZmV0Y2hJZGVudGlmaWVyKTsKIH0KIAogdm9pZCBXZWJTZXJ2 aWNlV29ya2VyRmV0Y2hUYXNrQ2xpZW50OjpkaWRSZWNlaXZlRm9ybURhdGFBbmRGaW5pc2goUmVm PEZvcm1EYXRhPiYmIGZvcm1EYXRhKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkVkaXRvckNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcAppbmRleCAyNzQ2MjA1 ODJjMmYyZmExOTdmNWY2ODJlMDdjM2E3M2EyNzU1ZTg4Li4xZDgzYjA5NzY5ZjMwMDdjNzU3ZTJj NjQyYWMyMzBkNzA2ZTcxZWNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv V2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcApAQCAtMTY0LDcgKzE2 NCw3IEBAIGJvb2wgV2ViRWRpdG9yQ2xpZW50OjpzaG91bGRBcHBseVN0eWxlKFN0eWxlUHJvcGVy dGllcyogc3R5bGUsIFJhbmdlKiByYW5nZSkKIAogdm9pZCBXZWJFZGl0b3JDbGllbnQ6OnJlZ2lz dGVyQXR0YWNobWVudElkZW50aWZpZXIoY29uc3QgU3RyaW5nJiBpZGVudGlmaWVyLCBjb25zdCBT dHJpbmcmIGNvbnRlbnRUeXBlLCBjb25zdCBTdHJpbmcmIHByZWZlcnJlZEZpbGVOYW1lLCBSZWY8 U2hhcmVkQnVmZmVyPiYmIGRhdGEpCiB7Ci0gICAgbV9wYWdlLT5zZW5kKE1lc3NhZ2VzOjpXZWJQ YWdlUHJveHk6OlJlZ2lzdGVyQXR0YWNobWVudElkZW50aWZpZXJGcm9tRGF0YShpZGVudGlmaWVy LCBjb250ZW50VHlwZSwgcHJlZmVycmVkRmlsZU5hbWUsIHsgZGF0YSB9KSk7CisgICAgbV9wYWdl LT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OlJlZ2lzdGVyQXR0YWNobWVudElkZW50aWZp ZXJGcm9tRGF0YShpZGVudGlmaWVyLCBjb250ZW50VHlwZSwgcHJlZmVycmVkRmlsZU5hbWUsIGRh dGEuZ2V0KCkpKTsKIH0KIAogdm9pZCBXZWJFZGl0b3JDbGllbnQ6OnJlZ2lzdGVyQXR0YWNobWVu dHMoVmVjdG9yPFdlYkNvcmU6OlNlcmlhbGl6ZWRBdHRhY2htZW50RGF0YT4mJiBkYXRhKQo=