20466 2008-08-20 15:10:30 -0700 Editing a property without quotes should add them if possible 2008-08-21 09:36:23 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 rik webkit-unassigned oldest_to_newest 88947 0 rik 2008-08-20 15:10:30 -0700 When editing a string property, people may not add quotes. After trying the expression entered, the inspector should try again with quotes. 88950 1 22902 rik 2008-08-20 15:17:06 -0700 Created attachment 22902 Proposed patch 88954 2 22902 timothy 2008-08-20 15:26:30 -0700 Comment on attachment 22902 Proposed patch + var result = WebInspector.panels.scripts.evaluateInSelectedCallFrame(expression, false); + else + var result = InspectorController.inspectedWindow().eval(expression); + return result; no need to store in a variable, just return in the two places. + var result = this.evaluateExpression("(" + expression + ")"); // Store the result in the property. this.parentObject[this.propertyName] = result; Put a empty line between the var result and the comment. + var result = this.evaluateExpression('"' + expression + '"'); + // Store the result in the property. + this.parentObject[this.propertyName] = result; You should escape double quotes in the expression, otherwise it will fail unexpectedly. Also put a empty line between the var result and the comment. r- for now until the string is escaped. Just do expression.escapeCharacters("\""); 88983 3 22916 rik 2008-08-20 18:12:08 -0700 Created attachment 22916 Comments adressed 89008 4 timothy 2008-08-21 09:36:23 -0700 Landed in r35874. 22902 2008-08-20 15:17:06 -0700 2008-08-20 18:12:08 -0700 Proposed patch plop.patch text/plain 3631 rik SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTg2MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDgtMDgtMjAgIEFudGhvbnkgUmljYXVkICA8cmlrMjRkQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8 aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDY2PiBFZGl0aW5nIGEg cHJvcGVydHkgd2l0aG91dCBxdW90ZXMgc2hvdWxkIGFkZCB0aGVtIGlmIHBvc3NpYmxlCisKKyAg ICAgICAgQWZ0ZXIgdHJ5aW5nIHRvIGFkZCB0aGUgZXhwcmVzc2lvbiwgdHJ5IGFnYWluIHdpdGgg cXVvdGVzIGZvciBlYXNpZXIgZWRpdGlvbi4KKworICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL09i amVjdFByb3BlcnRpZXNTZWN0aW9uLmpzOiBBZGRlZCBhbiBldmFsdWF0ZUV4cHJlc3Npb24gZnVu Y3Rpb24KKwogMjAwOC0wOC0yMCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0CkluZGV4OiBXZWJDb3JlL3BhZ2Uv aW5zcGVjdG9yL09iamVjdFByb3BlcnRpZXNTZWN0aW9uLmpzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGFnZS9pbnNwZWN0b3IvT2JqZWN0UHJvcGVydGllc1NlY3Rpb24uanMJKHJldmlzaW9uIDM1 ODYyKQorKysgV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9PYmplY3RQcm9wZXJ0aWVzU2VjdGlvbi5q cwkod29ya2luZyBjb3B5KQpAQCAtMjE0LDYgKzIxNCwxNyBAQCBXZWJJbnNwZWN0b3IuT2JqZWN0 UHJvcGVydHlUcmVlRWxlbWVudC5wCiAgICAgICAgIHRoaXMuZWRpdGluZ0VuZGVkKGNvbnRleHQp OwogICAgIH0sCiAKKyAgICBldmFsdWF0ZUV4cHJlc3Npb246IGZ1bmN0aW9uKGV4cHJlc3Npb24p CisgICAgeworICAgICAgICAvLyBFdmFsdWF0ZSBpbiB0aGUgY3VycmVudGx5IHNlbGVjdGVkIGNh bGwgZnJhbWUgaWYgdGhlIGRlYnVnZ2VyIGlzIHBhdXNlZC4KKyAgICAgICAgLy8gT3RoZXJ3aXNl IGV2YWx1YXRlIGluIGFnYWluc3QgdGhlIGluc3BlY3RlZCB3aW5kb3cuCisgICAgICAgIGlmIChX ZWJJbnNwZWN0b3IucGFuZWxzLnNjcmlwdHMucGF1c2VkICYmIHRoaXMudHJlZU91dGxpbmUuc2Vj dGlvbi5lZGl0SW5TZWxlY3RlZENhbGxGcmFtZVdoZW5QYXVzZWQpCisgICAgICAgICAgICB2YXIg cmVzdWx0ID0gV2ViSW5zcGVjdG9yLnBhbmVscy5zY3JpcHRzLmV2YWx1YXRlSW5TZWxlY3RlZENh bGxGcmFtZShleHByZXNzaW9uLCBmYWxzZSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHZh ciByZXN1bHQgPSBJbnNwZWN0b3JDb250cm9sbGVyLmluc3BlY3RlZFdpbmRvdygpLmV2YWwoZXhw cmVzc2lvbik7CisgICAgICAgIHJldHVybiByZXN1bHQ7CisgICAgfSwKKwogICAgIGFwcGx5RXhw cmVzc2lvbjogZnVuY3Rpb24oZXhwcmVzc2lvbiwgdXBkYXRlSW50ZXJmYWNlKQogICAgIHsKICAg ICAgICAgdmFyIGV4cHJlc3Npb25MZW5ndGggPSBleHByZXNzaW9uLnRyaW1XaGl0ZXNwYWNlKCku bGVuZ3RoOwpAQCAtMjM1LDI1ICsyNDYsMjQgQEAgV2ViSW5zcGVjdG9yLk9iamVjdFByb3BlcnR5 VHJlZUVsZW1lbnQucAogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKLSAgICAgICAg Ly8gU3Vycm91bmQgdGhlIGV4cHJlc3Npb24gaW4gcGFyZW50aGVzaXMgc28gdGhlIHJlc3VsdCBv ZiB0aGUgZXZhbCBpcyB0aGUgcmVzdWx0Ci0gICAgICAgIC8vIG9mIHRoZSB3aG9sZSBleHByZXNz aW9uIG5vdCB0aGUgbGFzdCBwb3RlbnRpYWwgc3ViLWV4cHJlc3Npb24uCi0gICAgICAgIGV4cHJl c3Npb24gPSAiKCIgKyBleHByZXNzaW9uICsgIikiOwotCiAgICAgICAgIHRyeSB7Ci0gICAgICAg ICAgICAvLyBFdmFsdWF0ZSBpbiB0aGUgY3VycmVudGx5IHNlbGVjdGVkIGNhbGwgZnJhbWUgaWYg dGhlIGRlYnVnZ2VyIGlzIHBhdXNlZC4KLSAgICAgICAgICAgIC8vIE90aGVyd2lzZSBldmFsdWF0 ZSBpbiBhZ2FpbnN0IHRoZSBpbnNwZWN0ZWQgd2luZG93LgotICAgICAgICAgICAgaWYgKFdlYklu c3BlY3Rvci5wYW5lbHMuc2NyaXB0cy5wYXVzZWQgJiYgdGhpcy50cmVlT3V0bGluZS5zZWN0aW9u LmVkaXRJblNlbGVjdGVkQ2FsbEZyYW1lV2hlblBhdXNlZCkKLSAgICAgICAgICAgICAgICB2YXIg cmVzdWx0ID0gV2ViSW5zcGVjdG9yLnBhbmVscy5zY3JpcHRzLmV2YWx1YXRlSW5TZWxlY3RlZENh bGxGcmFtZShleHByZXNzaW9uLCBmYWxzZSk7Ci0gICAgICAgICAgICBlbHNlCi0gICAgICAgICAg ICAgICAgdmFyIHJlc3VsdCA9IEluc3BlY3RvckNvbnRyb2xsZXIuaW5zcGVjdGVkV2luZG93KCku ZXZhbChleHByZXNzaW9uKTsKLQorICAgICAgICAgICAgLy8gU3Vycm91bmQgdGhlIGV4cHJlc3Np b24gaW4gcGFyZW50aGVzaXMgc28gdGhlIHJlc3VsdCBvZiB0aGUgZXZhbCBpcyB0aGUgcmVzdWx0 CisgICAgICAgICAgICAvLyBvZiB0aGUgd2hvbGUgZXhwcmVzc2lvbiBub3QgdGhlIGxhc3QgcG90 ZW50aWFsIHN1Yi1leHByZXNzaW9uLgorICAgICAgICAgICAgdmFyIHJlc3VsdCA9IHRoaXMuZXZh bHVhdGVFeHByZXNzaW9uKCIoIiArIGV4cHJlc3Npb24gKyAiKSIpOwogICAgICAgICAgICAgLy8g U3RvcmUgdGhlIHJlc3VsdCBpbiB0aGUgcHJvcGVydHkuCiAgICAgICAgICAgICB0aGlzLnBhcmVu dE9iamVjdFt0aGlzLnByb3BlcnR5TmFtZV0gPSByZXN1bHQ7CiAgICAgICAgIH0gY2F0Y2goZSkg ewotICAgICAgICAgICAgLy8gVGhlIGV4cHJlc3Npb24gZmFpbGVkIHNvIGRvbid0IGNoYW5nZSB0 aGUgdmFsdWUuIFNvIGp1c3QgdXBkYXRlIGFuZCByZXR1cm4uCi0gICAgICAgICAgICBpZiAodXBk YXRlSW50ZXJmYWNlKQotICAgICAgICAgICAgICAgIHRoaXMudXBkYXRlKCk7Ci0gICAgICAgICAg ICByZXR1cm47CisgICAgICAgICAgICB0cnkgeworICAgICAgICAgICAgICAgIC8vIFRyeSB0byB1 cGRhdGUgYXMgYSBzdHJpbmcKKyAgICAgICAgICAgICAgICB2YXIgcmVzdWx0ID0gdGhpcy5ldmFs dWF0ZUV4cHJlc3Npb24oJyInICsgZXhwcmVzc2lvbiArICciJyk7CisgICAgICAgICAgICAgICAg Ly8gU3RvcmUgdGhlIHJlc3VsdCBpbiB0aGUgcHJvcGVydHkuCisgICAgICAgICAgICAgICAgdGhp cy5wYXJlbnRPYmplY3RbdGhpcy5wcm9wZXJ0eU5hbWVdID0gcmVzdWx0OworICAgICAgICAgICAg fSBjYXRjaChlKSB7CisgICAgICAgICAgICAgICAgLy8gVGhlIGV4cHJlc3Npb24gZmFpbGVkIHNv IGRvbid0IGNoYW5nZSB0aGUgdmFsdWUuIFNvIGp1c3QgdXBkYXRlIGFuZCByZXR1cm4uCisgICAg ICAgICAgICAgICAgaWYgKHVwZGF0ZUludGVyZmFjZSkKKyAgICAgICAgICAgICAgICAgICAgdGhp cy51cGRhdGUoKTsKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9CiAgICAg ICAgIH0KIAogICAgICAgICBpZiAodXBkYXRlSW50ZXJmYWNlKSB7Cg== 22916 2008-08-20 18:12:08 -0700 2008-08-20 21:34:23 -0700 Comments adressed plop.patch text/plain 3625 rik SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTg2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDgtMDgtMjAgIEFudGhvbnkgUmljYXVkICA8cmlrMjRkQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8 aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDY2PiBFZGl0aW5nIGEg cHJvcGVydHkgd2l0aG91dCBxdW90ZXMgc2hvdWxkIGFkZCB0aGVtIGlmIHBvc3NpYmxlCisKKyAg ICAgICAgQWZ0ZXIgdHJ5aW5nIHRvIGFkZCB0aGUgZXhwcmVzc2lvbiwgdHJ5IGFnYWluIHdpdGgg cXVvdGVzIGZvciBlYXNpZXIgZWRpdGlvbi4KKworICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL09i amVjdFByb3BlcnRpZXNTZWN0aW9uLmpzOiBBZGRlZCBhbiBldmFsdWF0ZUV4cHJlc3Npb24gZnVu Y3Rpb24KKwogMjAwOC0wOC0yMCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAg ICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEpvaG4gU3VsbGl2YW4uCkluZGV4OiBXZWJDb3JlL3Bh Z2UvaW5zcGVjdG9yL09iamVjdFByb3BlcnRpZXNTZWN0aW9uLmpzCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGFnZS9pbnNwZWN0b3IvT2JqZWN0UHJvcGVydGllc1NlY3Rpb24uanMJKHJldmlzaW9u IDM1ODY1KQorKysgV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9PYmplY3RQcm9wZXJ0aWVzU2VjdGlv bi5qcwkod29ya2luZyBjb3B5KQpAQCAtMjE0LDYgKzIxNCwxNiBAQCBXZWJJbnNwZWN0b3IuT2Jq ZWN0UHJvcGVydHlUcmVlRWxlbWVudC5wCiAgICAgICAgIHRoaXMuZWRpdGluZ0VuZGVkKGNvbnRl eHQpOwogICAgIH0sCiAKKyAgICBldmFsdWF0ZUV4cHJlc3Npb246IGZ1bmN0aW9uKGV4cHJlc3Np b24pCisgICAgeworICAgICAgICAvLyBFdmFsdWF0ZSBpbiB0aGUgY3VycmVudGx5IHNlbGVjdGVk IGNhbGwgZnJhbWUgaWYgdGhlIGRlYnVnZ2VyIGlzIHBhdXNlZC4KKyAgICAgICAgLy8gT3RoZXJ3 aXNlIGV2YWx1YXRlIGluIGFnYWluc3QgdGhlIGluc3BlY3RlZCB3aW5kb3cuCisgICAgICAgIGlm IChXZWJJbnNwZWN0b3IucGFuZWxzLnNjcmlwdHMucGF1c2VkICYmIHRoaXMudHJlZU91dGxpbmUu c2VjdGlvbi5lZGl0SW5TZWxlY3RlZENhbGxGcmFtZVdoZW5QYXVzZWQpCisgICAgICAgICAgICBy ZXR1cm4gV2ViSW5zcGVjdG9yLnBhbmVscy5zY3JpcHRzLmV2YWx1YXRlSW5TZWxlY3RlZENhbGxG cmFtZShleHByZXNzaW9uLCBmYWxzZSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHJldHVy biBJbnNwZWN0b3JDb250cm9sbGVyLmluc3BlY3RlZFdpbmRvdygpLmV2YWwoZXhwcmVzc2lvbik7 CisgICAgfSwKKwogICAgIGFwcGx5RXhwcmVzc2lvbjogZnVuY3Rpb24oZXhwcmVzc2lvbiwgdXBk YXRlSW50ZXJmYWNlKQogICAgIHsKICAgICAgICAgdmFyIGV4cHJlc3Npb25MZW5ndGggPSBleHBy ZXNzaW9uLnRyaW1XaGl0ZXNwYWNlKCkubGVuZ3RoOwpAQCAtMjM1LDI1ICsyNDUsMjYgQEAgV2Vi SW5zcGVjdG9yLk9iamVjdFByb3BlcnR5VHJlZUVsZW1lbnQucAogICAgICAgICAgICAgcmV0dXJu OwogICAgICAgICB9CiAKLSAgICAgICAgLy8gU3Vycm91bmQgdGhlIGV4cHJlc3Npb24gaW4gcGFy ZW50aGVzaXMgc28gdGhlIHJlc3VsdCBvZiB0aGUgZXZhbCBpcyB0aGUgcmVzdWx0Ci0gICAgICAg IC8vIG9mIHRoZSB3aG9sZSBleHByZXNzaW9uIG5vdCB0aGUgbGFzdCBwb3RlbnRpYWwgc3ViLWV4 cHJlc3Npb24uCi0gICAgICAgIGV4cHJlc3Npb24gPSAiKCIgKyBleHByZXNzaW9uICsgIikiOwot CiAgICAgICAgIHRyeSB7Ci0gICAgICAgICAgICAvLyBFdmFsdWF0ZSBpbiB0aGUgY3VycmVudGx5 IHNlbGVjdGVkIGNhbGwgZnJhbWUgaWYgdGhlIGRlYnVnZ2VyIGlzIHBhdXNlZC4KLSAgICAgICAg ICAgIC8vIE90aGVyd2lzZSBldmFsdWF0ZSBpbiBhZ2FpbnN0IHRoZSBpbnNwZWN0ZWQgd2luZG93 LgotICAgICAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0cy5wYXVzZWQgJiYg dGhpcy50cmVlT3V0bGluZS5zZWN0aW9uLmVkaXRJblNlbGVjdGVkQ2FsbEZyYW1lV2hlblBhdXNl ZCkKLSAgICAgICAgICAgICAgICB2YXIgcmVzdWx0ID0gV2ViSW5zcGVjdG9yLnBhbmVscy5zY3Jp cHRzLmV2YWx1YXRlSW5TZWxlY3RlZENhbGxGcmFtZShleHByZXNzaW9uLCBmYWxzZSk7Ci0gICAg ICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgdmFyIHJlc3VsdCA9IEluc3BlY3RvckNvbnRy b2xsZXIuaW5zcGVjdGVkV2luZG93KCkuZXZhbChleHByZXNzaW9uKTsKKyAgICAgICAgICAgIC8v IFN1cnJvdW5kIHRoZSBleHByZXNzaW9uIGluIHBhcmVudGhlc2lzIHNvIHRoZSByZXN1bHQgb2Yg dGhlIGV2YWwgaXMgdGhlIHJlc3VsdAorICAgICAgICAgICAgLy8gb2YgdGhlIHdob2xlIGV4cHJl c3Npb24gbm90IHRoZSBsYXN0IHBvdGVudGlhbCBzdWItZXhwcmVzc2lvbi4KKyAgICAgICAgICAg IHZhciByZXN1bHQgPSB0aGlzLmV2YWx1YXRlRXhwcmVzc2lvbigiKCIgKyBleHByZXNzaW9uICsg IikiKTsKIAogICAgICAgICAgICAgLy8gU3RvcmUgdGhlIHJlc3VsdCBpbiB0aGUgcHJvcGVydHku CiAgICAgICAgICAgICB0aGlzLnBhcmVudE9iamVjdFt0aGlzLnByb3BlcnR5TmFtZV0gPSByZXN1 bHQ7CiAgICAgICAgIH0gY2F0Y2goZSkgewotICAgICAgICAgICAgLy8gVGhlIGV4cHJlc3Npb24g ZmFpbGVkIHNvIGRvbid0IGNoYW5nZSB0aGUgdmFsdWUuIFNvIGp1c3QgdXBkYXRlIGFuZCByZXR1 cm4uCi0gICAgICAgICAgICBpZiAodXBkYXRlSW50ZXJmYWNlKQotICAgICAgICAgICAgICAgIHRo aXMudXBkYXRlKCk7Ci0gICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB0cnkgeworICAg ICAgICAgICAgICAgIC8vIFRyeSB0byB1cGRhdGUgYXMgYSBzdHJpbmcKKyAgICAgICAgICAgICAg ICB2YXIgcmVzdWx0ID0gdGhpcy5ldmFsdWF0ZUV4cHJlc3Npb24oIlwiIiArIGV4cHJlc3Npb24u ZXNjYXBlQ2hhcmFjdGVycygiXCIiKSArICJcIiIpOworCisgICAgICAgICAgICAgICAgLy8gU3Rv cmUgdGhlIHJlc3VsdCBpbiB0aGUgcHJvcGVydHkuCisgICAgICAgICAgICAgICAgdGhpcy5wYXJl bnRPYmplY3RbdGhpcy5wcm9wZXJ0eU5hbWVdID0gcmVzdWx0OworICAgICAgICAgICAgfSBjYXRj aChlKSB7CisgICAgICAgICAgICAgICAgLy8gVGhlIGV4cHJlc3Npb24gZmFpbGVkIHNvIGRvbid0 IGNoYW5nZSB0aGUgdmFsdWUuIFNvIGp1c3QgdXBkYXRlIGFuZCByZXR1cm4uCisgICAgICAgICAg ICAgICAgaWYgKHVwZGF0ZUludGVyZmFjZSkKKyAgICAgICAgICAgICAgICAgICAgdGhpcy51cGRh dGUoKTsKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9CiAgICAgICAgIH0K IAogICAgICAgICBpZiAodXBkYXRlSW50ZXJmYWNlKSB7Cg==