204651 2019-11-27 12:51:25 -0800 [LFC] Run layout on the root when InvalidationState is empty. 2019-11-27 13:42:05 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1593908 0 zalan 2019-11-27 12:51:25 -0800 When simple constraint change happens. 1593909 1 webkit-bug-importer 2019-11-27 12:51:44 -0800 <rdar://problem/57509616> 1593910 2 384423 zalan 2019-11-27 12:54:51 -0800 Created attachment 384423 Patch 1593912 3 384423 koivisto 2019-11-27 13:22:09 -0800 Comment on attachment 384423 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384423&action=review > Source/WebCore/layout/RenderBlockFlowLineLayout.cpp:78 > if (!rootContainer.firstChild()) Could remove this check too 1593915 4 zalan 2019-11-27 13:42:05 -0800 Committed r252912: <https://trac.webkit.org/changeset/252912> 384423 2019-11-27 12:54:51 -0800 2019-11-27 13:22:09 -0800 Patch bug-204651-20191127125423.patch text/plain 6419 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyOTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGIwMDM1ZDk1NzhiN2Zi ZjE2NjgyZTU1NzQxZmIzODI5MGQ1ZTk3Ny4uNzZmMGI3NjA2YjRkZTBkNzUwNjkzNjM4NTA4M2Vl YzZjMmRiZjI0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTExLTI3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gUnVuIGxheW91dCBv biB0aGUgcm9vdCB3aGVuIEludmFsaWRhdGlvblN0YXRlIGlzIGVtcHR5LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0NjUxCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS81NzUwOTYxNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJbnZhbGlkYXRpb25TdGF0ZSBjYXB0dXJlcyBzdHlsZS90cmVlIG11dGF0 aW9uIHJlbGF0ZWQgY2hhbmdlcy4gQW4gZW1wdHkgSW52YWxpZGF0aW9uU3RhdGUgaW5kaWNhdGVz IHRoYXQgdGhlIGhvcml6b250YWwgY29uc3RyYWludCBjaGFuZ2VkCisgICAgICAgIGFuZCB3ZSBu ZWVkIHRvIGluaXRpYXRlIGEgbGF5b3V0IG9uIHRoZSBJQ0IgKGFuZCB0aGUgbGF5b3V0IGxvZ2lj IHdpbGwgcHJvcGFnYXRlIHRoZSBkYW1hZ2UgZG93biBvbiB0aGUgdHJlZSkuIAorCisgICAgICAg ICogbGF5b3V0L0xheW91dENvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpM YXlvdXRDb250ZXh0OjpsYXlvdXQpOgorICAgICAgICAqIGxheW91dC9SZW5kZXJCbG9ja0Zsb3dM aW5lTGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6UmVuZGVyQmxvY2tGbG93 TGluZUxheW91dDo6bGF5b3V0KToKKyAgICAgICAgKiBsYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRU cmVlQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OnByaW50TGF5b3V0VHJl ZUZvckxpdmVEb2N1bWVudHMpOgorICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3TGF5b3V0Q29udGV4 dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXdMYXlvdXRDb250ZXh0OjpsYXlvdXRV c2luZ0Zvcm1hdHRpbmdDb250ZXh0KToKKwogMjAxOS0xMS0yNyAgQW50dGkgS29pdmlzdG8gIDxh bnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bUmVuZGVyIHRyZWVdIFBlcmZvcm1hbmNl VGVzdHMvTGF5b3V0L2xpbmUtbGF5b3V0LXNpbXBsZS5odG1sIGRvZXMgbm90IHVwZGF0ZSBwcm9w ZXJseSB3aXRoIExGQyBlbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv TGF5b3V0Q29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvTGF5b3V0Q29udGV4dC5j cHAKaW5kZXggZjdhNDdmOWI4NjU5NmU5ZmM1Y2RjMTc3ZTZkNjM2YmY0NDA3MzIxNS4uZGU2MWJm ZGM0ZjcxZmUyZWYxNDc0NjEzOGRlNDkzNjZmN2RjOGNkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvbGF5b3V0L0xheW91dENvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9MYXlvdXRDb250ZXh0LmNwcApAQCAtNTksMTEgKzU5LDYgQEAgTGF5b3V0Q29udGV4dDo6TGF5 b3V0Q29udGV4dChMYXlvdXRTdGF0ZSYgbGF5b3V0U3RhdGUpCiB2b2lkIExheW91dENvbnRleHQ6 OmxheW91dChjb25zdCBMYXlvdXRTaXplJiByb290Q29udGVudEJveFNpemUsIEludmFsaWRhdGlv blN0YXRlJiBpbnZhbGlkYXRpb25TdGF0ZSkKIHsKICAgICBQaGFzZVNjb3BlIHNjb3BlKFBoYXNl OjpUeXBlOjpMYXlvdXQpOwotCi0gICAgYXV0byYgZm9ybWF0dGluZ0NvbnRleHRSb290c0Zvckxh eW91dCA9IGludmFsaWRhdGlvblN0YXRlLmZvcm1hdHRpbmdDb250ZXh0Um9vdHMoKTsKLSAgICBp ZiAoZm9ybWF0dGluZ0NvbnRleHRSb290c0ZvckxheW91dC5jb21wdXRlc0VtcHR5KCkpCi0gICAg ICAgIHJldHVybjsKLQogICAgIC8vIFNldCB0aGUgZ2VvbWV0cnkgb24gdGhlIHJvb3QuCiAgICAg Ly8gTm90ZSB0aGF0IHdlIG5ldmVyIGxheW91dCB0aGUgcm9vdCBib3guIEl0IGhhcyB0byBoYXZl IGFuIGFscmVhZHkgY29tcHV0ZWQgZ2VvbWV0cnkgKGluIGNhc2Ugb2YgSUNCLCBpdCdzIHRoZSB2 aWV3IGdlb21ldHJ5KS4KICAgICAvLyBJQ0IgZXN0YWJsaXNoZXMgdGhlIGluaXRpYWwgQkZDLCBi dXQgaXQgZG9lcyBub3QgbGl2ZSBpbiBhIGZvcm1hdHRpbmcgY29udGV4dCBhbmQgd2hpbGUgYSBu b24tSUNCIHJvb3Qoc3VidHJlZSBsYXlvdXQpIGhhcyB0byBoYXZlIGEgZm9ybWF0dGluZyBjb250 ZXh0LApAQCAtNzcsNiArNzIsMTIgQEAgdm9pZCBMYXlvdXRDb250ZXh0OjpsYXlvdXQoY29uc3Qg TGF5b3V0U2l6ZSYgcm9vdENvbnRlbnRCb3hTaXplLCBJbnZhbGlkYXRpb25TdGEKICAgICBkaXNw bGF5Qm94LnNldFRvcExlZnQoeyB9KTsKICAgICBkaXNwbGF5Qm94LnNldENvbnRlbnRCb3hIZWln aHQocm9vdENvbnRlbnRCb3hTaXplLmhlaWdodCgpKTsKICAgICBkaXNwbGF5Qm94LnNldENvbnRl bnRCb3hXaWR0aChyb290Q29udGVudEJveFNpemUud2lkdGgoKSk7CisKKyAgICBhdXRvJiBmb3Jt YXR0aW5nQ29udGV4dFJvb3RzRm9yTGF5b3V0ID0gaW52YWxpZGF0aW9uU3RhdGUuZm9ybWF0dGlu Z0NvbnRleHRSb290cygpOworICAgIC8vIFdoZW4gaW52YWxpZGF0aW9uIGlzIGVtcHR5LCB3ZSBh c3N1bWUgY29uc3RyYWludCBtdXRhdGlvbiBhbmQgc3RhcnQgcnVubmluZyBsYXlvdXQgb24gdGhl IGNvbnRleHQgcm9vdC4gTGF5b3V0IGxvZ2ljIHNob3VsZCBiZSBhYmxlIHRvIGZpZ3VyZSBvdXQg dGhlIGRhbWFnZS4KKyAgICBpZiAoZm9ybWF0dGluZ0NvbnRleHRSb290c0ZvckxheW91dC5jb21w dXRlc0VtcHR5KCkpCisgICAgICAgIHJldHVybiBsYXlvdXRGb3JtYXR0aW5nQ29udGV4dFN1YnRy ZWUobV9sYXlvdXRTdGF0ZS5yb290KCksIGludmFsaWRhdGlvblN0YXRlKTsKKwogICAgIGZvciAo YXV0byYgZm9ybWF0dGluZ0NvbnRleHRSb290IDogZm9ybWF0dGluZ0NvbnRleHRSb290c0Zvckxh eW91dCkKICAgICAgICAgbGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRTdWJ0cmVlKGZvcm1hdHRpbmdD b250ZXh0Um9vdCwgaW52YWxpZGF0aW9uU3RhdGUpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvbGF5b3V0L1JlbmRlckJsb2NrRmxvd0xpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L1JlbmRlckJsb2NrRmxvd0xpbmVMYXlvdXQuY3BwCmluZGV4IGRkZWMxOTAzNWQ4 Y2U5MjliZjY3YzhhZGIzY2I4ZWNhOTNhYTE2ODAuLmI2M2JiMGNiN2UwZDdjNmIzNjgwYjIxZWEz NzI4ODkzNDRjOTY4Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9SZW5kZXJC bG9ja0Zsb3dMaW5lTGF5b3V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvUmVuZGVy QmxvY2tGbG93TGluZUxheW91dC5jcHAKQEAgLTc4LDExICs3OCw4IEBAIHZvaWQgUmVuZGVyQmxv Y2tGbG93TGluZUxheW91dDo6bGF5b3V0KCkKICAgICBpZiAoIXJvb3RDb250YWluZXIuZmlyc3RD aGlsZCgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBJbnZhbGlkYXRpb25TdGF0ZSBpbnZhbGlk YXRpb25TdGF0ZTsKLSAgICAvLyBGSVhNRTogRmluZCBzb21lIGJldHRlciB3YXkgdG8gZG8gdGhp cy4KLSAgICBpbnZhbGlkYXRpb25TdGF0ZS5tYXJrTmVlZHNVcGRhdGUoKnJvb3RDb250YWluZXIu Zmlyc3RDaGlsZCgpKTsKLQotICAgIExheW91dENvbnRleHQgbGF5b3V0Q29udGV4dCgqbV9sYXlv dXRTdGF0ZSk7CisgICAgYXV0byBsYXlvdXRDb250ZXh0ID0gTGF5b3V0Q29udGV4dCB7ICptX2xh eW91dFN0YXRlIH07CisgICAgYXV0byBpbnZhbGlkYXRpb25TdGF0ZSA9IEludmFsaWRhdGlvblN0 YXRlIHsgfTsKICAgICBsYXlvdXRDb250ZXh0LmxheW91dChtX2Zsb3cuY29udGVudFNpemUoKSwg aW52YWxpZGF0aW9uU3RhdGUpOwogCiAgICAgYXV0byYgbGluZUJveGVzID0gZG93bmNhc3Q8SW5s aW5lRm9ybWF0dGluZ1N0YXRlPihtX2xheW91dFN0YXRlLT5lc3RhYmxpc2hlZEZvcm1hdHRpbmdT dGF0ZShyb290Q29udGFpbmVyKSkubGluZUJveGVzKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRUcmVlQnVpbGRlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRUcmVlQnVpbGRlci5jcHAKaW5kZXggYmU3ODA5 NmIwZGZjM2E4M2U4Y2Y3NTQxYjlkMjljMDMxZjZkNjU4My4uYjYzZmU5ZTExNWYyMWE3YTA4ZDQ1 NmVmYTdlY2FiZmVhNTgwZTM1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xh eW91dHRyZWUvTGF5b3V0VHJlZUJ1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9sYXlvdXR0cmVlL0xheW91dFRyZWVCdWlsZGVyLmNwcApAQCAtNDUwLDkgKzQ1MCw2IEBAIHZv aWQgcHJpbnRMYXlvdXRUcmVlRm9yTGl2ZURvY3VtZW50cygpCiAKICAgICAgICAgYXV0byYgbGF5 b3V0Um9vdCA9IGxheW91dFN0YXRlLnJvb3QoKTsKICAgICAgICAgYXV0byBpbnZhbGlkYXRpb25T dGF0ZSA9IEludmFsaWRhdGlvblN0YXRlIHsgfTsKLSAgICAgICAgYXV0byBpbnZhbGlkYXRpb25D b250ZXh0ID0gSW52YWxpZGF0aW9uQ29udGV4dCB7IGludmFsaWRhdGlvblN0YXRlIH07Ci0gICAg ICAgIGludmFsaWRhdGlvbkNvbnRleHQuc3R5bGVDaGFuZ2VkKCpsYXlvdXRSb290LmZpcnN0Q2hp bGQoKSwgU3R5bGVEaWZmZXJlbmNlOjpMYXlvdXQpOwotCiAgICAgICAgIExheW91dENvbnRleHQo bGF5b3V0U3RhdGUpLmxheW91dChyZW5kZXJWaWV3LnNpemUoKSwgaW52YWxpZGF0aW9uU3RhdGUp OwogICAgICAgICBzaG93TGF5b3V0VHJlZShsYXlvdXRSb290LCAmbGF5b3V0U3RhdGUpOwogICAg IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3TGF5b3V0Q29udGV4 dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlld0xheW91dENvbnRleHQuY3BwCmlu ZGV4IDE2Y2Y0MWI3NzAxNGY3YjdlNjI5ZTkxNTQzNGVmYjBhYjZlZGVlMzEuLjc0YTU1OGEzMzk5 ZmFlMGZlMDA1MGVkZDZiODU0MjE5ZGZkZGNmMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRnJhbWVWaWV3TGF5b3V0Q29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZVZpZXdMYXlvdXRDb250ZXh0LmNwcApAQCAtNjEsNiArNjEsMTAgQEAgdm9pZCBGcmFt ZVZpZXdMYXlvdXRDb250ZXh0OjpsYXlvdXRVc2luZ0Zvcm1hdHRpbmdDb250ZXh0KCkKICAgICBp ZiAoIVJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJlZEZlYXR1cmVzKCkubGF5b3V0Rm9ybWF0 dGluZ0NvbnRleHRFbmFibGVkKCkpCiAgICAgICAgIHJldHVybjsKIAorICAgIC8vIEZyYW1lVmll dzo6c2V0Q29udGVudHNTaXplIHRlbXBvcmFyeSBkaXNhYmxlcyBsYXlvdXQuCisgICAgaWYgKG1f ZGlzYWJsZVNldE5lZWRzTGF5b3V0Q291bnQpCisgICAgICAgIHJldHVybjsKKwogICAgIGF1dG8m IHJlbmRlclZpZXcgPSAqdGhpcy0+cmVuZGVyVmlldygpOwogICAgIGlmICghbV9sYXlvdXRUcmVl Q29udGVudCkgewogICAgICAgICBtX2xheW91dFRyZWVDb250ZW50ID0gTGF5b3V0OjpUcmVlQnVp bGRlcjo6YnVpbGRMYXlvdXRUcmVlKHJlbmRlclZpZXcpOwpAQCAtNzIsMTIgKzc2LDYgQEAgdm9p ZCBGcmFtZVZpZXdMYXlvdXRDb250ZXh0OjpsYXlvdXRVc2luZ0Zvcm1hdHRpbmdDb250ZXh0KCkK IAogICAgIC8vIEZJWE1FOiBUaGlzIGlzIG5vdCB0aGUgcmVhbCBpbnZhbGlkYXRpb24geWV0Lgog ICAgIGF1dG8gaW52YWxpZGF0aW9uU3RhdGUgPSBMYXlvdXQ6OkludmFsaWRhdGlvblN0YXRlIHsg fTsKLSAgICBhdXRvIGludmFsaWRhdGlvbkNvbnRleHQgPSBMYXlvdXQ6OkludmFsaWRhdGlvbkNv bnRleHQgeyBpbnZhbGlkYXRpb25TdGF0ZSB9OwotCi0gICAgLy8gRnJhbWVWaWV3OjpzZXRDb250 ZW50c1NpemUgdGVtcG9yYXJ5IGRpc2FibGVzIGxheW91dC4KLSAgICBpZiAoIW1fZGlzYWJsZVNl dE5lZWRzTGF5b3V0Q291bnQpCi0gICAgICAgIGludmFsaWRhdGlvbkNvbnRleHQuc3R5bGVDaGFu Z2VkKCptX2xheW91dFN0YXRlLT5yb290KCkuZmlyc3RDaGlsZCgpLCBTdHlsZURpZmZlcmVuY2U6 OkxheW91dCk7Ci0KICAgICBhdXRvIGxheW91dENvbnRleHQgPSBMYXlvdXQ6OkxheW91dENvbnRl eHQgeyAqbV9sYXlvdXRTdGF0ZSB9OwogICAgIGxheW91dENvbnRleHQubGF5b3V0KHZpZXcoKS5s YXlvdXRTaXplKCksIGludmFsaWRhdGlvblN0YXRlKTsKIAo=