<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>204644</bug_id>
          
          <creation_ts>2019-11-27 07:08:23 -0800</creation_ts>
          <short_desc>Using char* instead of String for StyleProperties::getShorthandValue()</short_desc>
          <delta_ts>2019-11-27 15:08:22 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Manuel Rego Casasnovas">rego</reporter>
          <assigned_to name="Manuel Rego Casasnovas">rego</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>jfernandez</cc>
    
    <cc>macpherson</cc>
    
    <cc>menard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1593862</commentid>
    <comment_count>0</comment_count>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2019-11-27 07:08:23 -0800</bug_when>
    <thetext>Using char* instead of String for StyleProperties::getShorthandValue()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1593863</commentid>
    <comment_count>1</comment_count>
      <attachid>384411</attachid>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2019-11-27 07:08:38 -0800</bug_when>
    <thetext>Created attachment 384411
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1593921</commentid>
    <comment_count>2</comment_count>
      <attachid>384411</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-11-27 15:07:53 -0800</bug_when>
    <thetext>Comment on attachment 384411
Patch

Clearing flags on attachment: 384411

Committed r252913: &lt;https://trac.webkit.org/changeset/252913&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1593922</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-11-27 15:07:55 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1593923</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-11-27 15:08:22 -0800</bug_when>
    <thetext>&lt;rdar://problem/57510642&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>384411</attachid>
            <date>2019-11-27 07:08:38 -0800</date>
            <delta_ts>2019-11-27 15:07:53 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-204644-20191127160837.patch</filename>
            <type>text/plain</type>
            <size>2582</size>
            <attacher name="Manuel Rego Casasnovas">rego</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyOTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDFiNWVkMTBiYjQwZDky
YzcyYmJkNTFmODMyMWRjMWMyMWRkMzIzNC4uOGU4OTgxZmQzN2Q4N2JhYmQ5MWJhZjI2ZTI2OGQy
OGU4ZjJjZjRlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTExLTI3ICBNYW51
ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFVzaW5nIGNo
YXIqIGluc3RlYWQgb2YgU3RyaW5nIGZvciBTdHlsZVByb3BlcnRpZXM6OmdldFNob3J0aGFuZFZh
bHVlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw
NDY0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo
aXMgaXMgZm9sbG93LXVwIHBhdGNoIGZvciByMjUyOTAxLiBXZSBkb24ndCBuZWVkIHRvIGNyZWF0
ZSBhIFN0cmluZyBvYmplY3QKKyAgICAgICAganVzdCBmb3IgdGhlIHNlcGFyYXRvciBhbmQgY2Fu
IHVzZSBjaGFyKiBpbnN0ZWFkLgorICAgICAgICBUaGlzIHdhcyBzdWdnZXN0ZWQgYnkgRGFyaW4g
QWRsZXIgaW4gd2Via2l0Lm9yZy9iLzIwNDUwOC4KKworICAgICAgICAqIGNzcy9TdHlsZVByb3Bl
cnRpZXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVQcm9wZXJ0aWVzOjpnZXRTaG9ydGhh
bmRWYWx1ZSBjb25zdCk6CisgICAgICAgICogY3NzL1N0eWxlUHJvcGVydGllcy5oOgorCiAyMDE5
LTExLTI3ICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgogCiAgICAg
ICAgIFtjc3MtZ3JpZF0gU2VyaWFsaXphdGlvbiBvZiBncmlkLWFyZWEsIGdyaWQtcm93IGFuZCBn
cmlkLWNvbHVtbiBzaG91bGQgaW5jbHVkZSAiLyIgc2VwYXJhdG9yCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0aWVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9T
dHlsZVByb3BlcnRpZXMuY3BwCmluZGV4IGZlZGYyM2U3NDhiNWQ1MDJlMzc4YWFiZjcwNmMwMjZi
NTIwMTMzYzIuLjhhYzUzMmZmZmVhN2VjNDYxOWJjMTljMzdkODI3M2QxZWUzN2UzZGUgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnRpZXMuY3BwCisrKyBiL1NvdXJj
ZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnRpZXMuY3BwCkBAIC02NTUsNyArNjU1LDcgQEAgU3Ry
aW5nIFN0eWxlUHJvcGVydGllczo6Z2V0R3JpZFNob3J0aGFuZFZhbHVlKGNvbnN0IFN0eWxlUHJv
cGVydHlTaG9ydGhhbmQmIHNob3IKICAgICByZXR1cm4gZ2V0U2hvcnRoYW5kVmFsdWUoc2hvcnRo
YW5kLCAiIC8gIik7CiB9CiAKLVN0cmluZyBTdHlsZVByb3BlcnRpZXM6OmdldFNob3J0aGFuZFZh
bHVlKGNvbnN0IFN0eWxlUHJvcGVydHlTaG9ydGhhbmQmIHNob3J0aGFuZCwgY29uc3QgU3RyaW5n
JiBzZXBhcmF0b3IpIGNvbnN0CitTdHJpbmcgU3R5bGVQcm9wZXJ0aWVzOjpnZXRTaG9ydGhhbmRW
YWx1ZShjb25zdCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kJiBzaG9ydGhhbmQsIGNvbnN0IGNoYXIq
IHNlcGFyYXRvcikgY29uc3QKIHsKICAgICBTdHJpbmcgY29tbW9uVmFsdWU7CiAgICAgU3RyaW5n
QnVpbGRlciByZXN1bHQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9w
ZXJ0aWVzLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0aWVzLmgKaW5kZXggZGUz
Yzc0ODQ0YzYxOTFiMzE4ZTE5OTJiY2I3MDg0N2Q5ODdhYTYzMC4uMzdhZTU2NDM0ZjlhODIwZWY4
NjVjYWJjNmU0ZTEyMmEwZmUxYzkwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0
eWxlUHJvcGVydGllcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnRpZXMu
aApAQCAtMTYwLDcgKzE2MCw3IEBAIHByb3RlY3RlZDoKIAogcHJpdmF0ZToKICAgICBTdHJpbmcg
Z2V0R3JpZFNob3J0aGFuZFZhbHVlKGNvbnN0IFN0eWxlUHJvcGVydHlTaG9ydGhhbmQmKSBjb25z
dDsKLSAgICBTdHJpbmcgZ2V0U2hvcnRoYW5kVmFsdWUoY29uc3QgU3R5bGVQcm9wZXJ0eVNob3J0
aGFuZCYsIGNvbnN0IFN0cmluZyYgc2VwYXJhdG9yID0gIiAiKSBjb25zdDsKKyAgICBTdHJpbmcg
Z2V0U2hvcnRoYW5kVmFsdWUoY29uc3QgU3R5bGVQcm9wZXJ0eVNob3J0aGFuZCYsIGNvbnN0IGNo
YXIqIHNlcGFyYXRvciA9ICIgIikgY29uc3Q7CiAgICAgU3RyaW5nIGdldENvbW1vblZhbHVlKGNv
bnN0IFN0eWxlUHJvcGVydHlTaG9ydGhhbmQmKSBjb25zdDsKICAgICBTdHJpbmcgZ2V0QWxpZ25t
ZW50U2hvcnRoYW5kVmFsdWUoY29uc3QgU3R5bGVQcm9wZXJ0eVNob3J0aGFuZCYpIGNvbnN0Owog
ICAgIFN0cmluZyBib3JkZXJQcm9wZXJ0eVZhbHVlKGNvbnN0IFN0eWxlUHJvcGVydHlTaG9ydGhh
bmQmLCBjb25zdCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kJiwgY29uc3QgU3R5bGVQcm9wZXJ0eVNo
b3J0aGFuZCYpIGNvbnN0Owo=
</data>

          </attachment>
      

    </bug>

</bugzilla>