204633 2019-11-27 00:27:00 -0800 [LFC][Render tree] RenderBlockFlow::ensureLineBoxes should work with lfc layout 2019-11-27 09:02:21 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1593803 0 koivisto 2019-11-27 00:27:00 -0800 We need to be able to switch to linebox layout when needed. 1593804 1 384400 koivisto 2019-11-27 00:31:16 -0800 Created attachment 384400 patch 1593877 2 384400 commit-queue 2019-11-27 09:01:17 -0800 Comment on attachment 384400 patch Clearing flags on attachment: 384400 Committed r252906: <https://trac.webkit.org/changeset/252906> 1593878 3 commit-queue 2019-11-27 09:01:19 -0800 All reviewed patches have been landed. Closing bug. 1593879 4 webkit-bug-importer 2019-11-27 09:02:21 -0800 <rdar://problem/57507569> 384400 2019-11-27 00:31:16 -0800 2019-11-27 09:01:17 -0800 patch lfc-ensurelineboxes.patch text/plain 4312 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNTIyZWU1YTBkNi4uM2MzNTNiZDhiNjIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOS0xMS0yNyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgW0xGQ11bUmVuZGVyIHRyZWVdIFJlbmRlckJsb2NrRmxvdzo6ZW5zdXJlTGlu ZUJveGVzIHNob3VsZCB3b3JrIHdpdGggbGZjIGxheW91dAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0NjMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVlZCB0byBiZSBhYmxlIHRvIHN3aXRjaCB0 byBsaW5lYm94IGxheW91dCB3aGVuIG5lZWRlZC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJCbG9ja0Zsb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2tGbG93OjpkZWxl dGVMaW5lcyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9ja0Zsb3c6OmludmFsaWRhdGVM aW5lTGF5b3V0UGF0aCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9ja0Zsb3c6OmVuc3Vy ZUxpbmVCb3hlcyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5oOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2tGbG93OjpoYXNMaW5lTGF5b3V0IGNvbnN0KToKKwor ICAgICAgICBBbHNvIHN3aXRjaCB0byB1c2luZyBXVEY6Ok1vbm9zdGF0ZSBhcyBlbXB0eSBzdGF0 ZS4KKwogMjAxOS0xMS0yNiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAg ICAgICAgW0xGQ11bUmVuZGVyIHRyZWVdIEFkZCBMRkMgbGluZSBsYXlvdXQgcGF0aCB0byBSZW5k ZXJCbG9ja0Zsb3cKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC bG9ja0Zsb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5j cHAKaW5kZXggZTYxZmMyNmUxMzMuLjJjZTY2ZjljMDgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcApAQCAtMjEyMSw3ICsyMTIxLDcgQEAgdm9pZCBS ZW5kZXJCbG9ja0Zsb3c6OnN0eWxlV2lsbENoYW5nZShTdHlsZURpZmZlcmVuY2UgZGlmZiwgY29u c3QgUmVuZGVyU3R5bGUmIG4KIAogdm9pZCBSZW5kZXJCbG9ja0Zsb3c6OmRlbGV0ZUxpbmVzKCkK IHsKLSAgICBtX2xpbmVMYXlvdXQgPSBudWxscHRyOworICAgIG1fbGluZUxheW91dCA9IFdURjo6 TW9ub3N0YXRlKCk7CiAKICAgICBSZW5kZXJCbG9jazo6ZGVsZXRlTGluZXMoKTsKIH0KQEAgLTM2 MzMsNyArMzYzMyw3IEBAIHZvaWQgUmVuZGVyQmxvY2tGbG93OjppbnZhbGlkYXRlTGluZUxheW91 dFBhdGgoKQogICAgICAgICByZXR1cm47CiAgICAgY2FzZSBTaW1wbGVMaW5lc1BhdGg6CiAgICAg ICAgIC8vIFRoZSBzaW1wbGUgbGluZSBsYXlvdXQgbWF5IGhhdmUgYmVjb21lIGludmFsaWQuCi0g ICAgICAgIG1fbGluZUxheW91dCA9IG51bGxwdHI7CisgICAgICAgIG1fbGluZUxheW91dCA9IFdU Rjo6TW9ub3N0YXRlKCk7CiAgICAgICAgIHNldExpbmVMYXlvdXRQYXRoKFVuZGV0ZXJtaW5lZFBh dGgpOwogICAgICAgICBpZiAobmVlZHNMYXlvdXQoKSkKICAgICAgICAgICAgIHJldHVybjsKQEAg LTM2OTUsMTYgKzM2OTUsMTggQEAgdm9pZCBSZW5kZXJCbG9ja0Zsb3c6OmVuc3VyZUxpbmVCb3hl cygpCiAKICAgICBzZXRMaW5lTGF5b3V0UGF0aChGb3JjZUxpbmVCb3hlc1BhdGgpOwogCi0gICAg aWYgKCFzaW1wbGVMaW5lTGF5b3V0KCkpCisgICAgaWYgKGNvbXBsZXhMaW5lTGF5b3V0KCkgfHwg IWhhc0xpbmVMYXlvdXQoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgYXV0byBzaW1wbGVMaW5l TGF5b3V0ID0gbWFrZVJlZigqdGhpcy0+c2ltcGxlTGluZUxheW91dCgpKTsKKyAgICBhdXRvIHNp bXBsZUxpbmVMYXlvdXQgPSBtYWtlUmVmUHRyKHRoaXMtPnNpbXBsZUxpbmVMYXlvdXQoKSk7CiAK ICAgICBtX2xpbmVMYXlvdXQgPSBtYWtlVW5pcXVlPENvbXBsZXhMaW5lTGF5b3V0PigqdGhpcyk7 CiAKLSAgICBpZiAoU2ltcGxlTGluZUxheW91dDo6Y2FuVXNlRm9yTGluZUJveFRyZWUoKnRoaXMs IHNpbXBsZUxpbmVMYXlvdXQuZ2V0KCkpKSB7Ci0gICAgICAgIFNpbXBsZUxpbmVMYXlvdXQ6Omdl bmVyYXRlTGluZUJveFRyZWUoKnRoaXMsIHNpbXBsZUxpbmVMYXlvdXQuZ2V0KCkpOwotICAgICAg ICByZXR1cm47CisgICAgaWYgKHNpbXBsZUxpbmVMYXlvdXQpIHsKKyAgICAgICAgaWYgKFNpbXBs ZUxpbmVMYXlvdXQ6OmNhblVzZUZvckxpbmVCb3hUcmVlKCp0aGlzLCAqc2ltcGxlTGluZUxheW91 dCkpIHsKKyAgICAgICAgICAgIFNpbXBsZUxpbmVMYXlvdXQ6OmdlbmVyYXRlTGluZUJveFRyZWUo KnRoaXMsICpzaW1wbGVMaW5lTGF5b3V0KTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg fQogICAgIH0KIAogICAgIGF1dG8mIGNvbXBsZXhMaW5lTGF5b3V0ID0gKnRoaXMtPmNvbXBsZXhM aW5lTGF5b3V0KCk7CkBAIC0zNzE3LDcgKzM3MTksNyBAQCB2b2lkIFJlbmRlckJsb2NrRmxvdzo6 ZW5zdXJlTGluZUJveGVzKCkKICAgICBib29sIHJlbGF5b3V0Q2hpbGRyZW4gPSBmYWxzZTsKICAg ICBMYXlvdXRVbml0IHJlcGFpbnRMb2dpY2FsVG9wOwogICAgIExheW91dFVuaXQgcmVwYWludExv Z2ljYWxCb3R0b207Ci0gICAgaWYgKHNpbXBsZUxpbmVMYXlvdXQtPmlzUGFnaW5hdGVkKCkpIHsK KyAgICBpZiAoc2ltcGxlTGluZUxheW91dCAmJiBzaW1wbGVMaW5lTGF5b3V0LT5pc1BhZ2luYXRl ZCgpKSB7CiAgICAgICAgIFBhZ2luYXRlZExheW91dFN0YXRlTWFpbnRhaW5lciBzdGF0ZSgqdGhp cyk7CiAgICAgICAgIGNvbXBsZXhMaW5lTGF5b3V0LmxheW91dExpbmVCb3hlcyhyZWxheW91dENo aWxkcmVuLCByZXBhaW50TG9naWNhbFRvcCwgcmVwYWludExvZ2ljYWxCb3R0b20pOwogICAgICAg ICAvLyBUaGlzIG1hdGNoZXMgcmVsYXlvdXRUb0F2b2lkV2lkb3dzLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5oIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5oCmluZGV4IDZmODgzYmIzNWQ4Li41OTk5YTk4NTVl NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuaApAQCAtNTQw LDYgKzU0MCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgYWRqdXN0SW5saW5lRGlyZWN0 aW9uTGluZUJvdW5kcyhpbnQgLyogZXhwYW5zaW9uT3Bwb3J0dW5pdHlDb3VudCAqLywgZmxvYXQm IC8qIGxvZ2ljYWxMZWZ0ICovLCBmbG9hdCYgLyogbG9naWNhbFdpZHRoICovKSBjb25zdCB7IH0K IAogcHJpdmF0ZToKKyAgICBib29sIGhhc0xpbmVMYXlvdXQoKSBjb25zdDsKICAgICBib29sIGhh c1NpbXBsZUxpbmVMYXlvdXQoKSBjb25zdDsKICAgICBib29sIGhhc0NvbXBsZXhMaW5lTGF5b3V0 KCkgY29uc3Q7CiAKQEAgLTU4OCw3ICs1ODksNyBAQCBwcm90ZWN0ZWQ6CiAKIHByaXZhdGU6CiAg ICAgVmFyaWFudDwKLSAgICAgICAgc3RkOjpudWxscHRyX3QsCisgICAgICAgIFdURjo6TW9ub3N0 YXRlLAogICAgICAgICBSZWY8U2ltcGxlTGluZUxheW91dDo6TGF5b3V0PiwKICNpZiBFTkFCTEUo TEFZT1VUX0ZPUk1BVFRJTkdfQ09OVEVYVCkKICAgICAgICAgc3RkOjp1bmlxdWVfcHRyPExheW91 dDo6UmVuZGVyQmxvY2tGbG93TGluZUxheW91dD4sCkBAIC02MDEsNiArNjAyLDExIEBAIHByaXZh dGU6CiAgICAgZnJpZW5kIGNsYXNzIENvbXBsZXhMaW5lTGF5b3V0OwogfTsKIAoraW5saW5lIGJv b2wgUmVuZGVyQmxvY2tGbG93OjpoYXNMaW5lTGF5b3V0KCkgY29uc3QKK3sKKyAgICByZXR1cm4g IVdURjo6aG9sZHNfYWx0ZXJuYXRpdmU8V1RGOjpNb25vc3RhdGU+KG1fbGluZUxheW91dCk7Cit9 CisKIGlubGluZSBib29sIFJlbmRlckJsb2NrRmxvdzo6aGFzQ29tcGxleExpbmVMYXlvdXQoKSBj b25zdAogewogICAgIHJldHVybiBXVEY6OmhvbGRzX2FsdGVybmF0aXZlPHN0ZDo6dW5pcXVlX3B0 cjxDb21wbGV4TGluZUxheW91dD4+KG1fbGluZUxheW91dCk7Cg==