204614 2019-11-26 05:35:23 -0800 [GTK] WebDriver: moving toplevel windows is not supported under wayland 2019-11-27 02:19:45 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned alex berto bugs-noreply ews-watchlist gustavo oldest_to_newest 1593648 0 cgarcia 2019-11-26 05:35:23 -0800 So we can stop trying and simply ignore the requests to move the window. 1593649 1 384347 cgarcia 2019-11-26 05:38:17 -0800 Created attachment 384347 Patch 1593650 2 ews-watchlist 2019-11-26 05:39:17 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1593811 3 384347 alex 2019-11-27 01:03:33 -0800 Comment on attachment 384347 Patch LGTM 1593819 4 cgarcia 2019-11-27 02:19:45 -0800 Committed r252898: <https://trac.webkit.org/changeset/252898> 384347 2019-11-26 05:38:17 -0800 2019-11-27 01:03:33 -0800 Patch wk2-wl-move-toplevel.diff text/plain 4923 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZTBlZjZhNDFlY2YuLmIzY2ZiNDUyNGQzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDE5LTExLTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBXZWJEcml2ZXI6IG1vdmluZyB0b3BsZXZlbCB3aW5kb3dz IGlzIG5vdCBzdXBwb3J0ZWQgdW5kZXIgd2F5bGFuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0NjE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU28gd2UgY2FuIHN0b3AgdHJ5aW5nIGFuZCBzaW1wbHkg aWdub3JlIHRoZSByZXF1ZXN0cyB0byBtb3ZlIHRoZSB3aW5kb3cuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL2dsaWIvV2ViS2l0VUlDbGllbnQuY3BwOgorICAgICAgICAoVUlDbGllbnQ6Ondp bmRvd0NvbmZpZ3VyZUV2ZW50Q2FsbGJhY2spOiBFbnN1cmUgd2Ugb25seSBtb3ZlIG9yIHJlc2l6 ZSB3aGVuIGFjdHVhbGx5IHJlcXVpcmVkIGFuZCByZWR1Y2UgdGhlCisgICAgICAgIHRpbWUgd2Ug d2FpdCBmb3IgY29uZmlndXJlIGV2ZW50cyB0byAyMDBtcyAoMSBzZWNvbmQgd2FzIHRvbyBsb25n KS4KKwogMjAxOS0xMS0yNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gVXBkYXRlIE9wdGlvbnNHVEsuY21ha2UgYW5kIE5F V1MgZm9yIDIuMjcuMyByZWxlYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHAKaW5kZXggNDc4MDEzNDJlYTYuLmY3Njk0MDdmZGM2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNs aWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0VUlD bGllbnQuY3BwCkBAIC0zNSw2ICszNSw3IEBACiAjaW5jbHVkZSAiV2ViUGFnZVByb3h5LmgiCiAj aW5jbHVkZSAiV2ViUHJvY2Vzc1Byb3h5LmgiCiAjaW5jbHVkZSAiV2Vic2l0ZURhdGFTdG9yZS5o IgorI2luY2x1ZGUgPFdlYkNvcmUvUGxhdGZvcm1EaXNwbGF5Lmg+CiAjaW5jbHVkZSA8d3RmL2ds aWIvR1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9nbGliL1J1bkxvb3BTb3VyY2VQcmlvcml0eS5o PgogCkBAIC0xNDIsMTEgKzE0MywxOCBAQCBwcml2YXRlOgogICAgIHN0YXRpYyBnYm9vbGVhbiB3 aW5kb3dDb25maWd1cmVFdmVudENhbGxiYWNrKEd0a1dpbmRvdyogd2luZG93LCBHZGtFdmVudENv bmZpZ3VyZSosIEdka1JlY3RhbmdsZSogdGFyZ2V0R2VvbWV0cnkpCiAgICAgewogICAgICAgICBH ZGtSZWN0YW5nbGUgZ2VvbWV0cnkgPSB7IDAsIDAsIDAsIDAgfTsKLSAgICAgICAgZ3RrX3dpbmRv d19nZXRfcG9zaXRpb24od2luZG93LCAmZ2VvbWV0cnkueCwgJmdlb21ldHJ5LnkpOworICAgICAg ICAvLyBQb3NpdGlvbiBhIHRvcGxldmVsIHdpbmRvdyBpcyBub3Qgc3VwcG9ydGVkIHVuZGVyIHdh eWxhbmQuCisgICAgICAgIGlmIChXZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXk6OnNoYXJlZERpc3Bs YXkoKS50eXBlKCkgIT0gV2ViQ29yZTo6UGxhdGZvcm1EaXNwbGF5OjpUeXBlOjpXYXlsYW5kKSB7 CisgICAgICAgICAgICBndGtfd2luZG93X2dldF9wb3NpdGlvbih3aW5kb3csICZnZW9tZXRyeS54 LCAmZ2VvbWV0cnkueSk7CisgICAgICAgICAgICBpZiAoZ2VvbWV0cnkueCAhPSB0YXJnZXRHZW9t ZXRyeS0+eCB8fCBnZW9tZXRyeS55ICE9IHRhcmdldEdlb21ldHJ5LT55KQorICAgICAgICAgICAg ICAgIHJldHVybiBGQUxTRTsKKyAgICAgICAgfQorCiAgICAgICAgIGd0a193aW5kb3dfZ2V0X3Np emUod2luZG93LCAmZ2VvbWV0cnkud2lkdGgsICZnZW9tZXRyeS5oZWlnaHQpOwotICAgICAgICBp ZiAoZ2VvbWV0cnkueCA9PSB0YXJnZXRHZW9tZXRyeS0+eCAmJiBnZW9tZXRyeS55ID09IHRhcmdl dEdlb21ldHJ5LT55ICYmIGdlb21ldHJ5LndpZHRoID09IHRhcmdldEdlb21ldHJ5LT53aWR0aCAm JiBnZW9tZXRyeS5oZWlnaHQgPT0gdGFyZ2V0R2VvbWV0cnktPmhlaWdodCkKLSAgICAgICAgICAg IFJ1bkxvb3A6OmN1cnJlbnQoKS5zdG9wKCk7CisgICAgICAgIGlmIChnZW9tZXRyeS53aWR0aCAh PSB0YXJnZXRHZW9tZXRyeS0+d2lkdGggfHwgZ2VvbWV0cnkuaGVpZ2h0ICE9IHRhcmdldEdlb21l dHJ5LT5oZWlnaHQpCisgICAgICAgICAgICByZXR1cm4gRkFMU0U7CiAKKyAgICAgICAgUnVuTG9v cDo6Y3VycmVudCgpLnN0b3AoKTsKICAgICAgICAgcmV0dXJuIEZBTFNFOwogICAgIH0KIApAQCAt MTYyLDIwICsxNzAsMzcgQEAgcHJpdmF0ZToKICAgICAgICAgR2RrUmVjdGFuZ2xlIGdlb21ldHJ5 ID0gV2ViQ29yZTo6SW50UmVjdChmcmFtZSk7CiAgICAgICAgIEd0a1dpZGdldCogd2luZG93ID0g Z3RrX3dpZGdldF9nZXRfdG9wbGV2ZWwoR1RLX1dJREdFVChtX3dlYlZpZXcpKTsKICAgICAgICAg aWYgKHdlYmtpdF93ZWJfdmlld19pc19jb250cm9sbGVkX2J5X2F1dG9tYXRpb24obV93ZWJWaWV3 KSAmJiBXZWJDb3JlOjp3aWRnZXRJc09uc2NyZWVuVG9wbGV2ZWxXaW5kb3cod2luZG93KSAmJiBn dGtfd2lkZ2V0X2dldF92aXNpYmxlKHdpbmRvdykpIHsKLSAgICAgICAgICAgIGlmICgoZ2VvbWV0 cnkueCA8IDAgfHwgZ2VvbWV0cnkueSA8IDApICYmIChnZW9tZXRyeS53aWR0aCA8PSAwIHx8IGdl b21ldHJ5LmhlaWdodCA8PSAwKSkKKyAgICAgICAgICAgIGJvb2wgbmVlZHNNb3ZlID0gZmFsc2U7 CisgICAgICAgICAgICAvLyBQb3NpdGlvbiBhIHRvcGxldmVsIHdpbmRvdyBpcyBub3Qgc3VwcG9y dGVkIHVuZGVyIHdheWxhbmQuCisgICAgICAgICAgICBpZiAoV2ViQ29yZTo6UGxhdGZvcm1EaXNw bGF5OjpzaGFyZWREaXNwbGF5KCkudHlwZSgpICE9IFdlYkNvcmU6OlBsYXRmb3JtRGlzcGxheTo6 VHlwZTo6V2F5bGFuZCkgeworICAgICAgICAgICAgICAgIGlmIChnZW9tZXRyeS54ID49IDAgJiYg Z2VvbWV0cnkueSA+PSAwKSB7CisgICAgICAgICAgICAgICAgICAgIGludCB4LCB5OworICAgICAg ICAgICAgICAgICAgICBndGtfd2luZG93X2dldF9wb3NpdGlvbihHVEtfV0lORE9XKHdpbmRvdyks ICZ4LCAmeSk7CisgICAgICAgICAgICAgICAgICAgIG5lZWRzTW92ZSA9IHggIT0gZ2VvbWV0cnku eCB8fCB5ICE9IGdlb21ldHJ5Lnk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQor CisgICAgICAgICAgICBib29sIG5lZWRzUmVzaXplID0gZmFsc2U7CisgICAgICAgICAgICBpZiAo Z2VvbWV0cnkud2lkdGggPiAwICYmIGdlb21ldHJ5LmhlaWdodCA+IDApIHsKKyAgICAgICAgICAg ICAgICBpbnQgd2lkdGgsIGhlaWdodDsKKyAgICAgICAgICAgICAgICBndGtfd2luZG93X2dldF9z aXplKEdUS19XSU5ET1cod2luZG93KSwgJndpZHRoLCAmaGVpZ2h0KTsKKyAgICAgICAgICAgICAg ICBuZWVkc1Jlc2l6ZSA9IHdpZHRoICE9IGdlb21ldHJ5LndpZHRoIHx8IGhlaWdodCAhPSBnZW9t ZXRyeS5oZWlnaHQ7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGlmICghbmVlZHNNb3Zl ICYmICFuZWVkc1Jlc2l6ZSkKICAgICAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgICAg IGF1dG8gc2lnbmFsSUQgPSBnX3NpZ25hbF9jb25uZWN0KHdpbmRvdywgImNvbmZpZ3VyZS1ldmVu dCIsIEdfQ0FMTEJBQ0sod2luZG93Q29uZmlndXJlRXZlbnRDYWxsYmFjayksICZnZW9tZXRyeSk7 Ci0gICAgICAgICAgICBpZiAoZ2VvbWV0cnkueCA+PSAwICYmIGdlb21ldHJ5LnkgPj0gMCkKKyAg ICAgICAgICAgIGlmIChuZWVkc01vdmUpCiAgICAgICAgICAgICAgICAgZ3RrX3dpbmRvd19tb3Zl KEdUS19XSU5ET1cod2luZG93KSwgZ2VvbWV0cnkueCwgZ2VvbWV0cnkueSk7Ci0gICAgICAgICAg ICBpZiAoZ2VvbWV0cnkud2lkdGggPiAwICYmIGdlb21ldHJ5LmhlaWdodCA+IDApCisgICAgICAg ICAgICBpZiAobmVlZHNSZXNpemUpCiAgICAgICAgICAgICAgICAgZ3RrX3dpbmRvd19yZXNpemUo R1RLX1dJTkRPVyh3aW5kb3cpLCBnZW9tZXRyeS53aWR0aCwgZ2VvbWV0cnkuaGVpZ2h0KTsKIAog ICAgICAgICAgICAgLy8gV2UgbmVlZCB0aGUgbW92ZS9yZXNpemUgdG8gaGFwcGVuIHN5bmNocm9u b3VzbHkgaW4gYXV0b21hdGlvbiBtb2RlLCBzbyB3ZSB1c2UgYSBuZXN0ZWQgUnVuTG9vcAotICAg ICAgICAgICAgLy8gdG8gd2FpdCwgdXAgdG9wIDEgc2Vjb25kLCBmb3IgdGhlIGNvbmZpZ3VyZSBl dmVudHMuCisgICAgICAgICAgICAvLyB0byB3YWl0LCB1cCB0b3AgMjAwIG1pbGxpc2Vjb25kcywg Zm9yIHRoZSBjb25maWd1cmUgZXZlbnRzLgogICAgICAgICAgICAgYXV0byB0aW1lciA9IG1ha2VV bmlxdWU8UnVuTG9vcDo6VGltZXI8VUlDbGllbnQ+PihSdW5Mb29wOjptYWluKCksIHRoaXMsICZV SUNsaWVudDo6c2V0V2luZG93RnJhbWVUaW1lckZpcmVkKTsKICAgICAgICAgICAgIHRpbWVyLT5z ZXRQcmlvcml0eShSdW5Mb29wU291cmNlUHJpb3JpdHk6OlJ1bkxvb3BUaW1lcik7Ci0gICAgICAg ICAgICB0aW1lci0+c3RhcnRPbmVTaG90KDFfcyk7CisgICAgICAgICAgICB0aW1lci0+c3RhcnRP bmVTaG90KDIwMF9tcyk7CiAgICAgICAgICAgICBSdW5Mb29wOjpydW4oKTsKICAgICAgICAgICAg IHRpbWVyID0gbnVsbHB0cjsKICAgICAgICAgICAgIGdfc2lnbmFsX2hhbmRsZXJfZGlzY29ubmVj dCh3aW5kb3csIHNpZ25hbElEKTsK