204586 2019-11-25 09:58:49 -0800 [LFC] Do not run layout when setNeedsLayout is disabled 2019-11-25 11:06:33 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1593472 0 zalan 2019-11-25 09:58:49 -0800 FrameView::setContentsSize temporary disables layout. 1593473 1 webkit-bug-importer 2019-11-25 09:59:09 -0800 <rdar://problem/57475333> 1593474 2 384305 zalan 2019-11-25 10:04:03 -0800 Created attachment 384305 Patch 1593479 3 384307 zalan 2019-11-25 10:22:17 -0800 Created attachment 384307 Patch 1593485 4 384307 commit-queue 2019-11-25 11:06:31 -0800 Comment on attachment 384307 Patch Clearing flags on attachment: 384307 Committed r252866: <https://trac.webkit.org/changeset/252866> 1593486 5 commit-queue 2019-11-25 11:06:33 -0800 All reviewed patches have been landed. Closing bug. 384305 2019-11-25 10:04:03 -0800 2019-11-25 10:22:15 -0800 Patch bug-204586-20191125100337.patch text/plain 3571 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmY2ZWI0MmRlMWI5ODk5 NzUxY2Y3MTBkYTY5ZDY4M2E4MDQxZGExNi4uZDc4NDE3ZTMyMjU1NjA0N2Y5MDg3ZTQ5MWEwNzIw M2VlZWViYjE0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTExLTI1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gRG8gbm90IHJ1biBs YXlvdXQgd2hlbiBzZXROZWVkc0xheW91dCBpcyBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0NTg2CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS81NzQ3NTMzMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBzZXROZWVkc0xheW91dCBpcyBkaXNhYmxlZCB3aGlsZSB0aGUgY29udGVudCBzaXpl IGlzIHNldCBvbiB0aGUgU2Nyb2xsVmlldy4gSXQgdHJpZ2dlcnMgYSBmb3JjZWQgbGF5b3V0IGlu IFdlYmtpdExlZ2FjeS4KKworICAgICAgICAqIGxheW91dC9MYXlvdXRDb250ZXh0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGF5b3V0Q29udGV4dDo6bGF5b3V0KToKKyAgICAgICAg KiBwYWdlL0ZyYW1lVmlld0xheW91dENvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJh bWVWaWV3TGF5b3V0Q29udGV4dDo6bGF5b3V0VXNpbmdGb3JtYXR0aW5nQ29udGV4dCk6CisKIDIw MTktMTEtMjUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZD XVtJRkNdIFJlbmFtZSBMaW5lTGF5b3V0IHRvIExpbmVMYXlvdXRDb250ZXh0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvTGF5b3V0Q29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvTGF5b3V0Q29udGV4dC5jcHAKaW5kZXggMmUwMmJkNzc1NzEwYTQ0ZTcwMWY1MTA0 MWYwZTc5ODJmMDZjZGEzNy4uODQ4NDdjMGM1NTQyMjllYzdhZGUzYTc3NTYzOWIyODhkZGZlN2M2 YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L0xheW91dENvbnRleHQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlvdXRDb250ZXh0LmNwcApAQCAtNTksNiArNTks MTEgQEAgTGF5b3V0Q29udGV4dDo6TGF5b3V0Q29udGV4dChMYXlvdXRTdGF0ZSYgbGF5b3V0U3Rh dGUpCiB2b2lkIExheW91dENvbnRleHQ6OmxheW91dChjb25zdCBMYXlvdXRTaXplJiByb290Q29u dGVudEJveFNpemUsIEludmFsaWRhdGlvblN0YXRlJiBpbnZhbGlkYXRpb25TdGF0ZSkKIHsKICAg ICBQaGFzZVNjb3BlIHNjb3BlKFBoYXNlOjpUeXBlOjpMYXlvdXQpOworCisgICAgYXV0byYgZm9y bWF0dGluZ0NvbnRleHRSb290c0ZvckxheW91dCA9IGludmFsaWRhdGlvblN0YXRlLmZvcm1hdHRp bmdDb250ZXh0Um9vdHMoKTsKKyAgICBpZiAoZm9ybWF0dGluZ0NvbnRleHRSb290c0ZvckxheW91 dC5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybjsKKwogICAgIC8vIFNldCB0aGUgZ2VvbWV0cnkg b24gdGhlIHJvb3QuCiAgICAgLy8gTm90ZSB0aGF0IHdlIG5ldmVyIGxheW91dCB0aGUgcm9vdCBi b3guIEl0IGhhcyB0byBoYXZlIGFuIGFscmVhZHkgY29tcHV0ZWQgZ2VvbWV0cnkgKGluIGNhc2Ug b2YgSUNCLCBpdCdzIHRoZSB2aWV3IGdlb21ldHJ5KS4KICAgICAvLyBJQ0IgZXN0YWJsaXNoZXMg dGhlIGluaXRpYWwgQkZDLCBidXQgaXQgZG9lcyBub3QgbGl2ZSBpbiBhIGZvcm1hdHRpbmcgY29u dGV4dCBhbmQgd2hpbGUgYSBub24tSUNCIHJvb3Qoc3VidHJlZSBsYXlvdXQpIGhhcyB0byBoYXZl IGEgZm9ybWF0dGluZyBjb250ZXh0LApAQCAtNzIsOSArNzcsNiBAQCB2b2lkIExheW91dENvbnRl eHQ6OmxheW91dChjb25zdCBMYXlvdXRTaXplJiByb290Q29udGVudEJveFNpemUsIEludmFsaWRh dGlvblN0YQogICAgIGRpc3BsYXlCb3guc2V0VG9wTGVmdCh7IH0pOwogICAgIGRpc3BsYXlCb3gu c2V0Q29udGVudEJveEhlaWdodChyb290Q29udGVudEJveFNpemUuaGVpZ2h0KCkpOwogICAgIGRp c3BsYXlCb3guc2V0Q29udGVudEJveFdpZHRoKHJvb3RDb250ZW50Qm94U2l6ZS53aWR0aCgpKTsK LQotICAgIGF1dG8mIGZvcm1hdHRpbmdDb250ZXh0Um9vdHNGb3JMYXlvdXQgPSBpbnZhbGlkYXRp b25TdGF0ZS5mb3JtYXR0aW5nQ29udGV4dFJvb3RzKCk7Ci0gICAgQVNTRVJUKCFmb3JtYXR0aW5n Q29udGV4dFJvb3RzRm9yTGF5b3V0LmNvbXB1dGVzRW1wdHkoKSk7CiAgICAgZm9yIChhdXRvJiBm b3JtYXR0aW5nQ29udGV4dFJvb3QgOiBmb3JtYXR0aW5nQ29udGV4dFJvb3RzRm9yTGF5b3V0KQog ICAgICAgICBsYXlvdXRGb3JtYXR0aW5nQ29udGV4dFN1YnRyZWUoZm9ybWF0dGluZ0NvbnRleHRS b290LCBpbnZhbGlkYXRpb25TdGF0ZSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL0ZyYW1lVmlld0xheW91dENvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZVZpZXdMYXlvdXRDb250ZXh0LmNwcAppbmRleCA5NzRjMmRmMDBlMTc4ZGRlMzc5MTZhM2I0YjAy OWM4ZTdhNDY2MzdhLi4xNmNmNDFiNzcwMTRmN2I3ZTYyOWU5MTU0MzRlZmIwYWI2ZWRlZTMxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlld0xheW91dENvbnRleHQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3TGF5b3V0Q29udGV4dC5jcHAKQEAg LTczLDcgKzczLDEwIEBAIHZvaWQgRnJhbWVWaWV3TGF5b3V0Q29udGV4dDo6bGF5b3V0VXNpbmdG b3JtYXR0aW5nQ29udGV4dCgpCiAgICAgLy8gRklYTUU6IFRoaXMgaXMgbm90IHRoZSByZWFsIGlu dmFsaWRhdGlvbiB5ZXQuCiAgICAgYXV0byBpbnZhbGlkYXRpb25TdGF0ZSA9IExheW91dDo6SW52 YWxpZGF0aW9uU3RhdGUgeyB9OwogICAgIGF1dG8gaW52YWxpZGF0aW9uQ29udGV4dCA9IExheW91 dDo6SW52YWxpZGF0aW9uQ29udGV4dCB7IGludmFsaWRhdGlvblN0YXRlIH07Ci0gICAgaW52YWxp ZGF0aW9uQ29udGV4dC5zdHlsZUNoYW5nZWQoKm1fbGF5b3V0U3RhdGUtPnJvb3QoKS5maXJzdENo aWxkKCksIFN0eWxlRGlmZmVyZW5jZTo6TGF5b3V0KTsKKworICAgIC8vIEZyYW1lVmlldzo6c2V0 Q29udGVudHNTaXplIHRlbXBvcmFyeSBkaXNhYmxlcyBsYXlvdXQuCisgICAgaWYgKCFtX2Rpc2Fi bGVTZXROZWVkc0xheW91dENvdW50KQorICAgICAgICBpbnZhbGlkYXRpb25Db250ZXh0LnN0eWxl Q2hhbmdlZCgqbV9sYXlvdXRTdGF0ZS0+cm9vdCgpLmZpcnN0Q2hpbGQoKSwgU3R5bGVEaWZmZXJl bmNlOjpMYXlvdXQpOwogCiAgICAgYXV0byBsYXlvdXRDb250ZXh0ID0gTGF5b3V0OjpMYXlvdXRD b250ZXh0IHsgKm1fbGF5b3V0U3RhdGUgfTsKICAgICBsYXlvdXRDb250ZXh0LmxheW91dCh2aWV3 KCkubGF5b3V0U2l6ZSgpLCBpbnZhbGlkYXRpb25TdGF0ZSk7Cg== 384307 2019-11-25 10:22:17 -0800 2019-11-25 11:06:31 -0800 Patch bug-204586-20191125102150.patch text/plain 3577 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmY2ZWI0MmRlMWI5ODk5 NzUxY2Y3MTBkYTY5ZDY4M2E4MDQxZGExNi4uZjU1ZGYxMDcyYmQwOGIxYWQxNzY1MWRmNjc4Y2I1 MjdhMjFhMjFjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTExLTI1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gRG8gbm90IHJ1biBs YXlvdXQgd2hlbiBzZXROZWVkc0xheW91dCBpcyBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0NTg2CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS81NzQ3NTMzMz4KKworICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KKwor ICAgICAgICBzZXROZWVkc0xheW91dCBpcyBkaXNhYmxlZCB3aGlsZSB0aGUgY29udGVudCBzaXpl IGlzIHNldCBvbiB0aGUgU2Nyb2xsVmlldy4gSXQgdHJpZ2dlcnMgYSBmb3JjZWQgbGF5b3V0IGlu IFdlYmtpdExlZ2FjeS4KKworICAgICAgICAqIGxheW91dC9MYXlvdXRDb250ZXh0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGF5b3V0Q29udGV4dDo6bGF5b3V0KToKKyAgICAgICAg KiBwYWdlL0ZyYW1lVmlld0xheW91dENvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJh bWVWaWV3TGF5b3V0Q29udGV4dDo6bGF5b3V0VXNpbmdGb3JtYXR0aW5nQ29udGV4dCk6CisKIDIw MTktMTEtMjUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZD XVtJRkNdIFJlbmFtZSBMaW5lTGF5b3V0IHRvIExpbmVMYXlvdXRDb250ZXh0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvTGF5b3V0Q29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvTGF5b3V0Q29udGV4dC5jcHAKaW5kZXggMmUwMmJkNzc1NzEwYTQ0ZTcwMWY1MTA0 MWYwZTc5ODJmMDZjZGEzNy4uZjdhNDdmOWI4NjU5NmU5ZmM1Y2RjMTc3ZTZkNjM2YmY0NDA3MzIx NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L0xheW91dENvbnRleHQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlvdXRDb250ZXh0LmNwcApAQCAtNTksNiArNTks MTEgQEAgTGF5b3V0Q29udGV4dDo6TGF5b3V0Q29udGV4dChMYXlvdXRTdGF0ZSYgbGF5b3V0U3Rh dGUpCiB2b2lkIExheW91dENvbnRleHQ6OmxheW91dChjb25zdCBMYXlvdXRTaXplJiByb290Q29u dGVudEJveFNpemUsIEludmFsaWRhdGlvblN0YXRlJiBpbnZhbGlkYXRpb25TdGF0ZSkKIHsKICAg ICBQaGFzZVNjb3BlIHNjb3BlKFBoYXNlOjpUeXBlOjpMYXlvdXQpOworCisgICAgYXV0byYgZm9y bWF0dGluZ0NvbnRleHRSb290c0ZvckxheW91dCA9IGludmFsaWRhdGlvblN0YXRlLmZvcm1hdHRp bmdDb250ZXh0Um9vdHMoKTsKKyAgICBpZiAoZm9ybWF0dGluZ0NvbnRleHRSb290c0ZvckxheW91 dC5jb21wdXRlc0VtcHR5KCkpCisgICAgICAgIHJldHVybjsKKwogICAgIC8vIFNldCB0aGUgZ2Vv bWV0cnkgb24gdGhlIHJvb3QuCiAgICAgLy8gTm90ZSB0aGF0IHdlIG5ldmVyIGxheW91dCB0aGUg cm9vdCBib3guIEl0IGhhcyB0byBoYXZlIGFuIGFscmVhZHkgY29tcHV0ZWQgZ2VvbWV0cnkgKGlu IGNhc2Ugb2YgSUNCLCBpdCdzIHRoZSB2aWV3IGdlb21ldHJ5KS4KICAgICAvLyBJQ0IgZXN0YWJs aXNoZXMgdGhlIGluaXRpYWwgQkZDLCBidXQgaXQgZG9lcyBub3QgbGl2ZSBpbiBhIGZvcm1hdHRp bmcgY29udGV4dCBhbmQgd2hpbGUgYSBub24tSUNCIHJvb3Qoc3VidHJlZSBsYXlvdXQpIGhhcyB0 byBoYXZlIGEgZm9ybWF0dGluZyBjb250ZXh0LApAQCAtNzIsOSArNzcsNiBAQCB2b2lkIExheW91 dENvbnRleHQ6OmxheW91dChjb25zdCBMYXlvdXRTaXplJiByb290Q29udGVudEJveFNpemUsIElu dmFsaWRhdGlvblN0YQogICAgIGRpc3BsYXlCb3guc2V0VG9wTGVmdCh7IH0pOwogICAgIGRpc3Bs YXlCb3guc2V0Q29udGVudEJveEhlaWdodChyb290Q29udGVudEJveFNpemUuaGVpZ2h0KCkpOwog ICAgIGRpc3BsYXlCb3guc2V0Q29udGVudEJveFdpZHRoKHJvb3RDb250ZW50Qm94U2l6ZS53aWR0 aCgpKTsKLQotICAgIGF1dG8mIGZvcm1hdHRpbmdDb250ZXh0Um9vdHNGb3JMYXlvdXQgPSBpbnZh bGlkYXRpb25TdGF0ZS5mb3JtYXR0aW5nQ29udGV4dFJvb3RzKCk7Ci0gICAgQVNTRVJUKCFmb3Jt YXR0aW5nQ29udGV4dFJvb3RzRm9yTGF5b3V0LmNvbXB1dGVzRW1wdHkoKSk7CiAgICAgZm9yIChh dXRvJiBmb3JtYXR0aW5nQ29udGV4dFJvb3QgOiBmb3JtYXR0aW5nQ29udGV4dFJvb3RzRm9yTGF5 b3V0KQogICAgICAgICBsYXlvdXRGb3JtYXR0aW5nQ29udGV4dFN1YnRyZWUoZm9ybWF0dGluZ0Nv bnRleHRSb290LCBpbnZhbGlkYXRpb25TdGF0ZSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlld0xheW91dENvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZVZpZXdMYXlvdXRDb250ZXh0LmNwcAppbmRleCA5NzRjMmRmMDBlMTc4ZGRlMzc5MTZh M2I0YjAyOWM4ZTdhNDY2MzdhLi4xNmNmNDFiNzcwMTRmN2I3ZTYyOWU5MTU0MzRlZmIwYWI2ZWRl ZTMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlld0xheW91dENvbnRl eHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3TGF5b3V0Q29udGV4dC5j cHAKQEAgLTczLDcgKzczLDEwIEBAIHZvaWQgRnJhbWVWaWV3TGF5b3V0Q29udGV4dDo6bGF5b3V0 VXNpbmdGb3JtYXR0aW5nQ29udGV4dCgpCiAgICAgLy8gRklYTUU6IFRoaXMgaXMgbm90IHRoZSBy ZWFsIGludmFsaWRhdGlvbiB5ZXQuCiAgICAgYXV0byBpbnZhbGlkYXRpb25TdGF0ZSA9IExheW91 dDo6SW52YWxpZGF0aW9uU3RhdGUgeyB9OwogICAgIGF1dG8gaW52YWxpZGF0aW9uQ29udGV4dCA9 IExheW91dDo6SW52YWxpZGF0aW9uQ29udGV4dCB7IGludmFsaWRhdGlvblN0YXRlIH07Ci0gICAg aW52YWxpZGF0aW9uQ29udGV4dC5zdHlsZUNoYW5nZWQoKm1fbGF5b3V0U3RhdGUtPnJvb3QoKS5m aXJzdENoaWxkKCksIFN0eWxlRGlmZmVyZW5jZTo6TGF5b3V0KTsKKworICAgIC8vIEZyYW1lVmll dzo6c2V0Q29udGVudHNTaXplIHRlbXBvcmFyeSBkaXNhYmxlcyBsYXlvdXQuCisgICAgaWYgKCFt X2Rpc2FibGVTZXROZWVkc0xheW91dENvdW50KQorICAgICAgICBpbnZhbGlkYXRpb25Db250ZXh0 LnN0eWxlQ2hhbmdlZCgqbV9sYXlvdXRTdGF0ZS0+cm9vdCgpLmZpcnN0Q2hpbGQoKSwgU3R5bGVE aWZmZXJlbmNlOjpMYXlvdXQpOwogCiAgICAgYXV0byBsYXlvdXRDb250ZXh0ID0gTGF5b3V0OjpM YXlvdXRDb250ZXh0IHsgKm1fbGF5b3V0U3RhdGUgfTsKICAgICBsYXlvdXRDb250ZXh0LmxheW91 dCh2aWV3KCkubGF5b3V0U2l6ZSgpLCBpbnZhbGlkYXRpb25TdGF0ZSk7Cg==