20457 2008-08-20 06:01:50 -0700 Canvas: createPattern crashes WebKit with a 1D pattern 2008-09-15 04:36:15 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://philip.html5.org/tests/canvas/suite/tests/2d.pattern.basic.zerocanvas.html HasReduction, InRadar P1 Normal --- 1 krit andersca oldest_to_newest 88914 0 krit 2008-08-20 06:01:50 -0700 If you create a 1 dimensional (width==0 || height==0) Pattern in Canvas, WebKit will crash. 88917 1 ap 2008-08-20 06:33:06 -0700 Reproducible crash -> P1. Thread 0 Crashed: 0 com.apple.WebCore 0x0322d99d WTF::RefPtr<WebCore::Image>::operator!() const + 9 (RefPtr.h:63) 1 com.apple.WebCore 0x034aaa81 WebCore::ImageBuffer::image() const + 27 (ImageBufferCG.cpp:99) 2 com.apple.WebCore 0x032340f7 WebCore::CanvasRenderingContext2D::createPattern(WebCore::HTMLCanvasElement*, WebCore::String const&, int&) + 135 (CanvasRenderingContext2D.cpp:1154) 3 com.apple.WebCore 0x034f431d WebCore::JSCanvasRenderingContext2D::createPattern(KJS::ExecState*, KJS::ArgList const&) + 545 (JSCanvasRenderingContext2DCustom.cpp:328) 4 com.apple.WebCore 0x034eff04 WebCore::jsCanvasRenderingContext2DPrototypeFunctionCreatePattern(KJS::ExecState*, KJS::JSObject*, KJS::JSValue*, KJS::ArgList const&) + 96 (JSCanvasRenderingContext2D.cpp:780) 88946 2 mrowe 2008-08-20 15:07:44 -0700 <rdar://problem/6163988> 91193 3 23434 andersca 2008-09-15 02:47:53 -0700 Created attachment 23434 Patch 91194 4 23434 mjs 2008-09-15 02:49:24 -0700 Comment on attachment 23434 Patch r=me 91198 5 andersca 2008-09-15 04:36:15 -0700 Committed revision 36442. 23434 2008-09-15 02:47:53 -0700 2008-09-15 02:49:24 -0700 Patch textmate stdin eU8aPE.txt text/plain 3895 andersca SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNjQzMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMDktMTUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNjE2Mzk4OD4gCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ1NworICAgICAgICBDYW52YXM6IGNyZWF0ZVBhdHRlcm4g Y3Jhc2hlcyBXZWJLaXQgaW4gV1RGOjpSZWZQdHI8V2ViQ29yZTo6SW1hZ2U+OjpvcGVyYXRvciEo KSBjb25zdCArIDkgd2l0aCBhIDFEIHBhdHRlcm4KKyAgICAgICAgCisgICAgICAgIENoZWNrIHRo ZSB3aWR0aCBhbmQgaGVpZ2h0IGFuZCB0aHJvdyBhbiBleGNlcHRpb24gaWYgYW55IG9mIHRoZW0g YXJlIDAuCisgICAgICAgIAorICAgICAgICAqIGh0bWwvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJE LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6Y3JlYXRl UGF0dGVybik6CisKIDIwMDgtMDktMTUgIERhdmlkIFNtaXRoICA8Y2F0ZmlzaC5tYW5AZ21haWwu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCkluZGV4OiBXZWJDb3JlL2h0 bWwvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0 bWwvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAkocmV2aXNpb24gMzY0MjkpCisrKyBXZWJD b3JlL2h0bWwvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTAzNCw2ICsxMDM0LDExIEBAIFBhc3NSZWZQdHI8Q2FudmFzUGF0dGVybj4gQ2FudmFzUmVuZGVy aW4KIFBhc3NSZWZQdHI8Q2FudmFzUGF0dGVybj4gQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpj cmVhdGVQYXR0ZXJuKEhUTUxDYW52YXNFbGVtZW50KiBjYW52YXMsCiAgICAgY29uc3QgU3RyaW5n JiByZXBldGl0aW9uVHlwZSwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7CisgICAgaWYgKCFjYW52YXMt PndpZHRoKCkgfHwgIWNhbnZhcy0+aGVpZ2h0KCkpIHsKKyAgICAgICAgZWMgPSBJTlZBTElEX1NU QVRFX0VSUjsKKyAgICAgICAgcmV0dXJuIDA7CisgICAgfQorICAgIAogICAgIGJvb2wgcmVwZWF0 WCwgcmVwZWF0WTsKICAgICBlYyA9IDA7CiAgICAgQ2FudmFzUGF0dGVybjo6cGFyc2VSZXBldGl0 aW9uVHlwZShyZXBldGl0aW9uVHlwZSwgcmVwZWF0WCwgcmVwZWF0WSwgZWMpOwpJbmRleDogTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwko cmV2aXNpb24gMzY0MzMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNiBAQAorMjAwOC0wOS0xNSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FA YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAg ICAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYxNjM5ODg+IAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0NTcKKyAgICAgICAgQ2FudmFzOiBjcmVh dGVQYXR0ZXJuIGNyYXNoZXMgV2ViS2l0IGluIFdURjo6UmVmUHRyPFdlYkNvcmU6OkltYWdlPjo6 b3BlcmF0b3IhKCkgY29uc3QgKyA5IHdpdGggYSAxRCBwYXR0ZXJuCisgICAgICAgIAorICAgICAg ICBBZGQgdGVzdCBmb3IgY3JlYXRlUGF0dGVybiB3aGVyZSB0aGUgY2FudmFzIHBhc3NlZCBpbiBo YXMgYSB6ZXJvIGhlaWdodC93aWR0aC4KKyAgICAgICAgCisgICAgICAgICogZmFzdC9jYW52YXMv Y2FudmFzLXdpdGgtaW5jb3JyZWN0LWFyZ3MtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3Qv Y2FudmFzL2NhbnZhcy13aXRoLWluY29ycmVjdC1hcmdzLmh0bWw6CisKIDIwMDgtMDktMTQgIEFs ZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IE1hY2llaiBTdGFjaG93aWFrLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFz LXdpdGgtaW5jb3JyZWN0LWFyZ3MtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2Zhc3QvY2FudmFzL2NhbnZhcy13aXRoLWluY29ycmVjdC1hcmdzLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMzY0MjkpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtd2l0aC1p bmNvcnJlY3QtYXJncy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTU2LDQgKzU2LDUg QEAgUEFTUyBkaWQgbm90IHRocm93IGV4Y2VwdGlvbiBvbiBiZXppZXJDdQogUEFTUyBkaWQgbm90 IHRocm93IGV4Y2VwdGlvbiBvbiBiZXppZXJDdXJ2ZVRvKE5hTiwgTmFOLCAyMCwgMjAsIDMwLCAz MCkuCiBQQVNTIGRpZCBub3QgdGhyb3cgZXhjZXB0aW9uIG9uIGJlemllckN1cnZlVG8oMjAsIE5h TiwgMjAsIDIwLCAzMCwgMzApLgogUEFTUyBkaWQgbm90IHRocm93IGV4Y2VwdGlvbiBvbiBiZXpp ZXJDdXJ2ZVRvKE5hTiwgMjAsIDIwLCAyMCwgMzAsIDMwKS4KK1BBU1MgdGhyZXcgZXhjZXB0aW9u IGNvZGUgdW5kZWZpbmVkIG9uIGNyZWF0ZVBhdHRlcm4gd2l0aCAweDAgY2FudmFzLgogCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtd2l0aC1pbmNvcnJlY3QtYXJncy5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy13aXRoLWluY29y cmVjdC1hcmdzLmh0bWwJKHJldmlzaW9uIDM2NDI5KQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52 YXMvY2FudmFzLXdpdGgtaW5jb3JyZWN0LWFyZ3MuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNDcy LDExICs0NzIsMTkgQEAgZnVuY3Rpb24gcnVuVGVzdCgpIHsKICAgICB9CiAgICAgY29udGV4dC5j bG9zZVBhdGgoKTsKIAorICAgIHZhciBjYW52YXMyID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgn Y2FudmFzJyk7CisgICAgY2FudmFzMi53aWR0aCA9IDA7CisgICAgY2FudmFzMi5oZWlnaHQgPSAw OworICAgIHRyeSB7CisgICAgICAgIHZhciBwYXR0ZXJuID0gY3R4LmNyZWF0ZVBhdHRlcm4oY2Fu dmFzMiwgJ3JlcGVhdCcpOworICAgICAgICBmYWlsKCJkaWQgbm90IHRocm93IGV4Y2VwdGlvbiBv biBjcmVhdGVQYXR0ZXJuIHdpdGggMHgwIGNhbnZhcy4iKQorICAgIH0gY2F0Y2ggKGUpIHsKKyAg ICAgICAgcGFzcygidGhyZXcgZXhjZXB0aW9uIGNvZGUgIiArIGUuY29kZSArICIgb24gY3JlYXRl UGF0dGVybiB3aXRoIDB4MCBjYW52YXMuIikKKyAgICB9CiAgICAgaWYgKCFmYWlsZWQpIHsKICAg ICAgICAgY29udGV4dC5maWxsU3R5bGUgPSAnIzBmMCc7CiAgICAgICAgIGNvbnRleHQuZmlsbFJl Y3QoMCwgMCwgY2FudmFzLndpZHRoLCBjYW52YXMuaGVpZ2h0KTsKICAgICB9Ci0KICAgICBpZiAo d2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5kdW1wQXNUZXh0KCk7CiB9Cg==