204565 2019-11-24 23:18:01 -0800 Queuing a task in EventLoop is not working with UserMediaRequest allow completion handler 2019-11-26 00:30:50 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf cdumez commit-queue eric.carlson ews-watchlist glenn hta jer.noble philipj rniwa sergio tommyw webkit-bug-importer youennf oldest_to_newest 1593328 0 youennf 2019-11-24 23:18:01 -0800 As can be seen from https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/r252843%20(823)/results.html, completion handlers given to UserMediaRequest::allow are not always called. ASSERTION FAILED: Completion handler should always be called !m_function /Volumes/Data/slave/catalina-debug/build/WebKitBuild/Debug/usr/local/include/wtf/CompletionHandler.h(53) : WTF::CompletionHandler<void ()>::~CompletionHandler() 1 0x4ab785659 WTFCrash 2 0x490e086b3 WTF::CompletionHandler<void ()>::~CompletionHandler() 3 0x490e08645 WTF::CompletionHandler<void ()>::~CompletionHandler() 4 0x492af75e3 WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&, WebCore::CaptureDevice&&, WTF::String&&, WTF::CompletionHandler<void ()>&&)::$_2::~$_2() 5 0x492af43d5 WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&, WebCore::CaptureDevice&&, WTF::String&&, WTF::CompletionHandler<void ()>&&)::$_2::~$_2() 6 0x492b01511 WTF::Detail::CallableWrapper<WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&, WebCore::CaptureDevice&&, WTF::String&&, WTF::CompletionHandler<void ()>&&)::$_2, void>::~CallableWrapper() 7 0x492b013f5 WTF::Detail::CallableWrapper<WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&, WebCore::CaptureDevice&&, WTF::String&&, WTF::CompletionHandler<void ()>&&)::$_2, void>::~CallableWrapper() 8 0x492b01419 WTF::Detail::CallableWrapper<WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&, WebCore::CaptureDevice&&, WTF::String&&, WTF::CompletionHandler<void ()>&&)::$_2, void>::~CallableWrapper() 9 0x490da79ff std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> >::operator()(WTF::Detail::CallableWrapperBase<void>*) const 10 0x490da79bf std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> > >::reset(WTF::Detail::CallableWrapperBase<void>*) 11 0x490da7959 std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> > >::~unique_ptr() 12 0x490da7935 std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> > >::~unique_ptr() 13 0x490da7915 WTF::Function<void ()>::~Function() 14 0x490da78f5 WTF::Function<void ()>::~Function() 15 0x492b00f13 void WebCore::ActiveDOMObject::queueTaskKeepingObjectAlive<WebCore::UserMediaRequest>(WebCore::UserMediaRequest&, WebCore::TaskSource, WTF::Function<void ()>&&)::'lambda'()::~() 16 0x492b00105 void WebCore::ActiveDOMObject::queueTaskKeepingObjectAlive<WebCore::UserMediaRequest>(WebCore::UserMediaRequest&, WebCore::TaskSource, WTF::Function<void ()>&&)::'lambda'()::~() 17 0x492b00a41 WTF::Detail::CallableWrapper<void WebCore::ActiveDOMObject::queueTaskKeepingObjectAlive<WebCore::UserMediaRequest>(WebCore::UserMediaRequest&, WebCore::TaskSource, WTF::Function<void ()>&&)::'lambda'(), void>::~CallableWrapper() 18 0x492b00585 WTF::Detail::CallableWrapper<void WebCore::ActiveDOMObject::queueTaskKeepingObjectAlive<WebCore::UserMediaRequest>(WebCore::UserMediaRequest&, WebCore::TaskSource, WTF::Function<void ()>&&)::'lambda'(), void>::~CallableWrapper() 19 0x492b005a9 WTF::Detail::CallableWrapper<void WebCore::ActiveDOMObject::queueTaskKeepingObjectAlive<WebCore::UserMediaRequest>(WebCore::UserMediaRequest&, WebCore::TaskSource, WTF::Function<void ()>&&)::'lambda'(), void>::~CallableWrapper() 20 0x490da79ff std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> >::operator()(WTF::Detail::CallableWrapperBase<void>*) const 21 0x490da79bf std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> > >::reset(WTF::Detail::CallableWrapperBase<void>*) 22 0x490da7959 std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> > >::~unique_ptr() 23 0x490da7935 std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> > >::~unique_ptr() 24 0x490da7915 WTF::Function<void ()>::~Function() 25 0x490da78f5 WTF::Function<void ()>::~Function() 26 0x49368c561 WebCore::EventLoopFunctionDispatchTask::~EventLoopFunctionDispatchTask() 27 0x49368bbc5 WebCore::EventLoopFunctionDispatchTask::~EventLoopFunctionDispatchTask() 28 0x49368bbe9 WebCore::EventLoopFunctionDispatchTask::~EventLoopFunctionDispatchTask() 29 0x4936971df std::__1::default_delete<WebCore::EventLoopTask>::operator()(WebCore::EventLoopTask*) const 30 0x49369719f std::__1::unique_ptr<WebCore::EventLoopTask, std::__1::default_delete<WebCore::EventLoopTask> >::reset(WebCore::EventLoopTask*) 31 0x493697139 std::__1::unique_ptr<WebCore::EventLoopTask, std::__1::default_delete<WebCore::EventLoopTask> >::~unique_ptr() LEAK: 1 WebPageProxy 1593329 1 webkit-bug-importer 2019-11-24 23:18:22 -0800 <rdar://problem/57466280> 1593346 2 384277 youennf 2019-11-25 00:29:41 -0800 Created attachment 384277 Patch 1593506 3 384277 rniwa 2019-11-25 13:57:38 -0800 Comment on attachment 384277 Patch Interesting. I wonder if this is a common pattern. If so, we can add a variant of queueTaskKeepingObjectAlive which takes a completion handler & automatically calls it in the case the task is dropped because the event loop knows when an active DOM object is stopped. 1593575 4 youennf 2019-11-25 23:47:05 -0800 (In reply to Ryosuke Niwa from comment #3) > Comment on attachment 384277 [details] > Patch > > Interesting. I wonder if this is a common pattern. If so, we can add a > variant of queueTaskKeepingObjectAlive which takes a completion handler & > automatically calls it in the case the task is dropped because the event > loop knows when an active DOM object is stopped. I did a grep of queueTaskKeepingObjectAlive and completionHandler and only found this place, hence the change of bug title and current patch. If we run in the same issue in the future, we might indeed try to find a better solution. 1593590 5 384277 commit-queue 2019-11-26 00:30:48 -0800 Comment on attachment 384277 Patch Clearing flags on attachment: 384277 Committed r252878: <https://trac.webkit.org/changeset/252878> 1593591 6 commit-queue 2019-11-26 00:30:50 -0800 All reviewed patches have been landed. Closing bug. 384277 2019-11-25 00:29:41 -0800 2019-11-26 00:30:48 -0800 Patch bug-204565-20191125092939.patch text/plain 4129 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyODQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGYxNWEwNGQ3NTFkN2Nj ZTRjNGM3MTA2YTU0ZjU0ZjAwY2EyOWNjMC4uMDI3NzdiMTNiMDQ5N2E0NmNiMzcwYTdmNDk1ZjJh OWZhMzIzNmQ0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTExLTI1ICB5b3Vl bm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBRdWV1aW5nIGEgdGFzayBp biBFdmVudExvb3AgaXMgbm90IHdvcmtpbmcgd2l0aCBVc2VyTWVkaWFSZXF1ZXN0IGFsbG93IGNv bXBsZXRpb24gaGFuZGxlcgorICAgICAgICBRdWV1aW5nIGEgdGFzayBpbiBFdmVudExvb3AgaXMg bm90IHdvcmtpbmcgd2l0aCBjb21wbGV0aW9uIGhhbmRsZXJzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ1NjUKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzU3NDY2MjgwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIERvIG5vdCBjYXB0dXJlIHRoZSBjb21wbGV0aW9uIGhhbmRsZXIgaW4gbGFtYmRhIHBh c3NlZCB0byB0aGUgZXZlbnQgcXVldWUuCisgICAgICAgIEluc3RlYWQsIGtlZXAgaXQgaW4gVXNl ck1lZGlxUmVxdWVzdCBhbmQgY2FsbCBpdCBlaXRoZXIgd2hlbiBydW5uaW5nIHRoZSB0YXNrIG9y IHdoZW4gZGVzdHJveWluZyBVc2VyTWVkaWFSZXF1ZXN0LgorICAgICAgICBDb3ZlcmVkIGJ5IGV4 aXN0aW5nIHRlc3RzIGZhaWxpbmcgdGhlIGRlYnVnIGFzc2VydGlvbi4KKworICAgICAgICAqIE1v ZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpVc2VyTWVkaWFSZXF1ZXN0Ojp+VXNlck1lZGlhUmVxdWVzdCk6CisgICAgICAgIChXZWJDb3Jl OjpVc2VyTWVkaWFSZXF1ZXN0OjphbGxvdyk6CisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVh bS9Vc2VyTWVkaWFSZXF1ZXN0Lmg6CisKIDIwMTktMTEtMjQgIFN1bm55IEhlICA8c3VubnlfaGVA YXBwbGUuY29tPgogCiAgICAgICAgIEVuc3VyZSBTcGVlY2hTeW50aGVzaXM6OmNhbmNlbCgpIGNv cnJlY3RseSBjbGVhcnMgbV9jdXJyZW50U3BlZWNoVXR0ZXJhbmNlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYVJlcXVlc3QuY3BwIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Vc2VyTWVkaWFSZXF1ZXN0LmNwcAppbmRl eCAzODQzOTYzNTYwZWJjMTdmOWFkOTEzYjk1OThjYjUwMjc4Nzk1MjYyLi5kNGU1Y2M3M2Y3ZDc0 MzBhODE4OWIyYzRkOWU5MzI1YzU2MzBmNzA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYVJlcXVlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5jcHAKQEAgLTY3LDcgKzY3 LDExIEBAIFVzZXJNZWRpYVJlcXVlc3Q6OlVzZXJNZWRpYVJlcXVlc3QoRG9jdW1lbnQmIGRvY3Vt ZW50LCBNZWRpYVN0cmVhbVJlcXVlc3QmJiByZXF1CiB7CiB9CiAKLVVzZXJNZWRpYVJlcXVlc3Q6 On5Vc2VyTWVkaWFSZXF1ZXN0KCkgPSBkZWZhdWx0OworVXNlck1lZGlhUmVxdWVzdDo6flVzZXJN ZWRpYVJlcXVlc3QoKQoreworICAgIGlmIChtX2FsbG93Q29tcGxldGlvbkhhbmRsZXIpCisgICAg ICAgIG1fYWxsb3dDb21wbGV0aW9uSGFuZGxlcigpOworfQogCiBTZWN1cml0eU9yaWdpbiogVXNl ck1lZGlhUmVxdWVzdDo6dXNlck1lZGlhRG9jdW1lbnRPcmlnaW4oKSBjb25zdAogewpAQCAtMjMw LDEwICsyMzQsMTAgQEAgc3RhdGljIGlubGluZSBib29sIGlzTWVkaWFTdHJlYW1Db3JyZWN0bHlT dGFydGVkKGNvbnN0IE1lZGlhU3RyZWFtJiBzdHJlYW0pCiB2b2lkIFVzZXJNZWRpYVJlcXVlc3Q6 OmFsbG93KENhcHR1cmVEZXZpY2UmJiBhdWRpb0RldmljZSwgQ2FwdHVyZURldmljZSYmIHZpZGVv RGV2aWNlLCBTdHJpbmcmJiBkZXZpY2VJZGVudGlmaWVySGFzaFNhbHQsIENvbXBsZXRpb25IYW5k bGVyPHZvaWQoKT4mJiBjb21wbGV0aW9uSGFuZGxlcikKIHsKICAgICBSRUxFQVNFX0xPRyhNZWRp YVN0cmVhbSwgIlVzZXJNZWRpYVJlcXVlc3Q6OmFsbG93ICVzICVzIiwgYXVkaW9EZXZpY2UgPyBh dWRpb0RldmljZS5wZXJzaXN0ZW50SWQoKS51dGY4KCkuZGF0YSgpIDogIiIsIHZpZGVvRGV2aWNl ID8gdmlkZW9EZXZpY2UucGVyc2lzdGVudElkKCkudXRmOCgpLmRhdGEoKSA6ICIiKTsKLQotICAg IHF1ZXVlVGFza0tlZXBpbmdPYmplY3RBbGl2ZSgqdGhpcywgVGFza1NvdXJjZTo6VXNlckludGVy YWN0aW9uLCBbdGhpcywgYXVkaW9EZXZpY2UgPSBXVEZNb3ZlKGF1ZGlvRGV2aWNlKSwgdmlkZW9E ZXZpY2UgPSBXVEZNb3ZlKHZpZGVvRGV2aWNlKSwgZGV2aWNlSWRlbnRpZmllckhhc2hTYWx0ID0g V1RGTW92ZShkZXZpY2VJZGVudGlmaWVySGFzaFNhbHQpLCBjb21wbGV0aW9uSGFuZGxlciA9IFdU Rk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXSgpIG11dGFibGUgewotICAgICAgICBhdXRvIGNhbGxi YWNrID0gW3RoaXMsIHByb3RlY3RvciA9IG1ha2VQZW5kaW5nQWN0aXZpdHkoKnRoaXMpLCBjb21w bGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXShSZWZQdHI8TWVkaWFT dHJlYW1Qcml2YXRlPiYmIHByaXZhdGVTdHJlYW0pIG11dGFibGUgewotICAgICAgICAgICAgYXV0 byBzY29wZUV4aXQgPSBtYWtlU2NvcGVFeGl0KFtjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUo Y29tcGxldGlvbkhhbmRsZXIpXSgpIG11dGFibGUgeworICAgIG1fYWxsb3dDb21wbGV0aW9uSGFu ZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpOworICAgIHF1ZXVlVGFza0tlZXBpbmdP YmplY3RBbGl2ZSgqdGhpcywgVGFza1NvdXJjZTo6VXNlckludGVyYWN0aW9uLCBbdGhpcywgYXVk aW9EZXZpY2UgPSBXVEZNb3ZlKGF1ZGlvRGV2aWNlKSwgdmlkZW9EZXZpY2UgPSBXVEZNb3ZlKHZp ZGVvRGV2aWNlKSwgZGV2aWNlSWRlbnRpZmllckhhc2hTYWx0ID0gV1RGTW92ZShkZXZpY2VJZGVu dGlmaWVySGFzaFNhbHQpXSgpIG11dGFibGUgeworICAgICAgICBhdXRvIGNhbGxiYWNrID0gW3Ro aXMsIHByb3RlY3RvciA9IG1ha2VQZW5kaW5nQWN0aXZpdHkoKnRoaXMpXShSZWZQdHI8TWVkaWFT dHJlYW1Qcml2YXRlPiYmIHByaXZhdGVTdHJlYW0pIG11dGFibGUgeworICAgICAgICAgICAgYXV0 byBzY29wZUV4aXQgPSBtYWtlU2NvcGVFeGl0KFtjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUo bV9hbGxvd0NvbXBsZXRpb25IYW5kbGVyKV0oKSBtdXRhYmxlIHsKICAgICAgICAgICAgICAgICBj b21wbGV0aW9uSGFuZGxlcigpOwogICAgICAgICAgICAgfSk7CiAgICAgICAgICAgICBpZiAoaXND b250ZXh0U3RvcHBlZCgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXN0cmVhbS9Vc2VyTWVkaWFSZXF1ZXN0LmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c3RyZWFtL1VzZXJNZWRpYVJlcXVlc3QuaAppbmRleCBlMzkyNDliZGE0OGE5ODE0NjM4NzgyYWJk ZmRiZTU5NWE0OWFmNzI5Li5kOTg3YWQzMjQ1ZDZiZjJiOWNmNDFlZjQ1YzJiN2MwMDAzMDFiYWQz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRp YVJlcXVlc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJN ZWRpYVJlcXVlc3QuaApAQCAtOTQsNiArOTQsNyBAQCBwcml2YXRlOgogICAgIFZlY3RvcjxTdHJp bmc+IG1fYXVkaW9EZXZpY2VVSURzOwogCiAgICAgVW5pcXVlUmVmPERPTVByb21pc2VEZWZlcnJl ZDxJRExJbnRlcmZhY2U8TWVkaWFTdHJlYW0+Pj4gbV9wcm9taXNlOworICAgIENvbXBsZXRpb25I YW5kbGVyPHZvaWQoKT4gbV9hbGxvd0NvbXBsZXRpb25IYW5kbGVyOwogICAgIE1lZGlhU3RyZWFt UmVxdWVzdCBtX3JlcXVlc3Q7CiB9OwogCg==