204542 2019-11-22 17:52:08 -0800 REGRESSION (r252792?): 6 inspector/canvas tests crashing 2019-11-22 19:30:15 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain rniwa aakash_jain ap bburg hi jbedard joepeck mjs rniwa webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1593126 0 aakash_jain 2019-11-22 17:52:08 -0800 Following tests started crashing recently: inspector/canvas/recording-2d-frameCount.html inspector/canvas/recording-2d-saves.html inspector/canvas/recording-bitmaprenderer-frameCount.html inspector/canvas/recording-webgl-frameCount.html inspector/canvas/recording-webgl-snapshots.html inspector/canvas/setRecordingAutoCaptureFrameCount.html e.g.: https://ews-build.webkit.org/#/builders/17/builds/7186 1593128 1 aakash_jain 2019-11-22 17:52:42 -0800 Flakiness dashboard: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=inspector%2Fcanvas%2Frecording-2d-frameCount.html&test=inspector%2Fcanvas%2Frecording-2d-saves.html&test=inspector%2Fcanvas%2Frecording-bitmaprenderer-frameCount.html&test=inspector%2Fcanvas%2Frecording-webgl-frameCount.html&test=inspector%2Fcanvas%2Frecording-webgl-snapshots.html&test=inspector%2Fcanvas%2FsetRecordingAutoCaptureFrameCount.html 1593130 2 aakash_jain 2019-11-22 17:53:23 -0800 Seems regression from either r252790 or r252792. 1593131 3 aakash_jain 2019-11-22 17:54:19 -0800 e.g.: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r252792%20(7061)/results.html https://ews-build.webkit.org/results/macOS-High-Sierra-Debug-WK1-Tests-EWS/r384184-7186-clean-tree/results.html 1593132 4 jbedard 2019-11-22 17:55:15 -0800 I'm pretty much positive it's r252792. Look at what files changed: https://results.webkit.org/commits?before_id=252792&after_id=252789 1593133 5 webkit-bug-importer 2019-11-22 17:56:20 -0800 <rdar://problem/57446993> 1593134 6 jbedard 2019-11-22 17:57:19 -0800 (In reply to Jonathan Bedard from comment #4) > I'm pretty much positive it's r252792. > > Look at what files changed: > https://results.webkit.org/commits?before_id=252792&after_id=252789 Although I suppose that r252792 could have broken the canvas stuff and then r252790 independently broke the inspector stuff. 1593142 7 rniwa 2019-11-22 18:14:54 -0800 Oops, I just landed a patch which would make reverting this harder. Let me see if I can figure something out... 1593144 8 384220 rniwa 2019-11-22 18:24:11 -0800 Created attachment 384220 Fixes the bug 1593149 9 384222 rniwa 2019-11-22 18:34:33 -0800 Created attachment 384222 Fixes the bug 1593151 10 384220 hi 2019-11-22 18:52:43 -0800 Comment on attachment 384220 Fixes the bug r=me, this actually should be enough as we shouldn’t be adding anything to `m_recordingCanvasIdentifiers` in this loop. If anything, it should already be empty at the end of this loop since each item gets removed inside `InspectorCanvasAgent::didFinishRecordingCanvasFrame`. Thanks for the quick fix! 1593156 11 384220 rniwa 2019-11-22 19:30:13 -0800 Comment on attachment 384220 Fixes the bug Clearing flags on attachment: 384220 Committed r252823: <https://trac.webkit.org/changeset/252823> 1593157 12 rniwa 2019-11-22 19:30:15 -0800 All reviewed patches have been landed. Closing bug. 384220 2019-11-22 18:24:11 -0800 2019-11-22 19:30:13 -0800 Fixes the bug bug-204542-20191122182411.patch text/plain 1639 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MjgyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTExLTIyICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNTI3OTI/ KTogNiBpbnNwZWN0b3IvY2FudmFzIHRlc3RzIGNyYXNoaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ1NDIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3B5IHRoZSBsaXN0IG9mIGlkZW50aWZpZXJz IHRvIGEgVmVjdG9yIGJlZm9yZSBpdGVyYXRpbmcgb3ZlciBpdAorICAgICAgICBzaW5jZSBtX2lk ZW50aWZpZXJUb0luc3BlY3RvckNhbnZhcyBjb3VsZCBiZSBtdXRhdGVkIG1lYW53aGlsZS4KKwor ICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ2FudmFzQWdlbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ2FudmFzQWdlbnQ6OnJlY29yZENhbnZhc0FjdGlvbik6 CisKIDIwMTktMTEtMjEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgQXNzb2NpYXRlIGVhY2ggbWljcm90YXNrIHdpdGggYSB0YXNrIGdyb3VwIGFuZCByZW1vdmUg QWN0aXZlRE9NQ2FsbGJhY2tNaWNyb3Rhc2sKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9hZ2VudHMvSW5zcGVjdG9yQ2FudmFzQWdlbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ2FudmFzQWdlbnQuY3BwCShyZXZpc2lv biAyNTI4MjEpCisrKyBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckNh bnZhc0FnZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDU3LDcgKzQ1Nyw4IEBAIHZvaWQgSW5z cGVjdG9yQ2FudmFzQWdlbnQ6OnJlY29yZENhbnZhc0EKIAogICAgICAgICAgICAgICAgIGF1dG8m IGNhbnZhc0FnZW50ID0gKndlYWtUaGlzOwogCi0gICAgICAgICAgICAgICAgZm9yIChhdXRvJiBp ZGVudGlmaWVyIDogY2FudmFzQWdlbnQubV9yZWNvcmRpbmdDYW52YXNJZGVudGlmaWVycykgewor ICAgICAgICAgICAgICAgIGF1dG8gaWRlbnRpZmllcnMgPSBjb3B5VG9WZWN0b3IoY2FudmFzQWdl bnQubV9yZWNvcmRpbmdDYW52YXNJZGVudGlmaWVycyk7CisgICAgICAgICAgICAgICAgZm9yIChh dXRvJiBpZGVudGlmaWVyIDogaWRlbnRpZmllcnMpIHsKICAgICAgICAgICAgICAgICAgICAgYXV0 byBpbnNwZWN0b3JDYW52YXMgPSBjYW52YXNBZ2VudC5tX2lkZW50aWZpZXJUb0luc3BlY3RvckNh bnZhcy5nZXQoaWRlbnRpZmllcik7CiAgICAgICAgICAgICAgICAgICAgIGlmICghaW5zcGVjdG9y Q2FudmFzKQogICAgICAgICAgICAgICAgICAgICAgICAgY29udGludWU7Cg== 384222 2019-11-22 18:34:33 -0800 2019-11-22 18:53:16 -0800 Fixes the bug bug-204542-20191122183432.patch text/plain 3024 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MjgyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTExLTIyICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNTI3OTI/ KTogNiBpbnNwZWN0b3IvY2FudmFzIHRlc3RzIGNyYXNoaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ1NDIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3B5IHRoZSBsaXN0IG9mIGlkZW50aWZpZXJz IHRvIGEgVmVjdG9yIGJlZm9yZSBpdGVyYXRpbmcgb3ZlciBpdAorICAgICAgICBzaW5jZSBtX2lk ZW50aWZpZXJUb0luc3BlY3RvckNhbnZhcyBjb3VsZCBiZSBtdXRhdGVkIG1lYW53aGlsZS4KKwor ICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ2FudmFzQWdlbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ2FudmFzQWdlbnQ6OnJlY29yZENhbnZhc0FjdGlvbik6 CisKIDIwMTktMTEtMjEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgQXNzb2NpYXRlIGVhY2ggbWljcm90YXNrIHdpdGggYSB0YXNrIGdyb3VwIGFuZCByZW1vdmUg QWN0aXZlRE9NQ2FsbGJhY2tNaWNyb3Rhc2sKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9hZ2VudHMvSW5zcGVjdG9yQ2FudmFzQWdlbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ2FudmFzQWdlbnQuY3BwCShyZXZpc2lv biAyNTI4MjEpCisrKyBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckNh bnZhc0FnZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDU3LDIwICs0NTcsMjIgQEAgdm9pZCBJ bnNwZWN0b3JDYW52YXNBZ2VudDo6cmVjb3JkQ2FudmFzQQogCiAgICAgICAgICAgICAgICAgYXV0 byYgY2FudmFzQWdlbnQgPSAqd2Vha1RoaXM7CiAKLSAgICAgICAgICAgICAgICBmb3IgKGF1dG8m IGlkZW50aWZpZXIgOiBjYW52YXNBZ2VudC5tX3JlY29yZGluZ0NhbnZhc0lkZW50aWZpZXJzKSB7 Ci0gICAgICAgICAgICAgICAgICAgIGF1dG8gaW5zcGVjdG9yQ2FudmFzID0gY2FudmFzQWdlbnQu bV9pZGVudGlmaWVyVG9JbnNwZWN0b3JDYW52YXMuZ2V0KGlkZW50aWZpZXIpOwotICAgICAgICAg ICAgICAgICAgICBpZiAoIWluc3BlY3RvckNhbnZhcykKLSAgICAgICAgICAgICAgICAgICAgICAg IGNvbnRpbnVlOwotCi0gICAgICAgICAgICAgICAgICAgIGF1dG8qIGNhbnZhc1JlbmRlcmluZ0Nv bnRleHQgPSBpbnNwZWN0b3JDYW52YXMtPmNhbnZhc0NvbnRleHQoKTsKLSAgICAgICAgICAgICAg ICAgICAgQVNTRVJUKGNhbnZhc1JlbmRlcmluZ0NvbnRleHQpOwotICAgICAgICAgICAgICAgICAg ICAvLyBGSVhNRTogPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIwMTY1MT4gV2ViIEluc3BlY3Rvcjog Q2FudmFzOiBzdXBwb3J0IGNhbnZhcyByZWNvcmRpbmdzIGZvciBXZWJHUFVEZXZpY2UKLQotICAg ICAgICAgICAgICAgICAgICBpZiAoY2FudmFzUmVuZGVyaW5nQ29udGV4dC0+Y2FsbFRyYWNpbmdB Y3RpdmUoKSkKLSAgICAgICAgICAgICAgICAgICAgICAgIGNhbnZhc0FnZW50LmRpZEZpbmlzaFJl Y29yZGluZ0NhbnZhc0ZyYW1lKCpjYW52YXNSZW5kZXJpbmdDb250ZXh0KTsKKyAgICAgICAgICAg ICAgICB3aGlsZSAoIWNhbnZhc0FnZW50Lm1fcmVjb3JkaW5nQ2FudmFzSWRlbnRpZmllcnMuaXNF bXB0eSgpKSB7CisgICAgICAgICAgICAgICAgICAgIGF1dG8gaWRlbnRpZmllcnMgPSBjb3B5VG9W ZWN0b3IoY2FudmFzQWdlbnQubV9yZWNvcmRpbmdDYW52YXNJZGVudGlmaWVycyk7CisgICAgICAg ICAgICAgICAgICAgIGNhbnZhc0FnZW50Lm1fcmVjb3JkaW5nQ2FudmFzSWRlbnRpZmllcnMuY2xl YXIoKTsKKyAgICAgICAgICAgICAgICAgICAgZm9yIChhdXRvJiBpZGVudGlmaWVyIDogaWRlbnRp ZmllcnMpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIGF1dG8gaW5zcGVjdG9yQ2FudmFzID0g Y2FudmFzQWdlbnQubV9pZGVudGlmaWVyVG9JbnNwZWN0b3JDYW52YXMuZ2V0KGlkZW50aWZpZXIp OworICAgICAgICAgICAgICAgICAgICAgICAgaWYgKCFpbnNwZWN0b3JDYW52YXMpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgY29udGludWU7CisKKyAgICAgICAgICAgICAgICAgICAgICAg IGF1dG8qIGNhbnZhc1JlbmRlcmluZ0NvbnRleHQgPSBpbnNwZWN0b3JDYW52YXMtPmNhbnZhc0Nv bnRleHQoKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIEFTU0VSVChjYW52YXNSZW5kZXJpbmdD b250ZXh0KTsKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIEZJWE1FOiA8aHR0cHM6Ly93ZWJr aXQub3JnL2IvMjAxNjUxPiBXZWIgSW5zcGVjdG9yOiBDYW52YXM6IHN1cHBvcnQgY2FudmFzIHJl Y29yZGluZ3MgZm9yIFdlYkdQVURldmljZQorCisgICAgICAgICAgICAgICAgICAgICAgICBpZiAo Y2FudmFzUmVuZGVyaW5nQ29udGV4dC0+Y2FsbFRyYWNpbmdBY3RpdmUoKSkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjYW52YXNBZ2VudC5kaWRGaW5pc2hSZWNvcmRpbmdDYW52YXNGcmFt ZSgqY2FudmFzUmVuZGVyaW5nQ29udGV4dCk7CisgICAgICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgICAgICB9Ci0KLSAgICAgICAgICAgICAgICBjYW52YXNBZ2VudC5tX3JlY29yZGluZ0Nh bnZhc0lkZW50aWZpZXJzLmNsZWFyKCk7CiAgICAgICAgICAgICB9KTsKICAgICAgICAgfQogICAg IH0K