204540 2019-11-22 15:36:41 -0800 [LFC][IFC] Remove unnecessary Line::hasContent() calls in LineLayout::placeInlineItem 2019-11-23 05:33:58 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1593065 0 zalan 2019-11-22 15:36:41 -0800 LineLayout::placeInlineItem is hot. 1593066 1 webkit-bug-importer 2019-11-22 15:37:06 -0800 <rdar://problem/57443500> 1593068 2 384209 zalan 2019-11-22 15:39:41 -0800 Created attachment 384209 Patch 1593199 3 384209 commit-queue 2019-11-23 05:33:56 -0800 Comment on attachment 384209 Patch Clearing flags on attachment: 384209 Committed r252829: <https://trac.webkit.org/changeset/252829> 1593200 4 commit-queue 2019-11-23 05:33:58 -0800 All reviewed patches have been landed. Closing bug. 384209 2019-11-22 15:39:41 -0800 2019-11-23 05:33:56 -0800 Patch bug-204540-20191122153919.patch text/plain 2697 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWYyYmU1ZDU3MGVhNGFh MzdhMTUwYTY4Y2RjZGI4YjMzMTZkOTlkNC4uNTQ0ZTVhNWY4ODkyNjQxNGFiOWU4ZWQ5MWI4OTQ3 Y2NlMWUzZDAwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE5LTExLTIyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBSZW1vdmUg dW5uZWNlc3NhcnkgTGluZTo6aGFzQ29udGVudCgpIGNhbGxzIGluIExpbmVMYXlvdXQ6OnBsYWNl SW5saW5lSXRlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA0NTQwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NzQ0MzUwMD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMaW5lTGF5b3V0OjpwbGFjZUlu bGluZUl0ZW0gaXMgaG90LiBUaGlzIHNoYXZlcyBvZmYgfjMlIG9uIGxpbmUtbGF5b3V0LXNpbXBs ZS5odG1sIAorCisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUxh eW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVMYXlvdXQ6OnBsYWNlSW5s aW5lSXRlbSk6CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RnJhbWVWaWV3OjpwYWludENvbnRlbnRzKToKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlld0xh eW91dENvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3TGF5b3V0Q29udGV4 dDo6bGF5b3V0VXNpbmdGb3JtYXR0aW5nQ29udGV4dCk6CisgICAgICAgIChXZWJDb3JlOjpGcmFt ZVZpZXdMYXlvdXRDb250ZXh0OjpsYXlvdXQpOgorICAgICAgICAqIHJlbmRlcmluZy91cGRhdGlu Zy9SZW5kZXJUcmVlQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUcmVlQnVp bGRlcjo6YXR0YWNoVG9SZW5kZXJFbGVtZW50SW50ZXJuYWwpOgorICAgICAgICAqIHJlbmRlcmlu Zy91cGRhdGluZy9SZW5kZXJUcmVlVXBkYXRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJUcmVlVXBkYXRlcjo6dXBkYXRlUmVuZGVyZXJTdHlsZSk6CisKIDIwMTktMTEtMjIgIFphbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNdIFRleHQgY29u dGVudCBpcyBub3QgZXhhY3RseSByYXJlIGRhdGEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lTGF5b3V0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVMYXlvdXQuY3BwCmluZGV4 IDdhZmNhM2MzNDhlMjgxMmQyNjk5OTAxYzZmNzlkYjllYjVhMWYxNmQuLjc1ZWI1NDg4YTNlZTE5 MmY1ZDA3MjQwZTk1OGYzNTMxNDYzMDZhYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVMYXlvdXQuY3BwCkBAIC0x NjYsNyArMTY2LDYgQEAgTGluZUxheW91dDo6SXNFbmRPZkxpbmUgTGluZUxheW91dDo6cGxhY2VJ bmxpbmVJdGVtKGNvbnN0IElubGluZUl0ZW0mIGlubGluZUl0ZW0KIHsKICAgICBhdXRvIGN1cnJl bnRMb2dpY2FsUmlnaHQgPSBtX2xpbmUubGluZUJveCgpLmxvZ2ljYWxSaWdodCgpOwogICAgIGF1 dG8gaXRlbUxvZ2ljYWxXaWR0aCA9IGlubGluZUl0ZW1XaWR0aChmb3JtYXR0aW5nQ29udGV4dCgp LCBpbmxpbmVJdGVtLCBjdXJyZW50TG9naWNhbFJpZ2h0KTsKLSAgICBhdXRvIGxpbmVJc0NvbnNp ZGVyZWRFbXB0eSA9ICFtX2xpbmUuaGFzQ29udGVudCgpICYmICFtX2xpbmVIYXNJbnRydXNpdmVG bG9hdDsKIAogICAgIC8vIEZsb2F0cyBhcmUgc3BlY2lhbCwgdGhleSBhcmUgaW50cnVzaXZlIGJ1 dCB0aGV5IGRvbid0IHJlYWxseSBwYXJ0aWNpcGF0ZSBpbiB0aGUgbGluZSBsYXlvdXQgY29udGV4 dC4KICAgICBpZiAoaW5saW5lSXRlbS5pc0Zsb2F0KCkpIHsKQEAgLTE3OCw2ICsxNzcsNyBAQCBM aW5lTGF5b3V0OjpJc0VuZE9mTGluZSBMaW5lTGF5b3V0OjpwbGFjZUlubGluZUl0ZW0oY29uc3Qg SW5saW5lSXRlbSYgaW5saW5lSXRlbQogICAgICAgICAgICAgaWYgKHByb2Nlc3NVbmNvbW1pdHRl ZENvbnRlbnQoKSA9PSBJc0VuZE9mTGluZTo6WWVzKQogICAgICAgICAgICAgICAgIHJldHVybiBJ c0VuZE9mTGluZTo6WWVzOwogICAgICAgICB9CisgICAgICAgIGF1dG8gbGluZUlzQ29uc2lkZXJl ZEVtcHR5ID0gIW1fbGluZS5oYXNDb250ZW50KCkgJiYgIW1fbGluZUhhc0ludHJ1c2l2ZUZsb2F0 OwogICAgICAgICBpZiAoTGluZUJyZWFrZXIoKS5zaG91bGRXcmFwRmxvYXRCb3goaXRlbUxvZ2lj YWxXaWR0aCwgbV9saW5lLmF2YWlsYWJsZVdpZHRoKCkgKyBtX2xpbmUudHJhaWxpbmdUcmltbWFi bGVXaWR0aCgpLCBsaW5lSXNDb25zaWRlcmVkRW1wdHkpKQogICAgICAgICAgICAgcmV0dXJuIElz RW5kT2ZMaW5lOjpZZXM7CiAK