204537 2019-11-22 14:12:42 -0800 [LFC][IFC] Merge "insert inline runs" and "setup display runs" loops in InlineFormattingContext::setDisplayBoxesForLine 2019-11-22 15:30:52 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1592993 0 zalan 2019-11-22 14:12:42 -0800 ssia 1592994 1 webkit-bug-importer 2019-11-22 14:13:24 -0800 <rdar://problem/57440394> 1593000 2 384196 zalan 2019-11-22 14:14:59 -0800 Created attachment 384196 Patch 1593003 3 384196 koivisto 2019-11-22 14:19:29 -0800 Comment on attachment 384196 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384196&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:-432 > - // FIXME: This is tempoary. Omg it is permenent now. 1593006 4 zalan 2019-11-22 14:21:54 -0800 (In reply to Antti Koivisto from comment #3) > Comment on attachment 384196 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384196&action=review > > > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:-432 > > - // FIXME: This is tempoary. > > Omg it is permenent now. A feature is being born here. 1593063 5 384196 commit-queue 2019-11-22 15:30:50 -0800 Comment on attachment 384196 Patch Clearing flags on attachment: 384196 Committed r252810: <https://trac.webkit.org/changeset/252810> 1593064 6 commit-queue 2019-11-22 15:30:52 -0800 All reviewed patches have been landed. Closing bug. 384196 2019-11-22 14:14:59 -0800 2019-11-22 15:30:50 -0800 Patch bug-204537-20191122141436.patch text/plain 3154 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2E5ZGY3NjUzNzcxMzhh YmU2YjY0NDhhNjFjODk1NTdhZTE3YzEzOC4uZjc1ZTU3MTg0NGE3NWY1YTEzNDllYjJmYTlhZjZk ZmJlNDkwMWNjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTExLTIyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBNZXJnZSAi aW5zZXJ0IGlubGluZSBydW5zIiBhbmQgInNldHVwIGRpc3BsYXkgcnVucyIgbG9vcHMgaW4gSW5s aW5lRm9ybWF0dGluZ0NvbnRleHQ6OnNldERpc3BsYXlCb3hlc0ZvckxpbmUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDUzNworICAgICAgICA8cmRh cjovL3Byb2JsZW0vNTc0NDAzOTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTGV0J3MgbG9vcCB0aGUgbmV3IExpbmU6OlJ1biBsaXN0IG9ubHkgb25j ZS4KKworICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdD b250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6SW5saW5lRm9ybWF0dGluZ0Nv bnRleHQ6OnNldERpc3BsYXlCb3hlc0ZvckxpbmUpOgorCiAyMDE5LTExLTIyICBaYWxhbiBCdWp0 YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBMaW5lOjpSdW46OmV4 cGFuZCBzaG91bGQgdGFrZSBhIHJhbmdlIG9mIHJ1bnMgdG8gbWVyZ2UKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250 ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZv cm1hdHRpbmdDb250ZXh0LmNwcAppbmRleCAzZDM4NGFiYjU5M2NmYTFiNjE5NWQ0Mjc0MTUyZTQ1 ZDc5MjUyNjQyLi4yZDViOWFhNDM4ZjU5NTUwMjI5YTViYTI1ZDNmZmMzOWNhNzg2NjE2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3Jt YXR0aW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1h dHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3BwCkBAIC00MjcsMjAgKzQyNyw4IEBAIHZv aWQgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OnNldERpc3BsYXlCb3hlc0ZvckxpbmUoY29uc3Qg TGluZUxheW91dDo6TGluZUNvbnRlCiAgICAgICAgIH0KICAgICB9CiAKLSAgICAvLyBBZGQgZmlu YWwgZGlzcGxheSBydW5zIHRvIHN0YXRlLgogICAgIGZvcm1hdHRpbmdTdGF0ZS5hZGRMaW5lQm94 KGxpbmVDb250ZW50LmxpbmVCb3gpOwotICAgIC8vIEZJWE1FOiBUaGlzIGlzIHRlbXBvYXJ5Lgog ICAgIGF1dG8mIGN1cnJlbnRMaW5lID0gKmZvcm1hdHRpbmdTdGF0ZS5saW5lQm94ZXMoKS5sYXN0 KCk7Ci0gICAgZm9yIChhdXRvJiBsaW5lUnVuIDogbGluZUNvbnRlbnQucnVuTGlzdCkgewotICAg ICAgICAvLyBJbmxpbmUgbGV2ZWwgY29udGFpbmVycyAoPHNwYW4+KSBkb24ndCBnZW5lcmF0ZSBk aXNwbGF5IHJ1bnMuCi0gICAgICAgIGlmIChsaW5lUnVuLmlzQ29udGFpbmVyU3RhcnQoKSB8fCBs aW5lUnVuLmlzQ29udGFpbmVyRW5kKCkpCi0gICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAg Ly8gQ29tcGxldGVseSBjb2xsYXBzZWQgbGluZSBydW5zIGRvbid0IGdlbmVyYXRlIGRpc3BsYXkg cnVucyBlaXRoZXIuCi0gICAgICAgIGlmIChsaW5lUnVuLmlzQ29sbGFwc2VkVG9WaXN1YWxseUVt cHR5KCkpCi0gICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgZm9ybWF0dGluZ1N0YXRlLmFk ZElubGluZVJ1bihtYWtlVW5pcXVlPERpc3BsYXk6OlJ1bj4obGluZVJ1bi5sYXlvdXRCb3goKS5z dHlsZSgpLCBsaW5lUnVuLmxvZ2ljYWxSZWN0KCksIGxpbmVSdW4udGV4dENvbnRleHQoKSksIGN1 cnJlbnRMaW5lKTsKLSAgICB9Ci0KICAgICAvLyBDb21wdXRlIGJveCBmaW5hbCBnZW9tZXRyeS4K ICAgICBhdXRvJiBsaW5lUnVucyA9IGxpbmVDb250ZW50LnJ1bkxpc3Q7CiAgICAgZm9yICh1bnNp Z25lZCBpbmRleCA9IDA7IGluZGV4IDwgbGluZVJ1bnMuc2l6ZSgpOyArK2luZGV4KSB7CkBAIC00 NDksNiArNDM3LDEyIEBAIHZvaWQgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OnNldERpc3BsYXlC b3hlc0ZvckxpbmUoY29uc3QgTGluZUxheW91dDo6TGluZUNvbnRlCiAgICAgICAgIGF1dG8mIGxh eW91dEJveCA9IGxpbmVSdW4ubGF5b3V0Qm94KCk7CiAgICAgICAgIGF1dG8mIGRpc3BsYXlCb3gg PSBmb3JtYXR0aW5nU3RhdGUuZGlzcGxheUJveChsYXlvdXRCb3gpOwogCisgICAgICAgIC8vIEFk ZCBmaW5hbCBkaXNwbGF5IHJ1bnMgdG8gc3RhdGUgZmlyc3QuCisgICAgICAgIC8vIElubGluZSBs ZXZlbCBjb250YWluZXJzICg8c3Bhbj4pIGRvbid0IGdlbmVyYXRlIGRpc3BsYXkgcnVucyBhbmQg bmVpdGhlciBkbyBjb21wbGV0ZWx5IGNvbGxhcHNlZCBydW5zLgorICAgICAgICBhdXRvIGluaXRp YXRlc0lubGluZVJ1biA9ICFsaW5lUnVuLmlzQ29udGFpbmVyU3RhcnQoKSAmJiAhbGluZVJ1bi5p c0NvbnRhaW5lckVuZCgpICYmICFsaW5lUnVuLmlzQ29sbGFwc2VkVG9WaXN1YWxseUVtcHR5KCk7 CisgICAgICAgIGlmIChpbml0aWF0ZXNJbmxpbmVSdW4pCisgICAgICAgICAgICBmb3JtYXR0aW5n U3RhdGUuYWRkSW5saW5lUnVuKG1ha2VVbmlxdWU8RGlzcGxheTo6UnVuPihsaW5lUnVuLmxheW91 dEJveCgpLnN0eWxlKCksIGxpbmVSdW4ubG9naWNhbFJlY3QoKSwgbGluZVJ1bi50ZXh0Q29udGV4 dCgpKSwgY3VycmVudExpbmUpOworCiAgICAgICAgIGlmIChsaW5lUnVuLmlzRm9yY2VkTGluZUJy ZWFrKCkpIHsKICAgICAgICAgICAgIGRpc3BsYXlCb3guc2V0VG9wTGVmdChsb2dpY2FsUmVjdC50 b3BMZWZ0KCkpOwogICAgICAgICAgICAgZGlzcGxheUJveC5zZXRDb250ZW50Qm94V2lkdGgobG9n aWNhbFJlY3Qud2lkdGgoKSk7Cg==