204534 2019-11-22 13:52:39 -0800 Fix compile error in release mode 2019-11-22 14:22:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1592983 0 pvollan 2019-11-22 13:52:39 -0800 A compiler error is thrown in release mode when compiling FullBytecodeLiveness::getLiveness, since not all paths are returning a value. 1592984 1 384191 pvollan 2019-11-22 13:56:36 -0800 Created attachment 384191 Patch 1592990 2 pvollan 2019-11-22 14:04:01 -0800 Thanks for reviewing! 1593004 3 384191 commit-queue 2019-11-22 14:21:13 -0800 Comment on attachment 384191 Patch Clearing flags on attachment: 384191 Committed r252801: <https://trac.webkit.org/changeset/252801> 1593005 4 commit-queue 2019-11-22 14:21:15 -0800 All reviewed patches have been landed. Closing bug. 1593007 5 webkit-bug-importer 2019-11-22 14:22:21 -0800 <rdar://problem/57440687> 384191 2019-11-22 13:56:36 -0800 2019-11-22 14:21:13 -0800 Patch bug-204534-20191122225636.patch text/plain 1416 pvollan SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUyNzk4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE5LTExLTIyICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAg ICAgICBGaXggY29tcGlsZSBlcnJvciBpbiByZWxlYXNlIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDUzNAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEEgY29tcGlsZXIgZXJyb3IgaXMgdGhyb3du IGluIHJlbGVhc2UgbW9kZSB3aGVuIGNvbXBpbGluZyBGdWxsQnl0ZWNvZGVMaXZlbmVzczo6Z2V0 TGl2ZW5lc3MsCisgICAgICAgIHNpbmNlIG5vdCBhbGwgcGF0aHMgYXJlIHJldHVybmluZyBhIHZh bHVlLgorCisgICAgICAgICogYnl0ZWNvZGUvRnVsbEJ5dGVjb2RlTGl2ZW5lc3MuaDoKKyAgICAg ICAgKEpTQzo6RnVsbEJ5dGVjb2RlTGl2ZW5lc3M6OmdldExpdmVuZXNzIGNvbnN0KToKKwogMjAx OS0xMS0yMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtK U0NdIERGRyB0ZXJtaW5hbCdzIGxpdmVuZXNzIHNob3VsZCByZXNwZWN0IGNhbGxlcidzIG9wY29k ZUlECkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvRnVsbEJ5dGVjb2RlTGl2 ZW5lc3MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvRnVs bEJ5dGVjb2RlTGl2ZW5lc3MuaAkocmV2aXNpb24gMjUyNzk1KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL0Z1bGxCeXRlY29kZUxpdmVuZXNzLmgJKHdvcmtpbmcgY29weSkKQEAg LTQ0LDcgKzQ0LDcgQEAgcHVibGljOgogICAgICAgICBjYXNlIExpdmVuZXNzQ2FsY3VsYXRpb25Q b2ludDo6QWZ0ZXJVc2U6CiAgICAgICAgICAgICByZXR1cm4gbV9hZnRlclVzZVZlY3RvcltieXRl Y29kZUluZGV4Lm9mZnNldCgpXTsKICAgICAgICAgfQotICAgICAgICBBU1NFUlRfTk9UX1JFQUNI RUQoKTsKKyAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICB9CiAgICAg CiAgICAgYm9vbCBvcGVyYW5kSXNMaXZlKGludCBvcGVyYW5kLCBCeXRlY29kZUluZGV4IGJ5dGVj b2RlSW5kZXgsIExpdmVuZXNzQ2FsY3VsYXRpb25Qb2ludCBwb2ludCkgY29uc3QK