204532 2019-11-22 12:58:47 -0800 Web Inspector: Console: the saved result value is still shown after page reload 2019-12-02 11:23:20 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1592964 0 hi 2019-11-22 12:58:47 -0800 # STEPS TO REPRODUCE: 1. inspect any page 2. go to the Console Tab 3. enable Preserve Log 4. evaluate `{a: 1, b: 2, c: 3, d: 4, e: 5, f: 6, g: 7}` => notice the " == $1" next to it 5. reload the page => the " == $1" stays visible 6. repeat step 4 => two " == $1" are shown 1592966 1 384188 hi 2019-11-22 13:00:27 -0800 Created attachment 384188 Patch 1593020 2 384188 bburg 2019-11-22 14:42:23 -0800 Comment on attachment 384188 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384188&action=review > Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:248 > + for (let node of this._messageBodyElement.querySelectorAll(".console-saved-variable")) This seems fragile. Can we re-render() the messages in ConsoleMessageView and not draw the saved result index element if the message is older than the epoch (uh, probably since last page reload)? 1593034 3 384188 hi 2019-11-22 15:01:42 -0800 Comment on attachment 384188 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384188&action=review >> Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:248 >> + for (let node of this._messageBodyElement.querySelectorAll(".console-saved-variable")) > > This seems fragile. Can we re-render() the messages in ConsoleMessageView and not draw the saved result index element if the message is older than the epoch (uh, probably since last page reload)? Fragile in what way? We don't ever save the `.console-saved-variable` element to a member variable, so it's basically "dropped" into the DOM with no expectations about it afterwards. Re-rendering all of the messages would likely have pretty awful performance, especially if there are a lot of messages from previous sessions. 1594697 4 384188 bburg 2019-12-02 10:38:15 -0800 Comment on attachment 384188 Patch r=me I don't think it's worth making this any more complicated at this point. 1594711 5 384188 commit-queue 2019-12-02 11:22:29 -0800 Comment on attachment 384188 Patch Clearing flags on attachment: 384188 Committed r253000: <https://trac.webkit.org/changeset/253000> 1594712 6 commit-queue 2019-12-02 11:22:30 -0800 All reviewed patches have been landed. Closing bug. 1594713 7 webkit-bug-importer 2019-12-02 11:23:20 -0800 <rdar://problem/57564556> 384188 2019-11-22 13:00:27 -0800 2019-12-02 11:22:29 -0800 Patch bug-204532-20191122130026.patch text/plain 4063 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE4ZDI3ZDI1OTY5Mjk3MTIyYmRiN2JjOTI0Y2Qy NDQxMWVmZWIwNjQuLmMwZTNkNmNhNDZhMmE3NjBkZmZkNDBkZDU5MTBjMzQwYzAzMTYxYjUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE5LTExLTIyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD b25zb2xlOiB0aGUgc2F2ZWQgcmVzdWx0IHZhbHVlIGlzIHN0aWxsIHNob3duIGFmdGVyIHBhZ2Ug cmVsb2FkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDQ1MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgYWRkaXRpb25hbCBwbHVtYmluZyB0byByZW1vdmUgYW55IGAuY29uc29sZS1zYXZlZC12YXJp YWJsZWAgZWxlbWVudHMgd2hlbmV2ZXIgYSBuZXcKKyAgICAgICAgc2Vzc2lvbiBpcyBjcmVhdGVk LCBhcyB3ZWxsIGFzIHJlc2V0IHRoZSBiYXNlIG9mIHRoZSBwcm9wZXJ0eSBwYXRoIHRvIGB0aGlz YC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanM6Cisg ICAgICAgIChXSS5Mb2dDb250ZW50Vmlldy5wcm90b3R5cGUuX3Nlc3Npb25TdGFydGVkKToKKyAg ICAgICAgKFdJLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5fbG9nQ2xlYXJlZCk6CisKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmlldy5qczoKKyAgICAgICAg KFdJLkNvbnNvbGVNZXNzYWdlVmlldy5wcm90b3R5cGUuY2xlYXJTYXZlZFZhcmlhYmxlU3RhdGUp OiBBZGRlZC4KKyAgICAgICAgKFdJLkNvbnNvbGVNZXNzYWdlVmlldy5wcm90b3R5cGUucmVtb3Zl RXZlbnRMaXN0ZW5lcnMpOiBEZWxldGVkLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9PYmplY3RUcmVlVmlldy5qczoKKyAgICAgICAgKFdJLk9iamVjdFRyZWVWaWV3LnByb3RvdHlw ZS5yZXNldFByb3BlcnR5UGF0aCk6IEFkZGVkLgorCiAyMDE5LTExLTIxICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IE91dGxp bmUgc1JHQi1zYWZlIGFyZWFzIG9uIFAzIGNvbG9yIHBpY2tlcgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZU1lc3NhZ2VWaWV3Lmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZU1lc3Nh Z2VWaWV3LmpzCmluZGV4IGJiZjhjMzhhMmU1ZTc0NjQxMmY1OThmNmZkNzgwNTRiYjc0NzVkNjku LjlmNzE0MzM1YWEyZjYxNTY4Njg3MzM2OTJjZGQ2YTYyNTM0MThhYTcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmll dy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db25z b2xlTWVzc2FnZVZpZXcuanMKQEAgLTI0Myw4ICsyNDMsMTQgQEAgV0kuQ29uc29sZU1lc3NhZ2VW aWV3ID0gY2xhc3MgQ29uc29sZU1lc3NhZ2VWaWV3IGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAg IHJldHVybiBjbGlwYm9hcmRTdHJpbmc7CiAgICAgfQogCi0gICAgcmVtb3ZlRXZlbnRMaXN0ZW5l cnMoKQorICAgIGNsZWFyU2F2ZWRWYXJpYWJsZVN0YXRlKCkKICAgICB7CisgICAgICAgIGZvciAo bGV0IG5vZGUgb2YgdGhpcy5fbWVzc2FnZUJvZHlFbGVtZW50LnF1ZXJ5U2VsZWN0b3JBbGwoIi5j b25zb2xlLXNhdmVkLXZhcmlhYmxlIikpCisgICAgICAgICAgICBub2RlLnJlbW92ZSgpOworCisg ICAgICAgIGlmICh0aGlzLl9vYmplY3RUcmVlKQorICAgICAgICAgICAgdGhpcy5fb2JqZWN0VHJl ZS5yZXNldFByb3BlcnR5UGF0aCgpOworCiAgICAgICAgIC8vIEZJWE1FOiA8aHR0cHM6Ly93ZWJr aXQub3JnL2IvMTk2OTU2PiBXZWIgSW5zcGVjdG9yOiB1c2Ugd2VhayBjb2xsZWN0aW9ucyBmb3Ig aG9sZGluZyBldmVudCBsaXN0ZW5lcnMKICAgICAgICAgV0kuc2V0dGluZ3MuY29uc29sZVNhdmVk UmVzdWx0QWxpYXMucmVtb3ZlRXZlbnRMaXN0ZW5lcihudWxsLCBudWxsLCB0aGlzKTsKICAgICB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9M b2dDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCmluZGV4IGU5OTQwMmU4MmExNzZjOWZkMWYyZTdmMzI4NGE4 NjdiY2U2ZTYyNTUuLjYyODU4YTRiNTQ1ODhjN2NmZDRiYTZhMDZhMzI5ZDA3NWE3MzZjZmUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0Nv bnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCkBAIC0zOTgsNyArMzk4LDcgQEAgV0kuTG9nQ29udGVudFZp ZXcgPSBjbGFzcyBMb2dDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWaWV3CiAKICAgICAg ICAgZm9yIChsZXQgbWVzc2FnZUVsZW1lbnQgb2YgdGhpcy5fYWxsTWVzc2FnZUVsZW1lbnRzKCkp IHsKICAgICAgICAgICAgIGlmIChtZXNzYWdlRWxlbWVudC5fX21lc3NhZ2VWaWV3KQotICAgICAg ICAgICAgICAgIG1lc3NhZ2VFbGVtZW50Ll9fbWVzc2FnZVZpZXcucmVtb3ZlRXZlbnRMaXN0ZW5l cnMoKTsKKyAgICAgICAgICAgICAgICBtZXNzYWdlRWxlbWVudC5fX21lc3NhZ2VWaWV3LmNsZWFy U2F2ZWRWYXJpYWJsZVN0YXRlKCk7CiAgICAgICAgIH0KIAogICAgICAgICBjb25zdCBpc0ZpcnN0 U2Vzc2lvbiA9IGZhbHNlOwpAQCAtODM2LDcgKzgzNiw3IEBAIFdJLkxvZ0NvbnRlbnRWaWV3ID0g Y2xhc3MgTG9nQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogCiAgICAgICAgIGZv ciAobGV0IG1lc3NhZ2VFbGVtZW50IG9mIHRoaXMuX2FsbE1lc3NhZ2VFbGVtZW50cygpKSB7CiAg ICAgICAgICAgICBpZiAobWVzc2FnZUVsZW1lbnQuX19tZXNzYWdlVmlldykKLSAgICAgICAgICAg ICAgICBtZXNzYWdlRWxlbWVudC5fX21lc3NhZ2VWaWV3LnJlbW92ZUV2ZW50TGlzdGVuZXJzKCk7 CisgICAgICAgICAgICAgICAgbWVzc2FnZUVsZW1lbnQuX19tZXNzYWdlVmlldy5jbGVhclNhdmVk VmFyaWFibGVTdGF0ZSgpOwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5fbG9nVmlld0NvbnRy b2xsZXIuY2xlYXIoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZVZpZXcuanMKaW5kZXggYTdiZDM3NTc5NmM1Y2I5 ZjU0Y2MwOWQzZGFiODlkZTNmZjc1NmEyNC4uZDc5MTVkNGVkNWIxZDJhMTE5NWI3MTFhOTM2NGRi MWMyNDVjMmZmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvT2JqZWN0VHJlZVZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZVZpZXcuanMKQEAgLTMyMSw2ICszMjEsMTEgQEAg V0kuT2JqZWN0VHJlZVZpZXcgPSBjbGFzcyBPYmplY3RUcmVlVmlldyBleHRlbmRzIFdJLk9iamVj dAogICAgICAgICB0aGlzLl9wcm90b3R5cGVOYW1lT3ZlcnJpZGUgPSBvdmVycmlkZTsKICAgICB9 CiAKKyAgICByZXNldFByb3BlcnR5UGF0aCgpCisgICAgeworICAgICAgICB0aGlzLl9wcm9wZXJ0 eVBhdGgucGF0aENvbXBvbmVudCA9ICJ0aGlzIjsKKyAgICB9CisKICAgICAvLyBQcm90ZWN0ZWQK IAogICAgIHVwZGF0ZSgpCg==