204526 2019-11-22 11:02:28 -0800 run-javascriptcore-tests: Failure to determine configuration for reporting is fatal 2019-11-22 18:25:53 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204513 https://bugs.webkit.org/show_bug.cgi?id=204091 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue pmatos webkit-bug-importer oldest_to_newest 1592908 0 jbedard 2019-11-22 11:02:28 -0800 There is a request to make a failure to determine the upload configuration for the results database a soft failure, rather than a hard one. 1592910 1 384173 jbedard 2019-11-22 11:08:47 -0800 Created attachment 384173 Patch 1592916 2 384173 aakash_jain 2019-11-22 11:14:40 -0800 Comment on attachment 384173 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384173&action=review > Tools/Scripts/run-javascriptcore-tests:880 > + if (!keys $configuration) { is this tested? 1592922 3 384173 jbedard 2019-11-22 11:22:18 -0800 Comment on attachment 384173 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384173&action=review >> Tools/Scripts/run-javascriptcore-tests:880 >> + if (!keys $configuration) { > > is this tested? I did a test locally by modifying configurationForUpload() to return an empty hash, yes. 'key $configuration' will return a string, it will be an empty string if the hash is empty 1592943 4 384173 commit-queue 2019-11-22 12:06:25 -0800 Comment on attachment 384173 Patch Clearing flags on attachment: 384173 Committed r252791: <https://trac.webkit.org/changeset/252791> 1592944 5 commit-queue 2019-11-22 12:06:27 -0800 All reviewed patches have been landed. Closing bug. 1592945 6 webkit-bug-importer 2019-11-22 12:07:23 -0800 <rdar://problem/57436631> 1592974 7 aakash_jain 2019-11-22 13:20:09 -0800 (In reply to Jonathan Bedard from comment #3) > >> + if (!keys $configuration) { > > is this tested? > > I did a test locally by modifying configurationForUpload() to return an > empty hash, yes. 'key $configuration' will return a string, it will be an > empty string if the hash is empty Seems like this broke the tests in different manner: https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/builds/10121/steps/jscore-test/logs/stdio It seems like this doesn't work with newer version of perl (or on the version of perl installed on the bots). Although it failed with different error on same bot here: https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/builds/10120/steps/jscore-test/logs/stdio 1592978 8 jbedard 2019-11-22 13:30:17 -0800 Reverted r252791 for reason: Cannot use key on scalar in some perl versions Committed r252797: <https://trac.webkit.org/changeset/252797> 1593110 9 jbedard 2019-11-22 17:17:14 -0800 Trying a different approach using uname. 1593113 10 384215 jbedard 2019-11-22 17:20:11 -0800 Created attachment 384215 Patch 1593145 11 384215 commit-queue 2019-11-22 18:25:51 -0800 Comment on attachment 384215 Patch Clearing flags on attachment: 384215 Committed r252822: <https://trac.webkit.org/changeset/252822> 1593146 12 commit-queue 2019-11-22 18:25:53 -0800 All reviewed patches have been landed. Closing bug. 384173 2019-11-22 11:08:47 -0800 2019-11-22 17:20:09 -0800 Patch bug-204526-20191122110846.patch text/plain 2140 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1Mjc4NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTExLTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6IEZhaWx1cmUgdG8gZGV0ZXJt aW5lIGNvbmZpZ3VyYXRpb24gZm9yIHJlcG9ydGluZyBpcyBmYXRhbAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0NTI2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1qYXZhc2NyaXB0 Y29yZS10ZXN0czoKKyAgICAgICAgKGNvbmZpZ3VyYXRpb25Gb3JVcGxvYWQpOiBSZXR1cm4gZW1w dHkgaGFzaCBpZiBubyBjb25maWd1cmF0aW9uIGlzIGF2YWlsYWJsZS4KKyAgICAgICAgKHVwbG9h ZFJlc3VsdHMpOiBTb2Z0LWZhaWwgdXBsb2FkIGlmIGNvbmZpZ3VyYXRpb24gaXMgZW1wdHkuCisK IDIwMTktMTEtMjIgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAg ICAgIHJ1bi1qYXZhc2NyaXB0Y29yZS10ZXN0czogSGlkZSB0aGUgb3V0cHV0IG9mIGJpbmFyaWVz IGJlaGluZCAtLXZlcmJvc2UKSW5kZXg6IFRvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3Jl LXRlc3RzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRl c3RzCShyZXZpc2lvbiAyNTI3ODApCisrKyBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29y ZS10ZXN0cwkod29ya2luZyBjb3B5KQpAQCAtNDIwLDcgKzQyMCw4IEBAIHN1YiBjb25maWd1cmF0 aW9uRm9yVXBsb2FkKCkKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0gZWxzZSB7Ci0g ICAgICAgIGRpZSAiQ2Fubm90IGRldGVybWluZSBwbGF0Zm9ybVxuIjsKKyAgICAgICAgcHJpbnQg IkNhbm5vdCBkZXRlcm1pbmUgcGxhdGZvcm1cbiI7CisgICAgICAgIHJldHVybiB7fTsKICAgICB9 CiAKICAgICBteSAkcmVzdWx0ID0gewpAQCAtNDU5LDcgKzQ2MCw2IEBAIGlmICgkc2hvd0hlbHAp IHsKIH0KIAogc2V0Q29uZmlndXJhdGlvblByb2R1Y3REaXIoQ3dkOjphYnNfcGF0aCgkcm9vdCkp IGlmIChkZWZpbmVkKCRyb290KSk7Ci1jb25maWd1cmF0aW9uRm9yVXBsb2FkKCkgaWYgKGRlZmlu ZWQoJHJlcG9ydCkpOwogCiBpZiAoZGVmaW5lZCgkanNvbkZpbGVOYW1lKSkgewogICAgICRqc29u RmlsZU5hbWUgPSBGaWxlOjpTcGVjLT5yZWwyYWJzKCRqc29uRmlsZU5hbWUpOwpAQCAtODc2LDYg Kzg3NiwxMiBAQCBzdWIgdXBsb2FkUmVzdWx0cwogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAK KyAgICBteSAkY29uZmlndXJhdGlvbiA9IGNvbmZpZ3VyYXRpb25Gb3JVcGxvYWQoKTsKKyAgICBp ZiAoIWtleXMgJGNvbmZpZ3VyYXRpb24pIHsKKyAgICAgICAgcHJpbnQgIkludmFsaWQgY29uZmln dXJhdGlvbiwgZmFpbGVkIHRvIHVwbG9hZCB0byAkcmVwb3J0XG4iOworICAgICAgICByZXR1cm4g MTsKKyAgICB9CisKICAgICBteSAldXBsb2FkID0gKAogICAgICAgICB2ZXJzaW9uID0+IDAsCiAg ICAgICAgIHN1aXRlID0+ICdqYXZhc2NyaXB0Y29yZS10ZXN0cycsCkBAIC04ODUsNyArODkxLDcg QEAgc3ViIHVwbG9hZFJlc3VsdHMKICAgICAgICAgICAgIHJlcG9zaXRvcnlfaWQgPT4gJ3dlYmtp dCcsCiAgICAgICAgICAgICBpZCA9PiBkZXRlcm1pbmVDdXJyZW50U1ZOUmV2aXNpb24oKSwKICAg ICAgICAgfV0sCi0gICAgICAgIGNvbmZpZ3VyYXRpb24gPT4gY29uZmlndXJhdGlvbkZvclVwbG9h ZCgpLAorICAgICAgICBjb25maWd1cmF0aW9uID0+ICRjb25maWd1cmF0aW9uLAogICAgICAgICB0 ZXN0X3Jlc3VsdHMgPT4gewogICAgICAgICAgICAgcnVuX3N0YXRzID0+IHsKICAgICAgICAgICAg ICAgICBzdGFydF90aW1lID0+ICRzdGFydFRpbWUsCg== 384215 2019-11-22 17:20:11 -0800 2019-11-22 18:25:51 -0800 Patch bug-204526-20191122172010.patch text/plain 1922 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MjgxOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTExLTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6IEZhaWx1cmUgdG8gZGV0ZXJt aW5lIGNvbmZpZ3VyYXRpb24gZm9yIHJlcG9ydGluZyBpcyBmYXRhbAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0NTI2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1qYXZhc2NyaXB0 Y29yZS10ZXN0czoKKyAgICAgICAgKGNvbmZpZ3VyYXRpb25Gb3JVcGxvYWQpOiBVc2UgdW5hbWUg YXMgdGhlIGRlZmF1bHQgdXBsb2FkIGNvbmZpZ3VyYXRpb24gCisKIDIwMTktMTEtMjIgIEpvbmF0 aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIHJlc3VsdHMud2Via2l0 Lm9yZy9hcGkvZmFpbHVyZXMgc2hvdWxkIHJldHVybiBhbiBlcnJvciB3aGVuIG5vIHRlc3QtcnVu IGlzIGZvdW5kIGZvciBzcGVjaWZpZWQgY3JpdGVyaWEKSW5kZXg6IFRvb2xzL1NjcmlwdHMvcnVu LWphdmFzY3JpcHRjb3JlLXRlc3RzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvcnVuLWph dmFzY3JpcHRjb3JlLXRlc3RzCShyZXZpc2lvbiAyNTI4MTUpCisrKyBUb29scy9TY3JpcHRzL3J1 bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwkod29ya2luZyBjb3B5KQpAQCAtMzg5LDEyICszODksNiBA QCBzdWIgY29uZmlndXJhdGlvbkZvclVwbG9hZCgpCiAgICAgICAgICAgICBjaG9tcCgkdmVyc2lv biA9IGB1bmFtZSAtcmApOwogICAgICAgICAgICAgJHZlcnNpb24gPSBzcGxpdFZlcnNpb25TdHJp bmcoJHZlcnNpb24pOwogICAgICAgICB9Ci0gICAgfSBlbHNpZiAoaXNKU0NPbmx5KCkpIHsKLSAg ICAgICAgJHBsYXRmb3JtID0gJ2pzYy1vbmx5JzsKLSAgICAgICAgaWYgKCEkdmVyc2lvbikgewot ICAgICAgICAgICAgY2hvbXAoJHZlcnNpb24gPSBgdW5hbWUgLXJgKTsKLSAgICAgICAgICAgICR2 ZXJzaW9uID0gc3BsaXRWZXJzaW9uU3RyaW5nKCR2ZXJzaW9uKTsKLSAgICAgICAgfQogICAgIH0g ZWxzaWYgKGlzQW55V2luZG93cygpKSB7CiAgICAgICAgICRwbGF0Zm9ybSA9ICd3aW4nOwogICAg ICAgICBpZiAoISR2ZXJzaW9uKSB7CkBAIC00MjAsNyArNDE0LDE0IEBAIHN1YiBjb25maWd1cmF0 aW9uRm9yVXBsb2FkKCkKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0gZWxzZSB7Ci0g ICAgICAgIGRpZSAiQ2Fubm90IGRldGVybWluZSBwbGF0Zm9ybVxuIjsKKyAgICAgICAgIyBGSVhN RTogVGhpcyB3aWxsIGJlIHRoZSBrZXJuZWwgdmVyc2lvbiwgd2hpY2ggaXMgbm90IGFsd2F5cyBl eGFjdGx5IHdoYXQgd2Ugd2FudCwgYnV0IGl0IHdpbGwgYXQgbGVhc3QKKyAgICAgICAgIyBhbHdh eXMgZ2l2ZSB1cyBzb21ldGhpbmcgdG8gd29yayB3aXRoCisgICAgICAgIGNob21wKCRwbGF0Zm9y bSA9IGB1bmFtZWApOworICAgICAgICAkcGxhdGZvcm0gPSBsYyAkcGxhdGZvcm07CisgICAgICAg IGlmICghJHZlcnNpb24pIHsKKyAgICAgICAgICAgIGNob21wKCR2ZXJzaW9uID0gYHVuYW1lIC1y YCk7CisgICAgICAgICAgICAkdmVyc2lvbiA9IHNwbGl0VmVyc2lvblN0cmluZygkdmVyc2lvbik7 CisgICAgICAgIH0KICAgICB9CiAKICAgICBteSAkcmVzdWx0ID0gewo=