204518 2019-11-22 08:19:24 -0800 run-webkit-tests: Failing to run spindump shouldn't be fatal 2019-11-22 09:51:43 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap commit-queue ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1592804 0 jbedard 2019-11-22 08:19:24 -0800 If spindump raises an exception, we sometimes abort the entire test run. This is a tremendous waste of machine time. 1592806 1 jbedard 2019-11-22 08:19:49 -0800 <rdar://problem/57397417> 1592814 2 384157 jbedard 2019-11-22 08:39:15 -0800 Created attachment 384157 Patch 1592820 3 384157 aakash_jain 2019-11-22 08:58:56 -0800 Comment on attachment 384157 Patch where did you notice it? 1592825 4 jbedard 2019-11-22 09:08:39 -0800 (In reply to Aakash Jain from comment #3) > Comment on attachment 384157 [details] > Patch > > where did you notice it? Alexey noticed it on an Internal build. I didn't investigate too much, once I looked at the code and what the entire function does, it was transparently wrong, so I figured we should just fix it and move on. 1592853 5 384157 commit-queue 2019-11-22 09:51:38 -0800 Comment on attachment 384157 Patch Clearing flags on attachment: 384157 Committed r252779: <https://trac.webkit.org/changeset/252779> 1592854 6 commit-queue 2019-11-22 09:51:43 -0800 All reviewed patches have been landed. Closing bug. 384157 2019-11-22 08:39:15 -0800 2019-11-22 09:51:38 -0800 Patch bug-204518-20191122083914.patch text/plain 1477 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1Mjc3NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTExLTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4td2Via2l0LXRlc3RzOiBGYWlsaW5nIHRvIHJ1biBzcGluZHVtcCBz aG91bGRuJ3QgYmUgZmF0YWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwNDUxOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTczOTc0MTc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3BvcnQvZGFyd2luLnB5OgorICAgICAgICAoRGFyd2luUG9ydC5zYW1wbGVfcHJvY2Vz cyk6IENhdGNoIHNjcmlwdCBlcnJvci4KKwogMjAxOS0xMS0yMiAgUGF1bG8gTWF0b3MgIDxwbWF0 b3NAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW1vdmUgSlNDIDMyYml0IEFSTXY3IGFuZCBNaXBz RWwgb2xkIEVXUyBxdWV1ZXMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kYXJ3 aW4ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Rhcndpbi5w eQkocmV2aXNpb24gMjUyNzM1KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Rhcndp bi5weQkod29ya2luZyBjb3B5KQpAQCAtMTg2LDcgKzE4Niw3IEBAIGNsYXNzIERhcndpblBvcnQo QXBwbGVQb3J0KToKICAgICAgICAgICAgICAgICAgICAgaG9zdC5leGVjdXRpdmUucnVuX2NvbW1h bmQoc3BpbmR1bXBfY29tbWFuZCkKICAgICAgICAgICAgICAgICBob3N0LmZpbGVzeXN0ZW0ubW92 ZV90b19iYXNlX2hvc3QoRGFyd2luUG9ydC50YWlsc3Bpbl9maWxlX3BhdGgoaG9zdCwgbmFtZSwg cGlkLCBzdHIodGVtcGRpcikpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBEYXJ3aW5Qb3J0LnRhaWxzcGluX2ZpbGVfcGF0aChzZWxmLmhvc3QsIG5h bWUsIHBpZCwgc2VsZi5yZXN1bHRzX2RpcmVjdG9yeSgpKSkKLSAgICAgICAgICAgIGV4Y2VwdCBJ T0Vycm9yIGFzIGU6CisgICAgICAgICAgICBleGNlcHQgKElPRXJyb3IsIFNjcmlwdEVycm9yKSBh cyBlOgogICAgICAgICAgICAgICAgIF9sb2cud2FybmluZygnVW5hYmxlIHRvIHN5bWJvbGljYXRl IHRhaWxzcGluIGxvZyBvZiBwcm9jZXNzOicgKyBzdHIoZSkpCiAgICAgICAgIGVsc2U6ICAjIFRh aWxzcGluIGZhaWxlZCwgcnVuIHNhbXBsZSBpbnN0ZWFkCiAgICAgICAgICAgICB0cnk6Cg==