204496 2019-11-22 01:49:00 -0800 Fix missing exception check in replaceUsingStringSearch(). 2019-11-22 03:35:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1592696 0 mark.lam 2019-11-22 01:49:00 -0800 This was caught by existing JSC stress tests when we run with a debug build. Unfortunately, the EWS only runs with a release build. 1592701 1 384134 mark.lam 2019-11-22 02:10:02 -0800 Created attachment 384134 proposed patch. 1592708 2 384134 ysuzuki 2019-11-22 02:37:28 -0800 Comment on attachment 384134 proposed patch. r=me 1592715 3 mark.lam 2019-11-22 03:34:03 -0800 Thanks for the review. Landed in r252767: <http://trac.webkit.org/r252767>. 1592718 4 webkit-bug-importer 2019-11-22 03:35:16 -0800 <rdar://problem/57425315> 384134 2019-11-22 02:10:02 -0800 2019-11-22 02:37:28 -0800 proposed patch. bug-204496.patch text/plain 2139 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUyNzY2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE5LTExLTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXggbWlzc2luZyBleGNlcHRpb24gY2hlY2sgaW4gcmVwbGFjZVVzaW5nU3RyaW5nU2VhcmNoKCku CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ0OTYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgQ2Fj aGVkQ2FsbCBjb25zdHJ1Y3RvciBjYW4gdGhyb3cgT3V0T2ZNZW1vcnkgb3IgU3RhY2tPdmVyZmxv dyBlcnJvcnMuCisgICAgICAgIFRoaXMgd2FzIGNhdWdodCBieSBleGlzdGluZyBKU0Mgc3RyZXNz IHRlc3RzIHdoZW4gd2UgcnVuIHdpdGggYSBkZWJ1ZyBidWlsZC4KKworICAgICAgICBBbHNvIHBs YWNhdGUgdGhlIGV4Y2VwdGlvbiBjaGVjayB2YWxpZGF0b3IgaW4gJHZtJ3MgZnVuY3Rpb25DYWxs V2l0aFN0YWNrU2l6ZSgpLgorCisgICAgICAgICogcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3Bw OgorICAgICAgICAoSlNDOjpyZXBsYWNlVXNpbmdTdHJpbmdTZWFyY2gpOgorICAgICAgICAqIHRv b2xzL0pTRG9sbGFyVk0uY3BwOgorICAgICAgICAoSlNDOjpmdW5jdGlvbkNhbGxXaXRoU3RhY2tT aXplKToKKwogMjAxOS0xMS0yMSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAg ICAgICAgcmVwbGFjZVVzaW5nU3RyaW5nU2VhcmNoKCkgc2hvdWxkIG5vdCB1c2UgQ2FjaGVkQ2Fs bCB3aXRoIGhvc3QgZnVuY3Rpb25zLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvU3RyaW5nUHJvdG90eXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCShyZXZpc2lvbiAyNTI3NjYpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC03OTUsNiArNzk1LDcgQEAgc3RhdGljIEFMV0FZU19JTkxJTkUgSlNTdHJpbmcqIHJl cGxhY2VVcwogICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBudWxscHRyKTsKICAg ICB9IGVsc2UgaWYgKGNhbGxUeXBlID09IENhbGxUeXBlOjpKUykgewogICAgICAgICBjYWNoZWRD YWxsLmVtcGxhY2UoZ2xvYmFsT2JqZWN0LCBjYWxsRnJhbWUsIGpzQ2FzdDxKU0Z1bmN0aW9uKj4o cmVwbGFjZVZhbHVlKSwgMyk7CisgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIG51 bGxwdHIpOwogICAgICAgICBjYWNoZWRDYWxsLT5zZXRUaGlzKGpzVW5kZWZpbmVkKCkpOwogICAg IH0KIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk0uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0RvbGxhclZNLmNwcAko cmV2aXNpb24gMjUyNzY2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFy Vk0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTAyLDYgKzIxMDIsNyBAQCBzdGF0aWMgRW5jb2Rl ZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jCiAgICAgUkVMRUFTRV9BU1NFUlQodm0uc29mdFN0 YWNrTGltaXQoKSA9PSBvcmlnaW5hbFZNU29mdFN0YWNrTGltaXQpOwogICAgIFJFTEVBU0VfQVNT RVJUKHZtLnN0YWNrTGltaXQoKSA9PSBvcmlnaW5hbFZNU3RhY2tMaW1pdCk7CiAKKyAgICB0aHJv d1Njb3BlLnJlbGVhc2UoKTsKICAgICByZXR1cm4gZW5jb2RlZEpTVW5kZWZpbmVkKCk7CiAKICNl bHNlIC8vIG5vdCBFTkFCTEUoTUFTTV9QUk9CRSkK