204495 2019-11-22 01:26:41 -0800 Support JSCOnly platform in test reporting 2019-11-22 06:56:20 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pmatos pmatos cgarcia commit-queue webkit-bug-importer oldest_to_newest 1592691 0 pmatos 2019-11-22 01:26:41 -0800 Build for 32bit jsconly worker is failing since 204091 made it upstream. --report is used which causes configurationForUpload to be called but it fails without determining platform. See https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/builds/10060/steps/jscore-test/logs/stdio 1592707 1 384138 pmatos 2019-11-22 02:33:17 -0800 Created attachment 384138 Patch 1592719 2 384140 pmatos 2019-11-22 03:40:05 -0800 Created attachment 384140 Patch 1592742 3 384140 cgarcia 2019-11-22 04:59:12 -0800 Comment on attachment 384140 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384140&action=review > Tools/Scripts/run-javascriptcore-tests:395 > + chomp($version = `/usr/bin/uname -r`); Use just uname, that should be in PATH, see bug #204452 1592759 4 384146 pmatos 2019-11-22 06:08:57 -0800 Created attachment 384146 Patch 1592760 5 pmatos 2019-11-22 06:09:30 -0800 (In reply to Carlos Garcia Campos from comment #3) > Comment on attachment 384140 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384140&action=review > > > Tools/Scripts/run-javascriptcore-tests:395 > > + chomp($version = `/usr/bin/uname -r`); > > Use just uname, that should be in PATH, see bug #204452 Thanks for the review. Fixed in latest patch. 1592776 6 384146 commit-queue 2019-11-22 06:55:10 -0800 Comment on attachment 384146 Patch Clearing flags on attachment: 384146 Committed r252773: <https://trac.webkit.org/changeset/252773> 1592777 7 commit-queue 2019-11-22 06:55:12 -0800 All reviewed patches have been landed. Closing bug. 1592778 8 webkit-bug-importer 2019-11-22 06:56:20 -0800 <rdar://problem/57427984> 384138 2019-11-22 02:33:17 -0800 2019-11-22 03:40:02 -0800 Patch bug-204495-20191122113252.patch text/plain 1429 pmatos U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNzI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2IwYzY0YmVkNTJkZGNmZTE3YTA2NWVhNGMxNDc1NjUx ZDIxNmMyMS4uNmU5ZGM2MDNkYTYyNDViZDA2YjhjYzA1NDk0ZTlmMzJlMmQ2YTc5NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTExLTIyICBQYXVsbyBNYXRvcyAgPHBtYXRvc0BpZ2FsaWEuY29tPgorCisgICAg ICAgIHBsYXRmb3JtIGNhbm5vdCBiZSBkZXRlcm1pbmVkIGluIDMyYml0cyBqb2JzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ0OTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgSlNDT25seSB0byBw b3NzaWJsZSBwbGF0Zm9ybXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29y ZS10ZXN0czoKKyAgICAgICAgKGNvbmZpZ3VyYXRpb25Gb3JVcGxvYWQpOgorCiAyMDE5LTExLTIw ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBydW4td2Vi a2l0LXRlc3RzOiBNYWtlIHVzYWJpbGl0eSB0ZXN0IG9uIGJvb3Rpbmcgc2ltdWxhdG9ycyBtb3Jl IHJvYnVzdApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVz dHMgYi9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwppbmRleCBkZjQ4MDU5 M2IwNDU1MGQ2M2RmNzdmM2RiMDUwMjcxZGY4NGI2Zjc4Li44OWUyNTUyNWVjZDVjM2QzNWE4Njk1 ZTBlMTU5ZjAzMDFlNTM4Y2RhIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2Ny aXB0Y29yZS10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0 cwpAQCAtMzg5LDYgKzM4OSwxMiBAQCBzdWIgY29uZmlndXJhdGlvbkZvclVwbG9hZCgpCiAgICAg ICAgICAgICBjaG9tcCgkdmVyc2lvbiA9IGAvdXNyL2Jpbi91bmFtZSAtcmApOwogICAgICAgICAg ICAgJHZlcnNpb24gPSBzcGxpdFZlcnNpb25TdHJpbmcoJHZlcnNpb24pOwogICAgICAgICB9Cisg ICAgfSBlbHNpZiAoaXNKU0NPbmx5KCkpIHsKKyAgICAgICAgJHBsYXRmb3JtID0gJ2pzYy1vbmx5 JzsKKyAgICAgICAgaWYgKCEkdmVyc2lvbikgeworICAgICAgICAgICAgY2hvbXAoJHZlcnNpb24g PSBgL3Vzci9iaW4vdW5hbWUgLXJgKTsKKyAgICAgICAgICAgICR2ZXJzaW9uID0gc3BsaXRWZXJz aW9uU3RyaW5nKCR2ZXJzaW9uKTsKKyAgICAgICAgfQogICAgIH0gZWxzaWYgKGlzQW55V2luZG93 cygpKSB7CiAgICAgICAgICRwbGF0Zm9ybSA9ICd3aW4nOwogICAgICAgICBpZiAoISR2ZXJzaW9u KSB7Cg== 384140 2019-11-22 03:40:05 -0800 2019-11-22 06:08:54 -0800 Patch bug-204495-20191122123939.patch text/plain 1427 pmatos U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNzI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2IwYzY0YmVkNTJkZGNmZTE3YTA2NWVhNGMxNDc1NjUx ZDIxNmMyMS4uNmUwMDY3MTBiZjQwOTgwMDUzNGZmZGFjYjQyMzZhNjA2YWUwYTIyMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTExLTIyICBQYXVsbyBNYXRvcyAgPHBtYXRvc0BpZ2FsaWEuY29tPgorCisgICAg ICAgIFN1cHBvcnQgSlNDT25seSBwbGF0Zm9ybSBpbiB0ZXN0IHJlcG9ydGluZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0NDk1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIEpTQ09ubHkgdG8gcG9z c2libGUgcGxhdGZvcm1zLgorCisgICAgICAgICogU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUt dGVzdHM6CisgICAgICAgIChjb25maWd1cmF0aW9uRm9yVXBsb2FkKToKKwogMjAxOS0xMS0yMCAg Sm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgcnVuLXdlYmtp dC10ZXN0czogTWFrZSB1c2FiaWxpdHkgdGVzdCBvbiBib290aW5nIHNpbXVsYXRvcnMgbW9yZSBy b2J1c3QKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3Rz IGIvVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMKaW5kZXggZGY0ODA1OTNi MDQ1NTBkNjNkZjc3ZjNkYjA1MDI3MWRmODRiNmY3OC4uODllMjU1MjVlY2Q1YzNkMzVhODY5NWUw ZTE1OWYwMzAxZTUzOGNkYSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlw dGNvcmUtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMK QEAgLTM4OSw2ICszODksMTIgQEAgc3ViIGNvbmZpZ3VyYXRpb25Gb3JVcGxvYWQoKQogICAgICAg ICAgICAgY2hvbXAoJHZlcnNpb24gPSBgL3Vzci9iaW4vdW5hbWUgLXJgKTsKICAgICAgICAgICAg ICR2ZXJzaW9uID0gc3BsaXRWZXJzaW9uU3RyaW5nKCR2ZXJzaW9uKTsKICAgICAgICAgfQorICAg IH0gZWxzaWYgKGlzSlNDT25seSgpKSB7CisgICAgICAgICRwbGF0Zm9ybSA9ICdqc2Mtb25seSc7 CisgICAgICAgIGlmICghJHZlcnNpb24pIHsKKyAgICAgICAgICAgIGNob21wKCR2ZXJzaW9uID0g YC91c3IvYmluL3VuYW1lIC1yYCk7CisgICAgICAgICAgICAkdmVyc2lvbiA9IHNwbGl0VmVyc2lv blN0cmluZygkdmVyc2lvbik7CisgICAgICAgIH0KICAgICB9IGVsc2lmIChpc0FueVdpbmRvd3Mo KSkgewogICAgICAgICAkcGxhdGZvcm0gPSAnd2luJzsKICAgICAgICAgaWYgKCEkdmVyc2lvbikg ewo= 384146 2019-11-22 06:08:57 -0800 2019-11-22 06:55:10 -0800 Patch bug-204495-20191122150832.patch text/plain 1424 pmatos U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNzI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2IwYzY0YmVkNTJkZGNmZTE3YTA2NWVhNGMxNDc1NjUx ZDIxNmMyMS4uYTU4Nzg5MTI4MDA2YmM3YTBlMjY3NDM1ZWU3MTQ2MjYzYjc2YmJkNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTExLTIyICBQYXVsbyBNYXRvcyAgPHBtYXRvc0BpZ2FsaWEuY29tPgorCisgICAg ICAgIFN1cHBvcnQgSlNDT25seSBwbGF0Zm9ybSBpbiB0ZXN0IHJlcG9ydGluZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0NDk1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgQ2FybG9zIEdhcmNpYSBDYW1wb3MuCisKKyAgICAgICAgQWRkIEpTQ09ubHkg dG8gcG9zc2libGUgcGxhdGZvcm1zLgorCisgICAgICAgICogU2NyaXB0cy9ydW4tamF2YXNjcmlw dGNvcmUtdGVzdHM6CisgICAgICAgIChjb25maWd1cmF0aW9uRm9yVXBsb2FkKToKKwogMjAxOS0x MS0yMCAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgcnVu LXdlYmtpdC10ZXN0czogTWFrZSB1c2FiaWxpdHkgdGVzdCBvbiBib290aW5nIHNpbXVsYXRvcnMg bW9yZSByb2J1c3QKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3Jl LXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMKaW5kZXggZGY0 ODA1OTNiMDQ1NTBkNjNkZjc3ZjNkYjA1MDI3MWRmODRiNmY3OC4uNTEyNTlhZjEyMzVkNzIzNjMx YjlkMmY1OGMzYmU5ZjAxMjhmZTRkNSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tamF2 YXNjcmlwdGNvcmUtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUt dGVzdHMKQEAgLTM4OSw2ICszODksMTIgQEAgc3ViIGNvbmZpZ3VyYXRpb25Gb3JVcGxvYWQoKQog ICAgICAgICAgICAgY2hvbXAoJHZlcnNpb24gPSBgL3Vzci9iaW4vdW5hbWUgLXJgKTsKICAgICAg ICAgICAgICR2ZXJzaW9uID0gc3BsaXRWZXJzaW9uU3RyaW5nKCR2ZXJzaW9uKTsKICAgICAgICAg fQorICAgIH0gZWxzaWYgKGlzSlNDT25seSgpKSB7CisgICAgICAgICRwbGF0Zm9ybSA9ICdqc2Mt b25seSc7CisgICAgICAgIGlmICghJHZlcnNpb24pIHsKKyAgICAgICAgICAgIGNob21wKCR2ZXJz aW9uID0gYHVuYW1lIC1yYCk7CisgICAgICAgICAgICAkdmVyc2lvbiA9IHNwbGl0VmVyc2lvblN0 cmluZygkdmVyc2lvbik7CisgICAgICAgIH0KICAgICB9IGVsc2lmIChpc0FueVdpbmRvd3MoKSkg ewogICAgICAgICAkcGxhdGZvcm0gPSAnd2luJzsKICAgICAgICAgaWYgKCEkdmVyc2lvbikgewo=