204494 2019-11-21 23:48:26 -0800 replaceUsingStringSearch() should not use CachedCall with host functions. 2019-11-22 01:40:09 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist fpizlo keith_miller msaboff rmorisset ross.kirsling saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1592677 0 mark.lam 2019-11-21 23:48:26 -0800 <rdar://problem/57421078> 1592678 1 384128 mark.lam 2019-11-21 23:54:02 -0800 Created attachment 384128 proposed patch. 1592686 2 384128 ross.kirsling 2019-11-22 00:39:27 -0800 Comment on attachment 384128 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=384128&action=review > Source/JavaScriptCore/runtime/StringPrototype.cpp:812 > - if (cachedCall) { > + if (callType == CallType::JS) { Might be clearer to leave this line -- then the branch reads as "if we have a cached call then call it". 1592694 3 384128 mark.lam 2019-11-22 01:34:09 -0800 Comment on attachment 384128 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=384128&action=review Thanks for the review. >> Source/JavaScriptCore/runtime/StringPrototype.cpp:812 >> + if (callType == CallType::JS) { > > Might be clearer to leave this line -- then the branch reads as "if we have a cached call then call it". Good point. I'll change it. 1592695 4 mark.lam 2019-11-22 01:40:09 -0800 Landed in r252766: <http://trac.webkit.org/r252766>. 384128 2019-11-21 23:54:02 -0800 2019-11-22 00:39:27 -0800 proposed patch. bug-204494.patch text/plain 3728 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTI3NjUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTExLTIxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICByZXBsYWNlVXNpbmdTdHJpbmdTZWFyY2goKSBzaG91bGQgbm90IHVzZSBD YWNoZWRDYWxsIHdpdGggaG9zdCBmdW5jdGlvbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ0OTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3 NDIxMDc4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogc3RyZXNzL3N0cmluZy1yZXBsYWNlQWxsLTIuanM6CisKIDIwMTktMTEtMjEgIFJvc3MgS2ly c2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdGVz dDI2MiBnYXJkZW5pbmcgZm9sbG93aW5nIHIyNTI2ODAuCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9z dHJpbmctcmVwbGFjZUFsbC0yLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3N0cmlu Zy1yZXBsYWNlQWxsLTIuanMJKHJldmlzaW9uIDI1Mjc1OCkKKysrIEpTVGVzdHMvc3RyZXNzL3N0 cmluZy1yZXBsYWNlQWxsLTIuanMJKHdvcmtpbmcgY29weSkKQEAgLTExMiw2ICsxMTIsMTggQEAg dGVzdCgiZnVuY3Rpb24gZm9vIiwgZm9vLCBbCiAgICAgeyByZXN1bHQ6ICcxMjMyNCcsIHZpc2l0 czogMCB9LCAvLyByZXBsYWNlQWxsICcwJwogXSk7CiAKK3Rlc3QoImZ1bmN0aW9uIHBhcnNlSW50 IiwgcGFyc2VJbnQsIFsKKyAgICB7IHJlc3VsdDogJzFOYU4zMjQnLCB2aXNpdHM6IDAgfSwgLy8g cmVwbGFjZSAnMicKKyAgICB7IHJlc3VsdDogJzFOYU4zMjQnLCB2aXNpdHM6IDAgfSwgLy8gcmVw bGFjZSAvMi9nCisgICAgeyByZXN1bHQ6ICcxTmFOMzI0JywgdmlzaXRzOiAwIH0sIC8vIHJlcGxh Y2VBbGwgJzInCisgICAgeyByZXN1bHQ6ICdOYU4xMjMyNCcsIHZpc2l0czogMCB9LCAvLyByZXBs YWNlICcnCisgICAgeyByZXN1bHQ6ICdOYU4xTmFOMk5hTjNOYU4yTmFONE5hTicsIHZpc2l0czog MCB9LCAvLyByZXBsYWNlIC8oPzopL2cKKyAgICB7IHJlc3VsdDogJ05hTjFOYU4yTmFOM05hTjJO YU40TmFOJywgdmlzaXRzOiAwIH0sIC8vIHJlcGxhY2VBbGwgJycKKyAgICB7IHJlc3VsdDogJzEy MzI0JywgdmlzaXRzOiAwIH0sIC8vIHJlcGxhY2UgJzAnCisgICAgeyByZXN1bHQ6ICcxMjMyNCcs IHZpc2l0czogMCB9LCAvLyByZXBsYWNlIC8wL2cKKyAgICB7IHJlc3VsdDogJzEyMzI0Jywgdmlz aXRzOiAwIH0sIC8vIHJlcGxhY2VBbGwgJzAnCitdKTsKKwogdmFyIHByb3h5ID0gbmV3IFByb3h5 KGZvbywgewogICAgIGFwcGx5KCkgewogICAgICAgICB2aXNpdHMrKzsKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUyNzU4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTExLTIxICBN YXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICByZXBsYWNlVXNpbmdTdHJp bmdTZWFyY2goKSBzaG91bGQgbm90IHVzZSBDYWNoZWRDYWxsIHdpdGggaG9zdCBmdW5jdGlvbnMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ0OTQK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3NDIxMDc4PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBDYWNoZWRDYWxsIG1lY2hhbmlzbSBkb2Vz IG5vdCBzdXBwb3J0IGNhbGxpbmcgaGlzdCBmdW5jdGlvbnMuCisKKyAgICAgICAgKiBydW50aW1l L1N0cmluZ1Byb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OnJlcGxhY2VVc2luZ1N0cmluZ1Nl YXJjaCk6CisKIDIwMTktMTEtMjEgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIEZpeCBicm9rZW4gU3RyaW5nLnByb3RvdHlwZS5yZXBsYWNlKCkgYW5kIHJlcGxhY2VB bGwoKS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlw ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5n UHJvdG90eXBlLmNwcAkocmV2aXNpb24gMjUyNzU4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzkzLDEyICs3 OTMsOSBAQCBzdGF0aWMgQUxXQVlTX0lOTElORSBKU1N0cmluZyogcmVwbGFjZVVzCiAgICAgaWYg KGNhbGxUeXBlID09IENhbGxUeXBlOjpOb25lKSB7CiAgICAgICAgIHJlcGxhY2VTdHJpbmcgPSBy ZXBsYWNlVmFsdWUudG9XVEZTdHJpbmcoZ2xvYmFsT2JqZWN0KTsKICAgICAgICAgUkVUVVJOX0lG X0VYQ0VQVElPTihzY29wZSwgbnVsbHB0cik7Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgSlNGdW5j dGlvbiogZnVuY3Rpb24gPSBqc0R5bmFtaWNDYXN0PEpTRnVuY3Rpb24qPih2bSwgcmVwbGFjZVZh bHVlKTsKLSAgICAgICAgaWYgKGZ1bmN0aW9uKSB7Ci0gICAgICAgICAgICBjYWNoZWRDYWxsLmVt cGxhY2UoZ2xvYmFsT2JqZWN0LCBjYWxsRnJhbWUsIGZ1bmN0aW9uLCAzKTsKLSAgICAgICAgICAg IGNhY2hlZENhbGwtPnNldFRoaXMoanNVbmRlZmluZWQoKSk7Ci0gICAgICAgIH0KKyAgICB9IGVs c2UgaWYgKGNhbGxUeXBlID09IENhbGxUeXBlOjpKUykgeworICAgICAgICBjYWNoZWRDYWxsLmVt cGxhY2UoZ2xvYmFsT2JqZWN0LCBjYWxsRnJhbWUsIGpzQ2FzdDxKU0Z1bmN0aW9uKj4ocmVwbGFj ZVZhbHVlKSwgMyk7CisgICAgICAgIGNhY2hlZENhbGwtPnNldFRoaXMoanNVbmRlZmluZWQoKSk7 CiAgICAgfQogCiAgICAgc2l6ZV90IG1hdGNoU3RhcnQgPSBzdHJpbmcuZmluZChzZWFyY2hTdHJp bmcpOwpAQCAtODEyLDcgKzgwOSw3IEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIEpTU3RyaW5nKiBy ZXBsYWNlVXMKICAgICBkbyB7CiAgICAgICAgIGlmIChjYWxsVHlwZSAhPSBDYWxsVHlwZTo6Tm9u ZSkgewogICAgICAgICAgICAgSlNWYWx1ZSByZXBsYWNlbWVudDsKLSAgICAgICAgICAgIGlmIChj YWNoZWRDYWxsKSB7CisgICAgICAgICAgICBpZiAoY2FsbFR5cGUgPT0gQ2FsbFR5cGU6OkpTKSB7 CiAgICAgICAgICAgICAgICAgYXV0byogc3Vic3RyaW5nID0ganNTdWJzdHJpbmcodm0sIHN0cmlu ZywgbWF0Y2hTdGFydCwgc2VhcmNoU3RyaW5nTGVuZ3RoKTsKICAgICAgICAgICAgICAgICBSRVRV Uk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBudWxscHRyKTsKICAgICAgICAgICAgICAgICBjYWNoZWRD YWxsLT5jbGVhckFyZ3VtZW50cygpOwo=