20449 2008-08-19 15:06:30 -0700 Build fails if LOW_BANDWIDTH_DISPLAY is defined 2008-08-20 15:16:20 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 chris.teague webkit-unassigned oldest_to_newest 88849 0 chris.teague 2008-08-19 15:06:30 -0700 The arm-linux variant does not compile successfully. This bug has been in the nightly since at least r35788, and as recently as r35814. To reproduce, build with this command line: ./autogen.sh --host=arm-linux --prefix=/usr make The errors produced are: WebCore/loader/FrameLoader.cpp: In member function `void WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady()': WebCore/loader/FrameLoader.cpp:5032: error: 'class WebCore::ScriptController' has no member named clear' WebCore/loader/FrameLoader.cpp:5037: error: `instance' is not a member of `WebCore::DOMImplementation' make[1]: *** [WebCore/loader/libWebCore_la-FrameLoader.lo] Error 1 88873 1 mrowe 2008-08-19 16:51:42 -0700 *** Bug 20450 has been marked as a duplicate of this bug. *** 88875 2 mrowe 2008-08-19 16:55:38 -0700 The code in question is surrounded by an #if USE(LOW_BANDWIDTH_DISPLAY), which is off on every platform. This suggest that you've modified your tree to turn this on, and that the steps you mention to reproduce will not work without a similar modification. 88876 3 chris.teague 2008-08-19 16:59:48 -0700 (In reply to comment #2) > The code in question is surrounded by an #if USE(LOW_BANDWIDTH_DISPLAY), which > is off on every platform. This suggest that you've modified your tree to turn > this on, and that the steps you mention to reproduce will not work without a > similar modification. > Yes, my normal build does in fact turn on the LOW_BANDWIDTH_DISPLAY feature. However, I did try to build without that turned on, and received the same error. It sounds like I must have not turned off the low bandwidth when I thought I had. I will re-try with a clean copy of the latest nightly, and with the LOW_BANDWIDTH_DISPLAY turned off. 88898 4 22887 chris.teague 2008-08-19 23:30:23 -0700 Created attachment 22887 Proposed fix for compile issue I think this updates the LOW_BANDWIDTH_DISPLAY code to use the new api's. This is my first Webkit patch, please let me know if I've done something wrong. 88948 5 22887 mrowe 2008-08-20 15:12:22 -0700 Comment on attachment 22887 Proposed fix for compile issue r=me. A minor issue in your patch is that you have a tab in your ChangeLog entry. I'll fix that as I land your patch. 88949 6 mrowe 2008-08-20 15:16:20 -0700 Landed in r35863. 22887 2008-08-19 23:30:23 -0700 2008-08-20 15:12:22 -0700 Proposed fix for compile issue lowbandwidth.patch text/plain 1664 chris.teague SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTg1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDgtMTkgIENocmlzIFRlYWd1ZSAgPGNocmlzLnRlYWd1ZUBn bWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisJTW9kaWZpZWQgdG8g Y29tcGlsZSBwcm9wZXJseSB3aGVuIExPV19CQU5EV0lEVEhfRElTUExBWSBpcyBzZXQKKworICAg ICAgICAqIENoYW5nZUxvZzoKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnN3aXRjaE91dExvd0JhbmR3aWR0aERpc3BsYXlJ ZlJlYWR5KToKKwogMjAwOC0wOC0xOSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmYgR2FyZW4uCkluZGV4OiBXZWJDb3JlL2xvYWRlci9G cmFtZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIu Y3BwCShyZXZpc2lvbiAzNTg1MikKKysrIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNTAyOSwxMyArNTAyOSwxMiBAQCB2b2lkIEZyYW1lTG9hZGVyOjpz d2l0Y2hPdXRMb3dCYW5kd2lkdGhECiAgICAgICAgICAgICBvbGREb2MtPmNhbmNlbFBhcnNpbmco KTsKICAgICAgICAgICAgIG9sZERvYy0+ZGV0YWNoKCk7CiAgICAgICAgICAgICBpZiAobV9mcmFt ZS0+c2NyaXB0KCktPmlzRW5hYmxlZCgpKQotICAgICAgICAgICAgICAgIG1fZnJhbWUtPnNjcmlw dCgpLT5jbGVhcigpOworICAgICAgICAgICAgICAgIG1fZnJhbWUtPnNjcmlwdCgpLT5jbGVhcldp bmRvd1NoZWxsKCk7CiAgICAgICAgICAgICBpZiAobV9mcmFtZS0+dmlldygpKQogICAgICAgICAg ICAgICAgIG1fZnJhbWUtPnZpZXcoKS0+Y2xlYXIoKTsKICAgICAgICAgICAgIAogICAgICAgICAg ICAgLy8gc2ltaWxhciB0byBiZWdpbigpLCBzaG91bGQgYmUgcmVmYWN0b3JlZCB0byBzaGFyZSBt b3JlIGNvZGUKLSAgICAgICAgICAgIFJlZlB0cjxEb2N1bWVudD4gbmV3RG9jID0gRE9NSW1wbGVt ZW50YXRpb246Omluc3RhbmNlKCktPgotICAgICAgICAgICAgICAgIGNyZWF0ZURvY3VtZW50KG1f cmVzcG9uc2VNSU1FVHlwZSwgbV9mcmFtZSwgbV9mcmFtZS0+aW5WaWV3U291cmNlTW9kZSgpKTsK KyAgICAgICAgICAgIFJlZlB0cjxEb2N1bWVudD4gbmV3RG9jID0gRE9NSW1wbGVtZW50YXRpb246 OmNyZWF0ZURvY3VtZW50KG1fcmVzcG9uc2VNSU1FVHlwZSwgbV9mcmFtZSwgbV9mcmFtZS0+aW5W aWV3U291cmNlTW9kZSgpKTsKICAgICAgICAgICAgIG1fZnJhbWUtPnNldERvY3VtZW50KG5ld0Rv Yyk7CiAgICAgICAgICAgICBuZXdEb2MtPnNldFVSTChtX1VSTCk7CiAgICAgICAgICAgICBpZiAo bV9kZWNvZGVyKQo=