204477 2019-11-21 15:57:40 -0800 Set 64-bit as default architecture on Windows 2019-12-02 09:39:23 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204571 InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue dbates don.olmstead ews-watchlist fujii glenn jbedard ross.kirsling webkit-bug-importer oldest_to_newest 1592569 0 pvollan 2019-11-21 15:57:40 -0800 This will make 64-bit building and testing the default. 1592571 1 384100 pvollan 2019-11-21 15:59:22 -0800 Created attachment 384100 Patch 1592574 2 384100 bfulgham 2019-11-21 16:06:35 -0800 Comment on attachment 384100 Patch Yes, please! 1592594 3 384107 pvollan 2019-11-21 17:11:06 -0800 Created attachment 384107 Patch 1592913 4 384175 pvollan 2019-11-22 11:11:09 -0800 Created attachment 384175 Patch 1592970 5 jbedard 2019-11-22 13:10:16 -0800 While the code looks fine, I'm a not super excited about landing a Windows change that's failing the Windows build in EWS. 1593008 6 384197 pvollan 2019-11-22 14:23:07 -0800 Created attachment 384197 Patch 1593025 7 pvollan 2019-11-22 14:48:09 -0800 (In reply to Jonathan Bedard from comment #5) > While the code looks fine, I'm a not super excited about landing a Windows > change that's failing the Windows build in EWS. The build failures are addressed in https://bugs.webkit.org/show_bug.cgi?id=204534. 1593047 8 384197 ross.kirsling 2019-11-22 15:12:17 -0800 Comment on attachment 384197 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384197&action=review > Tools/Scripts/webkitdirs.pm:1295 > - $isWin64 = checkForArgumentAndRemoveFromARGV("--64-bit") || ((isFTW() || isWinCairo() || isJSCOnly()) && !shouldBuild32Bit()); > + $isWin64 = checkForArgumentAndRemoveFromARGV("--64-bit") || ((isFTW() || isWinCairo() || isAppleWinWebKit() || isJSCOnly()) && !shouldBuild32Bit()); Should we do `isAnyWindows()` instead of `isFTW() || isWinCairo() || isAppleWinWebKit()`? (I guess we have the same trio in determineConfigurationProductDir, but it seems needless to give the complete list, right?) 1593056 9 ross.kirsling 2019-11-22 15:19:58 -0800 Also we can remove this line, which seems to have been added unnecessarily: https://github.com/WebKit/webkit/blob/master/Tools/Scripts/webkitdirs.pm#L498 1593061 10 pvollan 2019-11-22 15:28:51 -0800 (In reply to Ross Kirsling from comment #8) > Comment on attachment 384197 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384197&action=review > > > Tools/Scripts/webkitdirs.pm:1295 > > - $isWin64 = checkForArgumentAndRemoveFromARGV("--64-bit") || ((isFTW() || isWinCairo() || isJSCOnly()) && !shouldBuild32Bit()); > > + $isWin64 = checkForArgumentAndRemoveFromARGV("--64-bit") || ((isFTW() || isWinCairo() || isAppleWinWebKit() || isJSCOnly()) && !shouldBuild32Bit()); > > Should we do `isAnyWindows()` instead of `isFTW() || isWinCairo() || > isAppleWinWebKit()`? > That makes sense, I will update the patch. > (I guess we have the same trio in determineConfigurationProductDir, but it > seems needless to give the complete list, right?) Thanks for reviewing! 1593092 11 384212 pvollan 2019-11-22 16:10:41 -0800 Created attachment 384212 Patch 1593120 12 384212 ross.kirsling 2019-11-22 17:43:50 -0800 Comment on attachment 384212 Patch r=me, but can we also remove the redundant `push(@args, '--64-bit') if (isFTW());` line I mentioned in comment 9? 1593124 13 384217 pvollan 2019-11-22 17:50:51 -0800 Created attachment 384217 Patch 1593125 14 pvollan 2019-11-22 17:51:23 -0800 (In reply to Ross Kirsling from comment #12) > Comment on attachment 384212 [details] > Patch > > r=me, but can we also remove the redundant `push(@args, '--64-bit') if > (isFTW());` line I mentioned in comment 9? Done. Thanks for reviewing! 1593127 15 pvollan 2019-11-22 17:52:10 -0800 Will land this once the EWS bots are green. 1593174 16 384217 commit-queue 2019-11-22 21:37:54 -0800 Comment on attachment 384217 Patch Clearing flags on attachment: 384217 Committed r252827: <https://trac.webkit.org/changeset/252827> 1594647 17 webkit-bug-importer 2019-12-02 09:39:23 -0800 <rdar://problem/57560495> 384100 2019-11-21 15:59:22 -0800 2019-11-21 17:11:05 -0800 Patch bug-204477-20191121155922.patch text/plain 1086 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1Mjc1NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTExLTIxICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBTZXQgNjQtYml0IGFzIGRlZmF1bHQgYXJjaGl0ZWN0dXJlIG9uIFdpbmRv d3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDQ3 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg d2lsbCBtYWtlIDY0LWJpdCBidWlsZGluZyBhbmQgdGVzdGluZyB0aGUgZGVmYXVsdC4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHk6CisgICAgICAgIChXaW5Qb3J0KToK KwogMjAxOS0xMS0yMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAog ICAgICAgICBbaU9TXSBXZWIgcHJvY2VzcyBjcmFzaGVzIHdoZW4gYXR0ZW1wdGluZyB0byByZXF1 ZXN0IGRvY3VtZW50IGNvbnRleHQgaW4gYSB0ZXh0YXJlYQpJbmRleDogVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wb3J0L3dpbi5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3BvcnQvd2luLnB5CShyZXZpc2lvbiAyNTI2NTEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3BvcnQvd2luLnB5CSh3b3JraW5nIGNvcHkpCkBAIC02Miw2ICs2Miw4IEBAIGNsYXNzIFdpblBv cnQoQXBwbGVQb3J0KToKIAogICAgIEFSQ0hJVEVDVFVSRVMgPSBbJ3g4NicsICd4ODZfNjQnXQog CisgICAgREVGQVVMVF9BUkNISVRFQ1RVUkUgPSAneDg2XzY0JworCiAgICAgQ1JBU0hfTE9HX1BS RUZJWCA9ICJDcmFzaExvZyIKIAogICAgIGlmIHN5cy5wbGF0Zm9ybS5zdGFydHN3aXRoKCd3aW4n KToK 384107 2019-11-21 17:11:06 -0800 2019-11-22 11:11:07 -0800 Patch bug-204477-20191121171106.patch text/plain 1778 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1Mjc1NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTExLTIxICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBTZXQgNjQtYml0IGFzIGRlZmF1bHQgYXJjaGl0ZWN0dXJlIG9uIFdpbmRv d3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDQ3 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg d2lsbCBtYWtlIDY0LWJpdCBidWlsZGluZyBhbmQgdGVzdGluZyB0aGUgZGVmYXVsdC4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVybWluZUlzV2luNjQp OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHk6CisgICAgICAgIChXaW5Q b3J0KToKKwogMjAxOS0xMS0yMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNv bT4KIAogICAgICAgICBbaU9TXSBXZWIgcHJvY2VzcyBjcmFzaGVzIHdoZW4gYXR0ZW1wdGluZyB0 byByZXF1ZXN0IGRvY3VtZW50IGNvbnRleHQgaW4gYSB0ZXh0YXJlYQpJbmRleDogVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbQkocmV2aXNpb24gMjUyNjUxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3 b3JraW5nIGNvcHkpCkBAIC0xMjkyLDcgKzEyOTIsNyBAQCBzdWIgaXNXaW42NCgpCiBzdWIgZGV0 ZXJtaW5lSXNXaW42NCgpCiB7CiAgICAgcmV0dXJuIGlmIGRlZmluZWQoJGlzV2luNjQpOwotICAg ICRpc1dpbjY0ID0gY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCItLTY0LWJpdCIp IHx8ICgoaXNGVFcoKSB8fCBpc1dpbkNhaXJvKCkgfHwgaXNKU0NPbmx5KCkpICYmICFzaG91bGRC dWlsZDMyQml0KCkpOworICAgICRpc1dpbjY0ID0gY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZy b21BUkdWKCItLTY0LWJpdCIpIHx8ICgoaXNGVFcoKSB8fCBpc1dpbkNhaXJvKCkgfHwgaXNBcHBs ZVdpbldlYktpdCgpIHx8IGlzSlNDT25seSgpKSAmJiAhc2hvdWxkQnVpbGQzMkJpdCgpKTsKIH0K IAogc3ViIGRldGVybWluZUlzV2luNjRGcm9tQXJjaGl0ZWN0dXJlKCQpCkluZGV4OiBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC93aW4ucHkJKHJldmlzaW9uIDI1MjY1MSkKKysrIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC93aW4ucHkJKHdvcmtpbmcgY29weSkKQEAgLTYyLDYgKzYyLDggQEAgY2xh c3MgV2luUG9ydChBcHBsZVBvcnQpOgogCiAgICAgQVJDSElURUNUVVJFUyA9IFsneDg2JywgJ3g4 Nl82NCddCiAKKyAgICBERUZBVUxUX0FSQ0hJVEVDVFVSRSA9ICd4ODZfNjQnCisKICAgICBDUkFT SF9MT0dfUFJFRklYID0gIkNyYXNoTG9nIgogCiAgICAgaWYgc3lzLnBsYXRmb3JtLnN0YXJ0c3dp dGgoJ3dpbicpOgo= 384175 2019-11-22 11:11:09 -0800 2019-11-22 14:23:05 -0800 Patch bug-204477-20191122111108.patch text/plain 1778 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1Mjc1NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTExLTIxICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBTZXQgNjQtYml0IGFzIGRlZmF1bHQgYXJjaGl0ZWN0dXJlIG9uIFdpbmRv d3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDQ3 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg d2lsbCBtYWtlIDY0LWJpdCBidWlsZGluZyBhbmQgdGVzdGluZyB0aGUgZGVmYXVsdC4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVybWluZUlzV2luNjQp OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHk6CisgICAgICAgIChXaW5Q b3J0KToKKwogMjAxOS0xMS0yMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNv bT4KIAogICAgICAgICBbaU9TXSBXZWIgcHJvY2VzcyBjcmFzaGVzIHdoZW4gYXR0ZW1wdGluZyB0 byByZXF1ZXN0IGRvY3VtZW50IGNvbnRleHQgaW4gYSB0ZXh0YXJlYQpJbmRleDogVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbQkocmV2aXNpb24gMjUyNjUxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3 b3JraW5nIGNvcHkpCkBAIC0xMjkyLDcgKzEyOTIsNyBAQCBzdWIgaXNXaW42NCgpCiBzdWIgZGV0 ZXJtaW5lSXNXaW42NCgpCiB7CiAgICAgcmV0dXJuIGlmIGRlZmluZWQoJGlzV2luNjQpOwotICAg ICRpc1dpbjY0ID0gY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCItLTY0LWJpdCIp IHx8ICgoaXNGVFcoKSB8fCBpc1dpbkNhaXJvKCkgfHwgaXNKU0NPbmx5KCkpICYmICFzaG91bGRC dWlsZDMyQml0KCkpOworICAgICRpc1dpbjY0ID0gY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZy b21BUkdWKCItLTY0LWJpdCIpIHx8ICgoaXNGVFcoKSB8fCBpc1dpbkNhaXJvKCkgfHwgaXNBcHBs ZVdpbldlYktpdCgpIHx8IGlzSlNDT25seSgpKSAmJiAhc2hvdWxkQnVpbGQzMkJpdCgpKTsKIH0K IAogc3ViIGRldGVybWluZUlzV2luNjRGcm9tQXJjaGl0ZWN0dXJlKCQpCkluZGV4OiBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC93aW4ucHkJKHJldmlzaW9uIDI1MjY1MSkKKysrIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC93aW4ucHkJKHdvcmtpbmcgY29weSkKQEAgLTYyLDYgKzYyLDggQEAgY2xh c3MgV2luUG9ydChBcHBsZVBvcnQpOgogCiAgICAgQVJDSElURUNUVVJFUyA9IFsneDg2JywgJ3g4 Nl82NCddCiAKKyAgICBERUZBVUxUX0FSQ0hJVEVDVFVSRSA9ICd4ODZfNjQnCisKICAgICBDUkFT SF9MT0dfUFJFRklYID0gIkNyYXNoTG9nIgogCiAgICAgaWYgc3lzLnBsYXRmb3JtLnN0YXJ0c3dp dGgoJ3dpbicpOgo= 384197 2019-11-22 14:23:07 -0800 2019-11-22 17:19:38 -0800 Patch bug-204477-20191122142306.patch text/plain 1778 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1Mjc1NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTExLTIxICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBTZXQgNjQtYml0IGFzIGRlZmF1bHQgYXJjaGl0ZWN0dXJlIG9uIFdpbmRv d3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDQ3 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg d2lsbCBtYWtlIDY0LWJpdCBidWlsZGluZyBhbmQgdGVzdGluZyB0aGUgZGVmYXVsdC4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVybWluZUlzV2luNjQp OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHk6CisgICAgICAgIChXaW5Q b3J0KToKKwogMjAxOS0xMS0yMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNv bT4KIAogICAgICAgICBbaU9TXSBXZWIgcHJvY2VzcyBjcmFzaGVzIHdoZW4gYXR0ZW1wdGluZyB0 byByZXF1ZXN0IGRvY3VtZW50IGNvbnRleHQgaW4gYSB0ZXh0YXJlYQpJbmRleDogVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbQkocmV2aXNpb24gMjUyNjUxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3 b3JraW5nIGNvcHkpCkBAIC0xMjkyLDcgKzEyOTIsNyBAQCBzdWIgaXNXaW42NCgpCiBzdWIgZGV0 ZXJtaW5lSXNXaW42NCgpCiB7CiAgICAgcmV0dXJuIGlmIGRlZmluZWQoJGlzV2luNjQpOwotICAg ICRpc1dpbjY0ID0gY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCItLTY0LWJpdCIp IHx8ICgoaXNGVFcoKSB8fCBpc1dpbkNhaXJvKCkgfHwgaXNKU0NPbmx5KCkpICYmICFzaG91bGRC dWlsZDMyQml0KCkpOworICAgICRpc1dpbjY0ID0gY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZy b21BUkdWKCItLTY0LWJpdCIpIHx8ICgoaXNGVFcoKSB8fCBpc1dpbkNhaXJvKCkgfHwgaXNBcHBs ZVdpbldlYktpdCgpIHx8IGlzSlNDT25seSgpKSAmJiAhc2hvdWxkQnVpbGQzMkJpdCgpKTsKIH0K IAogc3ViIGRldGVybWluZUlzV2luNjRGcm9tQXJjaGl0ZWN0dXJlKCQpCkluZGV4OiBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC93aW4ucHkJKHJldmlzaW9uIDI1MjY1MSkKKysrIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC93aW4ucHkJKHdvcmtpbmcgY29weSkKQEAgLTYyLDYgKzYyLDggQEAgY2xh c3MgV2luUG9ydChBcHBsZVBvcnQpOgogCiAgICAgQVJDSElURUNUVVJFUyA9IFsneDg2JywgJ3g4 Nl82NCddCiAKKyAgICBERUZBVUxUX0FSQ0hJVEVDVFVSRSA9ICd4ODZfNjQnCisKICAgICBDUkFT SF9MT0dfUFJFRklYID0gIkNyYXNoTG9nIgogCiAgICAgaWYgc3lzLnBsYXRmb3JtLnN0YXJ0c3dp dGgoJ3dpbicpOgo= 384212 2019-11-22 16:10:41 -0800 2019-11-22 17:43:50 -0800 Patch bug-204477-20191122161041.patch text/plain 1747 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1Mjc1NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTExLTIxICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBTZXQgNjQtYml0IGFzIGRlZmF1bHQgYXJjaGl0ZWN0dXJlIG9uIFdpbmRv d3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDQ3 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg d2lsbCBtYWtlIDY0LWJpdCBidWlsZGluZyBhbmQgdGVzdGluZyB0aGUgZGVmYXVsdC4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVybWluZUlzV2luNjQp OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHk6CisgICAgICAgIChXaW5Q b3J0KToKKwogMjAxOS0xMS0yMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNv bT4KIAogICAgICAgICBbaU9TXSBXZWIgcHJvY2VzcyBjcmFzaGVzIHdoZW4gYXR0ZW1wdGluZyB0 byByZXF1ZXN0IGRvY3VtZW50IGNvbnRleHQgaW4gYSB0ZXh0YXJlYQpJbmRleDogVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbQkocmV2aXNpb24gMjUyNjUxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3 b3JraW5nIGNvcHkpCkBAIC0xMjkyLDcgKzEyOTIsNyBAQCBzdWIgaXNXaW42NCgpCiBzdWIgZGV0 ZXJtaW5lSXNXaW42NCgpCiB7CiAgICAgcmV0dXJuIGlmIGRlZmluZWQoJGlzV2luNjQpOwotICAg ICRpc1dpbjY0ID0gY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCItLTY0LWJpdCIp IHx8ICgoaXNGVFcoKSB8fCBpc1dpbkNhaXJvKCkgfHwgaXNKU0NPbmx5KCkpICYmICFzaG91bGRC dWlsZDMyQml0KCkpOworICAgICRpc1dpbjY0ID0gY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZy b21BUkdWKCItLTY0LWJpdCIpIHx8ICgoaXNBbnlXaW5kb3dzKCkgfHwgaXNKU0NPbmx5KCkpICYm ICFzaG91bGRCdWlsZDMyQml0KCkpOwogfQogCiBzdWIgZGV0ZXJtaW5lSXNXaW42NEZyb21BcmNo aXRlY3R1cmUoJCkKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weQkocmV2aXNpb24g MjUyNjUxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weQkod29ya2luZyBj b3B5KQpAQCAtNjIsNiArNjIsOCBAQCBjbGFzcyBXaW5Qb3J0KEFwcGxlUG9ydCk6CiAKICAgICBB UkNISVRFQ1RVUkVTID0gWyd4ODYnLCAneDg2XzY0J10KIAorICAgIERFRkFVTFRfQVJDSElURUNU VVJFID0gJ3g4Nl82NCcKKwogICAgIENSQVNIX0xPR19QUkVGSVggPSAiQ3Jhc2hMb2ciCiAKICAg ICBpZiBzeXMucGxhdGZvcm0uc3RhcnRzd2l0aCgnd2luJyk6Cg== 384217 2019-11-22 17:50:51 -0800 2019-11-22 21:37:54 -0800 Patch bug-204477-20191122175050.patch text/plain 2180 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MjgxOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTExLTIyICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBTZXQgNjQtYml0IGFzIGRlZmF1bHQgYXJjaGl0ZWN0dXJlIG9uIFdpbmRv d3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDQ3 NworCisgICAgICAgIFJldmlld2VkIGJ5IFJvc3MgS2lyc2xpbmcuCisKKyAgICAgICAgVGhpcyB3 aWxsIG1ha2UgNjQtYml0IGJ1aWxkaW5nIGFuZCB0ZXN0aW5nIHRoZSBkZWZhdWx0LgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoZGV0ZXJtaW5lSXNXaW42NCk6 CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weToKKyAgICAgICAgKFdpblBv cnQpOgorCiAyMDE5LTExLTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4K IAogICAgICAgICByZXN1bHRzLndlYmtpdC5vcmcvYXBpL2ZhaWx1cmVzIHNob3VsZCByZXR1cm4g YW4gZXJyb3Igd2hlbiBubyB0ZXN0LXJ1biBpcyBmb3VuZCBmb3Igc3BlY2lmaWVkIGNyaXRlcmlh CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtCShyZXZpc2lvbiAyNTI4MTkpCisrKyBUb29scy9TY3JpcHRz L3dlYmtpdGRpcnMucG0JKHdvcmtpbmcgY29weSkKQEAgLTQ5NSw3ICs0OTUsNiBAQCBzdWIgYXJn dW1lbnRzRm9yQ29uZmlndXJhdGlvbigpCiAgICAgcHVzaChAYXJncywgJy0tbWFjY2F0YWx5c3Qn KSBpZiAoZGVmaW5lZCAkeGNvZGVTREsgJiYgJHhjb2RlU0RLID1+IC9ebWFjY2F0YWx5c3QvKTsK ICAgICBwdXNoKEBhcmdzLCAnLS0zMi1iaXQnKSBpZiAoJGFyY2hpdGVjdHVyZSBlcSAieDg2IiBh bmQgIWlzV2luNjQoKSk7CiAgICAgcHVzaChAYXJncywgJy0tNjQtYml0JykgaWYgKGlzV2luNjQo KSk7Ci0gICAgcHVzaChAYXJncywgJy0tNjQtYml0JykgaWYgKGlzRlRXKCkpOwogICAgIHB1c2go QGFyZ3MsICctLWZ0dycpIGlmIGlzRlRXKCk7CiAgICAgcHVzaChAYXJncywgJy0tZ3RrJykgaWYg aXNHdGsoKTsKICAgICBwdXNoKEBhcmdzLCAnLS13cGUnKSBpZiBpc1dQRSgpOwpAQCAtMTI5Miw3 ICsxMjkxLDcgQEAgc3ViIGlzV2luNjQoKQogc3ViIGRldGVybWluZUlzV2luNjQoKQogewogICAg IHJldHVybiBpZiBkZWZpbmVkKCRpc1dpbjY0KTsKLSAgICAkaXNXaW42NCA9IGNoZWNrRm9yQXJn dW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS02NC1iaXQiKSB8fCAoKGlzRlRXKCkgfHwgaXNXaW5D YWlybygpIHx8IGlzSlNDT25seSgpKSAmJiAhc2hvdWxkQnVpbGQzMkJpdCgpKTsKKyAgICAkaXNX aW42NCA9IGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS02NC1iaXQiKSB8fCAo KGlzQW55V2luZG93cygpIHx8IGlzSlNDT25seSgpKSAmJiAhc2hvdWxkQnVpbGQzMkJpdCgpKTsK IH0KIAogc3ViIGRldGVybWluZUlzV2luNjRGcm9tQXJjaGl0ZWN0dXJlKCQpCkluZGV4OiBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC93aW4ucHkJKHJldmlzaW9uIDI1MjgxOSkKKysrIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC93aW4ucHkJKHdvcmtpbmcgY29weSkKQEAgLTYyLDYgKzYyLDggQEAg Y2xhc3MgV2luUG9ydChBcHBsZVBvcnQpOgogCiAgICAgQVJDSElURUNUVVJFUyA9IFsneDg2Jywg J3g4Nl82NCddCiAKKyAgICBERUZBVUxUX0FSQ0hJVEVDVFVSRSA9ICd4ODZfNjQnCisKICAgICBD UkFTSF9MT0dfUFJFRklYID0gIkNyYXNoTG9nIgogCiAgICAgaWYgc3lzLnBsYXRmb3JtLnN0YXJ0 c3dpdGgoJ3dpbicpOgo=