204476 2019-11-21 15:20:19 -0800 Web Inspector: limit P3 colors to two decimals 2022-02-10 15:55:44 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED MOVED P2 Normal --- 203534 1 hi hi hi inspector-bugzilla-changes nvasilyev oldest_to_newest 1592559 0 hi 2019-11-21 15:20:19 -0800 # STEPS TO REPRODUCE: 1. inspect any page 2. add `color: color(display-p3 1 0 0);` property to any node 3. click the color swatch that appears before the `color(` 4. drag the dot around the color square => some values appear with more than two decimals 1592560 1 384096 hi 2019-11-21 15:21:22 -0800 Created attachment 384096 Patch 1592584 2 nvasilyev 2019-11-21 16:34:12 -0800 I agree that we should limit the number of decimals but I don't agree on allowing only two. Display-P3 color space is 10bit per channel. Allowing only two decimals for 0 to 1 values is quite limiting. Re: bug title This isn't just about P3, it's about color function, e.g. `color(SRGB 1 0 1)`. 1592661 3 hi 2019-11-21 22:08:32 -0800 Looks like this is handled by <https://webkit.org/b/203534>. 384096 2019-11-21 15:21:22 -0800 2022-02-10 15:55:44 -0800 Patch bug-204476-20191121152122.patch text/plain 1471 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE4ZDI3ZDI1OTY5Mjk3MTIyYmRiN2JjOTI0Y2Qy NDQxMWVmZWIwNjQuLjE5M2Y4ZTE1ZTA5M2QyN2Q5Nzk4MTEwMTE0MjI1ZTgyZWZjNzkzMjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTExLTIxICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBs aW1pdCBQMyBjb2xvcnMgdG8gdHdvIGRlY2ltYWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ0NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL0NvbG9yLmpzOgor ICAgICAgICAoV0kuQ29sb3IucHJvdG90eXBlLl90b0Z1bmN0aW9uU3RyaW5nKToKKwogMjAxOS0x MS0yMSAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBPdXRsaW5lIHNSR0Itc2FmZSBhcmVhcyBvbiBQMyBjb2xvciBwaWNrZXIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9D b2xvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9Db2xv ci5qcwppbmRleCBiYjVlNGQ4ZGU2ZDAxYjJlNmY1MzgyNTI0NTMxZmVhMzU3Zjc1NmU2Li5lNmRh Y2MxYmZkM2QwNGQyMDJhNzlhMTRlNzFkNjc2NTQ1NDhiZmRhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ29sb3IuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NvbG9yLmpzCkBAIC03MzEsNyAr NzMxLDExIEBAIFdJLkNvbG9yID0gY2xhc3MgQ29sb3IKIAogICAgIF90b0Z1bmN0aW9uU3RyaW5n KCkKICAgICB7Ci0gICAgICAgIGxldCBbciwgZywgYiwgYWxwaGFdID0gdGhpcy5yZ2JhOworICAg ICAgICBsZXQgcmdiYSA9IHRoaXMucmdiYTsKKyAgICAgICAgbGV0IHIgPSByZ2JhWzBdLm1heERl Y2ltYWxzKDIpOworICAgICAgICBsZXQgZyA9IHJnYmFbMV0ubWF4RGVjaW1hbHMoMik7CisgICAg ICAgIGxldCBiID0gcmdiYVsyXS5tYXhEZWNpbWFscygyKTsKKyAgICAgICAgbGV0IGFscGhhID0g cmdiYVszXTsKICAgICAgICAgaWYgKGFscGhhID09PSAxKQogICAgICAgICAgICAgcmV0dXJuIGBj b2xvcigke3RoaXMuZ2FtdXR9ICR7cn0gJHtnfSAke2J9KWA7CiAgICAgICAgIHJldHVybiBgY29s b3IoJHt0aGlzLmdhbXV0fSAke3J9ICR7Z30gJHtifSAvICR7YWxwaGF9KWA7Cg==