204473 2019-11-21 14:03:02 -0800 Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'target.PageAgent.getCompositingBordersVisible') 2019-11-22 16:15:37 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1592538 0 hi 2019-11-21 14:03:02 -0800 Uncaught Exception in Web Inspector. Steps to Reproduce: 1. inspect any page 2. go to the Layers Tab 3. close Web Inspector 4. open Web Inspector Uncaught Exceptions: ----------------------- - TypeError: undefined is not an object (evaluating 'target.PageAgent.getCompositingBordersVisible') (at Layers3DContentView.js:426:25) _updateCompositingBordersButtonState @ Layers3DContentView.js:426:25 shown @ Layers3DContentView.js:83:50 prepareToShow @ BackForwardEntry.js:84:35 _showEntry @ ContentViewContainer.js:456:28 showBackForwardEntryForIndex @ ContentViewContainer.js:166:28 showContentView @ ContentViewContainer.js:142:42 shown @ LayersTabContentView.js:73:44 prepareToShow @ BackForwardEntry.js:84:35 _showEntry @ ContentViewContainer.js:456:28 showBackForwardEntryForIndex @ ContentViewContainer.js:166:28 showContentView @ ContentViewContainer.js:142:42 _tabBarItemSelected @ TabBrowser.js:240:55 dispatch @ Object.js:165:30 dispatchEventToListeners @ Object.js:172:17 selectedTabBarItem @ LegacyTabBar.js:387:38 ? @ Main.js:510:14 ----------------------- Notes: Inspected URL: (unknown) Loading completed: false Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko) 1592543 1 384090 hi 2019-11-21 14:22:10 -0800 Created attachment 384090 Patch 1593017 2 384090 bburg 2019-11-22 14:37:03 -0800 Comment on attachment 384090 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384090&action=review r=me > Source/WebInspectorUI/UserInterface/Controllers/TargetManager.js:261 > + WI._backendTargetAvailablePromise.resolve(); This reads nice now. > Source/WebInspectorUI/UserInterface/Controllers/TargetManager.js:273 > + WI._pageTargetAvailablePromise.resolve(); Ditto :) 1593094 3 384090 commit-queue 2019-11-22 16:14:56 -0800 Comment on attachment 384090 Patch Clearing flags on attachment: 384090 Committed r252814: <https://trac.webkit.org/changeset/252814> 1593095 4 commit-queue 2019-11-22 16:14:57 -0800 All reviewed patches have been landed. Closing bug. 1593098 5 webkit-bug-importer 2019-11-22 16:15:37 -0800 <rdar://problem/57444627> 384090 2019-11-21 14:22:10 -0800 2019-11-22 16:14:56 -0800 Patch bug-204473-20191121142210.patch text/plain 6515 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDcyNGMzNmU4Mjk4ZGNiYzJmZTJlNTM5OWE5MzQw YWFkZGY3NzU1MGYuLjhkMWVlMGYyYjhiMDg0ZGM5MmQwM2UwMzgzZTU2Y2U2YWZjZGJlMjAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDE5LTExLTIxICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBV bmNhdWdodCBFeGNlcHRpb246IFR5cGVFcnJvcjogdW5kZWZpbmVkIGlzIG5vdCBhbiBvYmplY3Qg KGV2YWx1YXRpbmcgJ3RhcmdldC5QYWdlQWdlbnQuZ2V0Q29tcG9zaXRpbmdCb3JkZXJzVmlzaWJs ZScpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ0 NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFu Z2UgdGhlIGRlZmluaXRpb24gb2YgYFdJLnRhcmdldHNBdmFpbGFibGVgIGFuZCBgV0kud2hlblRh cmdldHNBdmFpbGFibGVgIHRvIGluc3RlYWQKKyAgICAgICAgcmVzb2x2ZSBiYXNlZCBvbiB3aGVu IGEgcGFnZSB0YXJnZXQgaXMgY3JlYXRlZCwgbm90IHRoZSBiYWNrZW5kIHRhcmdldCwgYXMgdGhl IGxhdHRlciBjYW4KKyAgICAgICAgYmUgYSBtdWx0aXBsZXhpbmcgdGFyZ2V0IHdoaWNoIG9ubHkg aGFzIGEgYFRhcmdldGAgZG9tYWluLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9s bGVycy9UYXJnZXRNYW5hZ2VyLmpzOgorICAgICAgICAoV0kuVGFyZ2V0TWFuYWdlci5wcm90b3R5 cGUuX2luaXRpYWxpemVCYWNrZW5kVGFyZ2V0KToKKyAgICAgICAgKFdJLlRhcmdldE1hbmFnZXIu cHJvdG90eXBlLl9pbml0aWFsaXplUGFnZVRhcmdldCk6CisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL0Jhc2UvTWFpbi5qczoKKyAgICAgICAgKFdJLmxvYWRlZCk6CisgICAgICAgIChXSS5jb250 ZW50TG9hZGVkKToKKyAgICAgICAgKFdJLnRhcmdldHNBdmFpbGFibGUpOgorICAgICAgICAoV0ku d2hlblRhcmdldHNBdmFpbGFibGUpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVGVzdC9UZXN0 LmpzOgorICAgICAgICAoV0kubG9hZGVkKToKKyAgICAgICAgKFdJLmNvbnRlbnRMb2FkZWQpOgor ICAgICAgICAoV0kudGFyZ2V0c0F2YWlsYWJsZSk6CisgICAgICAgIChXSS53aGVuVGFyZ2V0c0F2 YWlsYWJsZSk6CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaFNpZGViYXJQ YW5lbC5qczoKKyAgICAgICAgKFdJLlNlYXJjaFNpZGViYXJQYW5lbC5wcm90b3R5cGUucGVyZm9y bVNlYXJjaCk6CisgICAgICAgIE9ubHkgd2FpdCBmb3IgdGFyZ2V0cyBpZiBpbnNwZWN0aW5nIGEg d2ViIGRlYnVnZ2FibGUsIGFzIG5vbi13ZWIgZGVidWdnYWJsZXMgZG9uJ3QgaGF2ZSBhCisgICAg ICAgIGRpZmZlcmVudCBwYWdlIHRhcmdldCB2cyB0aGUgYmFja2VuZCB0YXJnZXQgKHdoaWNoIGlz IGd1YXJhbnRlZWQgdG8gZXhpc3QgYW55d2F5cykuCisKIDIwMTktMTEtMjAgIFl1cnkgU2VtaWto YXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUkVH UkVTU0lPTihyMjUwNjE4KTogbWFpbiByZXNvdXJjZSB2aWV3IGlzIGVtcHR5IHdoZW4gcGF1c2lu ZyBvbiBpbmxpbmUgJ2RlYnVnZ2VyJyBzdGF0ZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCA3NzVkYzgyYmRiZjE4MjYwNmE4 Zjg1MjIzMGU4MDI2MWVhNzJlYTMxLi4yOWRmOTA2NjI4OGJiYzFmYjRjMTI1ZjA5Nzk5OGY4ZWM0 ZDRmYzkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFz ZS9NYWluLmpzCkBAIC0xODUsOCArMTg1LDEwIEBAIFdJLmxvYWRlZCA9IGZ1bmN0aW9uKCkKIAog ICAgIC8vIFRhcmdldHMuCiAgICAgV0kuYmFja2VuZFRhcmdldCA9IG51bGw7CisgICAgV0kuX2Jh Y2tlbmRUYXJnZXRBdmFpbGFibGVQcm9taXNlID0gbmV3IFdJLldyYXBwZWRQcm9taXNlOworCiAg ICAgV0kucGFnZVRhcmdldCA9IG51bGw7Ci0gICAgV0kuX3RhcmdldHNBdmFpbGFibGVQcm9taXNl ID0gbmV3IFdJLldyYXBwZWRQcm9taXNlOworICAgIFdJLl9wYWdlVGFyZ2V0QXZhaWxhYmxlUHJv bWlzZSA9IG5ldyBXSS5XcmFwcGVkUHJvbWlzZTsKIAogICAgIC8vIENPTVBBVElCSUxJVFkgKGlP UyAxMy4wKTogVGFyZ2V0LmV4aXN0cyB3YXMgInJlcGxhY2VkIiBieSBkaWZmZXJlbnRpYXRpbmcg IndlYiIgZGVidWdnYWJsZXMKICAgICAvLyBpbnRvICJwYWdlIiAoZGlyZWN0KSBhbmQgIndlYi1w YWdlIiBkZWJ1Z2dhYmxlcyAobXVsdGlwbGV4aW5nKS4KQEAgLTUyNyw3ICs1MjksNyBAQCBXSS5j b250ZW50TG9hZGVkID0gZnVuY3Rpb24oKQogICAgIHVwZGF0ZUNvbnNvbGVTYXZlZFJlc3VsdFBy ZWZpeENTU1ZhcmlhYmxlKCk7CiAKICAgICAvLyBTaWduYWwgdGhhdCB0aGUgZnJvbnRlbmQgaXMg bm93IHJlYWR5IHRvIHJlY2VpdmUgbWVzc2FnZXMuCi0gICAgV0kud2hlblRhcmdldHNBdmFpbGFi bGUoKS50aGVuKCgpID0+IHsKKyAgICBXSS5fYmFja2VuZFRhcmdldEF2YWlsYWJsZVByb21pc2Uu cHJvbWlzZS50aGVuKCgpID0+IHsKICAgICAgICAgSW5zcGVjdG9yRnJvbnRlbmRBUEkubG9hZENv bXBsZXRlZCgpOwogICAgIH0pOwogCkBAIC01ODgsMTIgKzU5MCwxMiBAQCBXSS5pbml0aWFsaXpl VGFyZ2V0ID0gZnVuY3Rpb24odGFyZ2V0KQogCiBXSS50YXJnZXRzQXZhaWxhYmxlID0gZnVuY3Rp b24oKQogewotICAgIHJldHVybiBXSS5fdGFyZ2V0c0F2YWlsYWJsZVByb21pc2Uuc2V0dGxlZDsK KyAgICByZXR1cm4gV0kuX3BhZ2VUYXJnZXRBdmFpbGFibGVQcm9taXNlLnNldHRsZWQ7CiB9Owog CiBXSS53aGVuVGFyZ2V0c0F2YWlsYWJsZSA9IGZ1bmN0aW9uKCkKIHsKLSAgICByZXR1cm4gV0ku X3RhcmdldHNBdmFpbGFibGVQcm9taXNlLnByb21pc2U7CisgICAgcmV0dXJuIFdJLl9wYWdlVGFy Z2V0QXZhaWxhYmxlUHJvbWlzZS5wcm9taXNlOwogfTsKIAogV0kuaXNUYWJUeXBlQWxsb3dlZCA9 IGZ1bmN0aW9uKHRhYlR5cGUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Db250cm9sbGVycy9UYXJnZXRNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVGFyZ2V0TWFuYWdlci5qcwppbmRleCA5 Njk4N2E0ZTU3ZDNhNmNlMzBmNzY2MzM1ZDI5OTIxOTUzMTg3MTE1Li4xNDk1MzFkODU4NzM5MjJi YzBjYjZlOTFkMjZiNzNjMWEyMTZmODUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UYXJnZXRNYW5hZ2VyLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1RhcmdldE1hbmFnZXIu anMKQEAgLTI1OCw3ICsyNTgsNyBAQCBXSS5UYXJnZXRNYW5hZ2VyID0gY2xhc3MgVGFyZ2V0TWFu YWdlciBleHRlbmRzIFdJLk9iamVjdAogCiAgICAgICAgIHRoaXMuX3Jlc2V0TWFpbkV4ZWN1dGlv bkNvbnRleHQoKTsKIAotICAgICAgICBXSS5fdGFyZ2V0c0F2YWlsYWJsZVByb21pc2UucmVzb2x2 ZSgpOworICAgICAgICBXSS5fYmFja2VuZFRhcmdldEF2YWlsYWJsZVByb21pc2UucmVzb2x2ZSgp OwogICAgIH0KIAogICAgIF9pbml0aWFsaXplUGFnZVRhcmdldCh0YXJnZXQpCkBAIC0yNjksNiAr MjY5LDggQEAgV0kuVGFyZ2V0TWFuYWdlciA9IGNsYXNzIFRhcmdldE1hbmFnZXIgZXh0ZW5kcyBX SS5PYmplY3QKICAgICAgICAgV0kucGFnZVRhcmdldCA9IHRhcmdldDsKIAogICAgICAgICB0aGlz Ll9yZXNldE1haW5FeGVjdXRpb25Db250ZXh0KCk7CisKKyAgICAgICAgV0kuX3BhZ2VUYXJnZXRB dmFpbGFibGVQcm9taXNlLnJlc29sdmUoKTsKICAgICB9CiAKICAgICBfdHJhbnNpdGlvblBhZ2VU YXJnZXQodGFyZ2V0KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVGVzdC9UZXN0LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv VGVzdC9UZXN0LmpzCmluZGV4IDgzYWE2MDliZmQxMjIzOTAwZDk0ZjIzZjhkZWZiYWZmZmM2M2U3 MDEuLjNjNDNhZTc4YmUxNzI3NzA3MjliNzAzMmFiZTU0NDQzYzk0NmE4YmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Rlc3QvVGVzdC5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9UZXN0L1Rlc3QuanMKQEAgLTc3LDgg Kzc3LDEwIEBAIFdJLmxvYWRlZCA9IGZ1bmN0aW9uKCkKIAogICAgIC8vIFRhcmdldHMuCiAgICAg V0kuYmFja2VuZFRhcmdldCA9IG51bGw7CisgICAgV0kuX2JhY2tlbmRUYXJnZXRBdmFpbGFibGVQ cm9taXNlID0gbmV3IFdJLldyYXBwZWRQcm9taXNlOworCiAgICAgV0kucGFnZVRhcmdldCA9IG51 bGw7Ci0gICAgV0kuX3RhcmdldHNBdmFpbGFibGVQcm9taXNlID0gbmV3IFdJLldyYXBwZWRQcm9t aXNlOworICAgIFdJLl9wYWdlVGFyZ2V0QXZhaWxhYmxlUHJvbWlzZSA9IG5ldyBXSS5XcmFwcGVk UHJvbWlzZTsKIAogICAgIGlmIChJbnNwZWN0b3JCYWNrZW5kLmhhc0RvbWFpbigiVGFyZ2V0Iikp CiAgICAgICAgIFdJLnRhcmdldE1hbmFnZXIuY3JlYXRlTXVsdGlwbGV4aW5nQmFja2VuZFRhcmdl dCgpOwpAQCAtOTksNyArMTAxLDcgQEAgV0kuY29udGVudExvYWRlZCA9IGZ1bmN0aW9uKCkKICAg ICBXSS50aW1lbGluZU1hbmFnZXIuZW5hYmxlKCk7CiAKICAgICAvLyBTaWduYWwgdGhhdCB0aGUg ZnJvbnRlbmQgaXMgbm93IHJlYWR5IHRvIHJlY2VpdmUgbWVzc2FnZXMuCi0gICAgV0kud2hlblRh cmdldHNBdmFpbGFibGUoKS50aGVuKCgpID0+IHsKKyAgICBXSS5fYmFja2VuZFRhcmdldEF2YWls YWJsZVByb21pc2UucHJvbWlzZS50aGVuKCgpID0+IHsKICAgICAgICAgSW5zcGVjdG9yRnJvbnRl bmRBUEkubG9hZENvbXBsZXRlZCgpOwogICAgIH0pOwogCkBAIC0xMjgsMTIgKzEzMCwxMiBAQCBX SS5pbml0aWFsaXplVGFyZ2V0ID0gZnVuY3Rpb24odGFyZ2V0KQogCiBXSS50YXJnZXRzQXZhaWxh YmxlID0gZnVuY3Rpb24oKQogewotICAgIHJldHVybiBXSS5fdGFyZ2V0c0F2YWlsYWJsZVByb21p c2Uuc2V0dGxlZDsKKyAgICByZXR1cm4gV0kuX3BhZ2VUYXJnZXRBdmFpbGFibGVQcm9taXNlLnNl dHRsZWQ7CiB9OwogCiBXSS53aGVuVGFyZ2V0c0F2YWlsYWJsZSA9IGZ1bmN0aW9uKCkKIHsKLSAg ICByZXR1cm4gV0kuX3RhcmdldHNBdmFpbGFibGVQcm9taXNlLnByb21pc2U7CisgICAgcmV0dXJu IFdJLl9wYWdlVGFyZ2V0QXZhaWxhYmxlUHJvbWlzZS5wcm9taXNlOwogfTsKIAogT2JqZWN0LmRl ZmluZVByb3BlcnR5KFdJLCAibWFpblRhcmdldCIsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZWFyY2hTaWRlYmFyUGFuZWwuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZWFyY2hTaWRlYmFyUGFuZWwu anMKaW5kZXggMTg3MTFmMmYxNTg2MmQ4M2IyYmY4ZDM2ZWM4ZjRmYTk1OTgwNGU3Ny4uZmU4MjAz MWM5YmJmNDkyOGIwNGU3OGRiMmI2Mjc1ZWFiMmIxYjM2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoU2lkZWJhclBhbmVsLmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaFNpZGVi YXJQYW5lbC5qcwpAQCAtMTA5LDcgKzEwOSw3IEBAIFdJLlNlYXJjaFNpZGViYXJQYW5lbCA9IGNs YXNzIFNlYXJjaFNpZGViYXJQYW5lbCBleHRlbmRzIFdJLk5hdmlnYXRpb25TaWRlYmFyUGFuCiAg ICAgICAgICAgICB0aGlzLnVwZGF0ZUVtcHR5Q29udGVudFBsYWNlaG9sZGVyKHNlYXJjaGluZ1Bs YWNlaG9sZGVyKTsKICAgICAgICAgfTsKIAotICAgICAgICBpZiAoIVdJLnRhcmdldHNBdmFpbGFi bGUoKSkgeworICAgICAgICBpZiAoIVdJLnRhcmdldHNBdmFpbGFibGUoKSAmJiBXSS5zaGFyZWRB cHAuaXNXZWJEZWJ1Z2dhYmxlKCkpIHsKICAgICAgICAgICAgIGNyZWF0ZVNlYXJjaGluZ1BsYWNl aG9sZGVyKCk7CiAgICAgICAgICAgICBXSS53aGVuVGFyZ2V0c0F2YWlsYWJsZSgpLnRoZW4oKCkg PT4gewogICAgICAgICAgICAgICAgIGlmICh0aGlzLl9zZWFyY2hRdWVyeVNldHRpbmcudmFsdWUg PT09IHNlYXJjaFF1ZXJ5KQo=