204472 2019-11-21 14:03:00 -0800 Simplify VisitedLinkStore process registration logic 2019-11-22 15:53:25 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren webkit-bug-importer youennf oldest_to_newest 1592537 0 cdumez 2019-11-21 14:03:00 -0800 Simplify VisitedLinkStore process registration logic. 1592541 1 384089 cdumez 2019-11-21 14:06:31 -0800 Created attachment 384089 Patch 1592869 2 384089 youennf 2019-11-22 10:19:28 -0800 Comment on attachment 384089 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384089&action=review > Source/WebKit/UIProcess/WebProcessProxy.cpp:-386 > - m_visitedLinkStoresWithUsers.clear(); This means the visitedLinkStore will keep shutdown but still existing processes. Can this create some changes of behavior? 1593016 3 384089 ggaren 2019-11-22 14:34:52 -0800 Comment on attachment 384089 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384089&action=review r=me > Source/WebKit/UIProcess/VisitedLinkStore.cpp:46 > + RELEASE_ASSERT(m_processes.computesEmpty()); FWIW, I think this function was supposed to be named computeIsEmpty(). >> Source/WebKit/UIProcess/WebProcessProxy.cpp:-386 >> - m_visitedLinkStoresWithUsers.clear(); > > This means the visitedLinkStore will keep shutdown but still existing processes. > Can this create some changes of behavior? Interesting point -- but I can't think of any consequence. We might try to send a message to shut a process -- and then the message should be dropped. 1593019 4 cdumez 2019-11-22 14:40:49 -0800 (In reply to youenn fablet from comment #2) > Comment on attachment 384089 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384089&action=review > > > Source/WebKit/UIProcess/WebProcessProxy.cpp:-386 > > - m_visitedLinkStoresWithUsers.clear(); > > This means the visitedLinkStore will keep shutdown but still existing > processes. > Can this create some changes of behavior? This is explained in the change log. It does not matter because IPC send() is a no-op for processes that are no longer running. So the VisitedLinkStore may now try to send IPC to processes that are no longer running but it will not matter. 1593078 5 384089 cdumez 2019-11-22 15:52:21 -0800 Comment on attachment 384089 Patch Clearing flags on attachment: 384089 Committed r252812: <https://trac.webkit.org/changeset/252812> 1593079 6 cdumez 2019-11-22 15:52:22 -0800 All reviewed patches have been landed. Closing bug. 1593081 7 webkit-bug-importer 2019-11-22 15:53:25 -0800 <rdar://problem/57444053> 384089 2019-11-21 14:06:31 -0800 2019-11-22 15:52:21 -0800 Patch bug-204472-20191121140631.patch text/plain 7690 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVhNmY2NGJjYzllN2JjMzY2 YjliNDU1MjM5NTc5M2JiODRmNGE4MTYuLjQyMjhhMDE1NjRlNjFhY2U4NzUyMDY1NDgxYWFjMDhk NDMwMzFjYTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzMgQEAKKzIwMTktMTEtMjEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBTaW1wbGlmeSBWaXNpdGVkTGlua1N0 b3JlIHByb2Nlc3MgcmVnaXN0cmF0aW9uIGxvZ2ljCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ0NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTaW1wbGlmeSBWaXNpdGVkTGlua1N0b3JlIHByb2Nlc3Mg cmVnaXN0cmF0aW9uIGxvZ2ljOgorICAgICAgICAxLiBXZWJQcm9jZXNzUHJveHkgb2JqZWN0cyBu byBsb25nZXIgZGVsYXkgdGhlaXIgcmVnaXN0cmF0aW9uIHdpdGggdGhlIFZpc2l0ZWRMaW5rU3Rv cmUgdW50aWwKKyAgICAgICAgICAgYWZ0ZXIgdGhleSBhcmUgZG9uZSBsYXVuY2hpbmcuIFRoZXJl IGlzIG5vIG5lZWQgdG8gZG8gdGhpcyBiZWNhdXNlIEF1eGlsaWF4eVByb2Nlc3NQcm94eTo6c2Vu ZCgpCisgICAgICAgICAgIHdpbGwgY29ycmVjdGx5IHF1ZXVlIHRoZSBJUEMgbWVzc2FnZSBpZiB0 aGUgcHJvY2VzcyBpcyBub3QgZG9uZSBsYXVuY2hpbmcgd2hlbiB0aGUgVmlzaXRlZExpbmtTdG9y ZQorICAgICAgICAgICB0cmllcyB0byBzZW5kIGl0cyBJUEMuCisgICAgICAgIDIuIFN3aXRjaCBW aXNpdGVkTGlua1N0b3JlIHRvIHVzaW5nIGEgV2Vha0hhc2hTZXQgdG8gc3RvcmUgdGhlIFdlYlBy b2Nlc3NQcm94eSBvYmplY3QgcG9pbnRlcnMuIFRoaXMKKyAgICAgICAgICAgaXMgc2FmZXIgYW5k IHRoaXMgYWxzbyBtYWtlcyBpdCBzbyB0aGF0IHRoZSBXZWJQcm9jZXNzUHJveHkgbm8gbG9uZ2Vy IG5lZWQgdG8gdW5yZWdpc3RlciB0aGVtc2VsdmVzCisgICAgICAgICAgIHdoZW4gc2h1dHRpbmcg ZG93bi4gTm90ZSB0aGF0IEF1eGlsaWF4eVByb2Nlc3NQcm94eTo6c2VuZCgpIHByb3Blcmx5IGRp c2NhcmRzIElQQyBtZXNzYWdlcyB0bworICAgICAgICAgICBhIHRlcm1pbmF0ZWQgcHJvY2VzcyBh bnl3YXkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvVmlzaXRlZExpbmtTdG9yZS5jcHA6CisgICAg ICAgIChXZWJLaXQ6OlZpc2l0ZWRMaW5rU3RvcmU6On5WaXNpdGVkTGlua1N0b3JlKToKKyAgICAg ICAgKFdlYktpdDo6VmlzaXRlZExpbmtTdG9yZTo6YWRkUHJvY2Vzcyk6CisgICAgICAgIChXZWJL aXQ6OlZpc2l0ZWRMaW5rU3RvcmU6OnJlbW92ZVByb2Nlc3MpOgorICAgICAgICAoV2ViS2l0OjpW aXNpdGVkTGlua1N0b3JlOjpyZW1vdmVBbGwpOgorICAgICAgICAoV2ViS2l0OjpWaXNpdGVkTGlu a1N0b3JlOjpkaWRJbnZhbGlkYXRlU2hhcmVkTWVtb3J5KToKKyAgICAgICAgKFdlYktpdDo6Vmlz aXRlZExpbmtTdG9yZTo6ZGlkVXBkYXRlU2hhcmVkU3RyaW5nSGFzaGVzKToKKyAgICAgICAgKiBV SVByb2Nlc3MvVmlzaXRlZExpbmtTdG9yZS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9j ZXNzUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6OnNodXREb3du KToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Byb3h5OjphZGRWaXNpdGVkTGlua1N0b3Jl VXNlcik6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQcm94eTo6ZGlkRmluaXNoTGF1bmNo aW5nKToKKwogMjAxOS0xMS0yMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAg ICAgICAgIFtpT1NdIE1ha2Ugc3VyZSBXZWJDb250ZW50IHByb2Nlc3MgZG9lcyBub3QgZ2V0IHN1 c3BlbmRlZCB3aGlsZSBpdCBpcyBob2xkaW5nIGEgcHJvY2VzcyBhc3NlcnRpb24gZm9yIHRoZSBV SVByb2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1Zpc2l0ZWRMaW5r U3RvcmUuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvVmlzaXRlZExpbmtTdG9yZS5jcHAK aW5kZXggYmI2NTA5OTAzNDlmMGYyMzJiYzhkMzA3NTYwMTMzZmQ3NmFhMjczYi4uZWIzYjEyZWU1 NjFkNTRjMzAyZDFmYTVhZmQwZGM2ZDI2MjUxNWU5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvVmlzaXRlZExpbmtTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvVmlzaXRlZExpbmtTdG9yZS5jcHAKQEAgLTQzLDcgKzQzLDcgQEAgUmVmPFZpc2l0ZWRM aW5rU3RvcmU+IFZpc2l0ZWRMaW5rU3RvcmU6OmNyZWF0ZSgpCiAKIFZpc2l0ZWRMaW5rU3RvcmU6 On5WaXNpdGVkTGlua1N0b3JlKCkKIHsKLSAgICBSRUxFQVNFX0FTU0VSVChtX3Byb2Nlc3Nlcy5p c0VtcHR5KCkpOworICAgIFJFTEVBU0VfQVNTRVJUKG1fcHJvY2Vzc2VzLmNvbXB1dGVzRW1wdHko KSk7CiB9CiAKIFZpc2l0ZWRMaW5rU3RvcmU6OlZpc2l0ZWRMaW5rU3RvcmUoKQpAQCAtNTMsMTAg KzUzLDkgQEAgVmlzaXRlZExpbmtTdG9yZTo6VmlzaXRlZExpbmtTdG9yZSgpCiAKIHZvaWQgVmlz aXRlZExpbmtTdG9yZTo6YWRkUHJvY2VzcyhXZWJQcm9jZXNzUHJveHkmIHByb2Nlc3MpCiB7Ci0g ICAgQVNTRVJUKHByb2Nlc3Muc3RhdGUoKSA9PSBXZWJQcm9jZXNzUHJveHk6OlN0YXRlOjpSdW5u aW5nKTsKLSAgICBBU1NFUlQoIW1fcHJvY2Vzc2VzLmNvbnRhaW5zKCZwcm9jZXNzKSk7CisgICAg QVNTRVJUKCFtX3Byb2Nlc3Nlcy5jb250YWlucyhwcm9jZXNzKSk7CiAKLSAgICBpZiAoIW1fcHJv Y2Vzc2VzLmFkZCgmcHJvY2VzcykuaXNOZXdFbnRyeSkKKyAgICBpZiAoIW1fcHJvY2Vzc2VzLmFk ZChwcm9jZXNzKS5pc05ld0VudHJ5KQogICAgICAgICByZXR1cm47CiAKICAgICBwcm9jZXNzLmFk ZE1lc3NhZ2VSZWNlaXZlcihNZXNzYWdlczo6VmlzaXRlZExpbmtTdG9yZTo6bWVzc2FnZVJlY2Vp dmVyTmFtZSgpLCBpZGVudGlmaWVyKCksICp0aGlzKTsKQEAgLTY5LDcgKzY4LDggQEAgdm9pZCBW aXNpdGVkTGlua1N0b3JlOjphZGRQcm9jZXNzKFdlYlByb2Nlc3NQcm94eSYgcHJvY2VzcykKIAog dm9pZCBWaXNpdGVkTGlua1N0b3JlOjpyZW1vdmVQcm9jZXNzKFdlYlByb2Nlc3NQcm94eSYgcHJv Y2VzcykKIHsKLSAgICBpZiAoIW1fcHJvY2Vzc2VzLnJlbW92ZSgmcHJvY2VzcykpCisgICAgQVNT RVJUKG1fcHJvY2Vzc2VzLmNvbnRhaW5zKHByb2Nlc3MpKTsKKyAgICBpZiAoIW1fcHJvY2Vzc2Vz LnJlbW92ZShwcm9jZXNzKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgcHJvY2Vzcy5yZW1vdmVN ZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OlZpc2l0ZWRMaW5rU3RvcmU6Om1lc3NhZ2VSZWNlaXZl ck5hbWUoKSwgaWRlbnRpZmllcigpKTsKQEAgLTk0LDkgKzk0LDkgQEAgdm9pZCBWaXNpdGVkTGlu a1N0b3JlOjpyZW1vdmVBbGwoKQogewogICAgIG1fbGlua0hhc2hTdG9yZS5jbGVhcigpOwogCi0g ICAgZm9yIChXZWJQcm9jZXNzUHJveHkqIHByb2Nlc3MgOiBtX3Byb2Nlc3NlcykgewotICAgICAg ICBBU1NFUlQocHJvY2Vzcy0+cHJvY2Vzc1Bvb2woKS5wcm9jZXNzZXMoKS5jb250YWlucyhwcm9j ZXNzKSk7Ci0gICAgICAgIHByb2Nlc3MtPnNlbmQoTWVzc2FnZXM6OlZpc2l0ZWRMaW5rVGFibGVD b250cm9sbGVyOjpSZW1vdmVBbGxWaXNpdGVkTGlua3MoKSwgaWRlbnRpZmllcigpKTsKKyAgICBm b3IgKGF1dG8mIHByb2Nlc3MgOiBtX3Byb2Nlc3NlcykgeworICAgICAgICBBU1NFUlQocHJvY2Vz cy5wcm9jZXNzUG9vbCgpLnByb2Nlc3NlcygpLmNvbnRhaW5zKCZwcm9jZXNzKSk7CisgICAgICAg IHByb2Nlc3Muc2VuZChNZXNzYWdlczo6VmlzaXRlZExpbmtUYWJsZUNvbnRyb2xsZXI6OlJlbW92 ZUFsbFZpc2l0ZWRMaW5rcygpLCBpZGVudGlmaWVyKCkpOwogICAgIH0KIH0KIApAQCAtMTIzLDIx ICsxMjMsMjEgQEAgdm9pZCBWaXNpdGVkTGlua1N0b3JlOjpzZW5kU3RvcmVIYW5kbGVUb1Byb2Nl c3MoV2ViUHJvY2Vzc1Byb3h5JiBwcm9jZXNzKQogCiB2b2lkIFZpc2l0ZWRMaW5rU3RvcmU6OmRp ZEludmFsaWRhdGVTaGFyZWRNZW1vcnkoKQogewotICAgIGZvciAoV2ViUHJvY2Vzc1Byb3h5KiBw cm9jZXNzIDogbV9wcm9jZXNzZXMpCi0gICAgICAgIHNlbmRTdG9yZUhhbmRsZVRvUHJvY2Vzcygq cHJvY2Vzcyk7CisgICAgZm9yIChhdXRvJiBwcm9jZXNzIDogbV9wcm9jZXNzZXMpCisgICAgICAg IHNlbmRTdG9yZUhhbmRsZVRvUHJvY2Vzcyhwcm9jZXNzKTsKIH0KIAogdm9pZCBWaXNpdGVkTGlu a1N0b3JlOjpkaWRVcGRhdGVTaGFyZWRTdHJpbmdIYXNoZXMoY29uc3QgVmVjdG9yPFdlYkNvcmU6 OlNoYXJlZFN0cmluZ0hhc2g+JiBhZGRlZEhhc2hlcywgY29uc3QgVmVjdG9yPFdlYkNvcmU6OlNo YXJlZFN0cmluZ0hhc2g+JiByZW1vdmVkSGFzaGVzKQogewogICAgIEFTU0VSVCghYWRkZWRIYXNo ZXMuaXNFbXB0eSgpIHx8ICFyZW1vdmVkSGFzaGVzLmlzRW1wdHkoKSk7CiAKLSAgICBmb3IgKGF1 dG8qIHByb2Nlc3MgOiBtX3Byb2Nlc3NlcykgewotICAgICAgICBBU1NFUlQocHJvY2Vzcy0+cHJv Y2Vzc1Bvb2woKS5wcm9jZXNzZXMoKS5jb250YWlucyhwcm9jZXNzKSk7CisgICAgZm9yIChhdXRv JiBwcm9jZXNzIDogbV9wcm9jZXNzZXMpIHsKKyAgICAgICAgQVNTRVJUKHByb2Nlc3MucHJvY2Vz c1Bvb2woKS5wcm9jZXNzZXMoKS5jb250YWlucygmcHJvY2VzcykpOwogCiAgICAgICAgIGlmIChh ZGRlZEhhc2hlcy5zaXplKCkgPiAyMCB8fCAhcmVtb3ZlZEhhc2hlcy5pc0VtcHR5KCkpCi0gICAg ICAgICAgICBwcm9jZXNzLT5zZW5kKE1lc3NhZ2VzOjpWaXNpdGVkTGlua1RhYmxlQ29udHJvbGxl cjo6QWxsVmlzaXRlZExpbmtTdGF0ZUNoYW5nZWQoKSwgaWRlbnRpZmllcigpKTsKKyAgICAgICAg ICAgIHByb2Nlc3Muc2VuZChNZXNzYWdlczo6VmlzaXRlZExpbmtUYWJsZUNvbnRyb2xsZXI6OkFs bFZpc2l0ZWRMaW5rU3RhdGVDaGFuZ2VkKCksIGlkZW50aWZpZXIoKSk7CiAgICAgICAgIGVsc2UK LSAgICAgICAgICAgIHByb2Nlc3MtPnNlbmQoTWVzc2FnZXM6OlZpc2l0ZWRMaW5rVGFibGVDb250 cm9sbGVyOjpWaXNpdGVkTGlua1N0YXRlQ2hhbmdlZChhZGRlZEhhc2hlcyksIGlkZW50aWZpZXIo KSk7CisgICAgICAgICAgICBwcm9jZXNzLnNlbmQoTWVzc2FnZXM6OlZpc2l0ZWRMaW5rVGFibGVD b250cm9sbGVyOjpWaXNpdGVkTGlua1N0YXRlQ2hhbmdlZChhZGRlZEhhc2hlcyksIGlkZW50aWZp ZXIoKSk7CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9W aXNpdGVkTGlua1N0b3JlLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9WaXNpdGVkTGlua1N0 b3JlLmgKaW5kZXggYzVjMzA4MWFhZmEzMTRjZWVkNTljNDM3YzA1NGQwMmM3MDJiZDc3MS4uNzgx M2RlMmE2MjQ3MjI5ZDE2NTJhN2RmOWVhOGRhMWE2MjUyNmM2OCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvVmlzaXRlZExpbmtTdG9yZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1Zpc2l0ZWRMaW5rU3RvcmUuaApAQCAtMzAsOSArMzAsOSBAQAogI2luY2x1ZGUg IlNoYXJlZFN0cmluZ0hhc2hTdG9yZS5oIgogI2luY2x1ZGUgIldlYlBhZ2VQcm94eUlkZW50aWZp ZXIuaCIKICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgotI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+ CiAjaW5jbHVkZSA8d3RmL0lkZW50aWZpZWQuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5o PgorI2luY2x1ZGUgPHd0Zi9XZWFrSGFzaFNldC5oPgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIApA QCAtNjUsNyArNjUsNyBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBzZW5kU3RvcmVIYW5kbGVUb1By b2Nlc3MoV2ViUHJvY2Vzc1Byb3h5Jik7CiAKLSAgICBIYXNoU2V0PFdlYlByb2Nlc3NQcm94eSo+ IG1fcHJvY2Vzc2VzOworICAgIFdlYWtIYXNoU2V0PFdlYlByb2Nlc3NQcm94eT4gbV9wcm9jZXNz ZXM7CiAgICAgU2hhcmVkU3RyaW5nSGFzaFN0b3JlIG1fbGlua0hhc2hTdG9yZTsKIH07CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCmluZGV4IDViMjEzMTNj ZWRmNTYwNjA5YWFhODYwNGI5YWQxNjYxM2I3OWI0NmYuLjM2NGFmYTdmOTk5OThhMjJkMjgwZTdj MzBhYzYwZDNhZjlkZGM5NmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl YlByb2Nlc3NQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vz c1Byb3h5LmNwcApAQCAtMzgxLDEwICszODEsNiBAQCB2b2lkIFdlYlByb2Nlc3NQcm94eTo6c2h1 dERvd24oKQogICAgICAgICBmcmFtZS0+d2ViUHJvY2Vzc1dpbGxTaHV0RG93bigpOwogICAgIG1f ZnJhbWVNYXAuY2xlYXIoKTsKIAotICAgIGZvciAoYXV0byogdmlzaXRlZExpbmtTdG9yZSA6IG1f dmlzaXRlZExpbmtTdG9yZXNXaXRoVXNlcnMua2V5cygpKQotICAgICAgICB2aXNpdGVkTGlua1N0 b3JlLT5yZW1vdmVQcm9jZXNzKCp0aGlzKTsKLSAgICBtX3Zpc2l0ZWRMaW5rU3RvcmVzV2l0aFVz ZXJzLmNsZWFyKCk7Ci0KICAgICBmb3IgKGF1dG8qIHdlYlVzZXJDb250ZW50Q29udHJvbGxlclBy b3h5IDogbV93ZWJVc2VyQ29udGVudENvbnRyb2xsZXJQcm94aWVzKQogICAgICAgICB3ZWJVc2Vy Q29udGVudENvbnRyb2xsZXJQcm94eS0+cmVtb3ZlUHJvY2VzcygqdGhpcyk7CiAgICAgbV93ZWJV c2VyQ29udGVudENvbnRyb2xsZXJQcm94aWVzLmNsZWFyKCk7CkBAIC00ODksNyArNDg1LDcgQEAg dm9pZCBXZWJQcm9jZXNzUHJveHk6OmFkZFZpc2l0ZWRMaW5rU3RvcmVVc2VyKFZpc2l0ZWRMaW5r U3RvcmUmIHZpc2l0ZWRMaW5rU3RvcmUKICAgICBBU1NFUlQoIXVzZXJzLmNvbnRhaW5zKHBhZ2VJ RCkpOwogICAgIHVzZXJzLmFkZChwYWdlSUQpOwogCi0gICAgaWYgKHVzZXJzLnNpemUoKSA9PSAx ICYmIHN0YXRlKCkgPT0gU3RhdGU6OlJ1bm5pbmcpCisgICAgaWYgKHVzZXJzLnNpemUoKSA9PSAx KQogICAgICAgICB2aXNpdGVkTGlua1N0b3JlLmFkZFByb2Nlc3MoKnRoaXMpOwogfQogCkBAIC04 NTgsOSArODU0LDYgQEAgdm9pZCBXZWJQcm9jZXNzUHJveHk6OmRpZEZpbmlzaExhdW5jaGluZyhQ cm9jZXNzTGF1bmNoZXIqIGxhdW5jaGVyLCBJUEM6OkNvbm5lY3QKICAgICBtX3Byb2Nlc3NQb29s LT5wcm9jZXNzRGlkRmluaXNoTGF1bmNoaW5nKHRoaXMpOwogICAgIG1fYmFja2dyb3VuZFJlc3Bv bnNpdmVuZXNzVGltZXIudXBkYXRlU3RhdGUoKTsKIAotICAgIGZvciAoYXV0byogdmlzaXRlZExp bmtTdG9yZSA6IG1fdmlzaXRlZExpbmtTdG9yZXNXaXRoVXNlcnMua2V5cygpKQotICAgICAgICB2 aXNpdGVkTGlua1N0b3JlLT5hZGRQcm9jZXNzKCp0aGlzKTsKLQogI2lmIFBMQVRGT1JNKElPU19G QU1JTFkpCiAgICAgaWYgKGNvbm5lY3Rpb24oKSkgewogICAgICAgICBpZiAoeHBjX2Nvbm5lY3Rp b25fdCB4cGNDb25uZWN0aW9uID0gY29ubmVjdGlvbigpLT54cGNDb25uZWN0aW9uKCkpCg==