204466 2019-11-21 12:31:25 -0800 [LFC][IFC] Cache trailing trimmable width. 2019-11-21 13:42:51 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1592495 0 zalan 2019-11-21 12:31:25 -0800 We shouldn't really need to loop through the trailing trimmable runs. 1592496 1 webkit-bug-importer 2019-11-21 12:31:35 -0800 <rdar://problem/57403888> 1592498 2 384082 zalan 2019-11-21 12:40:15 -0800 Created attachment 384082 Patch 1592502 3 384082 koivisto 2019-11-21 12:46:01 -0800 Comment on attachment 384082 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384082&action=review > Source/WebCore/layout/inlineformatting/InlineLine.h:160 > + using TrimmableList = Vector<InlineItemRun*, 5>; Do we need this many? 1592527 4 384082 commit-queue 2019-11-21 13:42:49 -0800 Comment on attachment 384082 Patch Clearing flags on attachment: 384082 Committed r252750: <https://trac.webkit.org/changeset/252750> 1592528 5 commit-queue 2019-11-21 13:42:51 -0800 All reviewed patches have been landed. Closing bug. 384082 2019-11-21 12:40:15 -0800 2019-11-21 13:42:49 -0800 Patch bug-204466-20191121124015.patch text/plain 6745 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzQ4OTA0NDNjMTJhY2I1 MWQ2NTBlYjY1MWFmYzNlMjFjYzRlZDUwOS4uNzhjODhlYWQ5N2E5MjRkY2MyMzYxNjY5MTI5NDM0 NGUzMzBlYjY4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE5LTExLTIxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBDYWNoZSB0 cmFpbGluZyB0cmltbWFibGUgd2lkdGguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDQ0NjYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3NDAzODg4 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExpbmU6 OnRyYWlsaW5nVHJpbW1hYmxlV2lkdGgoKSBpcyBjYWxsZWQgZXZlcnkgdGltZSB3ZSBwYXNzIGEg cnVuIHRvIHRoZSBsaW5lIGJyZWFrZXIgYmVjYXVzZSB0aGVpciBhY2N1bXVsYXRlZCB3aWR0aHMg YXJlIHBhcnQgb2YgdGhlICJhdmFpbGFibGUgd2lkdGggY29udGV4dCIuCisKKyAgICAgICAgKiBs YXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkxheW91dDo6TGluZTo6cmVtb3ZlVHJhaWxpbmdUcmltbWFibGVDb250ZW50KToKKyAgICAgICAg KFdlYkNvcmU6OkxheW91dDo6TGluZTo6YXBwZW5kVGV4dENvbnRlbnQpOgorICAgICAgICAoV2Vi Q29yZTo6TGF5b3V0OjpMaW5lOjphcHBlbmROb25SZXBsYWNlZElubGluZUJveCk6CisgICAgICAg IChXZWJDb3JlOjpMYXlvdXQ6OkxpbmU6OlRyaW1tYWJsZUNvbnRlbnQ6OmFwcGVuZCk6CisgICAg ICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmU6OnRyYWlsaW5nVHJpbW1hYmxlV2lkdGggY29uc3Qp OiBEZWxldGVkLgorICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUu aDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGluZTo6dHJhaWxpbmdUcmltbWFibGVXaWR0 aCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmU6OlRyaW1tYWJsZUNvbnRl bnQ6OndpZHRoIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGluZTo6VHJpbW1h YmxlQ29udGVudDo6cnVucyk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmU6OlRyaW1t YWJsZUNvbnRlbnQ6OmlzRW1wdHkgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpM aW5lOjpUcmltbWFibGVDb250ZW50OjpjbGVhcik6CisKIDIwMTktMTEtMjEgIFlvdWVubiBGYWJs ZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlZ3Jlc3Npb24gKHIyNTI2NjApOiBM YXlvdXQgVGVzdCBwbGF0Zm9ybS9pb3MvbWVkaWFzdHJlYW0vYXVkaW8tbXV0ZWQtaW4tYmFja2dy b3VuZC10YWIuaHRtbCBpcyBmYWlsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuY3BwCmluZGV4IDU3MDUzMzVkMjRmYjU0OTVl NDhmYjNiMTAzZGM2NTkwMmRhMWFkYTMuLjA4MWRiNDY1M2RiNDhlNWJmNmQ2M2JiOTRkYTM5YTFl ZDVmNWYxNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0 aW5nL0lubGluZUxpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3Jt YXR0aW5nL0lubGluZUxpbmUuY3BwCkBAIC00MjYsMTYgKzQyNiwxNyBAQCB2b2lkIExpbmU6OmFs aWduQ29udGVudEhvcml6b250YWxseShSdW5MaXN0JiBydW5MaXN0LCBJc0xhc3RMaW5lV2l0aElu bGluZUNvbnRlbgogCiB2b2lkIExpbmU6OnJlbW92ZVRyYWlsaW5nVHJpbW1hYmxlQ29udGVudCgp CiB7CisgICAgaWYgKG1fdHJpbW1hYmxlQ29udGVudC5pc0VtcHR5KCkgfHwgbV9pbmxpbmVJdGVt UnVucy5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybjsKKwogICAgIC8vIENvbGxhcHNlIHRyaW1t YWJsZSB0cmFpbGluZyBjb250ZW50Ci0gICAgTGF5b3V0VW5pdCB0cmltbWFibGVXaWR0aDsKLSAg ICBmb3IgKGF1dG8qIHRyaW1tYWJsZVJ1biA6IG1fdHJpbW1hYmxlUnVucykgeworICAgIGZvciAo YXV0byogdHJpbW1hYmxlUnVuIDogbV90cmltbWFibGVDb250ZW50LnJ1bnMoKSkgewogICAgICAg ICBBU1NFUlQodHJpbW1hYmxlUnVuLT5pc1RleHQoKSk7CiAgICAgICAgIC8vIEZJWE1FOiBXZSBt aWdodCBuZWVkIHRvIGJlIGFibGUgdG8gZGlmZmVyZW50aWF0ZSBiZXR3ZWVuIHRyaW1tZWQgYW5k IGNvbGxhcHNlZCBydW5zLgotICAgICAgICB0cmltbWFibGVXaWR0aCArPSB0cmltbWFibGVSdW4t PmxvZ2ljYWxSZWN0KCkud2lkdGgoKTsKICAgICAgICAgdHJpbW1hYmxlUnVuLT5zZXRDb2xsYXBz ZXNUb1plcm9BZHZhbmNlV2lkdGgoKTsKICAgICB9Ci0gICAgbV9saW5lQm94LnNocmlua0hvcml6 b250YWxseSh0cmltbWFibGVXaWR0aCk7Ci0gICAgbV90cmltbWFibGVSdW5zLmNsZWFyKCk7Cisg ICAgbV9saW5lQm94LnNocmlua0hvcml6b250YWxseShtX3RyaW1tYWJsZUNvbnRlbnQud2lkdGgo KSk7CisgICAgbV90cmltbWFibGVDb250ZW50LmNsZWFyKCk7CiB9CiAKIHZvaWQgTGluZTo6bW92 ZUxvZ2ljYWxMZWZ0KExheW91dFVuaXQgZGVsdGEpCkBAIC00NTMsMTQgKzQ1NCw2IEBAIHZvaWQg TGluZTo6bW92ZUxvZ2ljYWxSaWdodChMYXlvdXRVbml0IGRlbHRhKQogICAgIG1fbGluZUxvZ2lj YWxXaWR0aCAtPSBkZWx0YTsKIH0KIAotTGF5b3V0VW5pdCBMaW5lOjp0cmFpbGluZ1RyaW1tYWJs ZVdpZHRoKCkgY29uc3QKLXsKLSAgICBMYXlvdXRVbml0IHRyaW1tYWJsZVdpZHRoOwotICAgIGZv ciAoYXV0byogdHJpbW1hYmxlUnVuIDogbV90cmltbWFibGVSdW5zKQotICAgICAgICB0cmltbWFi bGVXaWR0aCArPSB0cmltbWFibGVSdW4tPmxvZ2ljYWxSZWN0KCkud2lkdGgoKTsKLSAgICByZXR1 cm4gdHJpbW1hYmxlV2lkdGg7Ci19Ci0KIHZvaWQgTGluZTo6YXBwZW5kKGNvbnN0IElubGluZUl0 ZW0mIGlubGluZUl0ZW0sIExheW91dFVuaXQgbG9naWNhbFdpZHRoKQogewogICAgIGlmIChpbmxp bmVJdGVtLmlzRm9yY2VkTGluZUJyZWFrKCkpCkBAIC01MDcsNyArNTAwLDcgQEAgdm9pZCBMaW5l OjphcHBlbmRUZXh0Q29udGVudChjb25zdCBJbmxpbmVUZXh0SXRlbSYgaW5saW5lSXRlbSwgTGF5 b3V0VW5pdCBsb2dpY2EKIHsKICAgICBhdXRvIGlzVHJpbW1hYmxlID0gIXNob3VsZFByZXNlcnZl VHJhaWxpbmdDb250ZW50KGlubGluZUl0ZW0pOwogICAgIGlmICghaXNUcmltbWFibGUpCi0gICAg ICAgIG1fdHJpbW1hYmxlUnVucy5jbGVhcigpOworICAgICAgICBtX3RyaW1tYWJsZUNvbnRlbnQu Y2xlYXIoKTsKIAogICAgIGF1dG8gd2lsbENvbGxhcHNlQ29tcGxldGVseSA9IFsmXSB7CiAgICAg ICAgIC8vIEVtcHR5IHJ1bi4KQEAgLTU2MCw3ICs1NTMsNyBAQCB2b2lkIExpbmU6OmFwcGVuZFRl eHRDb250ZW50KGNvbnN0IElubGluZVRleHRJdGVtJiBpbmxpbmVJdGVtLCBMYXlvdXRVbml0IGxv Z2ljYQogICAgIGlmIChjb2xsYXBzZWRSdW4pCiAgICAgICAgIGxpbmVSdW4tPnNldElzQ29sbGFw c2VkKCk7CiAgICAgaWYgKGlzVHJpbW1hYmxlKQotICAgICAgICBtX3RyaW1tYWJsZVJ1bnMuYXBw ZW5kKGxpbmVSdW4uZ2V0KCkpOworICAgICAgICBtX3RyaW1tYWJsZUNvbnRlbnQuYXBwZW5kKCps aW5lUnVuKTsKIAogICAgIG1fbGluZUJveC5leHBhbmRIb3Jpem9udGFsbHkobGluZVJ1bi0+bG9n aWNhbFJlY3QoKS53aWR0aCgpKTsKICAgICBtX2lubGluZUl0ZW1SdW5zLmFwcGVuZChXVEZNb3Zl KGxpbmVSdW4pKTsKQEAgLTU4Myw3ICs1NzYsNyBAQCB2b2lkIExpbmU6OmFwcGVuZE5vblJlcGxh Y2VkSW5saW5lQm94KGNvbnN0IElubGluZUl0ZW0mIGlubGluZUl0ZW0sIExheW91dFVuaXQgbAog ICAgIG1faW5saW5lSXRlbVJ1bnMuYXBwZW5kKG1ha2VVbmlxdWU8SW5saW5lSXRlbVJ1bj4oaW5s aW5lSXRlbSwgbG9naWNhbFJlY3QpKTsKICAgICBtX2xpbmVCb3guZXhwYW5kSG9yaXpvbnRhbGx5 KGxvZ2ljYWxXaWR0aCArIGhvcml6b250YWxNYXJnaW4uc3RhcnQgKyBob3Jpem9udGFsTWFyZ2lu LmVuZCk7CiAgICAgbV9saW5lQm94LnNldElzQ29uc2lkZXJlZE5vbkVtcHR5KCk7Ci0gICAgbV90 cmltbWFibGVSdW5zLmNsZWFyKCk7CisgICAgbV90cmltbWFibGVDb250ZW50LmNsZWFyKCk7CiB9 CiAKIHZvaWQgTGluZTo6YXBwZW5kUmVwbGFjZWRJbmxpbmVCb3goY29uc3QgSW5saW5lSXRlbSYg aW5saW5lSXRlbSwgTGF5b3V0VW5pdCBsb2dpY2FsV2lkdGgpCkBAIC03MTIsNiArNzA1LDEzIEBA IExheW91dFVuaXQgTGluZTo6aW5saW5lSXRlbUNvbnRlbnRIZWlnaHQoY29uc3QgSW5saW5lSXRl bSYgaW5saW5lSXRlbSkgY29uc3QKICAgICByZXR1cm4gYm94R2VvbWV0cnkubWFyZ2luQm94SGVp Z2h0KCk7CiB9CiAKK3ZvaWQgTGluZTo6VHJpbW1hYmxlQ29udGVudDo6YXBwZW5kKElubGluZUl0 ZW1SdW4mIGlubGluZUl0ZW1SdW4pCit7CisgICAgQVNTRVJUKGlubGluZUl0ZW1SdW4ubG9naWNh bFJlY3QoKS53aWR0aCgpID49IDApOworICAgIG1fd2lkdGggKz0gaW5saW5lSXRlbVJ1bi5sb2dp Y2FsUmVjdCgpLndpZHRoKCk7CisgICAgbV9pbmxpbmVJdGVtUnVucy5hcHBlbmQoJmlubGluZUl0 ZW1SdW4pOworfQorCiBMaW5lQm94OjpCYXNlbGluZSBMaW5lOjpoYWxmTGVhZGluZ01ldHJpY3Mo Y29uc3QgRm9udE1ldHJpY3MmIGZvbnRNZXRyaWNzLCBMYXlvdXRVbml0IGxpbmVMb2dpY2FsSGVp Z2h0KQogewogICAgIGF1dG8gYXNjZW50ID0gZm9udE1ldHJpY3MuYXNjZW50KCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmgg Yi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmgKaW5k ZXggY2YwMjY1YWMzYTY3ZDdjNDE2ZTBjOWY1MmI2MjQxZDA0Zjk4NzE5Yy4uN2M5OTBlYTgwOGU2 YmFjNjRlMDE4NDVmNTM5OTJlOGFjNGYxYjZhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuaApAQCAtNjEsNyArNjEsNyBAQCBw dWJsaWM6CiAgICAgYm9vbCBoYXNDb250ZW50KCkgY29uc3QgeyByZXR1cm4gIWlzVmlzdWFsbHlF bXB0eSgpOyB9CiAgICAgTGF5b3V0VW5pdCBhdmFpbGFibGVXaWR0aCgpIGNvbnN0IHsgcmV0dXJu IGxvZ2ljYWxXaWR0aCgpIC0gY29udGVudExvZ2ljYWxXaWR0aCgpOyB9CiAKLSAgICBMYXlvdXRV bml0IHRyYWlsaW5nVHJpbW1hYmxlV2lkdGgoKSBjb25zdDsKKyAgICBMYXlvdXRVbml0IHRyYWls aW5nVHJpbW1hYmxlV2lkdGgoKSBjb25zdCB7IHJldHVybiBtX3RyaW1tYWJsZUNvbnRlbnQud2lk dGgoKTsgfQogCiAgICAgY29uc3QgTGluZUJveCYgbGluZUJveCgpIGNvbnN0IHsgcmV0dXJuIG1f bGluZUJveDsgfQogICAgIHZvaWQgbW92ZUxvZ2ljYWxMZWZ0KExheW91dFVuaXQpOwpAQCAtMTUy LDcgKzE1MiwyMCBAQCBwcml2YXRlOgogCiAgICAgY29uc3QgSW5saW5lRm9ybWF0dGluZ0NvbnRl eHQmIG1faW5saW5lRm9ybWF0dGluZ0NvbnRleHQ7CiAgICAgVmVjdG9yPHN0ZDo6dW5pcXVlX3B0 cjxJbmxpbmVJdGVtUnVuPiwgNTA+IG1faW5saW5lSXRlbVJ1bnM7Ci0gICAgVmVjdG9yPElubGlu ZUl0ZW1SdW4qLCA1PiBtX3RyaW1tYWJsZVJ1bnM7CisgICAgc3RydWN0IFRyaW1tYWJsZUNvbnRl bnQgeworICAgICAgICB2b2lkIGFwcGVuZChJbmxpbmVJdGVtUnVuJik7CisgICAgICAgIHZvaWQg Y2xlYXIoKTsKKworICAgICAgICBMYXlvdXRVbml0IHdpZHRoKCkgY29uc3QgeyByZXR1cm4gbV93 aWR0aDsgfQorICAgICAgICB1c2luZyBUcmltbWFibGVMaXN0ID0gVmVjdG9yPElubGluZUl0ZW1S dW4qLCA1PjsKKyAgICAgICAgVHJpbW1hYmxlTGlzdCYgcnVucygpIHsgcmV0dXJuIG1faW5saW5l SXRlbVJ1bnM7IH0KKyAgICAgICAgYm9vbCBpc0VtcHR5KCkgY29uc3QgeyByZXR1cm4gbV9pbmxp bmVJdGVtUnVucy5pc0VtcHR5KCk7IH0KKworICAgIHByaXZhdGU6CisgICAgICAgIFRyaW1tYWJs ZUxpc3QgbV9pbmxpbmVJdGVtUnVuczsKKyAgICAgICAgTGF5b3V0VW5pdCBtX3dpZHRoOworICAg IH07CisgICAgVHJpbW1hYmxlQ29udGVudCBtX3RyaW1tYWJsZUNvbnRlbnQ7CiAgICAgT3B0aW9u YWw8TGluZUJveDo6QmFzZWxpbmU+IG1faW5pdGlhbFN0cnV0OwogICAgIExheW91dFVuaXQgbV9s aW5lTG9naWNhbFdpZHRoOwogICAgIE9wdGlvbmFsPFRleHRBbGlnbk1vZGU+IG1faG9yaXpvbnRh bEFsaWdubWVudDsKQEAgLTE2MCw2ICsxNzMsMTIgQEAgcHJpdmF0ZToKICAgICBMaW5lQm94IG1f bGluZUJveDsKIH07CiAKK2lubGluZSB2b2lkIExpbmU6OlRyaW1tYWJsZUNvbnRlbnQ6OmNsZWFy KCkKK3sKKyAgICBtX2lubGluZUl0ZW1SdW5zLmNsZWFyKCk7CisgICAgbV93aWR0aCA9IHsgfTsK K30KKwogfQogfQogI2VuZGlmCg==