204464 2019-11-21 12:03:38 -0800 Remove unneeded code that annotated DOMHTMLElement as conforming to UITextInputTraits protocol 2019-11-21 12:28:21 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build iPhone / iPad iOS 13 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=177917 https://bugs.webkit.org/show_bug.cgi?id=174394 InRadar P2 Normal --- 1 dbates dbates webkit-bug-importer wenson_hsieh oldest_to_newest 1592474 0 dbates 2019-11-21 12:03:38 -0800 Following the fix for bug #177917, DOMHTMLElement no longer needs to be annotated as conforming to UITextInputTraits protocol. It never really did implement that protocol. When it was annotated as implementing the UITextInputTraits protocol it was only to register with the runtime so that callers could send -acceptsAutofilledLoginCredentials and -representingPageURL messages to it. And those functions were removed in the patch for bug bug #177917. 1592475 1 dbates 2019-11-21 12:04:28 -0800 FYI, patch for bug #174394 first annotated DOMHTMLElement as implementing the UITextInputTraits protocol 1592482 2 384080 dbates 2019-11-21 12:13:14 -0800 Created attachment 384080 Patch 1592492 3 384080 dbates 2019-11-21 12:27:52 -0800 Comment on attachment 384080 Patch Clearing flags on attachment: 384080 Committed r252746: <https://trac.webkit.org/changeset/252746> 1592493 4 dbates 2019-11-21 12:27:54 -0800 All reviewed patches have been landed. Closing bug. 1592494 5 webkit-bug-importer 2019-11-21 12:28:21 -0800 <rdar://problem/57403788> 384080 2019-11-21 12:13:14 -0800 2019-11-21 12:27:52 -0800 Patch bug-204464-20191121121313.patch text/plain 2052 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggNTRkOGE2YTBlMjI3NWE2ZTY0Nzc4YTViZTRlYjdkNmI4ZGVkNzU0NC4uMWNkNzE3ODFiZjc2 MzY0NGI5M2Q5NDFjZWE0NTZhMGY4MTg5Mjc2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTExLTIxICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFw cGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW5uZWVkZWQgY29kZSB0aGF0IGFubm90YXRlZCBE T01IVE1MRWxlbWVudCBhcyBjb25mb3JtaW5nIHRvIFVJVGV4dElucHV0VHJhaXRzIHByb3RvY29s CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ0NjQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBET01IVE1M RWxlbWVudCBuZXZlciByZWFsbHkgY29uZm9ybWVkIHRvIHRoZSBVSVRleHRJbnB1dFRyYWl0cyBw cm90b2NvbC4gSXQgd2FzIGFubm90YXRlZCBhcyBkb2luZyBzbworICAgICAgICBpbiBvcmRlciB0 byByZWdpc3RlciB3aXRoIHRoZSBydW50aW1lIGFzIHBhcnQgb2YgYWR2ZXJ0aXNpbmcgdGhhdCBp dCBpbXBsZW1lbnRlZCB0d28gVUlUZXh0SW5wdXRUcmFpdHNfUHJpdmF0ZQorICAgICAgICBtZXNz YWdlcyBpbiByMjIyNDg3OiAtYWNjZXB0c0F1dG9maWxsZWRMb2dpbkNyZWRlbnRpYWxzIGFuZCAt cmVwcmVzZW50aW5nUGFnZVVSTC4gVGhlc2UgbWVzc2FnZXMgd2VyZQorICAgICAgICBzdWJzZXF1 ZW50bHkgcmVtb3ZlZCBpbiByMjIyOTkxIChvdmVyIHllYXJzIGFnbykuIFNvLCB3ZSBkbyBub3Qg bmVlZCB0byBjb250aW51ZSBhZHZlcnRpc2luZyBVSVRleHRJbnB1dFRyYWl0cworICAgICAgICBj b25mb3JtYW5jZS4KKworICAgICAgICAqIERPTS9ET01IVE1MSW5wdXRFbGVtZW50Lmg6CisKIDIw MTktMDktMTMgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFN1 cHBvcnQgYnVpbGRpbmcgV2ViS2l0IGZvciBNYWMgQ2F0YWx5c3QgZnJvbSBYY29kZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvRE9NL0RPTUhUTUxJbnB1dEVsZW1lbnQuaCBi L1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0RPTS9ET01IVE1MSW5wdXRFbGVtZW50LmgKaW5kZXgg MjZlY2UzYTYzZjk4OTlhZDMwMjJkZDk2ZjhiNzdkYmE2YzAwNmVmYy4uYmUyODM2M2JiMzk5ZThh MWJiMzhlZjcxZmI4NGMzMmE4NjQwNzUzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2Fj eS9tYWMvRE9NL0RPTUhUTUxJbnB1dEVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5 L21hYy9ET00vRE9NSFRNTElucHV0RWxlbWVudC5oCkBAIC0yNCw5ICsyNCw2IEBACiAgKi8KIAog I2ltcG9ydCA8V2ViS2l0TGVnYWN5L0RPTUhUTUxFbGVtZW50Lmg+Ci0jaWYgVEFSR0VUX09TX0lQ SE9ORQotI2ltcG9ydCA8VUlLaXQvVUlUZXh0SW5wdXRUcmFpdHMuaD4KLSNlbmRpZgogCiBAY2xh c3MgRE9NRmlsZUxpc3Q7CiBAY2xhc3MgRE9NSFRNTEZvcm1FbGVtZW50OwpAQCAtMzQsMTEgKzMx LDcgQEAKIEBjbGFzcyBOU1VSTDsKIAogV0VCS0lUX0NMQVNTX0RFUFJFQ0FURURfTUFDKDEwXzQs IDEwXzE0KQotI2lmIFRBUkdFVF9PU19JUEhPTkUKLUBpbnRlcmZhY2UgRE9NSFRNTElucHV0RWxl bWVudCA6IERPTUhUTUxFbGVtZW50PFVJVGV4dElucHV0VHJhaXRzPgotI2Vsc2UKIEBpbnRlcmZh Y2UgRE9NSFRNTElucHV0RWxlbWVudCA6IERPTUhUTUxFbGVtZW50Ci0jZW5kaWYKIEBwcm9wZXJ0 eSAoY29weSkgTlNTdHJpbmcgKmFjY2VwdDsKIEBwcm9wZXJ0eSAoY29weSkgTlNTdHJpbmcgKmFs dDsKIEBwcm9wZXJ0eSBCT09MIGF1dG9mb2N1cyBXRUJLSVRfQVZBSUxBQkxFX01BQygxMF82KTsK