204445 2019-11-21 00:22:34 -0800 add ASSERT_NOT_REACHED_WITH_MESSAGE and RELEASE_ASSERT_NOT_REACHED_WITH_MESSAGE 2019-11-21 05:00:26 -0800 1 1 1 Unclassified WebKit Web Template Framework Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tuomas.webkit webkit-unassigned benjamin cdumez cmarcelo commit-queue dbates ews-watchlist koivisto webkit-bug-importer oldest_to_newest 1592310 0 tuomas.webkit 2019-11-21 00:22:34 -0800 Add ASSERT_NOT_REACHED_WITH_MESSAGE and RELEASE_ASSERT_NOT_REACHED_WITH_MESSAGE to allow adding a message to code paths not expected to be reached, or to avoid the need to use a dummy assertion of 0 or false for the same effect. 1592311 1 384033 tuomas.webkit 2019-11-21 00:27:50 -0800 Created attachment 384033 proposed patch 1592334 2 384043 tuomas.webkit 2019-11-21 03:56:09 -0800 Created attachment 384043 proposed patch address issues brought up in review. 1592335 3 384043 koivisto 2019-11-21 04:01:31 -0800 Comment on attachment 384043 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=384043&action=review > Source/WTF/wtf/Assertions.h:315 > +#define ASSERT_NOT_REACHED_WITH_MESSAGE(...) ((void)0) This too should be inside #ifdef __cplusplus for consistency. 1592338 4 384044 tuomas.webkit 2019-11-21 04:15:51 -0800 Created attachment 384044 proposed patch cleanup 1592343 5 384044 commit-queue 2019-11-21 04:59:18 -0800 Comment on attachment 384044 proposed patch Clearing flags on attachment: 384044 Committed r252731: <https://trac.webkit.org/changeset/252731> 1592344 6 commit-queue 2019-11-21 04:59:20 -0800 All reviewed patches have been landed. Closing bug. 1592345 7 webkit-bug-importer 2019-11-21 05:00:26 -0800 <rdar://problem/57391975> 384033 2019-11-21 00:27:50 -0800 2019-11-21 03:56:09 -0800 proposed patch webkit_204445.patch text/plain 2793 tuomas.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggYTk0YzM1OGFlYzAuLmE5ZDMxZTRmNWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5 LTExLTIxICBUdW9tYXMgS2Fya2thaW5lbiAgPHR1b21hcy53ZWJraXRAYXBwbGUuY29tPgorCisg ICAgICAgIGFkZCBBU1NFUlRfTk9UX1JFQUNIRURfV0lUSF9NRVNTQUdFIGFuZCBSRUxFQVNFX0FT U0VSVF9OT1RfUkVBQ0hFRF9XSVRIX01FU1NBR0UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDQ0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhc3NlcnRpb25zIHRoYXQgY29tYmluZSBBU1NFUlRf Tk9UX1JFQUNIRUQgYW5kIEFTU0VSVF9XSVRIX01FU1NBR0UuCisKKyAgICAgICAgKiB3dGYvQXNz ZXJ0aW9ucy5oOgorCiAyMDE5LTExLTIwICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bz b255LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBhZGRyZXNzIERhcmluJ3MgZmVlZGJhY2sg b24gcjI1MjY4My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaCBiL1Nv dXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAppbmRleCA0MmEzYjg3NzY2YS4uMzM3MGMyYmFiZWUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAorKysgYi9Tb3VyY2UvV1RG L3d0Zi9Bc3NlcnRpb25zLmgKQEAgLTQwMCw2ICs0MDAsMTggQEAgV1RGX0VYUE9SVF9QUklWQVRF IE5PX1JFVFVSTl9EVUVfVE9fQ1JBU0ggdm9pZCBXVEZDcmFzaFdpdGhTZWN1cml0eUltcGxpY2F0 aW9uKHYKIH0gd2hpbGUgKDApCiAjZW5kaWYKIAorLyogQVNTRVJUX05PVF9SRUFDSEVEX1dJVEhf TUVTU0FHRSAqLworCisjaWYgQVNTRVJUX01TR19ESVNBQkxFRAorI2RlZmluZSBBU1NFUlRfTk9U X1JFQUNIRURfV0lUSF9NRVNTQUdFKC4uLikgKCh2b2lkKTApCisjZWxzZQorI2RlZmluZSBBU1NF UlRfTk9UX1JFQUNIRURfV0lUSF9NRVNTQUdFKC4uLikgZG8geyBcCisgICAgICAgIFdURlJlcG9y dEFzc2VydGlvbkZhaWx1cmVXaXRoTWVzc2FnZShfX0ZJTEVfXywgX19MSU5FX18sIFdURl9QUkVU VFlfRlVOQ1RJT04sICJVTlJFQUNIQUJMRSIsIF9fVkFfQVJHU19fKTsgXAorICAgICAgICBDUkFT SCgpOyBcCit9IHdoaWxlICgwKQorI2VuZGlmCisKKwogLyogQVNTRVJUX1dJVEhfTUVTU0FHRV9V TlVTRUQgKi8KIAogI2lmIEFTU0VSVF9NU0dfRElTQUJMRUQKQEAgLTUyNCw2ICs1MzYsOCBAQCBX VEZfRVhQT1JUX1BSSVZBVEUgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIFdURkNyYXNoV2l0 aFNlY3VyaXR5SW1wbGljYXRpb24odgogI2VuZGlmCiAKIAorI2RlZmluZSBBU1NFUlRJT05fRkFJ TFVSRV9EVUVfVE9fVU5SRUFDSEFCTEVfQ09ERSAwCisKIC8qIFJFTEVBU0VfQVNTRVJUICovCiAK ICNpZiBBU1NFUlRfRElTQUJMRUQKQEAgLTUzNCw2ICs1NDgsNyBAQCBXVEZfRVhQT1JUX1BSSVZB VEUgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIFdURkNyYXNoV2l0aFNlY3VyaXR5SW1wbGlj YXRpb24odgogI2RlZmluZSBSRUxFQVNFX0FTU0VSVF9XSVRIX01FU1NBR0UoYXNzZXJ0aW9uLCAu Li4pIFJFTEVBU0VfQVNTRVJUKGFzc2VydGlvbikKICNkZWZpbmUgUkVMRUFTRV9BU1NFUlRfV0lU SF9TRUNVUklUWV9JTVBMSUNBVElPTihhc3NlcnRpb24pIFJFTEVBU0VfQVNTRVJUKGFzc2VydGlv bikKICNkZWZpbmUgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoLi4uKSBDUkFTSF9XSVRIX0lO Rk8oX19WQV9BUkdTX18pCisjZGVmaW5lIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEX1dJVEhf TUVTU0FHRSguLi4pIFJFTEVBU0VfQVNTRVJUX1dJVEhfTUVTU0FHRShBU1NFUlRJT05fRkFJTFVS RV9EVUVfVE9fVU5SRUFDSEFCTEVfQ09ERSwgX19WQV9BUkdTX18pCiAjZGVmaW5lIFJFTEVBU0Vf QVNTRVJUX1VOREVSX0NPTlNURVhQUl9DT05URVhUKGFzc2VydGlvbikgZG8geyBcCiAgICAgaWYg KFVOTElLRUxZKCEoYXNzZXJ0aW9uKSkpIHsgXAogICAgICAgICBDUkFTSF9VTkRFUl9DT05TVEVY UFJfQ09OVEVYVCgpOyBcCkBAIC01NDQsNiArNTU5LDcgQEAgV1RGX0VYUE9SVF9QUklWQVRFIE5P X1JFVFVSTl9EVUVfVE9fQ1JBU0ggdm9pZCBXVEZDcmFzaFdpdGhTZWN1cml0eUltcGxpY2F0aW9u KHYKICNkZWZpbmUgUkVMRUFTRV9BU1NFUlRfV0lUSF9NRVNTQUdFKGFzc2VydGlvbiwgLi4uKSBB U1NFUlRfV0lUSF9NRVNTQUdFKGFzc2VydGlvbiwgX19WQV9BUkdTX18pCiAjZGVmaW5lIFJFTEVB U0VfQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oYXNzZXJ0aW9uKSBBU1NFUlRfV0lU SF9TRUNVUklUWV9JTVBMSUNBVElPTihhc3NlcnRpb24pCiAjZGVmaW5lIFJFTEVBU0VfQVNTRVJU X05PVF9SRUFDSEVEKCkgQVNTRVJUX05PVF9SRUFDSEVEKCkKKyNkZWZpbmUgUkVMRUFTRV9BU1NF UlRfTk9UX1JFQUNIRURfV0lUSF9NRVNTQUdFKC4uLikgUkVMRUFTRV9BU1NFUlRfV0lUSF9NRVNT QUdFKEFTU0VSVElPTl9GQUlMVVJFX0RVRV9UT19VTlJFQUNIQUJMRV9DT0RFLCBfX1ZBX0FSR1Nf XykKICNkZWZpbmUgUkVMRUFTRV9BU1NFUlRfVU5ERVJfQ09OU1RFWFBSX0NPTlRFWFQoYXNzZXJ0 aW9uKSBBU1NFUlRfVU5ERVJfQ09OU1RFWFBSX0NPTlRFWFQoYXNzZXJ0aW9uKQogI2VuZGlmCiAK 384043 2019-11-21 03:56:09 -0800 2019-11-21 04:15:51 -0800 proposed patch webkit_204445_b.patch text/plain 2474 tuomas.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggYTk0YzM1OGFlYzAuLmE5ZDMxZTRmNWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5 LTExLTIxICBUdW9tYXMgS2Fya2thaW5lbiAgPHR1b21hcy53ZWJraXRAYXBwbGUuY29tPgorCisg ICAgICAgIGFkZCBBU1NFUlRfTk9UX1JFQUNIRURfV0lUSF9NRVNTQUdFIGFuZCBSRUxFQVNFX0FT U0VSVF9OT1RfUkVBQ0hFRF9XSVRIX01FU1NBR0UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDQ0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhc3NlcnRpb25zIHRoYXQgY29tYmluZSBBU1NFUlRf Tk9UX1JFQUNIRUQgYW5kIEFTU0VSVF9XSVRIX01FU1NBR0UuCisKKyAgICAgICAgKiB3dGYvQXNz ZXJ0aW9ucy5oOgorCiAyMDE5LTExLTIwICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bz b255LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBhZGRyZXNzIERhcmluJ3MgZmVlZGJhY2sg b24gcjI1MjY4My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaCBiL1Nv dXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAppbmRleCA0MmEzYjg3NzY2YS4uZDczNjM0MDA2N2Ig MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAorKysgYi9Tb3VyY2UvV1RG L3d0Zi9Bc3NlcnRpb25zLmgKQEAgLTMwMiwxMiArMzAyLDE3IEBAIFdURl9FWFBPUlRfUFJJVkFU RSBOT19SRVRVUk5fRFVFX1RPX0NSQVNIIHZvaWQgV1RGQ3Jhc2hXaXRoU2VjdXJpdHlJbXBsaWNh dGlvbih2CiAjdW5kZWYgQVNTRVJUCiAjZW5kaWYKIAorI2lmZGVmIF9fY3BsdXNwbHVzCitjb25z dGV4cHIgYm9vbCBhc3NlcnRpb25GYWlsdXJlRHVlVG9VbnJlYWNoYWJsZUNvZGUgPSBmYWxzZTsK KyNlbmRpZgorCiAjaWYgQVNTRVJUX0RJU0FCTEVECiAKICNkZWZpbmUgQVNTRVJUKGFzc2VydGlv biwgLi4uKSAoKHZvaWQpMCkKICNkZWZpbmUgQVNTRVJUX1VOREVSX0NPTlNURVhQUl9DT05URVhU KGFzc2VydGlvbikgKCh2b2lkKTApCiAjZGVmaW5lIEFTU0VSVF9BVChhc3NlcnRpb24sIGZpbGUs IGxpbmUsIGZ1bmN0aW9uKSAoKHZvaWQpMCkKICNkZWZpbmUgQVNTRVJUX05PVF9SRUFDSEVEKC4u LikgKCh2b2lkKTApCisjZGVmaW5lIEFTU0VSVF9OT1RfUkVBQ0hFRF9XSVRIX01FU1NBR0UoLi4u KSAoKHZvaWQpMCkKICNkZWZpbmUgQVNTRVJUX05PVF9JTVBMRU1FTlRFRF9ZRVQoKSAoKHZvaWQp MCkKICNkZWZpbmUgQVNTRVJUX0lNUExJRVMoY29uZGl0aW9uLCBhc3NlcnRpb24pICgodm9pZCkw KQogI2RlZmluZSBOT19SRVRVUk5fRFVFX1RPX0FTU0VSVApAQCAtMzU1LDYgKzM2MCwxMCBAQCBX VEZfRVhQT1JUX1BSSVZBVEUgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIFdURkNyYXNoV2l0 aFNlY3VyaXR5SW1wbGljYXRpb24odgogICAgIENSQVNIX1dJVEhfSU5GTyhfX1ZBX0FSR1NfXyk7 IFwKIH0gd2hpbGUgKDApCiAKKyNpZmRlZiBfX2NwbHVzcGx1cworI2RlZmluZSBBU1NFUlRfTk9U X1JFQUNIRURfV0lUSF9NRVNTQUdFKC4uLikgQVNTRVJUX1dJVEhfTUVTU0FHRShhc3NlcnRpb25G YWlsdXJlRHVlVG9VbnJlYWNoYWJsZUNvZGUsIF9fVkFfQVJHU19fKQorI2VuZGlmCisKICNkZWZp bmUgQVNTRVJUX05PVF9JTVBMRU1FTlRFRF9ZRVQoKSBkbyB7IFwKICAgICBXVEZSZXBvcnROb3RJ bXBsZW1lbnRlZFlldChfX0ZJTEVfXywgX19MSU5FX18sIFdURl9QUkVUVFlfRlVOQ1RJT04pOyBc CiAgICAgQ1JBU0goKTsgXApAQCAtNTQ4LDYgKzU1Nyw3IEBAIFdURl9FWFBPUlRfUFJJVkFURSBO T19SRVRVUk5fRFVFX1RPX0NSQVNIIHZvaWQgV1RGQ3Jhc2hXaXRoU2VjdXJpdHlJbXBsaWNhdGlv bih2CiAjZW5kaWYKIAogI2lmZGVmIF9fY3BsdXNwbHVzCisjZGVmaW5lIFJFTEVBU0VfQVNTRVJU X05PVF9SRUFDSEVEX1dJVEhfTUVTU0FHRSguLi4pIFJFTEVBU0VfQVNTRVJUX1dJVEhfTUVTU0FH RShhc3NlcnRpb25GYWlsdXJlRHVlVG9VbnJlYWNoYWJsZUNvZGUsIF9fVkFfQVJHU19fKQogCiAv LyBUaGUgY29tYmluYXRpb24gb2YgbGluZSwgZmlsZSwgZnVuY3Rpb24sIGFuZCBjb3VudGVyIHNo b3VsZCBiZSBhIHVuaXF1ZSBudW1iZXIgcGVyIGNhbGwgdG8gdGhpcyBjcmFzaC4gVGhpcyB0cmlj a3MgdGhlIGNvbXBpbGVyIGludG8gbm90IGNvYWxlc2NpbmcgY2FsbHMgdG8gV1RGQ3Jhc2hXaXRo SW5mby4KIC8vIFRoZSBlYXNpZXN0IHdheSB0byBmaWxsIHRoZXNlIHZhbHVlcyBwZXIgdHJhbnNs YXRpb24gdW5pdCBpcyB0byBwYXNzIF9fTElORV9fLCBfX0ZJTEVfXywgV1RGX1BSRVRUWV9GVU5D VElPTiwgYW5kIF9fQ09VTlRFUl9fLgo= 384044 2019-11-21 04:15:51 -0800 2019-11-21 04:59:18 -0800 proposed patch webkit_204445_d.patch text/plain 1787 tuomas.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggYTk0YzM1OGFlYzAuLmE5ZDMxZTRmNWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5 LTExLTIxICBUdW9tYXMgS2Fya2thaW5lbiAgPHR1b21hcy53ZWJraXRAYXBwbGUuY29tPgorCisg ICAgICAgIGFkZCBBU1NFUlRfTk9UX1JFQUNIRURfV0lUSF9NRVNTQUdFIGFuZCBSRUxFQVNFX0FT U0VSVF9OT1RfUkVBQ0hFRF9XSVRIX01FU1NBR0UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDQ0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhc3NlcnRpb25zIHRoYXQgY29tYmluZSBBU1NFUlRf Tk9UX1JFQUNIRUQgYW5kIEFTU0VSVF9XSVRIX01FU1NBR0UuCisKKyAgICAgICAgKiB3dGYvQXNz ZXJ0aW9ucy5oOgorCiAyMDE5LTExLTIwICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bz b255LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBhZGRyZXNzIERhcmluJ3MgZmVlZGJhY2sg b24gcjI1MjY4My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaCBiL1Nv dXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAppbmRleCA0MmEzYjg3NzY2YS4uN2E2Yjc1YmE2ZDEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAorKysgYi9Tb3VyY2UvV1RG L3d0Zi9Bc3NlcnRpb25zLmgKQEAgLTQwMCw2ICs0MDAsMTEgQEAgV1RGX0VYUE9SVF9QUklWQVRF IE5PX1JFVFVSTl9EVUVfVE9fQ1JBU0ggdm9pZCBXVEZDcmFzaFdpdGhTZWN1cml0eUltcGxpY2F0 aW9uKHYKIH0gd2hpbGUgKDApCiAjZW5kaWYKIAorI2lmZGVmIF9fY3BsdXNwbHVzCitjb25zdGV4 cHIgYm9vbCBhc3NlcnRpb25GYWlsdXJlRHVlVG9VbnJlYWNoYWJsZUNvZGUgPSBmYWxzZTsKKyNk ZWZpbmUgQVNTRVJUX05PVF9SRUFDSEVEX1dJVEhfTUVTU0FHRSguLi4pIEFTU0VSVF9XSVRIX01F U1NBR0UoYXNzZXJ0aW9uRmFpbHVyZUR1ZVRvVW5yZWFjaGFibGVDb2RlLCBfX1ZBX0FSR1NfXykK KyNlbmRpZgorCiAvKiBBU1NFUlRfV0lUSF9NRVNTQUdFX1VOVVNFRCAqLwogCiAjaWYgQVNTRVJU X01TR19ESVNBQkxFRApAQCAtNTQ4LDYgKzU1Myw3IEBAIFdURl9FWFBPUlRfUFJJVkFURSBOT19S RVRVUk5fRFVFX1RPX0NSQVNIIHZvaWQgV1RGQ3Jhc2hXaXRoU2VjdXJpdHlJbXBsaWNhdGlvbih2 CiAjZW5kaWYKIAogI2lmZGVmIF9fY3BsdXNwbHVzCisjZGVmaW5lIFJFTEVBU0VfQVNTRVJUX05P VF9SRUFDSEVEX1dJVEhfTUVTU0FHRSguLi4pIFJFTEVBU0VfQVNTRVJUX1dJVEhfTUVTU0FHRShh c3NlcnRpb25GYWlsdXJlRHVlVG9VbnJlYWNoYWJsZUNvZGUsIF9fVkFfQVJHU19fKQogCiAvLyBU aGUgY29tYmluYXRpb24gb2YgbGluZSwgZmlsZSwgZnVuY3Rpb24sIGFuZCBjb3VudGVyIHNob3Vs ZCBiZSBhIHVuaXF1ZSBudW1iZXIgcGVyIGNhbGwgdG8gdGhpcyBjcmFzaC4gVGhpcyB0cmlja3Mg dGhlIGNvbXBpbGVyIGludG8gbm90IGNvYWxlc2NpbmcgY2FsbHMgdG8gV1RGQ3Jhc2hXaXRoSW5m by4KIC8vIFRoZSBlYXNpZXN0IHdheSB0byBmaWxsIHRoZXNlIHZhbHVlcyBwZXIgdHJhbnNsYXRp b24gdW5pdCBpcyB0byBwYXNzIF9fTElORV9fLCBfX0ZJTEVfXywgV1RGX1BSRVRUWV9GVU5DVElP TiwgYW5kIF9fQ09VTlRFUl9fLgo=