204434 2019-11-20 17:50:48 -0800 Crash at com.apple.WebCore: -[WebRevealHighlight revealContext:drawRectsForItem:] 2019-11-20 23:25:51 -0800 1 1 1 Unclassified WebKit PDF WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 conrad_shultz conrad_shultz commit-queue conrad_shultz ews-watchlist megan_gardner mifenton webkit-bug-importer oldest_to_newest 1592241 0 conrad_shultz 2019-11-20 17:50:48 -0800 It's possible to trigger a crash under -[WebRevealHighlight revealContext:drawRectsForItem:]. 1592243 1 conrad_shultz 2019-11-20 17:51:55 -0800 <rdar://problem/57123416> 1592246 2 384016 conrad_shultz 2019-11-20 17:56:12 -0800 Created attachment 384016 Patch 1592250 3 384016 megan_gardner 2019-11-20 18:09:13 -0800 Comment on attachment 384016 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384016&action=review r+ as long as you make sure that old systems aren't going to be broken. > Source/WebCore/editing/cocoa/DictionaryLookup.mm:82 > } I know I did this on purpose, I believe so that it would work on older 32 bit systems, but we might not compile for them anymore. Please verify that this is true before removing. > Source/WebCore/editing/cocoa/DictionaryLookup.mm:-101 > - Ditto. 1592300 4 conrad_shultz 2019-11-20 22:33:03 -0800 (In reply to Megan Gardner from comment #3) > Comment on attachment 384016 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384016&action=review > > r+ as long as you make sure that old systems aren't going to be broken. > > > Source/WebCore/editing/cocoa/DictionaryLookup.mm:82 > > } > > I know I did this on purpose, I believe so that it would work on older 32 > bit systems, but we might not compile for them anymore. Please verify that > this is true before removing. > > > Source/WebCore/editing/cocoa/DictionaryLookup.mm:-101 > > - > > Ditto. We should be good as of macOS Catalina. Bots are green too. Thanks! 1592307 5 384016 commit-queue 2019-11-20 23:25:50 -0800 Comment on attachment 384016 Patch Clearing flags on attachment: 384016 Committed r252729: <https://trac.webkit.org/changeset/252729> 1592308 6 commit-queue 2019-11-20 23:25:51 -0800 All reviewed patches have been landed. Closing bug. 384016 2019-11-20 17:56:12 -0800 2019-11-20 23:25:50 -0800 Patch bug-204434-20191120175611.patch text/plain 3001 conrad_shultz U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjFlODk3ODhlZWQwMzEz YTY4MzMzNzAyMzBiNTk2MjZmOGE3ZWY2NC4uYzM0ODgzYTlmNTRlMGNiYjA3MzU5NmY2OTNhODMy MTUxYzM1OWJlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTExLTIwICBDb25y YWQgU2h1bHR6ICA8Y29ucmFkX3NodWx0ekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggYXQg Y29tLmFwcGxlLldlYkNvcmU6IC1bV2ViUmV2ZWFsSGlnaGxpZ2h0IHJldmVhbENvbnRleHQ6ZHJh d1JlY3RzRm9ySXRlbTpdCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDQ0MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBfYXR0cmlidXRlZFN0cmluZyB3YXMgbm90IHJldGFpbmVkLCBsZWFkaW5nIHRvIGEg cG90ZW50aWFsIHVzZS1hZnRlci1kZWFsbG9jLiBGaXgKKyAgICAgICAgdGhpcyBieSB3cmFwcGlu ZyBpdCBpbiBhIFJldGFpblB0ci4gV2hpbGUgd2UncmUgaGVyZSwgcmVtb3ZlIGV4cGxpY2l0IGl2 YXJzIGFuZAorICAgICAgICBwcm9wZXJ0eSBzeW50aGVzaXMgYW5kIGNvcHkgdGhlIHN0cmluZyBk dXJpbmcgYXNzaWdubWVudC4KKworICAgICAgICBSZXZlYWwgZnVuY3Rpb25hbGl0eSBpcyBjdXJy ZW50bHkgbm90IHRlc3RhYmxlLgorCisgICAgICAgICogZWRpdGluZy9jb2NvYS9EaWN0aW9uYXJ5 TG9va3VwLm1tOgorICAgICAgICAoU09GVF9MSU5LX0NMQVNTX09QVElPTkFMKToKKyAgICAgICAg KC1bV2ViUmV2ZWFsSGlnaGxpZ2h0IGluaXRXaXRoSGlnaGxpZ2h0UmVjdDp1c2VEZWZhdWx0SGln aGxpZ2h0OmF0dHJpYnV0ZWRTdHJpbmc6XSk6CisKIDIwMTktMTEtMjAgIFNpbW9uIEZyYXNlciAg PHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI1MjE2MSk6 IGJveC1zaGFkb3cgd2l0aCBpbnNldCBhbmQgcm91bmRlZCBib3JkZXJzIGlzIGNsaXBwZWQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29jb2EvRGljdGlvbmFyeUxvb2t1cC5t bSBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29jb2EvRGljdGlvbmFyeUxvb2t1cC5tbQppbmRl eCBiZTIyNTI5Y2Y0ZTI1MTMxYTNlM2ZjMGI3YTNjODJkMGU1ZWJlMGNkLi5kMzU1MzlhOWRmZDhk NDdlZTRlMDExNzBkNWIyOGNmMTUxMDNlZDcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9l ZGl0aW5nL2NvY29hL0RpY3Rpb25hcnlMb29rdXAubW0KKysrIGIvU291cmNlL1dlYkNvcmUvZWRp dGluZy9jb2NvYS9EaWN0aW9uYXJ5TG9va3VwLm1tCkBAIC03OSwxNCArNzksMTEgQEAgU09GVF9M SU5LX0NMQVNTX09QVElPTkFMKFJldmVhbENvcmUsIFJWU2VsZWN0aW9uKQogQGludGVyZmFjZSBX ZWJSZXZlYWxIaWdobGlnaHQgPFJWUHJlc2VudGVySGlnaGxpZ2h0RGVsZWdhdGU+IDogTlNPYmpl Y3QgewogQHByaXZhdGUKICAgICBGdW5jdGlvbjx2b2lkKCk+IF9jbGVhclRleHRJbmRpY2F0b3I7 Ci0gICAgTlNSZWN0IF9oaWdobGlnaHRSZWN0OwotICAgIEJPT0wgX3VzZURlZmF1bHRIaWdobGln aHQ7Ci0gICAgTlNBdHRyaWJ1dGVkU3RyaW5nICpfYXR0cmlidXRlZFN0cmluZzsKIH0KIAogQHBy b3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBOU1JlY3QgaGlnaGxpZ2h0UmVjdDsKIEBwcm9w ZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgQk9PTCB1c2VEZWZhdWx0SGlnaGxpZ2h0OwotQHBy b3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBOU0F0dHJpYnV0ZWRTdHJpbmcgKmF0dHJpYnV0 ZWRTdHJpbmc7CitAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIFJldGFpblB0cjxOU0F0 dHJpYnV0ZWRTdHJpbmc+IGF0dHJpYnV0ZWRTdHJpbmc7CiAKIC0gKGluc3RhbmNldHlwZSlpbml0 V2l0aEhpZ2hsaWdodFJlY3Q6KE5TUmVjdCloaWdobGlnaHRSZWN0IHVzZURlZmF1bHRIaWdobGln aHQ6KEJPT0wpdXNlRGVmYXVsdEhpZ2hsaWdodCBhdHRyaWJ1dGVkU3RyaW5nOihOU0F0dHJpYnV0 ZWRTdHJpbmcgKikgYXR0cmlidXRlZFN0cmluZzsKIC0gKHZvaWQpc2V0Q2xlYXJUZXh0SW5kaWNh dG9yOihGdW5jdGlvbjx2b2lkKCk+JiYpY2xlYXJUZXh0SW5kaWNhdG9yOwpAQCAtOTUsMTAgKzky LDYgQEAgQGVuZAogCiBAaW1wbGVtZW50YXRpb24gV2ViUmV2ZWFsSGlnaGxpZ2h0CiAKLUBzeW50 aGVzaXplIGhpZ2hsaWdodFJlY3Q9X2hpZ2hsaWdodFJlY3Q7Ci1Ac3ludGhlc2l6ZSB1c2VEZWZh dWx0SGlnaGxpZ2h0PV91c2VEZWZhdWx0SGlnaGxpZ2h0OwotQHN5bnRoZXNpemUgYXR0cmlidXRl ZFN0cmluZz1fYXR0cmlidXRlZFN0cmluZzsKLQogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoSGln aGxpZ2h0UmVjdDooTlNSZWN0KWhpZ2hsaWdodFJlY3QgdXNlRGVmYXVsdEhpZ2hsaWdodDooQk9P TCl1c2VEZWZhdWx0SGlnaGxpZ2h0IGF0dHJpYnV0ZWRTdHJpbmc6KE5TQXR0cmlidXRlZFN0cmlu ZyAqKSBhdHRyaWJ1dGVkU3RyaW5nCiB7CiAgICAgaWYgKCEoc2VsZiA9IFtzdXBlciBpbml0XSkp CkBAIC0xMDYsNyArOTksNyBAQCAtIChpbnN0YW5jZXR5cGUpaW5pdFdpdGhIaWdobGlnaHRSZWN0 OihOU1JlY3QpaGlnaGxpZ2h0UmVjdCB1c2VEZWZhdWx0SGlnaGxpZ2h0OgogICAgIAogICAgIF9o aWdobGlnaHRSZWN0ID0gaGlnaGxpZ2h0UmVjdDsKICAgICBfdXNlRGVmYXVsdEhpZ2hsaWdodCA9 IHVzZURlZmF1bHRIaWdobGlnaHQ7Ci0gICAgX2F0dHJpYnV0ZWRTdHJpbmcgPSBhdHRyaWJ1dGVk U3RyaW5nOworICAgIF9hdHRyaWJ1dGVkU3RyaW5nID0gYWRvcHROUyhbYXR0cmlidXRlZFN0cmlu ZyBjb3B5XSk7CiAgICAgCiAgICAgcmV0dXJuIHNlbGY7CiB9Cg==