204432 2019-11-20 17:37:31 -0800 Baseline JIT should fill in StructureStubInfo's propertyIsInt32 and the slow path should update the array profile more frequently 2019-11-20 18:01:24 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1592227 0 saam 2019-11-20 17:37:31 -0800 ... 1592236 1 384013 saam 2019-11-20 17:47:50 -0800 Created attachment 384013 patch 1592239 2 384013 saam 2019-11-20 17:48:42 -0800 Comment on attachment 384013 patch View in context: https://bugs.webkit.org/attachment.cgi?id=384013&action=review > Source/JavaScriptCore/jit/JITOperations.cpp:2013 > + Structure* structure = baseValue.structureOrNull(); let me improve this to just call structure() 1592240 3 384014 saam 2019-11-20 17:49:57 -0800 Created attachment 384014 patch 1592242 4 384014 tzagallo 2019-11-20 17:51:54 -0800 Comment on attachment 384014 patch r=me 1592248 5 saam 2019-11-20 18:00:38 -0800 landed in: https://trac.webkit.org/changeset/252725/webkit 1592249 6 webkit-bug-importer 2019-11-20 18:01:24 -0800 <rdar://problem/57380299> 384013 2019-11-20 17:47:50 -0800 2019-11-20 17:49:57 -0800 patch b-backup.diff text/plain 3675 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUyNzIyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE5LTExLTIwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEJhc2VsaW5lIEpJVCBzaG91bGQgZmlsbCBpbiBTU0kncyBwcm9wZXJ0eUlzSW50MzIgYW5kIHRo ZSBzbG93IHBhdGggc2hvdWxkIHVwZGF0ZSB0aGUgYXJyYXkgcHJvZmlsZSBtb3JlIGZyZXF1ZW50 bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDQz MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4g SSBhZGRlZCBpbmxpbmUgY2FjaGluZyBmb3IgZ2V0IGJ5IHZhbCwgSSByZW1vdmVkIGNvZGUgd2hp Y2ggdXBkYXRlZCB0aGUKKyAgICAgICAgQXJyYXlQcm9maWxlIHdpdGggc29tZSBmcmVxdWVuY3ku IFRoaXMgcGF0Y2ggYWRkcyBjb2RlIHRoYXQgZG9lcyB0aGF0IGJhY2ssCisgICAgICAgIHdoaWNo IHJlY292ZXJzIHNvbWUgb2YgdGhlIEpldFN0cmVhbTIgcmVncmVzc2lvbnMgd2UgYXJlIHNlZWlu Zy4KKworICAgICAgICAqIGppdC9KSVRPcGVyYXRpb25zLmNwcDoKKyAgICAgICAgKiBqaXQvSklU UHJvcGVydHlBY2Nlc3MuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfb3BfZ2V0X2J5X3Zh bCk6CisKIDIwMTktMTEtMjAgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGFkZHJlc3MgRGFyaW4ncyBmZWVkYmFjayBvbiByMjUy NjgzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3Bw CShyZXZpc2lvbiAyNTI3MjIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJh dGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDA3LDkgKzIwMDcsMTcgQEAgRW5jb2RlZEpT VmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRpb25HZQogICAgIEpTVmFsdWUgYmFzZVZhbHVlID0g SlNWYWx1ZTo6ZGVjb2RlKGVuY29kZWRCYXNlKTsKICAgICBKU1ZhbHVlIHN1YnNjcmlwdCA9IEpT VmFsdWU6OmRlY29kZShlbmNvZGVkU3Vic2NyaXB0KTsKIAorICAgIENvZGVCbG9jayogY29kZUJs b2NrID0gY2FsbEZyYW1lLT5jb2RlQmxvY2soKTsKKwogICAgIGlmIChiYXNlVmFsdWUuaXNDZWxs KCkgJiYgc3Vic2NyaXB0LmlzSW50MzIoKSkgewotICAgICAgICBpZiAoc3R1YkluZm8tPmNvbnNp ZGVyQ2FjaGluZyh2bSwgY2FsbEZyYW1lLT5jb2RlQmxvY2soKSwgYmFzZVZhbHVlLnN0cnVjdHVy ZU9yTnVsbCgpKSkKLSAgICAgICAgICAgIHJlcGF0Y2hBcnJheUdldEJ5VmFsKGdsb2JhbE9iamVj dCwgY2FsbEZyYW1lLT5jb2RlQmxvY2soKSwgYmFzZVZhbHVlLCBzdWJzY3JpcHQsICpzdHViSW5m byk7CisgICAgICAgIFN0cnVjdHVyZSogc3RydWN0dXJlID0gYmFzZVZhbHVlLnN0cnVjdHVyZU9y TnVsbCgpOworICAgICAgICBpZiAoc3R1YkluZm8tPmNvbnNpZGVyQ2FjaGluZyh2bSwgY29kZUJs b2NrLCBzdHJ1Y3R1cmUpKSB7CisgICAgICAgICAgICBpZiAocHJvZmlsZSkgeworICAgICAgICAg ICAgICAgIENvbmN1cnJlbnRKU0xvY2tlciBsb2NrZXIoY29kZUJsb2NrLT5tX2xvY2spOworICAg ICAgICAgICAgICAgIHByb2ZpbGUtPmNvbXB1dGVVcGRhdGVkUHJlZGljdGlvbihsb2NrZXIsIGNv ZGVCbG9jaywgc3RydWN0dXJlKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIHJlcGF0Y2hB cnJheUdldEJ5VmFsKGdsb2JhbE9iamVjdCwgY29kZUJsb2NrLCBiYXNlVmFsdWUsIHN1YnNjcmlw dCwgKnN0dWJJbmZvKTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIGlmIChiYXNlVmFsdWUuaXND ZWxsKCkgJiYgaXNTdHJpbmdPclN5bWJvbChzdWJzY3JpcHQpKSB7CkBAIC0yMDIwLDcgKzIwMjgs NiBAQCBFbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkdlCiAgICAgICAgICAg ICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGJhc2VWYWx1ZS5nZXRQcm9wZXJ0eVNsb3QoZ2xvYmFs T2JqZWN0LCBwcm9wZXJ0eU5hbWUsIFsmXSAoYm9vbCBmb3VuZCwgUHJvcGVydHlTbG90JiBzbG90 KSAtPiBKU1ZhbHVlIHsKICAgICAgICAgICAgICAgICBMT0dfSUMoKElDRXZlbnQ6Ok9wZXJhdGlv bkdldEJ5VmFsT3B0aW1pemUsIGJhc2VWYWx1ZS5jbGFzc0luZm9Pck51bGwodm0pLCBwcm9wZXJ0 eU5hbWUsIGJhc2VWYWx1ZSA9PSBzbG90LnNsb3RCYXNlKCkpKTsgCiAgICAgICAgICAgICAgICAg Ci0gICAgICAgICAgICAgICAgQ29kZUJsb2NrKiBjb2RlQmxvY2sgPSBjYWxsRnJhbWUtPmNvZGVC bG9jaygpOwogICAgICAgICAgICAgICAgIGlmIChzdHViSW5mby0+Y29uc2lkZXJDYWNoaW5nKHZt LCBjb2RlQmxvY2ssIGJhc2VWYWx1ZS5zdHJ1Y3R1cmVPck51bGwoKSkpCiAgICAgICAgICAgICAg ICAgICAgIHJlcGF0Y2hHZXRCeShnbG9iYWxPYmplY3QsIGNvZGVCbG9jaywgYmFzZVZhbHVlLCBw cm9wZXJ0eU5hbWUsIHNsb3QsICpzdHViSW5mbywgR2V0QnlLaW5kOjpOb3JtYWxCeVZhbCk7CiAg ICAgICAgICAgICAgICAgcmV0dXJuIGZvdW5kID8gc2xvdC5nZXRWYWx1ZShnbG9iYWxPYmplY3Qs IHByb3BlcnR5TmFtZSkgOiBqc1VuZGVmaW5lZCgpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAJKHJldmlzaW9uIDI1MjcyMikKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC03MCw2ICs3MCw4IEBAIHZvaWQgSklUOjplbWl0X29wX2dldF9ieV92YWwoY29u c3QgSW5zdHIKICAgICBKSVRHZXRCeVZhbEdlbmVyYXRvciBnZW4oCiAgICAgICAgIG1fY29kZUJs b2NrLCBDb2RlT3JpZ2luKG1fYnl0ZWNvZGVJbmRleCksIENhbGxTaXRlSW5kZXgobV9ieXRlY29k ZUluZGV4KSwgUmVnaXN0ZXJTZXQ6OnN0dWJVbmF2YWlsYWJsZVJlZ2lzdGVycygpLAogICAgICAg ICBKU1ZhbHVlUmVncyhyZWdUMCksIEpTVmFsdWVSZWdzKHJlZ1QxKSwgSlNWYWx1ZVJlZ3MocmVn VDApKTsKKyAgICBpZiAoaXNPcGVyYW5kQ29uc3RhbnRJbnQocHJvcGVydHkpKQorICAgICAgICBn ZW4uc3R1YkluZm8oKS0+cHJvcGVydHlJc0ludDMyID0gdHJ1ZTsKICAgICBnZW4uZ2VuZXJhdGVG YXN0UGF0aCgqdGhpcyk7CiAgICAgYWRkU2xvd0Nhc2UoZ2VuLnNsb3dQYXRoSnVtcCgpKTsKICAg ICBtX2dldEJ5VmFscy5hcHBlbmQoZ2VuKTsK 384014 2019-11-20 17:49:57 -0800 2019-11-20 17:51:54 -0800 patch b-backup.diff text/plain 3681 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUyNzIyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE5LTExLTIwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEJhc2VsaW5lIEpJVCBzaG91bGQgZmlsbCBpbiBTU0kncyBwcm9wZXJ0eUlzSW50MzIgYW5kIHRo ZSBzbG93IHBhdGggc2hvdWxkIHVwZGF0ZSB0aGUgYXJyYXkgcHJvZmlsZSBtb3JlIGZyZXF1ZW50 bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDQz MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4g SSBhZGRlZCBpbmxpbmUgY2FjaGluZyBmb3IgZ2V0IGJ5IHZhbCwgSSByZW1vdmVkIGNvZGUgd2hp Y2ggdXBkYXRlZCB0aGUKKyAgICAgICAgQXJyYXlQcm9maWxlIHdpdGggc29tZSBmcmVxdWVuY3ku IFRoaXMgcGF0Y2ggYWRkcyBjb2RlIHRoYXQgZG9lcyB0aGF0IGJhY2ssCisgICAgICAgIHdoaWNo IHJlY292ZXJzIHNvbWUgb2YgdGhlIEpldFN0cmVhbTIgcmVncmVzc2lvbnMgd2UgYXJlIHNlZWlu Zy4KKworICAgICAgICAqIGppdC9KSVRPcGVyYXRpb25zLmNwcDoKKyAgICAgICAgKiBqaXQvSklU UHJvcGVydHlBY2Nlc3MuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfb3BfZ2V0X2J5X3Zh bCk6CisKIDIwMTktMTEtMjAgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGFkZHJlc3MgRGFyaW4ncyBmZWVkYmFjayBvbiByMjUy NjgzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3Bw CShyZXZpc2lvbiAyNTI3MjIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJh dGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDA3LDkgKzIwMDcsMTcgQEAgRW5jb2RlZEpT VmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRpb25HZQogICAgIEpTVmFsdWUgYmFzZVZhbHVlID0g SlNWYWx1ZTo6ZGVjb2RlKGVuY29kZWRCYXNlKTsKICAgICBKU1ZhbHVlIHN1YnNjcmlwdCA9IEpT VmFsdWU6OmRlY29kZShlbmNvZGVkU3Vic2NyaXB0KTsKIAorICAgIENvZGVCbG9jayogY29kZUJs b2NrID0gY2FsbEZyYW1lLT5jb2RlQmxvY2soKTsKKwogICAgIGlmIChiYXNlVmFsdWUuaXNDZWxs KCkgJiYgc3Vic2NyaXB0LmlzSW50MzIoKSkgewotICAgICAgICBpZiAoc3R1YkluZm8tPmNvbnNp ZGVyQ2FjaGluZyh2bSwgY2FsbEZyYW1lLT5jb2RlQmxvY2soKSwgYmFzZVZhbHVlLnN0cnVjdHVy ZU9yTnVsbCgpKSkKLSAgICAgICAgICAgIHJlcGF0Y2hBcnJheUdldEJ5VmFsKGdsb2JhbE9iamVj dCwgY2FsbEZyYW1lLT5jb2RlQmxvY2soKSwgYmFzZVZhbHVlLCBzdWJzY3JpcHQsICpzdHViSW5m byk7CisgICAgICAgIFN0cnVjdHVyZSogc3RydWN0dXJlID0gYmFzZVZhbHVlLmFzQ2VsbCgpLT5z dHJ1Y3R1cmUodm0pOworICAgICAgICBpZiAoc3R1YkluZm8tPmNvbnNpZGVyQ2FjaGluZyh2bSwg Y29kZUJsb2NrLCBzdHJ1Y3R1cmUpKSB7CisgICAgICAgICAgICBpZiAocHJvZmlsZSkgeworICAg ICAgICAgICAgICAgIENvbmN1cnJlbnRKU0xvY2tlciBsb2NrZXIoY29kZUJsb2NrLT5tX2xvY2sp OworICAgICAgICAgICAgICAgIHByb2ZpbGUtPmNvbXB1dGVVcGRhdGVkUHJlZGljdGlvbihsb2Nr ZXIsIGNvZGVCbG9jaywgc3RydWN0dXJlKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIHJl cGF0Y2hBcnJheUdldEJ5VmFsKGdsb2JhbE9iamVjdCwgY29kZUJsb2NrLCBiYXNlVmFsdWUsIHN1 YnNjcmlwdCwgKnN0dWJJbmZvKTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIGlmIChiYXNlVmFs dWUuaXNDZWxsKCkgJiYgaXNTdHJpbmdPclN5bWJvbChzdWJzY3JpcHQpKSB7CkBAIC0yMDIwLDcg KzIwMjgsNiBAQCBFbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkdlCiAgICAg ICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGJhc2VWYWx1ZS5nZXRQcm9wZXJ0eVNsb3Qo Z2xvYmFsT2JqZWN0LCBwcm9wZXJ0eU5hbWUsIFsmXSAoYm9vbCBmb3VuZCwgUHJvcGVydHlTbG90 JiBzbG90KSAtPiBKU1ZhbHVlIHsKICAgICAgICAgICAgICAgICBMT0dfSUMoKElDRXZlbnQ6Ok9w ZXJhdGlvbkdldEJ5VmFsT3B0aW1pemUsIGJhc2VWYWx1ZS5jbGFzc0luZm9Pck51bGwodm0pLCBw cm9wZXJ0eU5hbWUsIGJhc2VWYWx1ZSA9PSBzbG90LnNsb3RCYXNlKCkpKTsgCiAgICAgICAgICAg ICAgICAgCi0gICAgICAgICAgICAgICAgQ29kZUJsb2NrKiBjb2RlQmxvY2sgPSBjYWxsRnJhbWUt PmNvZGVCbG9jaygpOwogICAgICAgICAgICAgICAgIGlmIChzdHViSW5mby0+Y29uc2lkZXJDYWNo aW5nKHZtLCBjb2RlQmxvY2ssIGJhc2VWYWx1ZS5zdHJ1Y3R1cmVPck51bGwoKSkpCiAgICAgICAg ICAgICAgICAgICAgIHJlcGF0Y2hHZXRCeShnbG9iYWxPYmplY3QsIGNvZGVCbG9jaywgYmFzZVZh bHVlLCBwcm9wZXJ0eU5hbWUsIHNsb3QsICpzdHViSW5mbywgR2V0QnlLaW5kOjpOb3JtYWxCeVZh bCk7CiAgICAgICAgICAgICAgICAgcmV0dXJuIGZvdW5kID8gc2xvdC5nZXRWYWx1ZShnbG9iYWxP YmplY3QsIHByb3BlcnR5TmFtZSkgOiBqc1VuZGVmaW5lZCgpOwpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAJKHJldmlzaW9uIDI1Mjcy MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC03MCw2ICs3MCw4IEBAIHZvaWQgSklUOjplbWl0X29wX2dldF9ieV92 YWwoY29uc3QgSW5zdHIKICAgICBKSVRHZXRCeVZhbEdlbmVyYXRvciBnZW4oCiAgICAgICAgIG1f Y29kZUJsb2NrLCBDb2RlT3JpZ2luKG1fYnl0ZWNvZGVJbmRleCksIENhbGxTaXRlSW5kZXgobV9i eXRlY29kZUluZGV4KSwgUmVnaXN0ZXJTZXQ6OnN0dWJVbmF2YWlsYWJsZVJlZ2lzdGVycygpLAog ICAgICAgICBKU1ZhbHVlUmVncyhyZWdUMCksIEpTVmFsdWVSZWdzKHJlZ1QxKSwgSlNWYWx1ZVJl Z3MocmVnVDApKTsKKyAgICBpZiAoaXNPcGVyYW5kQ29uc3RhbnRJbnQocHJvcGVydHkpKQorICAg ICAgICBnZW4uc3R1YkluZm8oKS0+cHJvcGVydHlJc0ludDMyID0gdHJ1ZTsKICAgICBnZW4uZ2Vu ZXJhdGVGYXN0UGF0aCgqdGhpcyk7CiAgICAgYWRkU2xvd0Nhc2UoZ2VuLnNsb3dQYXRoSnVtcCgp KTsKICAgICBtX2dldEJ5VmFscy5hcHBlbmQoZ2VuKTsK