204426 2019-11-20 15:37:55 -0800 run-webkit-tests: Do not create global SystemHost objects 2019-11-20 17:26:20 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue ews-watchlist glenn jbedard slewis webkit-bug-importer oldest_to_newest 1592180 0 jbedard 2019-11-20 15:37:55 -0800 Stumbled upon this when fixing https://bugs.webkit.org/show_bug.cgi?id=204423. 1592182 1 383997 jbedard 2019-11-20 15:41:43 -0800 Created attachment 383997 Patch 1592208 2 383997 aakash_jain 2019-11-20 16:48:10 -0800 Comment on attachment 383997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383997&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:168 > + def device_by_filter(filter, host=None): missing 'host = host or SystemHost()' in this function? 1592213 3 384005 jbedard 2019-11-20 17:04:46 -0800 Created attachment 384005 Patch for landing 1592221 4 384005 commit-queue 2019-11-20 17:25:26 -0800 Comment on attachment 384005 Patch for landing Clearing flags on attachment: 384005 Committed r252722: <https://trac.webkit.org/changeset/252722> 1592222 5 commit-queue 2019-11-20 17:25:27 -0800 All reviewed patches have been landed. Closing bug. 1592223 6 webkit-bug-importer 2019-11-20 17:26:20 -0800 <rdar://problem/57379300> 383997 2019-11-20 15:41:43 -0800 2019-11-20 17:04:44 -0800 Patch bug-204426-20191120154142.patch text/plain 5878 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MjcxNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI1IEBACisyMDE5LTExLTIwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4td2Via2l0LXRlc3RzOiBEbyBub3QgY3JlYXRlIGdsb2JhbCBTeXN0 ZW1Ib3N0IG9iamVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwNDQyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIElmIGNyZWF0ZWQsIFN5c3RlbUhvc3Qgb2JqZWN0cyBzaG91bGQgYmUgY3JlYXRlZCBv bi1kZW1hbmQsIG5vdCBnbG9iYWxseQorICAgICAgICBzaGFyZWQgYmV0d2VlbiBhbGwgaW5zdGFu Y2VzIG9mIGEgZnVuY3Rpb24uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3Np bXVsYXRlZF9kZXZpY2UucHk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLnBvcHVs YXRlX2F2YWlsYWJsZV9kZXZpY2VzKToKKyAgICAgICAgKFNpbXVsYXRlZERldmljZU1hbmFnZXIu YXZhaWxhYmxlX2RldmljZXMpOgorICAgICAgICAoU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5kZXZp Y2VfYnlfZmlsdGVyKToKKyAgICAgICAgKFNpbXVsYXRlZERldmljZU1hbmFnZXIuX2NyZWF0ZV9v cl9maW5kX2RldmljZV9mb3JfcmVxdWVzdCk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VNYW5h Z2VyLl9ib290X2RldmljZSk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLmRldmlj ZV9jb3VudF9mb3JfdHlwZSk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLmluaXRp YWxpemVfZGV2aWNlcyk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLm1heF9zdXBw b3J0ZWRfc2ltdWxhdG9ycyk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLnN3YXAp OgorICAgICAgICAoU2ltdWxhdGVkRGV2aWNlTWFuYWdlci50ZWFyX2Rvd24pOgorCiAyMDE5LTEx LTIwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAg IHJ1bi1hcGktdGVzdHMgcmVwb3J0cyBBc3NlcnRpb25FcnJvciBvcy5wYXRoc2VwIG5vdCBpbiB2 YWx1ZSBpbiBfYXBwZW5kX3ZhbHVlX2NvbG9uX3NlcGFyYXRlZCBpbiBDeWd3aW4gUHl0aG9uCklu ZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNl LnB5CShyZXZpc2lvbiAyNTI2NDQpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3Np bXVsYXRlZF9kZXZpY2UucHkJKHdvcmtpbmcgY29weSkKQEAgLTEyMyw3ICsxMjMsOCBAQCBjbGFz cyBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyKG9iamVjdCk6CiAgICAgICAgIHJldHVybiByZXN1bHQK IAogICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgcG9wdWxhdGVfYXZhaWxhYmxlX2RldmljZXMo aG9zdD1TeXN0ZW1Ib3N0KCkpOgorICAgIGRlZiBwb3B1bGF0ZV9hdmFpbGFibGVfZGV2aWNlcyho b3N0PU5vbmUpOgorICAgICAgICBob3N0ID0gaG9zdCBvciBTeXN0ZW1Ib3N0KCkKICAgICAgICAg aWYgbm90IGhvc3QucGxhdGZvcm0uaXNfbWFjKCk6CiAgICAgICAgICAgICByZXR1cm4KIApAQCAt MTU3LDEzICsxNTgsMTQgQEAgY2xhc3MgU2ltdWxhdGVkRGV2aWNlTWFuYWdlcihvYmplY3QpOgog ICAgICAgICByZXR1cm4KIAogICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgYXZhaWxhYmxlX2Rl dmljZXMoaG9zdD1TeXN0ZW1Ib3N0KCkpOgorICAgIGRlZiBhdmFpbGFibGVfZGV2aWNlcyhob3N0 PU5vbmUpOgorICAgICAgICBob3N0ID0gaG9zdCBvciBTeXN0ZW1Ib3N0KCkKICAgICAgICAgaWYg U2ltdWxhdGVkRGV2aWNlTWFuYWdlci5BVkFJTEFCTEVfREVWSUNFUyA9PSBbXToKICAgICAgICAg ICAgIFNpbXVsYXRlZERldmljZU1hbmFnZXIucG9wdWxhdGVfYXZhaWxhYmxlX2RldmljZXMoaG9z dCkKICAgICAgICAgcmV0dXJuIFNpbXVsYXRlZERldmljZU1hbmFnZXIuQVZBSUxBQkxFX0RFVklD RVMKIAogICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgZGV2aWNlX2J5X2ZpbHRlcihmaWx0ZXIs IGhvc3Q9U3lzdGVtSG9zdCgpKToKKyAgICBkZWYgZGV2aWNlX2J5X2ZpbHRlcihmaWx0ZXIsIGhv c3Q9Tm9uZSk6CiAgICAgICAgIHJlc3VsdCA9IFtdCiAgICAgICAgIGZvciBkZXZpY2UgaW4gU2lt dWxhdGVkRGV2aWNlTWFuYWdlci5hdmFpbGFibGVfZGV2aWNlcyhob3N0KToKICAgICAgICAgICAg IGlmIGZpbHRlcihkZXZpY2UpOgpAQCAtMjQ5LDggKzI1MSw5IEBAIGNsYXNzIFNpbXVsYXRlZERl dmljZU1hbmFnZXIob2JqZWN0KToKICAgICAgICAgcmV0dXJuIE5vbmUKIAogICAgIEBzdGF0aWNt ZXRob2QKLSAgICBkZWYgX2NyZWF0ZV9vcl9maW5kX2RldmljZV9mb3JfcmVxdWVzdChyZXF1ZXN0 LCBob3N0PVN5c3RlbUhvc3QoKSwgbmFtZV9iYXNlPSdNYW5hZ2VkJyk6CisgICAgZGVmIF9jcmVh dGVfb3JfZmluZF9kZXZpY2VfZm9yX3JlcXVlc3QocmVxdWVzdCwgaG9zdD1Ob25lLCBuYW1lX2Jh c2U9J01hbmFnZWQnKToKICAgICAgICAgYXNzZXJ0IGlzaW5zdGFuY2UocmVxdWVzdCwgRGV2aWNl UmVxdWVzdCkKKyAgICAgICAgaG9zdCA9IGhvc3Qgb3IgU3lzdGVtSG9zdCgpCiAKICAgICAgICAg ZGV2aWNlID0gU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5fZmluZF9leGlzaXRpbmdfZGV2aWNlX2Zv cl9yZXF1ZXN0KHJlcXVlc3QpCiAgICAgICAgIGlmIGRldmljZToKQEAgLTMzMywxNCArMzM2LDE2 IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZU1hbmFnZXIob2JqZWN0KToKICAgICAgICAgICAgIHRp bWUuc2xlZXAoMSkKIAogICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgX2Jvb3RfZGV2aWNlKGRl dmljZSwgaG9zdD1TeXN0ZW1Ib3N0KCkpOgorICAgIGRlZiBfYm9vdF9kZXZpY2UoZGV2aWNlLCBo b3N0PU5vbmUpOgorICAgICAgICBob3N0ID0gaG9zdCBvciBTeXN0ZW1Ib3N0KCkKICAgICAgICAg X2xvZy5kZWJ1Zyh1IkJvb3RpbmcgZGV2aWNlICd7fSciLmZvcm1hdChkZXZpY2UudWRpZCkpCiAg ICAgICAgIGRldmljZS5wbGF0Zm9ybV9kZXZpY2UuYm9vdGVkX2J5X3NjcmlwdCA9IFRydWUKICAg ICAgICAgaG9zdC5leGVjdXRpdmUucnVuX2NvbW1hbmQoW1NpbXVsYXRlZERldmljZU1hbmFnZXIu eGNydW4sICdzaW1jdGwnLCAnYm9vdCcsIGRldmljZS51ZGlkXSkKICAgICAgICAgU2ltdWxhdGVk RGV2aWNlTWFuYWdlci5JTklUSUFMSVpFRF9ERVZJQ0VTLmFwcGVuZChkZXZpY2UpCiAKICAgICBA c3RhdGljbWV0aG9kCi0gICAgZGVmIGRldmljZV9jb3VudF9mb3JfdHlwZShkZXZpY2VfdHlwZSwg aG9zdD1TeXN0ZW1Ib3N0KCksIHVzZV9ib290ZWRfc2ltdWxhdG9yPVRydWUsICoqa3dhcmdzKToK KyAgICBkZWYgZGV2aWNlX2NvdW50X2Zvcl90eXBlKGRldmljZV90eXBlLCBob3N0PU5vbmUsIHVz ZV9ib290ZWRfc2ltdWxhdG9yPVRydWUsICoqa3dhcmdzKToKKyAgICAgICAgaG9zdCA9IGhvc3Qg b3IgU3lzdGVtSG9zdCgpCiAgICAgICAgIGlmIG5vdCBob3N0LnBsYXRmb3JtLmlzX21hYygpOgog ICAgICAgICAgICAgcmV0dXJuIDAKIApAQCAtMzU0LDcgKzM1OSw4IEBAIGNsYXNzIFNpbXVsYXRl ZERldmljZU1hbmFnZXIob2JqZWN0KToKICAgICAgICAgcmV0dXJuIDAKIAogICAgIEBzdGF0aWNt ZXRob2QKLSAgICBkZWYgaW5pdGlhbGl6ZV9kZXZpY2VzKHJlcXVlc3RzLCBob3N0PVN5c3RlbUhv c3QoKSwgbmFtZV9iYXNlPSdNYW5hZ2VkJywgc2ltdWxhdG9yX3VpPVRydWUsIHRpbWVvdXQ9U0lN VUxBVE9SX0JPT1RfVElNRU9VVCwgKiprd2FyZ3MpOgorICAgIGRlZiBpbml0aWFsaXplX2Rldmlj ZXMocmVxdWVzdHMsIGhvc3Q9Tm9uZSwgbmFtZV9iYXNlPSdNYW5hZ2VkJywgc2ltdWxhdG9yX3Vp PVRydWUsIHRpbWVvdXQ9U0lNVUxBVE9SX0JPT1RfVElNRU9VVCwgKiprd2FyZ3MpOgorICAgICAg ICBob3N0ID0gaG9zdCBvciBTeXN0ZW1Ib3N0KCkKICAgICAgICAgaWYgU2ltdWxhdGVkRGV2aWNl TWFuYWdlci5JTklUSUFMSVpFRF9ERVZJQ0VTIGlzIG5vdCBOb25lOgogICAgICAgICAgICAgcmV0 dXJuIFNpbXVsYXRlZERldmljZU1hbmFnZXIuSU5JVElBTElaRURfREVWSUNFUwogCkBAIC00MTAs NyArNDE2LDggQEAgY2xhc3MgU2ltdWxhdGVkRGV2aWNlTWFuYWdlcihvYmplY3QpOgogCiAgICAg QHN0YXRpY21ldGhvZAogICAgIEBtZW1vaXplZAotICAgIGRlZiBtYXhfc3VwcG9ydGVkX3NpbXVs YXRvcnMoaG9zdD1TeXN0ZW1Ib3N0KCkpOgorICAgIGRlZiBtYXhfc3VwcG9ydGVkX3NpbXVsYXRv cnMoaG9zdD1Ob25lKToKKyAgICAgICAgaG9zdCA9IGhvc3Qgb3IgU3lzdGVtSG9zdCgpCiAgICAg ICAgIGlmIG5vdCBob3N0LnBsYXRmb3JtLmlzX21hYygpOgogICAgICAgICAgICAgcmV0dXJuIDAK IApAQCAtNDM4LDcgKzQ0NSw4IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZU1hbmFnZXIob2JqZWN0 KToKICAgICAgICAgcmV0dXJuIG1pbihtYXhfc3VwcG9ydGVkX3NpbXVsYXRvcnNfbG9jYWxseSwg bWF4X3N1cHBvcnRlZF9zaW11bGF0b3JzX2Zvcl9oYXJkd2FyZSkKIAogICAgIEBzdGF0aWNtZXRo b2QKLSAgICBkZWYgc3dhcChkZXZpY2UsIHJlcXVlc3QsIGhvc3Q9U3lzdGVtSG9zdCgpLCBuYW1l X2Jhc2U9J01hbmFnZWQnLCB0aW1lb3V0PVNJTVVMQVRPUl9CT09UX1RJTUVPVVQpOgorICAgIGRl ZiBzd2FwKGRldmljZSwgcmVxdWVzdCwgaG9zdD1Ob25lLCBuYW1lX2Jhc2U9J01hbmFnZWQnLCB0 aW1lb3V0PVNJTVVMQVRPUl9CT09UX1RJTUVPVVQpOgorICAgICAgICBob3N0ID0gaG9zdCBvciBT eXN0ZW1Ib3N0KCkKICAgICAgICAgaWYgU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5JTklUSUFMSVpF RF9ERVZJQ0VTIGlzIE5vbmU6CiAgICAgICAgICAgICByYWlzZSBSdW50aW1lRXJyb3IoJ0Nhbm5v dCBzd2FwIHdoZW4gdGhlcmUgYXJlIG5vIGluaXRpYWxpemVkIGRldmljZXMnKQogICAgICAgICBp ZiBkZXZpY2Ugbm90IGluIFNpbXVsYXRlZERldmljZU1hbmFnZXIuSU5JVElBTElaRURfREVWSUNF UzoKQEAgLTQ2MSw3ICs0NjksOCBAQCBjbGFzcyBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyKG9iamVj dCk6CiAgICAgICAgIFNpbXVsYXRlZERldmljZU1hbmFnZXIuX3dhaXRfdW50aWxfZGV2aWNlX2lz X3VzYWJsZShkZXZpY2UsIG1heCgwLCBkZWFkbGluZSAtIHRpbWUudGltZSgpKSkKIAogICAgIEBz dGF0aWNtZXRob2QKLSAgICBkZWYgdGVhcl9kb3duKGhvc3Q9U3lzdGVtSG9zdCgpLCB0aW1lb3V0 PVNJTVVMQVRPUl9CT09UX1RJTUVPVVQpOgorICAgIGRlZiB0ZWFyX2Rvd24oaG9zdD1Ob25lLCB0 aW1lb3V0PVNJTVVMQVRPUl9CT09UX1RJTUVPVVQpOgorICAgICAgICBob3N0ID0gaG9zdCBvciBT eXN0ZW1Ib3N0KCkKICAgICAgICAgaWYgU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5fbWFuYWdpbmdf c2ltdWxhdG9yX2FwcDoKICAgICAgICAgICAgIGhvc3QuZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsn a2lsbGFsbCcsICctOScsICdTaW11bGF0b3InXSwgcmV0dXJuX2V4aXRfY29kZT1UcnVlKQogICAg ICAgICAgICAgU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5fbWFuYWdpbmdfc2ltdWxhdG9yX2FwcCA9 IEZhbHNlCg== 384005 2019-11-20 17:04:46 -0800 2019-11-20 17:25:26 -0800 Patch for landing bug-204426-20191120170445.patch text/plain 5912 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MjcxOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI1IEBACisyMDE5LTExLTIwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4td2Via2l0LXRlc3RzOiBEbyBub3QgY3JlYXRlIGdsb2JhbCBTeXN0 ZW1Ib3N0IG9iamVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwNDQyNgorCisgICAgICAgIFJldmlld2VkIGJ5IEFha2FzaCBKYWluLgorCisgICAg ICAgIElmIGNyZWF0ZWQsIFN5c3RlbUhvc3Qgb2JqZWN0cyBzaG91bGQgYmUgY3JlYXRlZCBvbi1k ZW1hbmQsIG5vdCBnbG9iYWxseQorICAgICAgICBzaGFyZWQgYmV0d2VlbiBhbGwgaW5zdGFuY2Vz IG9mIGEgZnVuY3Rpb24uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVs YXRlZF9kZXZpY2UucHk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLnBvcHVsYXRl X2F2YWlsYWJsZV9kZXZpY2VzKToKKyAgICAgICAgKFNpbXVsYXRlZERldmljZU1hbmFnZXIuYXZh aWxhYmxlX2RldmljZXMpOgorICAgICAgICAoU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5kZXZpY2Vf YnlfZmlsdGVyKToKKyAgICAgICAgKFNpbXVsYXRlZERldmljZU1hbmFnZXIuX2NyZWF0ZV9vcl9m aW5kX2RldmljZV9mb3JfcmVxdWVzdCk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VNYW5hZ2Vy Ll9ib290X2RldmljZSk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLmRldmljZV9j b3VudF9mb3JfdHlwZSk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLmluaXRpYWxp emVfZGV2aWNlcyk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLm1heF9zdXBwb3J0 ZWRfc2ltdWxhdG9ycyk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLnN3YXApOgor ICAgICAgICAoU2ltdWxhdGVkRGV2aWNlTWFuYWdlci50ZWFyX2Rvd24pOgorCiAyMDE5LTExLTIw ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIHJ1 bi1hcGktdGVzdHMgcmVwb3J0cyBBc3NlcnRpb25FcnJvciBvcy5wYXRoc2VwIG5vdCBpbiB2YWx1 ZSBpbiBfYXBwZW5kX3ZhbHVlX2NvbG9uX3NlcGFyYXRlZCBpbiBDeWd3aW4gUHl0aG9uCkluZGV4 OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5 CShyZXZpc2lvbiAyNTI3MTgpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVs YXRlZF9kZXZpY2UucHkJKHdvcmtpbmcgY29weSkKQEAgLTEyMyw3ICsxMjMsOCBAQCBjbGFzcyBT aW11bGF0ZWREZXZpY2VNYW5hZ2VyKG9iamVjdCk6CiAgICAgICAgIHJldHVybiByZXN1bHQKIAog ICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgcG9wdWxhdGVfYXZhaWxhYmxlX2RldmljZXMoaG9z dD1TeXN0ZW1Ib3N0KCkpOgorICAgIGRlZiBwb3B1bGF0ZV9hdmFpbGFibGVfZGV2aWNlcyhob3N0 PU5vbmUpOgorICAgICAgICBob3N0ID0gaG9zdCBvciBTeXN0ZW1Ib3N0KCkKICAgICAgICAgaWYg bm90IGhvc3QucGxhdGZvcm0uaXNfbWFjKCk6CiAgICAgICAgICAgICByZXR1cm4KIApAQCAtMTU3 LDEzICsxNTgsMTUgQEAgY2xhc3MgU2ltdWxhdGVkRGV2aWNlTWFuYWdlcihvYmplY3QpOgogICAg ICAgICByZXR1cm4KIAogICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgYXZhaWxhYmxlX2Rldmlj ZXMoaG9zdD1TeXN0ZW1Ib3N0KCkpOgorICAgIGRlZiBhdmFpbGFibGVfZGV2aWNlcyhob3N0PU5v bmUpOgorICAgICAgICBob3N0ID0gaG9zdCBvciBTeXN0ZW1Ib3N0KCkKICAgICAgICAgaWYgU2lt dWxhdGVkRGV2aWNlTWFuYWdlci5BVkFJTEFCTEVfREVWSUNFUyA9PSBbXToKICAgICAgICAgICAg IFNpbXVsYXRlZERldmljZU1hbmFnZXIucG9wdWxhdGVfYXZhaWxhYmxlX2RldmljZXMoaG9zdCkK ICAgICAgICAgcmV0dXJuIFNpbXVsYXRlZERldmljZU1hbmFnZXIuQVZBSUxBQkxFX0RFVklDRVMK IAogICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgZGV2aWNlX2J5X2ZpbHRlcihmaWx0ZXIsIGhv c3Q9U3lzdGVtSG9zdCgpKToKKyAgICBkZWYgZGV2aWNlX2J5X2ZpbHRlcihmaWx0ZXIsIGhvc3Q9 Tm9uZSk6CisgICAgICAgIGhvc3QgPSBob3N0IG9yIFN5c3RlbUhvc3QoKQogICAgICAgICByZXN1 bHQgPSBbXQogICAgICAgICBmb3IgZGV2aWNlIGluIFNpbXVsYXRlZERldmljZU1hbmFnZXIuYXZh aWxhYmxlX2RldmljZXMoaG9zdCk6CiAgICAgICAgICAgICBpZiBmaWx0ZXIoZGV2aWNlKToKQEAg LTI0OSw4ICsyNTIsOSBAQCBjbGFzcyBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyKG9iamVjdCk6CiAg ICAgICAgIHJldHVybiBOb25lCiAKICAgICBAc3RhdGljbWV0aG9kCi0gICAgZGVmIF9jcmVhdGVf b3JfZmluZF9kZXZpY2VfZm9yX3JlcXVlc3QocmVxdWVzdCwgaG9zdD1TeXN0ZW1Ib3N0KCksIG5h bWVfYmFzZT0nTWFuYWdlZCcpOgorICAgIGRlZiBfY3JlYXRlX29yX2ZpbmRfZGV2aWNlX2Zvcl9y ZXF1ZXN0KHJlcXVlc3QsIGhvc3Q9Tm9uZSwgbmFtZV9iYXNlPSdNYW5hZ2VkJyk6CiAgICAgICAg IGFzc2VydCBpc2luc3RhbmNlKHJlcXVlc3QsIERldmljZVJlcXVlc3QpCisgICAgICAgIGhvc3Qg PSBob3N0IG9yIFN5c3RlbUhvc3QoKQogCiAgICAgICAgIGRldmljZSA9IFNpbXVsYXRlZERldmlj ZU1hbmFnZXIuX2ZpbmRfZXhpc2l0aW5nX2RldmljZV9mb3JfcmVxdWVzdChyZXF1ZXN0KQogICAg ICAgICBpZiBkZXZpY2U6CkBAIC0zMzMsMTQgKzMzNywxNiBAQCBjbGFzcyBTaW11bGF0ZWREZXZp Y2VNYW5hZ2VyKG9iamVjdCk6CiAgICAgICAgICAgICB0aW1lLnNsZWVwKDEpCiAKICAgICBAc3Rh dGljbWV0aG9kCi0gICAgZGVmIF9ib290X2RldmljZShkZXZpY2UsIGhvc3Q9U3lzdGVtSG9zdCgp KToKKyAgICBkZWYgX2Jvb3RfZGV2aWNlKGRldmljZSwgaG9zdD1Ob25lKToKKyAgICAgICAgaG9z dCA9IGhvc3Qgb3IgU3lzdGVtSG9zdCgpCiAgICAgICAgIF9sb2cuZGVidWcodSJCb290aW5nIGRl dmljZSAne30nIi5mb3JtYXQoZGV2aWNlLnVkaWQpKQogICAgICAgICBkZXZpY2UucGxhdGZvcm1f ZGV2aWNlLmJvb3RlZF9ieV9zY3JpcHQgPSBUcnVlCiAgICAgICAgIGhvc3QuZXhlY3V0aXZlLnJ1 bl9jb21tYW5kKFtTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLnhjcnVuLCAnc2ltY3RsJywgJ2Jvb3Qn LCBkZXZpY2UudWRpZF0pCiAgICAgICAgIFNpbXVsYXRlZERldmljZU1hbmFnZXIuSU5JVElBTEla RURfREVWSUNFUy5hcHBlbmQoZGV2aWNlKQogCiAgICAgQHN0YXRpY21ldGhvZAotICAgIGRlZiBk ZXZpY2VfY291bnRfZm9yX3R5cGUoZGV2aWNlX3R5cGUsIGhvc3Q9U3lzdGVtSG9zdCgpLCB1c2Vf Ym9vdGVkX3NpbXVsYXRvcj1UcnVlLCAqKmt3YXJncyk6CisgICAgZGVmIGRldmljZV9jb3VudF9m b3JfdHlwZShkZXZpY2VfdHlwZSwgaG9zdD1Ob25lLCB1c2VfYm9vdGVkX3NpbXVsYXRvcj1UcnVl LCAqKmt3YXJncyk6CisgICAgICAgIGhvc3QgPSBob3N0IG9yIFN5c3RlbUhvc3QoKQogICAgICAg ICBpZiBub3QgaG9zdC5wbGF0Zm9ybS5pc19tYWMoKToKICAgICAgICAgICAgIHJldHVybiAwCiAK QEAgLTM1NCw3ICszNjAsOCBAQCBjbGFzcyBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyKG9iamVjdCk6 CiAgICAgICAgIHJldHVybiAwCiAKICAgICBAc3RhdGljbWV0aG9kCi0gICAgZGVmIGluaXRpYWxp emVfZGV2aWNlcyhyZXF1ZXN0cywgaG9zdD1TeXN0ZW1Ib3N0KCksIG5hbWVfYmFzZT0nTWFuYWdl ZCcsIHNpbXVsYXRvcl91aT1UcnVlLCB0aW1lb3V0PVNJTVVMQVRPUl9CT09UX1RJTUVPVVQsICoq a3dhcmdzKToKKyAgICBkZWYgaW5pdGlhbGl6ZV9kZXZpY2VzKHJlcXVlc3RzLCBob3N0PU5vbmUs IG5hbWVfYmFzZT0nTWFuYWdlZCcsIHNpbXVsYXRvcl91aT1UcnVlLCB0aW1lb3V0PVNJTVVMQVRP Ul9CT09UX1RJTUVPVVQsICoqa3dhcmdzKToKKyAgICAgICAgaG9zdCA9IGhvc3Qgb3IgU3lzdGVt SG9zdCgpCiAgICAgICAgIGlmIFNpbXVsYXRlZERldmljZU1hbmFnZXIuSU5JVElBTElaRURfREVW SUNFUyBpcyBub3QgTm9uZToKICAgICAgICAgICAgIHJldHVybiBTaW11bGF0ZWREZXZpY2VNYW5h Z2VyLklOSVRJQUxJWkVEX0RFVklDRVMKIApAQCAtNDEwLDcgKzQxNyw4IEBAIGNsYXNzIFNpbXVs YXRlZERldmljZU1hbmFnZXIob2JqZWN0KToKIAogICAgIEBzdGF0aWNtZXRob2QKICAgICBAbWVt b2l6ZWQKLSAgICBkZWYgbWF4X3N1cHBvcnRlZF9zaW11bGF0b3JzKGhvc3Q9U3lzdGVtSG9zdCgp KToKKyAgICBkZWYgbWF4X3N1cHBvcnRlZF9zaW11bGF0b3JzKGhvc3Q9Tm9uZSk6CisgICAgICAg IGhvc3QgPSBob3N0IG9yIFN5c3RlbUhvc3QoKQogICAgICAgICBpZiBub3QgaG9zdC5wbGF0Zm9y bS5pc19tYWMoKToKICAgICAgICAgICAgIHJldHVybiAwCiAKQEAgLTQzOCw3ICs0NDYsOCBAQCBj bGFzcyBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyKG9iamVjdCk6CiAgICAgICAgIHJldHVybiBtaW4o bWF4X3N1cHBvcnRlZF9zaW11bGF0b3JzX2xvY2FsbHksIG1heF9zdXBwb3J0ZWRfc2ltdWxhdG9y c19mb3JfaGFyZHdhcmUpCiAKICAgICBAc3RhdGljbWV0aG9kCi0gICAgZGVmIHN3YXAoZGV2aWNl LCByZXF1ZXN0LCBob3N0PVN5c3RlbUhvc3QoKSwgbmFtZV9iYXNlPSdNYW5hZ2VkJywgdGltZW91 dD1TSU1VTEFUT1JfQk9PVF9USU1FT1VUKToKKyAgICBkZWYgc3dhcChkZXZpY2UsIHJlcXVlc3Qs IGhvc3Q9Tm9uZSwgbmFtZV9iYXNlPSdNYW5hZ2VkJywgdGltZW91dD1TSU1VTEFUT1JfQk9PVF9U SU1FT1VUKToKKyAgICAgICAgaG9zdCA9IGhvc3Qgb3IgU3lzdGVtSG9zdCgpCiAgICAgICAgIGlm IFNpbXVsYXRlZERldmljZU1hbmFnZXIuSU5JVElBTElaRURfREVWSUNFUyBpcyBOb25lOgogICAg ICAgICAgICAgcmFpc2UgUnVudGltZUVycm9yKCdDYW5ub3Qgc3dhcCB3aGVuIHRoZXJlIGFyZSBu byBpbml0aWFsaXplZCBkZXZpY2VzJykKICAgICAgICAgaWYgZGV2aWNlIG5vdCBpbiBTaW11bGF0 ZWREZXZpY2VNYW5hZ2VyLklOSVRJQUxJWkVEX0RFVklDRVM6CkBAIC00NjEsNyArNDcwLDggQEAg Y2xhc3MgU2ltdWxhdGVkRGV2aWNlTWFuYWdlcihvYmplY3QpOgogICAgICAgICBTaW11bGF0ZWRE ZXZpY2VNYW5hZ2VyLl93YWl0X3VudGlsX2RldmljZV9pc191c2FibGUoZGV2aWNlLCBtYXgoMCwg ZGVhZGxpbmUgLSB0aW1lLnRpbWUoKSkpCiAKICAgICBAc3RhdGljbWV0aG9kCi0gICAgZGVmIHRl YXJfZG93bihob3N0PVN5c3RlbUhvc3QoKSwgdGltZW91dD1TSU1VTEFUT1JfQk9PVF9USU1FT1VU KToKKyAgICBkZWYgdGVhcl9kb3duKGhvc3Q9Tm9uZSwgdGltZW91dD1TSU1VTEFUT1JfQk9PVF9U SU1FT1VUKToKKyAgICAgICAgaG9zdCA9IGhvc3Qgb3IgU3lzdGVtSG9zdCgpCiAgICAgICAgIGlm IFNpbXVsYXRlZERldmljZU1hbmFnZXIuX21hbmFnaW5nX3NpbXVsYXRvcl9hcHA6CiAgICAgICAg ICAgICBob3N0LmV4ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ2tpbGxhbGwnLCAnLTknLCAnU2ltdWxh dG9yJ10sIHJldHVybl9leGl0X2NvZGU9VHJ1ZSkKICAgICAgICAgICAgIFNpbXVsYXRlZERldmlj ZU1hbmFnZXIuX21hbmFnaW5nX3NpbXVsYXRvcl9hcHAgPSBGYWxzZQo=