204420 2019-11-20 13:06:40 -0800 run-webkit-tests rebuilds ImageDiff every time 2020-09-04 14:44:34 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap jbedard darin ews-watchlist glenn jbedard thorton webkit-bug-importer oldest_to_newest 1592110 0 ap 2019-11-20 13:06:40 -0800 Every time I run run-webkit-tests --ios-simulator, I get this error, and ImageDiff gets rebuilt. 12:52:45.307 72842 Checking build ... 12:52:45.309 72842 ImageDiff was not found at /Users/ap/Safari/OpenSource/WebKitBuild/Release-iphonesimulator/ImageDiff This path is incorrect, as ImageDiff is not a simulator project, it's built into Release/ImageDiff 1685153 1 darin 2020-09-02 21:20:44 -0700 *** Bug 216100 has been marked as a duplicate of this bug. *** 1685155 2 darin 2020-09-02 21:21:27 -0700 <rdar://problem/68232690> 1685836 3 408015 jbedard 2020-09-04 13:26:59 -0700 Created attachment 408015 Patch 1685839 4 408015 jbedard 2020-09-04 13:30:29 -0700 Comment on attachment 408015 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408015&action=review > Tools/Scripts/webkitpy/port/base.py:278 > + image_diff_path = self._path_to_image_diff() Tim Horton's original point that _path_to_image_diff is memoized, is true, kind of, but not for Apple's ports. We really need to memoize _path_to_image_diff in all children classes, and then explicitly clear the memoization after building. 1685859 5 ews-feeder 2020-09-04 14:44:33 -0700 Committed r266638: <https://trac.webkit.org/changeset/266638> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408015. 408015 2020-09-04 13:26:59 -0700 2020-09-04 14:44:34 -0700 Patch bug-204420-20200904132658.patch text/plain 5722 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NjYzNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDIwLTA5LTA0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4td2Via2l0LXRlc3RzIHJlYnVpbGRzIEltYWdlRGlmZiBldmVyeSB0 aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ0 MjAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY4MjMyNjkwPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jh c2UucHk6CisgICAgICAgIChQb3J0LmNoZWNrX2ltYWdlX2RpZmYpOiBDaGVjayB0aGUgdmVyc2lv biBvZiBJbWFnZURpZmYgd2UgYWN0dWFsbHkgaW50ZW5kIHRvIHVzZS4KKyAgICAgICAgKFBvcnQp OiBVc2Ugd2Via2l0Y29yZXB5J3MgTWVtb2l6ZSBpbiBfcGF0aF90b19pbWFnZV9kaWZmLgorICAg ICAgICAoUG9ydC5fYnVpbGRfaW1hZ2VfZGlmZik6IENsZWFyIHRoZSBtZW1vaXplZCBjYWNoZSBh ZnRlciBidWlsZGluZyBJbWFnZURpZmYuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0 L2Rhcndpbi5weToKKyAgICAgICAgKERhcndpblBvcnQpOiBNZW1vaXplIF9wYXRoX3RvX2ltYWdl X2RpZmYuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0ay5weToKKyAgICAgICAg KEd0a1BvcnQpOiBNZW1vaXplIF9wYXRoX3RvX2ltYWdlX2RpZmYuCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9wb3J0L3dwZS5weToKKyAgICAgICAgKFdQRVBvcnQpOiBNZW1vaXplIF9wYXRo X3RvX2ltYWdlX2RpZmYuCisKIDIwMjAtMDktMDQgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5A YXBwbGUuY29tPgogCiAgICAgICAgIFtld3NdIE5vdGlmeSBib3Qgd2F0Y2hlcnMgYWJvdXQgcHJl LWV4aXN0aW5nIGFuZCBmbGFreSB0ZXN0IGZhaWx1cmVzIGZvciBKU0MgdGVzdHMKSW5kZXg6IFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5CShyZXZpc2lvbiAyNjY2MzEpCisrKyBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQkod29ya2luZyBjb3B5KQpAQCAtNDEsNyArNDEs NyBAQCBpbXBvcnQgc3lzCiAKIGZyb20gY29sbGVjdGlvbnMgaW1wb3J0IE9yZGVyZWREaWN0CiBm cm9tIGZ1bmN0b29scyBpbXBvcnQgcGFydGlhbAotZnJvbSB3ZWJraXRjb3JlcHkgaW1wb3J0IHN0 cmluZ191dGlscworZnJvbSB3ZWJraXRjb3JlcHkgaW1wb3J0IHN0cmluZ191dGlscywgZGVjb3Jh dG9ycwogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbiBpbXBvcnQgZmluZF9maWxlcwogZnJvbSB3ZWJr aXRweS5jb21tb24gaW1wb3J0IHJlYWRfY2hlY2tzdW1fZnJvbV9wbmcKQEAgLTI3NSw3ICsyNzUs NyBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAKICAgICBkZWYgY2hlY2tfaW1hZ2VfZGlmZihzZWxm LCBvdmVycmlkZV9zdGVwPU5vbmUsIGxvZ2dpbmc9VHJ1ZSk6CiAgICAgICAgICIiIlRoaXMgcm91 dGluZSBpcyB1c2VkIHRvIGNoZWNrIHdoZXRoZXIgaW1hZ2VfZGlmZiBiaW5hcnkgZXhpc3RzLiIi IgotICAgICAgICBpbWFnZV9kaWZmX3BhdGggPSBzZWxmLl9wYXRoX3RvX2RlZmF1bHRfaW1hZ2Vf ZGlmZigpCisgICAgICAgIGltYWdlX2RpZmZfcGF0aCA9IHNlbGYuX3BhdGhfdG9faW1hZ2VfZGlm ZigpCiAgICAgICAgIGlmIG5vdCBzZWxmLl9maWxlc3lzdGVtLmV4aXN0cyhpbWFnZV9kaWZmX3Bh dGgpOgogICAgICAgICAgICAgaWYgbG9nZ2luZzoKICAgICAgICAgICAgICAgICBfbG9nLmVycm9y KCJJbWFnZURpZmYgd2FzIG5vdCBmb3VuZCBhdCAlcyIgJSBpbWFnZV9kaWZmX3BhdGgpCkBAIC0x Mzc5LDcgKzEzNzksNyBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAgIGFyZ3MuYXBwZW5k KCItLSVzIiAlIHNlbGYuZ2V0X29wdGlvbigncGxhdGZvcm0nKSkKICAgICAgICAgcmV0dXJuIHNl bGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbbWluaUJyb3dzZXJdICsgYXJncywgc3Rkb3V0PU5v bmUsIGN3ZD1zZWxmLndlYmtpdF9iYXNlKCksIHJldHVybl9zdGRlcnI9RmFsc2UsIGRlY29kZV9v dXRwdXQ9RmFsc2UsIGlnbm9yZV9lcnJvcnM9VHJ1ZSkKIAotICAgIEBtZW1vaXplZAorICAgIEBk ZWNvcmF0b3JzLk1lbW9pemUoKQogICAgIGRlZiBfcGF0aF90b19pbWFnZV9kaWZmKHNlbGYpOgog ICAgICAgICAiIiJSZXR1cm5zIHRoZSBmdWxsIHBhdGggdG8gdGhlIGltYWdlX2RpZmYgYmluYXJ5 LCBvciBOb25lIGlmIGl0IGlzIG5vdCBhdmFpbGFibGUuCiAKQEAgLTE1MjksNiArMTUyOSw3IEBA IGNsYXNzIFBvcnQob2JqZWN0KToKICAgICAgICAgZW52ID0gZW52aXJvbm1lbnQudG9fZGljdGlv bmFyeSgpCiAgICAgICAgIHRyeToKICAgICAgICAgICAgIHNlbGYuX3J1bl9zY3JpcHQoImJ1aWxk LWltYWdlZGlmZiIsIGVudj1lbnYpCisgICAgICAgICAgICBzZWxmLl9wYXRoX3RvX2ltYWdlX2Rp ZmYuY2xlYXIoKQogICAgICAgICBleGNlcHQgU2NyaXB0RXJyb3IgYXMgZToKICAgICAgICAgICAg IF9sb2cuZXJyb3IoZS5tZXNzYWdlX3dpdGhfb3V0cHV0KG91dHB1dF9saW1pdD1Ob25lKSkKICAg ICAgICAgICAgIHJldHVybiBGYWxzZQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0 L2Rhcndpbi5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGFy d2luLnB5CShyZXZpc2lvbiAyNjY2MzEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQv ZGFyd2luLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMCw2ICszMCw4IEBAIGZyb20gd2Via2l0cHku Y29tbW9uLnN5c3RlbS5leGVjdXRpdmUgaW0KIGZyb20gd2Via2l0cHkucG9ydC5hcHBsZSBpbXBv cnQgQXBwbGVQb3J0CiBmcm9tIHdlYmtpdHB5LnBvcnQubGVha2RldGVjdG9yIGltcG9ydCBMZWFr RGV0ZWN0b3IKIAorZnJvbSB3ZWJraXRjb3JlcHkgaW1wb3J0IGRlY29yYXRvcnMKKwogCiBfbG9n ID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCiAKQEAgLTIyNCw2ICsyMjYsNyBAQCBjbGFz cyBEYXJ3aW5Qb3J0KEFwcGxlUG9ydCk6CiAgICAgICAgICAgICAgICAgICAgIHNhbXBsZV9maWxl c1t0ZXN0X25hbWVdID0gdGFpbHNwaW5fZmlsZQogICAgICAgICByZXR1cm4gc2FtcGxlX2ZpbGVz CiAKKyAgICBAZGVjb3JhdG9ycy5NZW1vaXplKCkKICAgICBkZWYgX3BhdGhfdG9faW1hZ2VfZGlm ZihzZWxmKToKICAgICAgICAgIyBJbWFnZURpZmYgZm9yIERhcndpblBvcnRzIGlzIGEgbGl0dGxl IGNvbXBsaWNhdGVkLiBJdCB3aWxsIGVpdGhlciBiZSBpbgogICAgICAgICAjIGEgZGlyZWN0b3J5 IG5hbWVkIC4uL21hYyByZWxhdGl2ZSB0byB0aGUgcG9ydCBidWlsZCBkaXJlY3RvcnksIGluIGEg ZGlyZWN0b3J5CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9ndGsucHkJKHJldmlzaW9uIDI2 NjYzMSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9ndGsucHkJKHdvcmtpbmcgY29w eSkKQEAgLTI5LDcgKzI5LDYgQEAKICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VE IE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIAogaW1wb3J0IG9zCi1pbXBvcnQg c3VicHJvY2VzcwogaW1wb3J0IHV1aWQKIGltcG9ydCBsb2dnaW5nCiAKQEAgLTQ1LDYgKzQ0LDgg QEAgZnJvbSB3ZWJraXRweS5wb3J0LndheWxhbmRkcml2ZXIgaW1wb3J0IAogZnJvbSB3ZWJraXRw eS5wb3J0LmxpbnV4X2dldF9jcmFzaF9sb2cgaW1wb3J0IEdEQkNyYXNoTG9nR2VuZXJhdG9yCiBm cm9tIHdlYmtpdHB5LnBvcnQubGVha2RldGVjdG9yX3ZhbGdyaW5kIGltcG9ydCBMZWFrRGV0ZWN0 b3JWYWxncmluZAogCitmcm9tIHdlYmtpdGNvcmVweSBpbXBvcnQgZGVjb3JhdG9ycworCiBfbG9n ID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCiAKIApAQCAtMTg1LDYgKzE4Niw3IEBAIGNs YXNzIEd0a1BvcnQoUG9ydCk6CiAgICAgZGVmIF9wYXRoX3RvX2RyaXZlcihzZWxmKToKICAgICAg ICAgcmV0dXJuIHNlbGYuX2J1aWx0X2V4ZWN1dGFibGVzX3BhdGgoc2VsZi5kcml2ZXJfbmFtZSgp KQogCisgICAgQGRlY29yYXRvcnMuTWVtb2l6ZSgpCiAgICAgZGVmIF9wYXRoX3RvX2ltYWdlX2Rp ZmYoc2VsZik6CiAgICAgICAgIHJldHVybiBzZWxmLl9idWlsdF9leGVjdXRhYmxlc19wYXRoKCdJ bWFnZURpZmYnKQogCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd3BlLnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93cGUucHkJKHJldmlzaW9u IDI2NjYzMSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93cGUucHkJKHdvcmtpbmcg Y29weSkKQEAgLTI2LDEzICsyNiwxNyBAQAogIyAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RI RVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKICMgT0YgVEhJUyBTT0ZU V0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4K IAoraW1wb3J0IG9zCisKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbSBpbXBvcnQgcGF0aAog ZnJvbSB3ZWJraXRweS5jb21tb24ubWVtb2l6ZWQgaW1wb3J0IG1lbW9pemVkCiBmcm9tIHdlYmtp dHB5LmxheW91dF90ZXN0cy5tb2RlbHMudGVzdF9jb25maWd1cmF0aW9uIGltcG9ydCBUZXN0Q29u ZmlndXJhdGlvbgogZnJvbSB3ZWJraXRweS5wb3J0LmJhc2UgaW1wb3J0IFBvcnQKIGZyb20gd2Vi a2l0cHkucG9ydC5oZWFkbGVzc2RyaXZlciBpbXBvcnQgSGVhZGxlc3NEcml2ZXIKIGZyb20gd2Vi a2l0cHkucG9ydC5saW51eF9nZXRfY3Jhc2hfbG9nIGltcG9ydCBHREJDcmFzaExvZ0dlbmVyYXRv cgotaW1wb3J0IG9zCisKK2Zyb20gd2Via2l0Y29yZXB5IGltcG9ydCBkZWNvcmF0b3JzCisKIAog Y2xhc3MgV1BFUG9ydChQb3J0KToKICAgICBwb3J0X25hbWUgPSAid3BlIgpAQCAtMTA2LDYgKzEx MCw3IEBAIGNsYXNzIFdQRVBvcnQoUG9ydCk6CiAgICAgZGVmIF9wYXRoX3RvX2RyaXZlcihzZWxm KToKICAgICAgICAgcmV0dXJuIHNlbGYuX2J1aWx0X2V4ZWN1dGFibGVzX3BhdGgoc2VsZi5kcml2 ZXJfbmFtZSgpKQogCisgICAgQGRlY29yYXRvcnMuTWVtb2l6ZSgpCiAgICAgZGVmIF9wYXRoX3Rv X2ltYWdlX2RpZmYoc2VsZik6CiAgICAgICAgIHJldHVybiBzZWxmLl9idWlsdF9leGVjdXRhYmxl c19wYXRoKCdJbWFnZURpZmYnKQogCg==