204418 2019-11-20 12:05:32 -0800 [iOS] Make sure WebContent process does not get suspended while it is holding a process assertion for the UIProcess 2019-11-20 15:02:21 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen commit-queue ggaren jer.noble webkit-bug-importer oldest_to_newest 1592090 0 cdumez 2019-11-20 12:05:32 -0800 Make sure WebContent process does not get suspended while it is holding a process assertion for the UIProcess. We see this happening in sysdiagnoses, and it means the system ends up killing the WebContent process because it leaked a process assertion. 1592095 1 383977 cdumez 2019-11-20 12:07:14 -0800 Created attachment 383977 Patch 1592146 2 383977 commit-queue 2019-11-20 15:01:47 -0800 Comment on attachment 383977 Patch Clearing flags on attachment: 383977 Committed r252712: <https://trac.webkit.org/changeset/252712> 1592147 3 commit-queue 2019-11-20 15:01:49 -0800 All reviewed patches have been landed. Closing bug. 1592148 4 webkit-bug-importer 2019-11-20 15:02:21 -0800 <rdar://problem/57374289> 383977 2019-11-20 12:07:14 -0800 2019-11-20 15:01:47 -0800 Patch bug-204418-20191120120714.patch text/plain 6989 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDlmNmVmZGU1NmNjYmNlNDdh MzhhOTVmZDU4ZTg0NmUxYWJhZDc4ZDkuLmJjMzU3MzdiMDFmMThkMGNlYzZmNjE1YmEyMTcxMTg2 MGYzOGFiNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMTEtMjAgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBNYWtlIHN1cmUgV2ViQ29u dGVudCBwcm9jZXNzIGRvZXMgbm90IGdldCBzdXNwZW5kZWQgd2hpbGUgaXQgaXMgaG9sZGluZyBh IHByb2Nlc3MgYXNzZXJ0aW9uIGZvciB0aGUgVUlQcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ0MTgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgV2ViQ29udGVudCBwcm9jZXNz IGRvZXMgbm90IGdldCBzdXNwZW5kZWQgd2hpbGUgaXQgaXMgaG9sZGluZyBhIHByb2Nlc3MgYXNz ZXJ0aW9uIGZvciB0aGUgVUlQcm9jZXNzLiBXZQorICAgICAgICBzZWUgdGhpcyBoYXBwZW5pbmcg aW4gc3lzZGlhZ25vc2VzLCBhbmQgaXQgbWVhbnMgdGhlIHN5c3RlbSBlbmRzIHVwIGtpbGxpbmcg dGhlIFdlYkNvbnRlbnQgcHJvY2VzcyBiZWNhdXNlIGl0IGxlYWtlZAorICAgICAgICBhIHByb2Nl c3MgYXNzZXJ0aW9uLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmg6CisgICAg ICAgICogV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW06CisgICAgICAgIChXZWJL aXQ6OldlYlByb2Nlc3M6OnByb2Nlc3NUYXNrU3RhdGVEaWRDaGFuZ2UpOgorICAgICAgICAoV2Vi S2l0OjpXZWJQcm9jZXNzOjpyZWxlYXNlUHJvY2Vzc1dhc1Jlc3VtZWRBc3NlcnRpb25zKToKKwog MjAxOS0xMS0xOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIGZpeCB3ZWJraXRweSBmYWlsdXJlcyBhZnRlciByMjUyNjU1LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuaCBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmgKaW5kZXggNTVjY2MyZWNkZWNmZWFmZDc3MDMwNmM1ZTNj ZDgwYjZlYTc1ODY2Zi4uZGUxYzk3NTcyNTU5OWE0ZjgzOWM1YTdkZDFjMmMwMDJiZDkxYzU1NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuaAorKysgYi9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5oCkBAIC00NjQsNiArNDY0LDggQEAg cHJpdmF0ZToKICAgICB2b2lkIHByb2Nlc3NUYXNrU3RhdGVEaWRDaGFuZ2UoUHJvY2Vzc1Rhc2tT dGF0ZU9ic2VydmVyOjpUYXNrU3RhdGUpIGZpbmFsOwogICAgIGJvb2wgc2hvdWxkRnJlZXplT25T dXNwZW5zaW9uKCkgY29uc3Q7CiAgICAgdm9pZCB1cGRhdGVGcmVlemVyU3RhdHVzKCk7CisKKyAg ICB2b2lkIHJlbGVhc2VQcm9jZXNzV2FzUmVzdW1lZEFzc2VydGlvbnMoKTsKICNlbmRpZgogCiAj aWYgRU5BQkxFKFZJREVPKQpAQCAtNTQyLDggKzU0NCw5IEBAIHByaXZhdGU6CiAjaWYgUExBVEZP Uk0oSU9TX0ZBTUlMWSkKICAgICBXZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXIgbV93ZWJTUUxpdGVE YXRhYmFzZVRyYWNrZXI7CiAgICAgUmVmUHRyPFByb2Nlc3NUYXNrU3RhdGVPYnNlcnZlcj4gbV90 YXNrU3RhdGVPYnNlcnZlcjsKLSAgICBMb2NrIG1fcHJvY2Vzc1dhc1Jlc3VtZWRVSUFzc2VydGlv bkxvY2s7CisgICAgTG9jayBtX3Byb2Nlc3NXYXNSZXN1bWVkQXNzZXJ0aW9uc0xvY2s7CiAgICAg UmV0YWluUHRyPEJLU1Byb2Nlc3NBc3NlcnRpb24+IG1fcHJvY2Vzc1dhc1Jlc3VtZWRVSUFzc2Vy dGlvbjsKKyAgICBSZXRhaW5QdHI8QktTUHJvY2Vzc0Fzc2VydGlvbj4gbV9wcm9jZXNzV2FzUmVz dW1lZE93bkFzc2VydGlvbjsKICNlbmRpZgogCiAgICAgZW51bSBQYWdlTWFya2luZ0xheWVyc0Fz Vm9sYXRpbGVDb3VudGVyVHlwZSB7IH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQppbmRleCAwYzFhNTcxMzgwZDZjZDQwNTExOGI4OWE3 ZmRjYzdkNDc0MjgyMzc2Li4yN2U4N2YxZTYzYzNhNWNkOThmMzc0MDM5M2JhMTc5MDJkMDJiMGFk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0Nv Y29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29j b2EubW0KQEAgLTMwMCwzMCArMzAwLDQ5IEBAIHZvaWQgV2ViUHJvY2Vzczo6cHJvY2Vzc1Rhc2tT dGF0ZURpZENoYW5nZShQcm9jZXNzVGFza1N0YXRlT2JzZXJ2ZXI6OlRhc2tTdGF0ZSB0CiAgICAg aWYgKHRhc2tTdGF0ZSAhPSBQcm9jZXNzVGFza1N0YXRlT2JzZXJ2ZXI6OlJ1bm5pbmcpCiAgICAg ICAgIHJldHVybjsKIAotICAgIExvY2tIb2xkZXIgaG9sZGVyKG1fcHJvY2Vzc1dhc1Jlc3VtZWRV SUFzc2VydGlvbkxvY2spOwotICAgIGlmIChtX3Byb2Nlc3NXYXNSZXN1bWVkVUlBc3NlcnRpb24p CisgICAgTG9ja0hvbGRlciBob2xkZXIobV9wcm9jZXNzV2FzUmVzdW1lZEFzc2VydGlvbnNMb2Nr KTsKKyAgICBpZiAobV9wcm9jZXNzV2FzUmVzdW1lZFVJQXNzZXJ0aW9uICYmIG1fcHJvY2Vzc1dh c1Jlc3VtZWRPd25Bc3NlcnRpb24pCiAgICAgICAgIHJldHVybjsKIAogICAgIC8vIFdlIHdlcmUg YXdha2VuZWQgZnJvbSBzdXNwZW5zaW9uIHVuZXhwZWN0ZWRseS4gTm90aWZ5IHRoZSBXZWJQcm9j ZXNzUHJveHksIGJ1dCB0YWtlIGEgcHJvY2VzcyBhc3NlcnRpb24gb24gb3VyIHBhcmVudCBQSUQK ICAgICAvLyB0byBlbnN1cmUgdGhhdCBpdCB0b28gaXMgYXdha2VuZWQuCiAgICAgUkVMRUFTRV9M T0coUHJvY2Vzc1N1c3BlbnNpb24sICIlcCAtIFdlYlByb2Nlc3M6OnByb2Nlc3NUYXNrU3RhdGVD aGFuZ2VkKCkgVGFraW5nICdXZWJQcm9jZXNzIHdhcyByZXN1bWVkJyBhc3NlcnRpb24gb24gYmVo YWxmIG9uIFVJUHJvY2VzcyIsIHRoaXMpOwotICAgIG1fcHJvY2Vzc1dhc1Jlc3VtZWRVSUFzc2Vy dGlvbiA9IGFkb3B0TlMoW1tCS1NQcm9jZXNzQXNzZXJ0aW9uIGFsbG9jXSBpbml0V2l0aFBJRDpw YXJlbnRQcm9jZXNzQ29ubmVjdGlvbigpLT5yZW1vdGVQcm9jZXNzSUQoKSBmbGFnczpCS1NQcm9j ZXNzQXNzZXJ0aW9uUHJldmVudFRhc2tTdXNwZW5kIHJlYXNvbjpCS1NQcm9jZXNzQXNzZXJ0aW9u UmVhc29uRmluaXNoVGFzayBuYW1lOkAiV2ViUHJvY2VzcyB3YXMgcmVzdW1lZCIgd2l0aEhhbmRs ZXI6bmlsXSk7Ci0KKyAgICBtX3Byb2Nlc3NXYXNSZXN1bWVkVUlBc3NlcnRpb24gPSBhZG9wdE5T KFtbQktTUHJvY2Vzc0Fzc2VydGlvbiBhbGxvY10gaW5pdFdpdGhQSUQ6cGFyZW50UHJvY2Vzc0Nv bm5lY3Rpb24oKS0+cmVtb3RlUHJvY2Vzc0lEKCkgZmxhZ3M6QktTUHJvY2Vzc0Fzc2VydGlvblBy ZXZlbnRUYXNrU3VzcGVuZCByZWFzb246QktTUHJvY2Vzc0Fzc2VydGlvblJlYXNvbkZpbmlzaFRh c2sgbmFtZTpAIldlYlByb2Nlc3Mgd2FzIHJlc3VtZWQiIHdpdGhIYW5kbGVyOl4oQk9PTCBhY3F1 aXJlZCkgeworICAgICAgICBpZiAoIWFjcXVpcmVkKQorICAgICAgICAgICAgUkVMRUFTRV9MT0df RVJST1IoUHJvY2Vzc1N1c3BlbnNpb24sICIlcCAtIFdlYlByb2Nlc3M6OnByb2Nlc3NUYXNrU3Rh dGVEaWRDaGFuZ2UoKSBmYWlsZWQgdG8gdGFrZSAnV2ViUHJvY2VzcyB3YXMgcmVzdW1lZCcgYXNz ZXJ0aW9uIGZvciBwYXJlbnQgcHJvY2VzcyIsIHRoaXMpOworICAgIH1dKTsKICAgICBtX3Byb2Nl c3NXYXNSZXN1bWVkVUlBc3NlcnRpb24uZ2V0KCkuaW52YWxpZGF0aW9uSGFuZGxlciA9IFt0aGlz XSB7Ci0gICAgICAgIExvY2tIb2xkZXIgaG9sZGVyKG1fcHJvY2Vzc1dhc1Jlc3VtZWRVSUFzc2Vy dGlvbkxvY2spOwotICAgICAgICBSRUxFQVNFX0xPRyhQcm9jZXNzU3VzcGVuc2lvbiwgIiVwIC0g V2ViUHJvY2Vzczo6cHJvY2Vzc1Rhc2tTdGF0ZUNoYW5nZWQoKSBSZWxlYXNpbmcgJ1dlYlByb2Nl c3Mgd2FzIHJlc3VtZWQnIGFzc2VydGlvbiBvbiBiZWhhbGYgb24gVUlQcm9jZXNzIGR1ZSBpbnZh bGlkYXRpb24iLCB0aGlzKTsKLSAgICAgICAgW21fcHJvY2Vzc1dhc1Jlc3VtZWRVSUFzc2VydGlv biBpbnZhbGlkYXRlXTsKLSAgICAgICAgbV9wcm9jZXNzV2FzUmVzdW1lZFVJQXNzZXJ0aW9uID0g bnVsbHB0cjsKKyAgICAgICAgUkVMRUFTRV9MT0dfRVJST1IoUHJvY2Vzc1N1c3BlbnNpb24sICIl cCAtIFdlYlByb2Nlc3M6OnByb2Nlc3NUYXNrU3RhdGVDaGFuZ2VkKCkgUmVsZWFzaW5nICdXZWJQ cm9jZXNzIHdhcyByZXN1bWVkJyBhc3NlcnRpb24gb24gYmVoYWxmIG9uIFVJUHJvY2VzcyBkdWUg dG8gaW52YWxpZGF0aW9uIiwgdGhpcyk7CisgICAgICAgIHJlbGVhc2VQcm9jZXNzV2FzUmVzdW1l ZEFzc2VydGlvbnMoKTsKKyAgICB9OworICAgIG1fcHJvY2Vzc1dhc1Jlc3VtZWRPd25Bc3NlcnRp b24gPSBhZG9wdE5TKFtbQktTUHJvY2Vzc0Fzc2VydGlvbiBhbGxvY10gaW5pdFdpdGhQSUQ6Z2V0 cGlkKCkgZmxhZ3M6QktTUHJvY2Vzc0Fzc2VydGlvblByZXZlbnRUYXNrU3VzcGVuZCByZWFzb246 QktTUHJvY2Vzc0Fzc2VydGlvblJlYXNvbkZpbmlzaFRhc2sgbmFtZTpAIldlYlByb2Nlc3Mgd2Fz IHJlc3VtZWQiIHdpdGhIYW5kbGVyOl4oQk9PTCBhY3F1aXJlZCkgeworICAgICAgICBpZiAoIWFj cXVpcmVkKQorICAgICAgICAgICAgUkVMRUFTRV9MT0dfRVJST1IoUHJvY2Vzc1N1c3BlbnNpb24s ICIlcCAtIFdlYlByb2Nlc3M6OnByb2Nlc3NUYXNrU3RhdGVEaWRDaGFuZ2UoKSBmYWlsZWQgdG8g dGFrZSAnV2ViUHJvY2VzcyB3YXMgcmVzdW1lZCcgYXNzZXJ0aW9uIGZvciBXZWJDb250ZW50IHBy b2Nlc3MiLCB0aGlzKTsKKyAgICB9XSk7CisgICAgbV9wcm9jZXNzV2FzUmVzdW1lZE93bkFzc2Vy dGlvbi5nZXQoKS5pbnZhbGlkYXRpb25IYW5kbGVyID0gW3RoaXNdIHsKKyAgICAgICAgUkVMRUFT RV9MT0dfRVJST1IoUHJvY2Vzc1N1c3BlbnNpb24sICIlcCAtIFdlYlByb2Nlc3M6OnByb2Nlc3NU YXNrU3RhdGVDaGFuZ2VkKCkgUmVsZWFzaW5nICdXZWJQcm9jZXNzIHdhcyByZXN1bWVkJyBhc3Nl cnRpb24gb24gYmVoYWxmIG9uIFdlYkNvbnRlbnQgcHJvY2VzcyBkdWUgdG8gaW52YWxpZGF0aW9u IiwgdGhpcyk7CisgICAgICAgIHJlbGVhc2VQcm9jZXNzV2FzUmVzdW1lZEFzc2VydGlvbnMoKTsK ICAgICB9OwogCi0gICAgLy8gVGhpcyB3aWxsIGNhdXNlIHRoZSBwYXJlbnQgcHJvY2VzcyB0byBz ZW5kIGEgUGFyZW50UHJvY2Vzc0RpZEhhbmRsZVByb2Nlc3NXYXNSZXN1bWVkIElQQyBiYWNrLCBz byB0aGF0IHdlIGNhbiByZWxlYXNlIG91ciBhc3NlcnRpb24gb24gaXRzIGJlaGFsZi4KICAgICBw YXJlbnRQcm9jZXNzQ29ubmVjdGlvbigpLT5zZW5kV2l0aEFzeW5jUmVwbHkoTWVzc2FnZXM6Oldl YlByb2Nlc3NQcm94eTo6UHJvY2Vzc1dhc1Jlc3VtZWQoKSwgW3RoaXNdIHsKLSAgICAgICAgTG9j a0hvbGRlciBob2xkZXIobV9wcm9jZXNzV2FzUmVzdW1lZFVJQXNzZXJ0aW9uTG9jayk7Ci0gICAg ICAgIEFTU0VSVChtX3Byb2Nlc3NXYXNSZXN1bWVkVUlBc3NlcnRpb24pOwotICAgICAgICBSRUxF QVNFX0xPRyhQcm9jZXNzU3VzcGVuc2lvbiwgIiVwIC0gV2ViUHJvY2Vzczo6cGFyZW50UHJvY2Vz c0RpZEhhbmRsZVByb2Nlc3NXYXNSZXN1bWVkKCkgUmVsZWFzaW5nICdXZWJQcm9jZXNzIHdhcyBy ZXN1bWVkJyBhc3NlcnRpb24gb24gYmVoYWxmIG9uIFVJUHJvY2VzcyIsIHRoaXMpOworICAgICAg ICBSRUxFQVNFX0xPRyhQcm9jZXNzU3VzcGVuc2lvbiwgIiVwIC0gV2ViUHJvY2Vzczo6cHJvY2Vz c1Rhc2tTdGF0ZURpZENoYW5nZSgpIFBhcmVudCBwcm9jZXNzIGhhbmRsZWQgUHJvY2Vzc1dhc1Jl c3VtZWQgSVBDLCByZWxlYXNpbmcgb3VyIGFzc2VydGlvbnMiLCB0aGlzKTsKKyAgICAgICAgcmVs ZWFzZVByb2Nlc3NXYXNSZXN1bWVkQXNzZXJ0aW9ucygpOworICAgIH0pOworfQorCit2b2lkIFdl YlByb2Nlc3M6OnJlbGVhc2VQcm9jZXNzV2FzUmVzdW1lZEFzc2VydGlvbnMoKQoreworICAgIExv Y2tIb2xkZXIgaG9sZGVyKG1fcHJvY2Vzc1dhc1Jlc3VtZWRBc3NlcnRpb25zTG9jayk7CisgICAg aWYgKG1fcHJvY2Vzc1dhc1Jlc3VtZWRVSUFzc2VydGlvbikgeworICAgICAgICBSRUxFQVNFX0xP RyhQcm9jZXNzU3VzcGVuc2lvbiwgIiVwIC0gV2ViUHJvY2Vzczo6cmVsZWFzZVByb2Nlc3NXYXNS ZXN1bWVkQXNzZXJ0aW9ucygpIFJlbGVhc2luZyBwYXJlbnQgcHJvY2VzcyAnV2ViUHJvY2VzcyB3 YXMgcmVzdW1lZCcgYXNzZXJ0aW9uIiwgdGhpcyk7CiAgICAgICAgIFttX3Byb2Nlc3NXYXNSZXN1 bWVkVUlBc3NlcnRpb24gaW52YWxpZGF0ZV07CiAgICAgICAgIG1fcHJvY2Vzc1dhc1Jlc3VtZWRV SUFzc2VydGlvbiA9IG51bGxwdHI7Ci0gICAgfSk7CisgICAgfQorICAgIGlmIChtX3Byb2Nlc3NX YXNSZXN1bWVkT3duQXNzZXJ0aW9uKSB7CisgICAgICAgIFJFTEVBU0VfTE9HKFByb2Nlc3NTdXNw ZW5zaW9uLCAiJXAgLSBXZWJQcm9jZXNzOjpyZWxlYXNlUHJvY2Vzc1dhc1Jlc3VtZWRBc3NlcnRp b25zKCkgUmVsZWFzaW5nIFdlYkNvbnRlbnQgcHJvY2VzcyAnV2ViUHJvY2VzcyB3YXMgcmVzdW1l ZCcgYXNzZXJ0aW9uIiwgdGhpcyk7CisgICAgICAgIFttX3Byb2Nlc3NXYXNSZXN1bWVkT3duQXNz ZXJ0aW9uIGludmFsaWRhdGVdOworICAgICAgICBtX3Byb2Nlc3NXYXNSZXN1bWVkT3duQXNzZXJ0 aW9uID0gbnVsbHB0cjsKKyAgICB9CiB9CiAKICNlbmRpZgo=