204405 2019-11-20 03:35:37 -0800 Flaky JSC test: stress/stack-overflow-in-yarr-byteCompile.js.dfg-eager 2019-11-22 10:36:32 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain mark.lam ap ews-watchlist guijemont keith_miller mark.lam msaboff saam tzagallo webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1591949 0 aakash_jain 2019-11-20 03:35:37 -0800 stress/stack-overflow-in-yarr-byteCompile.js.dfg-eager seems flaky. In https://ews-build.webkit.org/#/builders/1/builds/328, the test failed in jscore-test step. However, in the immediately next retry step (jscore-test-rerun), it passed. 1591952 1 aakash_jain 2019-11-20 03:49:46 -0800 Another instance of flakiness: https://ews-build.webkit.org/#/builders/1/builds/256 1591953 2 aakash_jain 2019-11-20 03:50:12 -0800 This test was added recently in https://trac.webkit.org/changeset/252239/webkit 1592024 3 383966 mark.lam 2019-11-20 09:15:51 -0800 Created attachment 383966 proposed patch. 1592048 4 383966 ap 2019-11-20 10:31:06 -0800 Comment on attachment 383966 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=383966&action=review > Source/JavaScriptCore/ChangeLog:9 > + $vm.allWithStackSize() manipulates the stack in ways that will freak out ASan. > + So, add SUPPRESS_ASAN to functionCallWithStackSize() to tell ASan to ignore it. Was there a separate bug where this was reported? 1592058 5 mark.lam 2019-11-20 10:47:45 -0800 (In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 383966 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383966&action=review > > > Source/JavaScriptCore/ChangeLog:9 > > + $vm.allWithStackSize() manipulates the stack in ways that will freak out ASan. > > + So, add SUPPRESS_ASAN to functionCallWithStackSize() to tell ASan to ignore it. > > Was there a separate bug where this was reported? Nope. I just happened to run an ASan build when I was trying to reproduce this issue, and noticed the ASan issue. Thought I might as well fix it since it can be a source of failures for this test. 1592060 6 mark.lam 2019-11-20 10:51:55 -0800 Thanks for the review. Landed in r252694: <http://trac.webkit.org/r252694>. 1592061 7 webkit-bug-importer 2019-11-20 10:52:31 -0800 <rdar://problem/57365049> 1592062 8 webkit-bug-importer 2019-11-20 10:52:32 -0800 <rdar://problem/57365050> 1592065 9 mark.lam 2019-11-20 10:54:00 -0800 <rdar://problem/57365049> 1592113 10 383966 msaboff 2019-11-20 13:21:16 -0800 Comment on attachment 383966 proposed patch. lgtm 1592880 11 383966 guijemont 2019-11-22 10:36:32 -0800 Comment on attachment 383966 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=383966&action=review > JSTests/stress/stack-overflow-in-yarr-byteCompile.js:2 > +//@ runDefault("--disableOptionsFreezingForTesting") > //@ skip if $hostOS != "darwin" or $architecture != "x86-64" If runDefault() is before the skip, then it is always run. I corrected that in Bug 204522. 383966 2019-11-20 09:15:51 -0800 2019-11-20 10:52:05 -0800 proposed patch. bug-204405.patch text/plain 2626 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTI2ODgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE2IEBACisyMDE5LTExLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBGbGFreSBKU0MgdGVzdDogc3RyZXNzL3N0YWNrLW92ZXJmbG93LWluLXlh cnItYnl0ZUNvbXBpbGUuanMuZGZnLWVhZ2VyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0NDA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIHRlc3Qgd2FzIHRpbWluZyBvdXQgYmVjYXVzZSBpdCdz IHNsb3cuICBXZSBkb24ndCByZWFsbHkgbmVlZCB0byBydW4gdGhpcyB0ZXN0CisgICAgICAgIG9u IGFsbCBjb25maWd1cmF0aW9ucy4gIFNvLCB3ZSdsbCBjaGFuZ2UgaXQgdG8gb24gcnVuIHdpdGgg dGhlIGRlZmF1bHQKKyAgICAgICAgY29uZmlndXJhdGlvbi4gIEFsc28gZGVjbGFyZSB0aGUgdGVz dCBhcyAiLy9AIHNsb3chIi4KKworICAgICAgICAqIHN0cmVzcy9zdGFjay1vdmVyZmxvdy1pbi15 YXJyLWJ5dGVDb21waWxlLmpzOgorCiAyMDE5LTExLTE5ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5r aXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgU3RyaW5nLnByb3RvdHlwZS5y ZXBsYWNlQWxsCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9zdGFjay1vdmVyZmxvdy1pbi15YXJyLWJ5 dGVDb21waWxlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3N0YWNrLW92ZXJmbG93 LWluLXlhcnItYnl0ZUNvbXBpbGUuanMJKHJldmlzaW9uIDI1MjY4NykKKysrIEpTVGVzdHMvc3Ry ZXNzL3N0YWNrLW92ZXJmbG93LWluLXlhcnItYnl0ZUNvbXBpbGUuanMJKHdvcmtpbmcgY29weSkK QEAgLTEsNSArMSw2IEBACi0vL0AgcmVxdWlyZU9wdGlvbnMoIi0tZGlzYWJsZU9wdGlvbnNGcmVl emluZ0ZvclRlc3RpbmciKQorLy9AIHJ1bkRlZmF1bHQoIi0tZGlzYWJsZU9wdGlvbnNGcmVlemlu Z0ZvclRlc3RpbmciKQogLy9AIHNraXAgaWYgJGhvc3RPUyAhPSAiZGFyd2luIiBvciAkYXJjaGl0 ZWN0dXJlICE9ICJ4ODYtNjQiCisvL0Agc2xvdyEKIAogZnVuY3Rpb24gZm9vKCkgewogICAgIGNs YXNzIEMgewpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTI2ODcpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTktMTEtMjAgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisg ICAgICAgIEZsYWt5IEpTQyB0ZXN0OiBzdHJlc3Mvc3RhY2stb3ZlcmZsb3ctaW4teWFyci1ieXRl Q29tcGlsZS5qcy5kZmctZWFnZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDQ0MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAkdm0uYWxsV2l0aFN0YWNrU2l6ZSgpIG1hbmlwdWxhdGVzIHRoZSBzdGFj ayBpbiB3YXlzIHRoYXQgd2lsbCBmcmVhayBvdXQgQVNhbi4KKyAgICAgICAgU28sIGFkZCBTVVBQ UkVTU19BU0FOIHRvIGZ1bmN0aW9uQ2FsbFdpdGhTdGFja1NpemUoKSB0byB0ZWxsIEFTYW4gdG8g aWdub3JlIGl0LgorCisgICAgICAgICogdG9vbHMvSlNEb2xsYXJWTS5jcHA6CisKIDIwMTktMTEt MTkgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgR2V0QnlWYWwg c2hvdWxkIHVzZSBwb2x5bW9ycGhpYyBhY2Nlc3MgYW5kIGhvb2sgaW50byBhIHN0YXR1cyBvYmpl Y3QKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0RvbGxhclZNLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvSlNEb2xsYXJWTS5jcHAJKHJl dmlzaW9uIDI1MjY4NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0RvbGxhclZN LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjAxNiw2ICsyMDE2LDcgQEAgc3RhdGljIHZvaWQgY2Fs bFdpdGhTdGFja1NpemVQcm9iZUZ1bmN0aQogfQogI2VuZGlmIC8vIEVOQUJMRShNQVNNX1BST0JF KQogCitTVVBQUkVTU19BU0FOCiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBm dW5jdGlvbkNhbGxXaXRoU3RhY2tTaXplKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIENh bGxGcmFtZSogY2FsbEZyYW1lKQogewogICAgIERvbGxhclZNQXNzZXJ0U2NvcGUgYXNzZXJ0U2Nv cGU7Cg==