204400 2019-11-20 00:00:49 -0800 run-api-tests reports AssertionError os.pathsep not in value in _append_value_colon_separated in Cygwin Python 2019-11-20 15:22:32 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii ap bfulgham commit-queue ews-watchlist glenn jbedard pvollan webkit-bug-importer oldest_to_newest 1591913 0 fujii 2019-11-20 00:00:49 -0800 [Win][Cygwin][run-api-tests] assert os.pathsep not in value in _append_value_colon_separated AppleWin run-api-tests is failing. https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Tests%29/builds/4036 > AssertionError raised: > Traceback (most recent call last): > File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/api_tests/run_api_tests.py", line 59, in main > return run(port, options, args, stderr) > File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/api_tests/run_api_tests.py", line 77, in run > result = manager.run(args, json_output=options.json_output) > File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/api_tests/manager.py", line 171, in run > test_names = self._collect_tests(args) > File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/api_tests/manager.py", line 100, in _collect_tests > env=self._port.environment_for_api_tests()) > File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/port/win.py", line 141, in environment_for_api_tests > env = super(WinPort, self).environment_for_api_tests() > File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/port/base.py", line 266, in environment_for_api_tests > self._append_value_colon_separated(environment, name, build_root_path) > File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/port/base.py", line 942, in _append_value_colon_separated > assert os.pathsep not in value > AssertionError 1591914 1 fujii 2019-11-20 00:02:11 -0800 r249500 (Bug 201311) seems the culprit. 1591930 2 fujii 2019-11-20 01:17:43 -0800 Port._build_path contains ':' because webkit-build-directory returns native paths. $ perl webkit-build-directory C:\webkit\gb\WebKitBuild C:/webkit/gb/WebKitBuild/Release 1591935 3 383951 fujii 2019-11-20 01:45:00 -0800 Created attachment 383951 Patch 1592163 4 383951 commit-queue 2019-11-20 15:21:17 -0800 Comment on attachment 383951 Patch Clearing flags on attachment: 383951 Committed r252714: <https://trac.webkit.org/changeset/252714> 1592164 5 commit-queue 2019-11-20 15:21:19 -0800 All reviewed patches have been landed. Closing bug. 1592166 6 webkit-bug-importer 2019-11-20 15:22:32 -0800 <rdar://problem/57374957> 383951 2019-11-20 01:45:00 -0800 2019-11-20 15:21:17 -0800 Patch bug-204400-20191120184459.patch text/plain 2979 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNjIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGNmNTVmYzZjZmI5NzI3MmMyMGJkYTlkMTA5MTczNzMy NDI5ZjM4NC4uZDMyYWNmZTZhYTQyZGQzMWRmNTkyMzhlZmUxMmJhYjgxOWMxNTc5ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDE5LTExLTIwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIHJ1bi1hcGktdGVzdHMgcmVwb3J0cyBBc3NlcnRpb25FcnJvciBvcy5wYXRo c2VwIG5vdCBpbiB2YWx1ZSBpbiBfYXBwZW5kX3ZhbHVlX2NvbG9uX3NlcGFyYXRlZCBpbiBDeWd3 aW4gUHl0aG9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDQ0MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICByMjQ5NTAwIGNoYW5nZWQgUG9ydC5lbnZpcm9ubWVudF9mb3JfYXBpX3Rlc3RzIHRvIHVzZQor ICAgICAgICBQb3J0Ll9hcHBlbmRfdmFsdWVfY29sb25fc2VwYXJhdGVkIHRvIGFwcGVuZCBhIGJ1 aWxkIHBhdGggdG8gc29tZQorICAgICAgICBlbnZpcm9tZW50IHZhcmlhYmxlcy4gX2FwcGVuZF92 YWx1ZV9jb2xvbl9zZXBhcmF0ZWQgaGFzIGEKKyAgICAgICAgYXNzZXJ0aW9uIHRvIGVuc3VyZSB0 aGUgZ2l2ZW4gdmFsdWUgZG9lc24ndCBpY2x1ZGUgJzonLiBIb3dldmVyLAorICAgICAgICBQb3J0 Ll9idWlsZF9wYXRoIGNvbnRhaW5zICc6JyBvbiBDeWd3aW4gUHl0aG9uLgorCisgICAgICAgIFRo b3NlIGVudmlyb21lbnQgdmFyaWFibGVzIGFyZSBvbmx5IGZvciBtYWNPUyBhbmQgaU9TLiBNb3Zl IHRoZSBjb2RlIHRvIGRhcndpbi5weS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9y dC9iYXNlLnB5OgorICAgICAgICAoUG9ydC5lbnZpcm9ubWVudF9mb3JfYXBpX3Rlc3RzKToKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGFyd2luLnB5OgorICAgICAgICAoRGFyd2lu UG9ydC5lbnZpcm9ubWVudF9mb3JfYXBpX3Rlc3RzKToKKwogMjAxOS0xMS0xOCAgRnVqaWkgSGly b25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBbV2luXSBraWxsLW9s ZC1wcm9jZXNzZXMgc2hvdWxkIGtpbGwgV2ViS2l0V2ViUHJvY2Vzcy5leGUgYW5kIFdlYktpdE5l dHdvcmtQcm9jZXNzLmV4ZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0 L2Jhc2UucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQppbmRleCAyYmY1 N2EwMmZmNzI1YTRjMmQ1NjIwMTZmOTc4Yzc5MjZkZGE5YWNmLi4yNzJiNzZjMDA5ZTIzM2EwNGUx NWQ0Y2UyYTBiMmMwMmFkNDIwNzZkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3BvcnQvYmFzZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQpA QCAtMjYwLDEyICsyNjAsNyBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAgIHJldHVybiBU cnVlCiAKICAgICBkZWYgZW52aXJvbm1lbnRfZm9yX2FwaV90ZXN0cyhzZWxmKToKLSAgICAgICAg YnVpbGRfcm9vdF9wYXRoID0gc3RyKHNlbGYuX2J1aWxkX3BhdGgoKSkKLSAgICAgICAgZW52aXJv bm1lbnQgPSBzZWxmLnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcigpCi0gICAgICAgIGZvciBuYW1l IGluIFsnRFlMRF9MSUJSQVJZX1BBVEgnLCAnX19YUENfRFlMRF9MSUJSQVJZX1BBVEgnLCAnRFlM RF9GUkFNRVdPUktfUEFUSCcsICdfX1hQQ19EWUxEX0ZSQU1FV09SS19QQVRIJ106Ci0gICAgICAg ICAgICBzZWxmLl9hcHBlbmRfdmFsdWVfY29sb25fc2VwYXJhdGVkKGVudmlyb25tZW50LCBuYW1l LCBidWlsZF9yb290X3BhdGgpCi0KLSAgICAgICAgcmV0dXJuIGVudmlyb25tZW50CisgICAgICAg IHJldHVybiBzZWxmLnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcigpCiAKICAgICBkZWYgX2NoZWNr X2RyaXZlcihzZWxmKToKICAgICAgICAgZHJpdmVyX3BhdGggPSBzZWxmLl9wYXRoX3RvX2RyaXZl cigpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGFyd2luLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Rhcndpbi5weQppbmRleCAxZmM2YzdhYWM0ZjIw MjFlMGI3YmYyMjMxMTgwMGU0MmRlYTgwNjlkLi5mNWRjMmRhZGIxOGI4OTFiMDEyMDVlZjJmMjRi NmE1MzEyMTIwYWQ5IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGFy d2luLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kYXJ3aW4ucHkKQEAgLTI2 OSwzICsyNjksMTAgQEAgY2xhc3MgRGFyd2luUG9ydChBcHBsZVBvcnQpOgogCiAgICAgZGVmIGFw cF9leGVjdXRhYmxlX2Zyb21fYnVuZGxlKHNlbGYsIGFwcF9idW5kbGUpOgogICAgICAgICByZXR1 cm4gc2VsZi5fcGxpc3RfZGF0YV9mcm9tX2J1bmRsZShhcHBfYnVuZGxlLCAnQ0ZCdW5kbGVFeGVj dXRhYmxlJykKKworICAgIGRlZiBlbnZpcm9ubWVudF9mb3JfYXBpX3Rlc3RzKHNlbGYpOgorICAg ICAgICBlbnZpcm9ubWVudCA9IHN1cGVyKERhcndpblBvcnQsIHNlbGYpLmVudmlyb25tZW50X2Zv cl9hcGlfdGVzdHMoKQorICAgICAgICBidWlsZF9yb290X3BhdGggPSBzdHIoc2VsZi5fYnVpbGRf cGF0aCgpKQorICAgICAgICBmb3IgbmFtZSBpbiBbJ0RZTERfTElCUkFSWV9QQVRIJywgJ19fWFBD X0RZTERfTElCUkFSWV9QQVRIJywgJ0RZTERfRlJBTUVXT1JLX1BBVEgnLCAnX19YUENfRFlMRF9G UkFNRVdPUktfUEFUSCddOgorICAgICAgICAgICAgc2VsZi5fYXBwZW5kX3ZhbHVlX2NvbG9uX3Nl cGFyYXRlZChlbnZpcm9ubWVudCwgbmFtZSwgYnVpbGRfcm9vdF9wYXRoKQorICAgICAgICByZXR1 cm4gZW52aXJvbm1lbnQK