204385 2019-11-19 15:57:17 -0800 results.webkit.org/api/failures should return an error when no test-run is found for specified criteria 2019-11-22 16:15:14 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue webkit-bug-importer oldest_to_newest 1591733 0 jbedard 2019-11-19 15:57:17 -0800 This is a problem pretty unique to the failures endpoint, at the moment, since it's the only endpoint which is collapsing results from multiple test runs. 1591734 1 jbedard 2019-11-19 15:57:46 -0800 <rdar://problem/57334389> 1591737 2 383916 jbedard 2019-11-19 16:01:43 -0800 Created attachment 383916 Patch 1592397 3 383916 aakash_jain 2019-11-21 09:24:53 -0800 Comment on attachment 383916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383916&action=review rs=me > Tools/resultsdbpy/resultsdbpy/controller/failure_controller.py:86 > + abort(404, description='No test runs found with the specified criteria') should it be 404 or something else. It might make it hard to distinguish incorrect urls from correct urls returning 404. 1592411 4 383916 jbedard 2019-11-21 09:45:54 -0800 Comment on attachment 383916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383916&action=review >> Tools/resultsdbpy/resultsdbpy/controller/failure_controller.py:86 >> + abort(404, description='No test runs found with the specified criteria') > > should it be 404 or something else. It might make it hard to distinguish incorrect urls from correct urls returning 404. The error messages for this is different 'No test runs found with the specified criteria' vs 'The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.'. We clearly need a 400 family error, I don't see one that fits better....maybe 406 or 425? But you kind of have to think creatively for why those fit. 1593023 5 384200 jbedard 2019-11-22 14:43:39 -0800 Created attachment 384200 Patch for landing 1593096 6 384200 commit-queue 2019-11-22 16:15:13 -0800 Comment on attachment 384200 Patch for landing Clearing flags on attachment: 384200 Committed r252815: <https://trac.webkit.org/changeset/252815> 1593097 7 commit-queue 2019-11-22 16:15:14 -0800 All reviewed patches have been landed. Closing bug. 383916 2019-11-19 16:01:43 -0800 2019-11-22 14:43:37 -0800 Patch bug-204385-20191119160142.patch text/plain 6680 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MjY1MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE5LTExLTE5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmcvYXBpL2ZhaWx1cmVzIHNob3VsZCByZXR1 cm4gYW4gZXJyb3Igd2hlbiBubyB0ZXN0LXJ1biBpcyBmb3VuZCBmb3Igc3BlY2lmaWVkIGNyaXRl cmlhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQz ODUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3MzM0Mzg5PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVzdWx0c2RicHkvcmVzdWx0c2RicHkv Y29udHJvbGxlci9mYWlsdXJlX2NvbnRyb2xsZXIucHk6CisgICAgICAgIChGYWlsdXJlQ29udHJv bGxlci5mYWlsdXJlcyk6IFJldHVybiBhIDQwNCBlcnJvciBpZiBubyB0ZXN0IHJ1bnMgYXJlIGZv dW5kLgorICAgICAgICAqIHJlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L2NvbnRyb2xsZXIvZmFpbHVy ZV9jb250cm9sbGVyX3VuaXR0ZXN0LnB5OgorICAgICAgICAoRmFpbHVyZUNvbnRyb2xsZXJUZXN0 KToKKyAgICAgICAgKEZhaWx1cmVDb250cm9sbGVyVGVzdC50ZXN0X25vX3J1bnMpOgorICAgICAg ICAqIHJlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL2ZhaWx1cmVfY29udGV4dC5weToKKyAg ICAgICAgKEZhaWx1cmVDb250ZXh0Ll9mYWlsdXJlcyk6IFJldHVybiAnTm9uZScgaWYgbm8gdGVz dCBydW5zIGFyZSBmb3VuZC4KKyAgICAgICAgKiByZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2Rl bC9mYWlsdXJlX2NvbnRleHRfdW5pdHRlc3QucHk6CisgICAgICAgIChGYWlsdXJlQ29udGV4dFRl c3QpOgorICAgICAgICAoRmFpbHVyZUNvbnRleHRUZXN0LnRlc3Rfbm9fdGVzdF9ydW5zKToKKwog MjAxOS0xMS0xOSAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAg ICAgcmVzdWx0cy53ZWJraXQub3JnOiBIYXZlIGJ1aWxkLndlYmtpdC5vcmcgcmVwb3J0IEpTQyB0 ZXN0cwpJbmRleDogVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvY29udHJvbGxlci9mYWls dXJlX2NvbnRyb2xsZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0 c2RicHkvY29udHJvbGxlci9mYWlsdXJlX2NvbnRyb2xsZXIucHkJKHJldmlzaW9uIDI1MjY1MikK KysrIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L2NvbnRyb2xsZXIvZmFpbHVyZV9jb250 cm9sbGVyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC04MSwxMyArODEsMTUgQEAgY2xhc3MgRmFpbHVy ZUNvbnRyb2xsZXIoSGFzQ29tbWl0Q29udGV4dAogICAgICAgICAgICAgICAgIGRlZiBzb3J0X2Z1 bmN0aW9uKHJlc3VsdCk6CiAgICAgICAgICAgICAgICAgICAgIHJldHVybiByZXN1bHRbJ3N0YXJ0 X3RpbWUnXQogCisgICAgICAgICAgICBmYWlsdXJlcyA9IGZpbmRfZnVuY3Rpb24oKipxdWVyeV9k aWN0KQorICAgICAgICAgICAgaWYgZmFpbHVyZXMgaXMgTm9uZToKKyAgICAgICAgICAgICAgICBh Ym9ydCg0MDQsIGRlc2NyaXB0aW9uPSdObyB0ZXN0IHJ1bnMgZm91bmQgd2l0aCB0aGUgc3BlY2lm aWVkIGNyaXRlcmlhJykKKwogICAgICAgICAgICAgaWYgY29sbGFwc2VkOgotICAgICAgICAgICAg ICAgIHJlc3BvbnNlID0gc2V0KCkKLSAgICAgICAgICAgICAgICByZXNwb25zZS51cGRhdGUoZmlu ZF9mdW5jdGlvbigqKnF1ZXJ5X2RpY3QpKQotICAgICAgICAgICAgICAgIHJldHVybiBqc29uaWZ5 KHNvcnRlZChyZXNwb25zZSkpCisgICAgICAgICAgICAgICAgcmV0dXJuIGpzb25pZnkoc29ydGVk KHNldChmYWlsdXJlcykpKQogCiAgICAgICAgICAgICByZXNwb25zZSA9IFtdCi0gICAgICAgICAg ICBmb3IgY29uZmlnLCByZXN1bHRzIGluIGZpbmRfZnVuY3Rpb24oKipxdWVyeV9kaWN0KS5pdGVt cygpOgorICAgICAgICAgICAgZm9yIGNvbmZpZywgcmVzdWx0cyBpbiBmYWlsdXJlcy5pdGVtcygp OgogICAgICAgICAgICAgICAgIHJlc3BvbnNlLmFwcGVuZChkaWN0KAogICAgICAgICAgICAgICAg ICAgICBjb25maWd1cmF0aW9uPUNvbmZpZ3VyYXRpb24uRW5jb2RlcigpLmRlZmF1bHQoY29uZmln KSwKICAgICAgICAgICAgICAgICAgICAgcmVzdWx0cz1zb3J0ZWQocmVzdWx0cywga2V5PXNvcnRf ZnVuY3Rpb24pLApJbmRleDogVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvY29udHJvbGxl ci9mYWlsdXJlX2NvbnRyb2xsZXJfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvcmVz dWx0c2RicHkvcmVzdWx0c2RicHkvY29udHJvbGxlci9mYWlsdXJlX2NvbnRyb2xsZXJfdW5pdHRl c3QucHkJKHJldmlzaW9uIDI1MjY1MikKKysrIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5 L2NvbnRyb2xsZXIvZmFpbHVyZV9jb250cm9sbGVyX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkp CkBAIC05OSwxMCArOTksMjAgQEAgY2xhc3MgRmFpbHVyZUNvbnRyb2xsZXJUZXN0KEZsYXNrVGVz dENhcwogICAgICAgICByZXNwb25zZSA9IGNsaWVudC5nZXQoZid7c2VsZi5VUkx9L2FwaS9mYWls dXJlcy9sYXlvdXQtdGVzdHM/cGxhdGZvcm09aU9TJnN0eWxlPURlYnVnJnJlY2VudD1GYWxzZSZh ZnRlcl90aW1lPXt0aW1lLnRpbWUoKSAtIDYwICogNjB9JmNvbGxhcHNlZD1GYWxzZScpCiAgICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWwocmVzcG9uc2Uuc3RhdHVzX2NvZGUsIDIwMCkKICAgICAgICAg c2VsZi5hc3NlcnRFcXVhbChsZW4ocmVzcG9uc2UuanNvbigpKSwgMikKLSAgICAgICAgcHJpbnQo cmVzcG9uc2UuanNvbigpKQogICAgICAgICBmb3IgaSBpbiByYW5nZSgyKToKICAgICAgICAgICAg IHNlbGYuYXNzZXJ0RXF1YWwobGVuKHJlc3BvbnNlLmpzb24oKVtpXVsncmVzdWx0cyddKSwgNSkK ICAgICAgICAgICAgIGxhc3Rfc3RhcnRfdGltZSA9IDAKICAgICAgICAgICAgIGZvciByZXN1bHQg aW4gcmVzcG9uc2UuanNvbigpW2ldWydyZXN1bHRzJ106CiAgICAgICAgICAgICAgICAgc2VsZi5h c3NlcnRHcmVhdGVyRXF1YWwocmVzdWx0WydzdGFydF90aW1lJ10sIGxhc3Rfc3RhcnRfdGltZSkK ICAgICAgICAgICAgICAgICBsYXN0X3N0YXJ0X3RpbWUgPSByZXN1bHRbJ3N0YXJ0X3RpbWUnXQor CisgICAgQFdhaXRGb3JEb2NrZXJUZXN0Q2FzZS5tb2NrX2lmX25vX2RvY2tlcihtb2NrX3JlZGlz PUZha2VTdHJpY3RSZWRpcywgbW9ja19jYXNzYW5kcmE9TW9ja0Nhc3NhbmRyYUNvbnRleHQpCisg ICAgQEZsYXNrVGVzdENhc2UucnVuX3dpdGhfd2Vic2VydmVyKCkKKyAgICBkZWYgdGVzdF9ub19y dW5zKHNlbGYsIGNsaWVudCwgKiprd2FyZ3MpOgorICAgICAgICByZXNwb25zZSA9IGNsaWVudC5n ZXQoZid7c2VsZi5VUkx9L2FwaS9mYWlsdXJlcy9sYXlvdXQtdGVzdHM/cGxhdGZvcm09aU9TJnN0 eWxlPURlYnVnJnJlY2VudD1GYWxzZSZiZWZvcmVfdXVpZD0wJykKKyAgICAgICAgc2VsZi5hc3Nl cnRFcXVhbChyZXNwb25zZS5zdGF0dXNfY29kZSwgNDA0KQorICAgICAgICBzZWxmLmFzc2VydEVx dWFsKHJlc3BvbnNlLmpzb24oKSwgZGljdCgKKyAgICAgICAgICAgIHN0YXR1cz0nZXJyb3InLAor ICAgICAgICAgICAgZXJyb3I9J05vdCBGb3VuZCcsCisgICAgICAgICAgICBkZXNjcmlwdGlvbj0n Tm8gdGVzdCBydW5zIGZvdW5kIHdpdGggdGhlIHNwZWNpZmllZCBjcml0ZXJpYScsCisgICAgICAg ICkpCkluZGV4OiBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC9mYWlsdXJlX2Nv bnRleHQucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvbW9k ZWwvZmFpbHVyZV9jb250ZXh0LnB5CShyZXZpc2lvbiAyNTI2NTIpCisrKyBUb29scy9yZXN1bHRz ZGJweS9yZXN1bHRzZGJweS9tb2RlbC9mYWlsdXJlX2NvbnRleHQucHkJKHdvcmtpbmcgY29weSkK QEAgLTE2NCw2ICsxNjQsNyBAQCBjbGFzcyBGYWlsdXJlQ29udGV4dChVcGxvYWRDYWxsYmFja0Nv bnRlCiAgICAgICAgICAgICByZXR1cm4gTm9uZQogCiAgICAgICAgIHdpdGggc2VsZjoKKyAgICAg ICAgICAgIGhhc190ZXN0X3J1bnMgPSBGYWxzZQogICAgICAgICAgICAgaWYgY29sbGFwc2VkOgog ICAgICAgICAgICAgICAgIHJlc3VsdCA9IHNldCgpCiAgICAgICAgICAgICBlbHNlOgpAQCAtMTgw LDEyICsxODEsMTUgQEAgY2xhc3MgRmFpbHVyZUNvbnRleHQoVXBsb2FkQ2FsbGJhY2tDb250ZQog ICAgICAgICAgICAgICAgICkuaXRlbXMoKToKICAgICAgICAgICAgICAgICAgICAgaWYgY29sbGFw c2VkOgogICAgICAgICAgICAgICAgICAgICAgICAgZm9yIHZhbHVlIGluIHZhbHVlczoKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICBoYXNfdGVzdF9ydW5zID0gVHJ1ZQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGZvciB0ZXN0IGluIHZhbHVlLnVucGFjaygpOgogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpZiB0ZXN0IG5vdCBpbiBbJ3V1aWQnLCAnc3RhcnRfdGltZSdd OgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVzdWx0LmFkZCh0ZXN0KQog ICAgICAgICAgICAgICAgICAgICBlbHNlOgogICAgICAgICAgICAgICAgICAgICAgICAgcnVucyA9 IFtdCiAgICAgICAgICAgICAgICAgICAgICAgICBmb3IgdmFsdWUgaW4gdmFsdWVzOgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGhhc190ZXN0X3J1bnMgPSBUcnVlCisKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAjIHV1aWQgYW5kIHN0YXJ0X3RpbWUgYXJlIG5vdCBpbiB0aGUgdW5w YWNrZWQgdmFsdWVzCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5wYWNrZWQgPSB2YWx1 ZS51bnBhY2soKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIGxlbih1bnBhY2tlZCkg PiAyOgpAQCAtMTkzLDcgKzE5Nyw3IEBAIGNsYXNzIEZhaWx1cmVDb250ZXh0KFVwbG9hZENhbGxi YWNrQ29udGUKICAgICAgICAgICAgICAgICAgICAgICAgIGlmIHJ1bnM6CiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcmVzdWx0LnVwZGF0ZSh7Y29uZmlnOiBydW5zfSkKIAotICAgICAgICAg ICAgcmV0dXJuIHJlc3VsdAorICAgICAgICAgICAgcmV0dXJuIHJlc3VsdCBpZiBoYXNfdGVzdF9y dW5zIGVsc2UgTm9uZQogCiAgICAgZGVmIGZhaWx1cmVzX2J5X2NvbW1pdChzZWxmLCAqYXJncywg Kiprd2FyZ3MpOgogICAgICAgICByZXR1cm4gc2VsZi5fZmFpbHVyZXMoc2VsZi5UZXN0RmFpbHVy ZXNCeUNvbW1pdCwgc2VsZi5VbmV4cGVjdGVkVGVzdEZhaWx1cmVzQnlDb21taXQsICphcmdzLCAq Kmt3YXJncykKSW5kZXg6IFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL2ZhaWx1 cmVfY29udGV4dF91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9yZXN1bHRzZGJweS9y ZXN1bHRzZGJweS9tb2RlbC9mYWlsdXJlX2NvbnRleHRfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI1 MjY1MikKKysrIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL2ZhaWx1cmVfY29u dGV4dF91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMTIxLDMgKzEyMSwxMiBAQCBjbGFz cyBGYWlsdXJlQ29udGV4dFRlc3QoV2FpdEZvckRvY2tlclRlCiAgICAgICAgICAgICBzdWl0ZT0n bGF5b3V0LXRlc3RzJywgcmVjZW50PVRydWUsIGNvbGxhcHNlZD1GYWxzZSwgdW5leHBlY3RlZD1G YWxzZSwKICAgICAgICAgKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGxlbihyZXN1bHRzKSwg MCkKKworICAgIEBXYWl0Rm9yRG9ja2VyVGVzdENhc2UubW9ja19pZl9ub19kb2NrZXIobW9ja19y ZWRpcz1GYWtlU3RyaWN0UmVkaXMsIG1vY2tfY2Fzc2FuZHJhPU1vY2tDYXNzYW5kcmFDb250ZXh0 KQorICAgIGRlZiB0ZXN0X25vX3Rlc3RfcnVucyhzZWxmLCByZWRpcz1TdHJpY3RSZWRpcywgY2Fz c2FuZHJhPUNhc3NhbmRyYUNvbnRleHQpOgorICAgICAgICBzZWxmLmluaXRfZGF0YWJhc2UocmVk aXM9cmVkaXMsIGNhc3NhbmRyYT1jYXNzYW5kcmEpCisgICAgICAgIHJlc3VsdHMgPSBzZWxmLm1v ZGVsLmZhaWx1cmVfY29udGV4dC5mYWlsdXJlc19ieV9jb21taXQoCisgICAgICAgICAgICBjb25m aWd1cmF0aW9ucz1bQ29uZmlndXJhdGlvbihwbGF0Zm9ybT0nTWFjJywgc3R5bGU9J1JlbGVhc2Un LCBmbGF2b3I9J3drMScpXSwKKyAgICAgICAgICAgIHN1aXRlPSdsYXlvdXQtdGVzdHMnLCByZWNl bnQ9VHJ1ZSwgZW5kPTAsCisgICAgICAgICkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChyZXN1 bHRzLCBOb25lKQo= 384200 2019-11-22 14:43:39 -0800 2019-11-22 16:15:13 -0800 Patch for landing bug-204385-20191122144338.patch text/plain 6657 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MjgwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE5LTExLTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmcvYXBpL2ZhaWx1cmVzIHNob3VsZCByZXR1 cm4gYW4gZXJyb3Igd2hlbiBubyB0ZXN0LXJ1biBpcyBmb3VuZCBmb3Igc3BlY2lmaWVkIGNyaXRl cmlhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQz ODUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3MzM0Mzg5PgorCisgICAgICAgIFJ1YmJlci1z dGFtcGVkIGJ5IEFha2FzaCBKYWluLgorCisgICAgICAgICogcmVzdWx0c2RicHkvcmVzdWx0c2Ri cHkvY29udHJvbGxlci9mYWlsdXJlX2NvbnRyb2xsZXIucHk6CisgICAgICAgIChGYWlsdXJlQ29u dHJvbGxlci5mYWlsdXJlcyk6IFJldHVybiBhIDQwNCBlcnJvciBpZiBubyB0ZXN0IHJ1bnMgYXJl IGZvdW5kLgorICAgICAgICAqIHJlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L2NvbnRyb2xsZXIvZmFp bHVyZV9jb250cm9sbGVyX3VuaXR0ZXN0LnB5OgorICAgICAgICAoRmFpbHVyZUNvbnRyb2xsZXJU ZXN0KToKKyAgICAgICAgKEZhaWx1cmVDb250cm9sbGVyVGVzdC50ZXN0X25vX3J1bnMpOgorICAg ICAgICAqIHJlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL2ZhaWx1cmVfY29udGV4dC5weToK KyAgICAgICAgKEZhaWx1cmVDb250ZXh0Ll9mYWlsdXJlcyk6IFJldHVybiAnTm9uZScgaWYgbm8g dGVzdCBydW5zIGFyZSBmb3VuZC4KKyAgICAgICAgKiByZXN1bHRzZGJweS9yZXN1bHRzZGJweS9t b2RlbC9mYWlsdXJlX2NvbnRleHRfdW5pdHRlc3QucHk6CisgICAgICAgIChGYWlsdXJlQ29udGV4 dFRlc3QpOgorICAgICAgICAoRmFpbHVyZUNvbnRleHRUZXN0LnRlc3Rfbm9fdGVzdF9ydW5zKToK KwogMjAxOS0xMS0yMiAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI1Mjc5MS4KSW5kZXg6IFRvb2xzL3Jlc3Vs dHNkYnB5L3Jlc3VsdHNkYnB5L2NvbnRyb2xsZXIvZmFpbHVyZV9jb250cm9sbGVyLnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L2NvbnRyb2xsZXIvZmFpbHVy ZV9jb250cm9sbGVyLnB5CShyZXZpc2lvbiAyNTI4MDIpCisrKyBUb29scy9yZXN1bHRzZGJweS9y ZXN1bHRzZGJweS9jb250cm9sbGVyL2ZhaWx1cmVfY29udHJvbGxlci5weQkod29ya2luZyBjb3B5 KQpAQCAtODEsMTMgKzgxLDE1IEBAIGNsYXNzIEZhaWx1cmVDb250cm9sbGVyKEhhc0NvbW1pdENv bnRleHQKICAgICAgICAgICAgICAgICBkZWYgc29ydF9mdW5jdGlvbihyZXN1bHQpOgogICAgICAg ICAgICAgICAgICAgICByZXR1cm4gcmVzdWx0WydzdGFydF90aW1lJ10KIAorICAgICAgICAgICAg ZmFpbHVyZXMgPSBmaW5kX2Z1bmN0aW9uKCoqcXVlcnlfZGljdCkKKyAgICAgICAgICAgIGlmIGZh aWx1cmVzIGlzIE5vbmU6CisgICAgICAgICAgICAgICAgYWJvcnQoNDA0LCBkZXNjcmlwdGlvbj0n Tm8gdGVzdCBydW5zIGZvdW5kIHdpdGggdGhlIHNwZWNpZmllZCBjcml0ZXJpYScpCisKICAgICAg ICAgICAgIGlmIGNvbGxhcHNlZDoKLSAgICAgICAgICAgICAgICByZXNwb25zZSA9IHNldCgpCi0g ICAgICAgICAgICAgICAgcmVzcG9uc2UudXBkYXRlKGZpbmRfZnVuY3Rpb24oKipxdWVyeV9kaWN0 KSkKLSAgICAgICAgICAgICAgICByZXR1cm4ganNvbmlmeShzb3J0ZWQocmVzcG9uc2UpKQorICAg ICAgICAgICAgICAgIHJldHVybiBqc29uaWZ5KHNvcnRlZChzZXQoZmFpbHVyZXMpKSkKIAogICAg ICAgICAgICAgcmVzcG9uc2UgPSBbXQotICAgICAgICAgICAgZm9yIGNvbmZpZywgcmVzdWx0cyBp biBmaW5kX2Z1bmN0aW9uKCoqcXVlcnlfZGljdCkuaXRlbXMoKToKKyAgICAgICAgICAgIGZvciBj b25maWcsIHJlc3VsdHMgaW4gZmFpbHVyZXMuaXRlbXMoKToKICAgICAgICAgICAgICAgICByZXNw b25zZS5hcHBlbmQoZGljdCgKICAgICAgICAgICAgICAgICAgICAgY29uZmlndXJhdGlvbj1Db25m aWd1cmF0aW9uLkVuY29kZXIoKS5kZWZhdWx0KGNvbmZpZyksCiAgICAgICAgICAgICAgICAgICAg IHJlc3VsdHM9c29ydGVkKHJlc3VsdHMsIGtleT1zb3J0X2Z1bmN0aW9uKSwKSW5kZXg6IFRvb2xz L3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L2NvbnRyb2xsZXIvZmFpbHVyZV9jb250cm9sbGVyX3Vu aXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L2Nv bnRyb2xsZXIvZmFpbHVyZV9jb250cm9sbGVyX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNTI4MDIp CisrKyBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9jb250cm9sbGVyL2ZhaWx1cmVfY29u dHJvbGxlcl91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtOTksMTAgKzk5LDIwIEBAIGNs YXNzIEZhaWx1cmVDb250cm9sbGVyVGVzdChGbGFza1Rlc3RDYXMKICAgICAgICAgcmVzcG9uc2Ug PSBjbGllbnQuZ2V0KGYne3NlbGYuVVJMfS9hcGkvZmFpbHVyZXMvbGF5b3V0LXRlc3RzP3BsYXRm b3JtPWlPUyZzdHlsZT1EZWJ1ZyZyZWNlbnQ9RmFsc2UmYWZ0ZXJfdGltZT17dGltZS50aW1lKCkg LSA2MCAqIDYwfSZjb2xsYXBzZWQ9RmFsc2UnKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHJl c3BvbnNlLnN0YXR1c19jb2RlLCAyMDApCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwobGVuKHJl c3BvbnNlLmpzb24oKSksIDIpCi0gICAgICAgIHByaW50KHJlc3BvbnNlLmpzb24oKSkKICAgICAg ICAgZm9yIGkgaW4gcmFuZ2UoMik6CiAgICAgICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGxlbihy ZXNwb25zZS5qc29uKClbaV1bJ3Jlc3VsdHMnXSksIDUpCiAgICAgICAgICAgICBsYXN0X3N0YXJ0 X3RpbWUgPSAwCiAgICAgICAgICAgICBmb3IgcmVzdWx0IGluIHJlc3BvbnNlLmpzb24oKVtpXVsn cmVzdWx0cyddOgogICAgICAgICAgICAgICAgIHNlbGYuYXNzZXJ0R3JlYXRlckVxdWFsKHJlc3Vs dFsnc3RhcnRfdGltZSddLCBsYXN0X3N0YXJ0X3RpbWUpCiAgICAgICAgICAgICAgICAgbGFzdF9z dGFydF90aW1lID0gcmVzdWx0WydzdGFydF90aW1lJ10KKworICAgIEBXYWl0Rm9yRG9ja2VyVGVz dENhc2UubW9ja19pZl9ub19kb2NrZXIobW9ja19yZWRpcz1GYWtlU3RyaWN0UmVkaXMsIG1vY2tf Y2Fzc2FuZHJhPU1vY2tDYXNzYW5kcmFDb250ZXh0KQorICAgIEBGbGFza1Rlc3RDYXNlLnJ1bl93 aXRoX3dlYnNlcnZlcigpCisgICAgZGVmIHRlc3Rfbm9fcnVucyhzZWxmLCBjbGllbnQsICoqa3dh cmdzKToKKyAgICAgICAgcmVzcG9uc2UgPSBjbGllbnQuZ2V0KGYne3NlbGYuVVJMfS9hcGkvZmFp bHVyZXMvbGF5b3V0LXRlc3RzP3BsYXRmb3JtPWlPUyZzdHlsZT1EZWJ1ZyZyZWNlbnQ9RmFsc2Um YmVmb3JlX3V1aWQ9MCcpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocmVzcG9uc2Uuc3RhdHVz X2NvZGUsIDQwNCkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChyZXNwb25zZS5qc29uKCksIGRp Y3QoCisgICAgICAgICAgICBzdGF0dXM9J2Vycm9yJywKKyAgICAgICAgICAgIGVycm9yPSdOb3Qg Rm91bmQnLAorICAgICAgICAgICAgZGVzY3JpcHRpb249J05vIHRlc3QgcnVucyBmb3VuZCB3aXRo IHRoZSBzcGVjaWZpZWQgY3JpdGVyaWEnLAorICAgICAgICApKQpJbmRleDogVG9vbHMvcmVzdWx0 c2RicHkvcmVzdWx0c2RicHkvbW9kZWwvZmFpbHVyZV9jb250ZXh0LnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL2ZhaWx1cmVfY29udGV4dC5weQko cmV2aXNpb24gMjUyODAyKQorKysgVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvbW9kZWwv ZmFpbHVyZV9jb250ZXh0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNjQsNiArMTY0LDcgQEAgY2xh c3MgRmFpbHVyZUNvbnRleHQoVXBsb2FkQ2FsbGJhY2tDb250ZQogICAgICAgICAgICAgcmV0dXJu IE5vbmUKIAogICAgICAgICB3aXRoIHNlbGY6CisgICAgICAgICAgICBoYXNfdGVzdF9ydW5zID0g RmFsc2UKICAgICAgICAgICAgIGlmIGNvbGxhcHNlZDoKICAgICAgICAgICAgICAgICByZXN1bHQg PSBzZXQoKQogICAgICAgICAgICAgZWxzZToKQEAgLTE4MCwxMiArMTgxLDE1IEBAIGNsYXNzIEZh aWx1cmVDb250ZXh0KFVwbG9hZENhbGxiYWNrQ29udGUKICAgICAgICAgICAgICAgICApLml0ZW1z KCk6CiAgICAgICAgICAgICAgICAgICAgIGlmIGNvbGxhcHNlZDoKICAgICAgICAgICAgICAgICAg ICAgICAgIGZvciB2YWx1ZSBpbiB2YWx1ZXM6CisgICAgICAgICAgICAgICAgICAgICAgICAgICAg aGFzX3Rlc3RfcnVucyA9IFRydWUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmb3IgdGVz dCBpbiB2YWx1ZS51bnBhY2soKToKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYg dGVzdCBub3QgaW4gWyd1dWlkJywgJ3N0YXJ0X3RpbWUnXToKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHJlc3VsdC5hZGQodGVzdCkKICAgICAgICAgICAgICAgICAgICAgZWxz ZToKICAgICAgICAgICAgICAgICAgICAgICAgIHJ1bnMgPSBbXQogICAgICAgICAgICAgICAgICAg ICAgICAgZm9yIHZhbHVlIGluIHZhbHVlczoKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBo YXNfdGVzdF9ydW5zID0gVHJ1ZQorCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIyB1dWlk IGFuZCBzdGFydF90aW1lIGFyZSBub3QgaW4gdGhlIHVucGFja2VkIHZhbHVlcwogICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHVucGFja2VkID0gdmFsdWUudW5wYWNrKCkKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpZiBsZW4odW5wYWNrZWQpID4gMjoKQEAgLTE5Myw3ICsxOTcsNyBA QCBjbGFzcyBGYWlsdXJlQ29udGV4dChVcGxvYWRDYWxsYmFja0NvbnRlCiAgICAgICAgICAgICAg ICAgICAgICAgICBpZiBydW5zOgogICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlc3VsdC51 cGRhdGUoe2NvbmZpZzogcnVuc30pCiAKLSAgICAgICAgICAgIHJldHVybiByZXN1bHQKKyAgICAg ICAgICAgIHJldHVybiByZXN1bHQgaWYgaGFzX3Rlc3RfcnVucyBlbHNlIE5vbmUKIAogICAgIGRl ZiBmYWlsdXJlc19ieV9jb21taXQoc2VsZiwgKmFyZ3MsICoqa3dhcmdzKToKICAgICAgICAgcmV0 dXJuIHNlbGYuX2ZhaWx1cmVzKHNlbGYuVGVzdEZhaWx1cmVzQnlDb21taXQsIHNlbGYuVW5leHBl Y3RlZFRlc3RGYWlsdXJlc0J5Q29tbWl0LCAqYXJncywgKiprd2FyZ3MpCkluZGV4OiBUb29scy9y ZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC9mYWlsdXJlX2NvbnRleHRfdW5pdHRlc3QucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvbW9kZWwvZmFpbHVy ZV9jb250ZXh0X3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNTI4MDIpCisrKyBUb29scy9yZXN1bHRz ZGJweS9yZXN1bHRzZGJweS9tb2RlbC9mYWlsdXJlX2NvbnRleHRfdW5pdHRlc3QucHkJKHdvcmtp bmcgY29weSkKQEAgLTEyMSwzICsxMjEsMTIgQEAgY2xhc3MgRmFpbHVyZUNvbnRleHRUZXN0KFdh aXRGb3JEb2NrZXJUZQogICAgICAgICAgICAgc3VpdGU9J2xheW91dC10ZXN0cycsIHJlY2VudD1U cnVlLCBjb2xsYXBzZWQ9RmFsc2UsIHVuZXhwZWN0ZWQ9RmFsc2UsCiAgICAgICAgICkKICAgICAg ICAgc2VsZi5hc3NlcnRFcXVhbChsZW4ocmVzdWx0cyksIDApCisKKyAgICBAV2FpdEZvckRvY2tl clRlc3RDYXNlLm1vY2tfaWZfbm9fZG9ja2VyKG1vY2tfcmVkaXM9RmFrZVN0cmljdFJlZGlzLCBt b2NrX2Nhc3NhbmRyYT1Nb2NrQ2Fzc2FuZHJhQ29udGV4dCkKKyAgICBkZWYgdGVzdF9ub190ZXN0 X3J1bnMoc2VsZiwgcmVkaXM9U3RyaWN0UmVkaXMsIGNhc3NhbmRyYT1DYXNzYW5kcmFDb250ZXh0 KToKKyAgICAgICAgc2VsZi5pbml0X2RhdGFiYXNlKHJlZGlzPXJlZGlzLCBjYXNzYW5kcmE9Y2Fz c2FuZHJhKQorICAgICAgICByZXN1bHRzID0gc2VsZi5tb2RlbC5mYWlsdXJlX2NvbnRleHQuZmFp bHVyZXNfYnlfY29tbWl0KAorICAgICAgICAgICAgY29uZmlndXJhdGlvbnM9W0NvbmZpZ3VyYXRp b24ocGxhdGZvcm09J01hYycsIHN0eWxlPSdSZWxlYXNlJywgZmxhdm9yPSd3azEnKV0sCisgICAg ICAgICAgICBzdWl0ZT0nbGF5b3V0LXRlc3RzJywgcmVjZW50PVRydWUsIGVuZD0wLAorICAgICAg ICApCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocmVzdWx0cywgTm9uZSkK