204384 2019-11-19 15:56:46 -0800 [JSC] Work-around Leaks' false-positive report about memory leaking 2019-11-19 16:56:55 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki mark.lam webkit-bug-importer oldest_to_newest 1591732 0 ysuzuki 2019-11-19 15:56:46 -0800 [JSC] Work-around Leaks' false-positive report about memory leaking 1591735 1 383915 ysuzuki 2019-11-19 16:00:19 -0800 Created attachment 383915 Patch 1591736 2 ysuzuki 2019-11-19 16:00:21 -0800 <rdar://problem/56950932> 1591738 3 383915 mark.lam 2019-11-19 16:04:01 -0800 Comment on attachment 383915 Patch r=me 1591740 4 383915 mark.lam 2019-11-19 16:05:41 -0800 Comment on attachment 383915 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383915&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.cpp:425 > - g_jscConfig.fixedVMPoolExecutableAllocator = new FixedVMPoolExecutableAllocator(); > + auto* allocator = new FixedVMPoolExecutableAllocator(); > + g_jscConfig.fixedVMPoolExecutableAllocator = allocator; > + globalFixedVMPoolExecutableAllocatorToWorkAroundLeaks = allocator; You could just implement this as: g_jscConfig.fixedVMPoolExecutableAllocator = new FixedVMPoolExecutableAllocator(); globalFixedVMPoolExecutableAllocatorToWorkAroundLeaks = g_jscConfig.fixedVMPoolExecutableAllocator; That way, there's only a 1 line change that is easier to undo later. > Source/JavaScriptCore/jit/ExecutableAllocator.cpp:657 > - g_jscConfig.executableAllocator = new ExecutableAllocator; > + auto* allocator = new ExecutableAllocator; > + g_jscConfig.executableAllocator = allocator; > + globalExecutableAllocatorToWorkAroundLeaks = allocator; Ditto. 1591779 5 383915 ysuzuki 2019-11-19 16:55:57 -0800 Comment on attachment 383915 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383915&action=review >> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:425 >> + globalFixedVMPoolExecutableAllocatorToWorkAroundLeaks = allocator; > > You could just implement this as: > g_jscConfig.fixedVMPoolExecutableAllocator = new FixedVMPoolExecutableAllocator(); > globalFixedVMPoolExecutableAllocatorToWorkAroundLeaks = g_jscConfig.fixedVMPoolExecutableAllocator; > > That way, there's only a 1 line change that is easier to undo later. Nice, fixed. >> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:657 >> + globalExecutableAllocatorToWorkAroundLeaks = allocator; > > Ditto. Fixed. 1591780 6 ysuzuki 2019-11-19 16:56:55 -0800 Committed r252661: <https://trac.webkit.org/changeset/252661> 383915 2019-11-19 16:00:19 -0800 2019-11-19 16:04:01 -0800 Patch bug-204384-20191119160018.patch text/plain 3157 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNjQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi NGExNmVlYzMxNDQ4ODc5OTYwNDMxYWM4YTQ4NGUxZWQzMDBkNTFjLi5jNGE3YTFkNDU3MTVhMzA0 MmJhZGQwZWRiMGE0NjU5MDBjNTM5OTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOS0xMS0xOSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFdvcmstYXJvdW5kIExlYWtzJyBmYWxzZS1wb3NpdGl2ZSByZXBv cnQgYWJvdXQgbWVtb3J5IGxlYWtpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNDM4NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTY5NTA5MzI+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjb3Jk aW5nIHRvIHRoZSByYWRhciwgTGVha3Mgc3RhcnQgcmVwb3J0aW5nIGZhbHNlLXBvc2l0aXZlIG1l bW9yeSBsZWFrcyBhYm91dCBFeGVjdXRhYmxlQWxsb2NhdG9yIGFuZCBGaXhlZFZNUG9vbEV4ZWN1 dGFibGVBbGxvY2F0b3IsCisgICAgICAgIHdoaWxlIHRoZXkgYXJlIHBlci1wcm9jZXNzIHNpbmds ZXRvbiBhbmQgcmVhY2hhYmxlIHRocm91Z2ggZ19qc2NDb25maWcuIEknbSBndWVzc2luZyB0aGlz IGlzIGJlY2F1c2UgTGVha3Mgc3RhcnQgc2tpcHBpbmcgc2NhbiBmb3IKKyAgICAgICAgcmVhZG9u bHkgbWVtb3J5IHJlZ2lvbi4gKGdfanNjQ29uZmlnIGlzIG5vdyBtcHJvdGVjdGVkIHRvIHJlYWRv bmx5KS4KKworICAgICAgICBUbyB3b3JrLWFyb3VuZCB0aGlzLCB3ZSBhbmNob3IgdGhlc2UgaGVh cCBhbGxvY2F0ZWQgdGhpbmdzIHRvIGdsb2JhbCB2YXJpYWJsZXMgdG8gaGVscCBMZWFrcyBzY2Fu LiBPbmNlIGl0IGlzIGZpeGVkLCB3ZSBzaG91bGQgcmVtb3ZlIGl0LgorCisgICAgICAgICogaml0 L0V4ZWN1dGFibGVBbGxvY2F0b3IuY3BwOgorICAgICAgICAoSlNDOjpFeGVjdXRhYmxlQWxsb2Nh dG9yOjppbml0aWFsaXplVW5kZXJseWluZ0FsbG9jYXRvcik6CisgICAgICAgIChKU0M6OkV4ZWN1 dGFibGVBbGxvY2F0b3I6OmluaXRpYWxpemUpOgorCiAyMDE5LTExLTE4ICBNYXJrIExhbSAgPG1h cmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBBbHdheXMgZW5hYmxlIE9wdGlvbmFsPE9wdGlv bnNTdG9yYWdlOjpTaXplPiBwYXJzZShjb25zdCBjaGFyKiBzdHJpbmcpIGZvciBPUyhEQVJXSU4p LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2Nh dG9yLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5j cHAKaW5kZXggYTBkMjc3YTkyMmVhYzUxOTYzZWQzMTFkODRiODRjZjc0MzNmOGIwMC4uN2IwZDBm NDE1ZWJlYmU4ZmJmMTdiNzE4NDU5ZTBlMmUyZjQzYTkwOSAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuY3BwCkBAIC00MTQsMTAgKzQxNCwx NSBAQCBGaXhlZFZNUG9vbEV4ZWN1dGFibGVBbGxvY2F0b3I6On5GaXhlZFZNUG9vbEV4ZWN1dGFi bGVBbGxvY2F0b3IoKQogICAgIG1fcmVzZXJ2YXRpb24uZGVhbGxvY2F0ZSgpOwogfQogCisvLyBL ZWVwIHRoaXMgcG9pbnRlciBpbiBhIG11dGFibGUgZ2xvYmFsIHZhcmlhYmxlIHRvIGhlbHAgTGVh a3MgZmluZCBpdC4KKy8vIEJ1dCB3ZSBkbyBub3QgdXNlIHRoaXMgcG9pbnRlci4KK3N0YXRpYyBG aXhlZFZNUG9vbEV4ZWN1dGFibGVBbGxvY2F0b3IqIGdsb2JhbEZpeGVkVk1Qb29sRXhlY3V0YWJs ZUFsbG9jYXRvclRvV29ya0Fyb3VuZExlYWtzID0gbnVsbHB0cjsKIHZvaWQgRXhlY3V0YWJsZUFs bG9jYXRvcjo6aW5pdGlhbGl6ZVVuZGVybHlpbmdBbGxvY2F0b3IoKQogewogICAgIFJFTEVBU0Vf QVNTRVJUKCFnX2pzY0NvbmZpZy5maXhlZFZNUG9vbEV4ZWN1dGFibGVBbGxvY2F0b3IpOwotICAg IGdfanNjQ29uZmlnLmZpeGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9jYXRvciA9IG5ldyBGaXhlZFZN UG9vbEV4ZWN1dGFibGVBbGxvY2F0b3IoKTsKKyAgICBhdXRvKiBhbGxvY2F0b3IgPSBuZXcgRml4 ZWRWTVBvb2xFeGVjdXRhYmxlQWxsb2NhdG9yKCk7CisgICAgZ19qc2NDb25maWcuZml4ZWRWTVBv b2xFeGVjdXRhYmxlQWxsb2NhdG9yID0gYWxsb2NhdG9yOworICAgIGdsb2JhbEZpeGVkVk1Qb29s RXhlY3V0YWJsZUFsbG9jYXRvclRvV29ya0Fyb3VuZExlYWtzID0gYWxsb2NhdG9yOwogICAgIENv ZGVQcm9maWxpbmc6Om5vdGlmeUFsbG9jYXRvcihnX2pzY0NvbmZpZy5maXhlZFZNUG9vbEV4ZWN1 dGFibGVBbGxvY2F0b3IpOwogfQogCkBAIC02NDIsOSArNjQ3LDE0IEBAIHZvaWQgZHVtcEpJVE1l bW9yeShjb25zdCB2b2lkKiBkc3QsIGNvbnN0IHZvaWQqIHNyYywgc2l6ZV90IHNpemUpCiAKIG5h bWVzcGFjZSBKU0MgewogCisvLyBLZWVwIHRoaXMgcG9pbnRlciBpbiBhIG11dGFibGUgZ2xvYmFs IHZhcmlhYmxlIHRvIGhlbHAgTGVha3MgZmluZCBpdC4KKy8vIEJ1dCB3ZSBkbyBub3QgdXNlIHRo aXMgcG9pbnRlci4KK3N0YXRpYyBFeGVjdXRhYmxlQWxsb2NhdG9yKiBnbG9iYWxFeGVjdXRhYmxl QWxsb2NhdG9yVG9Xb3JrQXJvdW5kTGVha3MgPSBudWxscHRyOwogdm9pZCBFeGVjdXRhYmxlQWxs b2NhdG9yOjppbml0aWFsaXplKCkKIHsKLSAgICBnX2pzY0NvbmZpZy5leGVjdXRhYmxlQWxsb2Nh dG9yID0gbmV3IEV4ZWN1dGFibGVBbGxvY2F0b3I7CisgICAgYXV0byogYWxsb2NhdG9yID0gbmV3 IEV4ZWN1dGFibGVBbGxvY2F0b3I7CisgICAgZ19qc2NDb25maWcuZXhlY3V0YWJsZUFsbG9jYXRv ciA9IGFsbG9jYXRvcjsKKyAgICBnbG9iYWxFeGVjdXRhYmxlQWxsb2NhdG9yVG9Xb3JrQXJvdW5k TGVha3MgPSBhbGxvY2F0b3I7CiB9CiAKIEV4ZWN1dGFibGVBbGxvY2F0b3ImIEV4ZWN1dGFibGVB bGxvY2F0b3I6OnNpbmdsZXRvbigpCg==