204356 2019-11-19 09:04:07 -0800 [LFC][IFC] Display::Run:TextContext should use StringView 2019-11-19 12:00:37 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1591557 0 zalan 2019-11-19 09:04:07 -0800 instead of String (though this is temporary anyway) 1591558 1 webkit-bug-importer 2019-11-19 09:04:29 -0800 <rdar://problem/57323695> 1591561 2 383876 zalan 2019-11-19 09:09:47 -0800 Created attachment 383876 Patch 1591599 3 383876 commit-queue 2019-11-19 11:01:03 -0800 Comment on attachment 383876 Patch Rejecting attachment 383876 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: UBLIC_SUFFIX_LIST -DENABLE_REMOTE_INSPECTOR -DENABLE_RESIZE_OBSERVER -DENABLE_RESOURCE_LOAD_STATISTICS -DENABLE_RESOURCE_USAGE -DENABLE_RUBBER_BANDING -DENABLE_SANDBOX_EXTENSIONS -DENABLE_SERVER_PRECONNECT -DENABLE_SERVICE_CONTROLS -DENABLE_SERVICE_WORKER -DENABLE_SHAREABLE_RESOURCE -DENABLE_SPEECH_SYNTHESIS -DENABLE_STREAMS_API -DENABLE_SVG_FONTS -DENABLE_TELEPHONE_NUMBER_DETECTION -DENABLE_TEXT_AUTOSIZING -DENABLE_USERSELECT_ALL -DENABLE_USER_MESSAGE_HANDLERS -DENABLE_VARIATION_FONTS -DENABLE_VIDEO -DENABLE_VIDEO_PRESENTATION_MODE -DENABLE_VIDEO_TRACK -DENABLE_VIDEO_USES_ELEMENT_FULLSCREEN -DENABLE_WEBDRIVER_MOUSE_INTERACTIONS -DENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS -DENABLE_WEBGL -DENABLE_WEBGL2 -DENABLE_WEB_AUDIO -DENABLE_WEB_AUTHN -DENABLE_WEB_CRYPTO -DENABLE_WEB_RTC -DENABLE_WIRELESS_PLAYBACK_TARGET -DENABLE_XSLT -DBUILDING_WEBKIT -DU_DISABLE_RENAMING=1 -DU_SHOW_CPLUSPLUS_API=0 -DGL_SILENCE_DEPRECATION=1 -DGLES_SILENCE_DEPRECATION=1 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.13 -g -fvisibility=hidden -fvisibility-inlines-hidden -fno-threadsafe-statics -Wno-sign-conversion -Winfinite-recursion -Wmove -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wrange-loop-analysis -Wno-semicolon-before-method-body -iquote /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/WebCore-generated-files.hmap -I/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/WebCore-own-target-headers.hmap -I/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/WebCore-all-target-headers.hmap -iquote /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/WebCore-project-headers.hmap -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/include -IPAL -IForwardingHeaders -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/libxslt -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/libxml2 -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/WebKitAdditions -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/local/include/WebKitAdditions -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/webrtc -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/local/include/webrtc -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/webrtc/sdk/objc/Framework/Headers -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/local/include/webrtc/sdk/objc/Framework/Headers -I/Volumes/Data/EWS/WebKit/Source/WebCore -I/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/DerivedSources/x86_64 -I/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/DerivedSources -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wno-unknown-warning-option -F/Volumes/Data/EWS/WebKit/WebKitBuild/Release -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/PrivateFrameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks -isystem /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/System.framework/PrivateHeaders -include /Volumes/Data/EWS/WebKit/WebKitBuild/PrecompiledHeaders/WebCorePrefix-hesoptuqnbqggaewbsnjerkudzpe/WebCorePrefix.h -MMD -MT dependencies -MF /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource309.d --serialize-diagnostics /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource309.dia -c /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource309.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource309.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource187.o /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource187.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: https://webkit-queues.webkit.org/results/13267361 1591611 4 383887 zalan 2019-11-19 11:16:11 -0800 Created attachment 383887 Patch 1591628 5 383887 commit-queue 2019-11-19 12:00:35 -0800 Comment on attachment 383887 Patch Clearing flags on attachment: 383887 Committed r252640: <https://trac.webkit.org/changeset/252640> 1591629 6 commit-queue 2019-11-19 12:00:37 -0800 All reviewed patches have been landed. Closing bug. 383876 2019-11-19 09:09:47 -0800 2019-11-19 11:16:10 -0800 Patch bug-204356-20191119090927.patch text/plain 5735 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmM3NWQ5M2U5YWVkYmRi MWNiYjAyZjQ5MjFhZGQ0NGVlZGYwOWVhOS4uNmQ1OGQ3NTllYjZhYzYzMGQ1OTIwMDczZDk5ZjMy ZjFhNTdmOTkxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTExLTE5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBEaXNwbGF5 OjpSdW46VGV4dENvbnRleHQgc2hvdWxkIHVzZSBTdHJpbmdWaWV3CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQzNTYKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzU3MzIzNjk1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdlIGNvdWxkIGp1c3QgdXNlIFN0cmluZ1ZpZXcgaW5zdGVhZCBvZiBTdHJpbmcg aGVyZSAodGhvdWdoIHRoaXMgaXMgYWxsIHRlbXBvcmFyeSB1bnRpbCBXZSBmaWd1cmUgb3V0IHRo ZSByZWxhdGlvbnNoaXAKKyAgICAgICAgYmV0d2VlbiB0aGUgbGF5b3V0IGFuZCB0aGUgZGlzcGxh eSB0cmVlcyBlLmcuIGhvdyB0byByZWZlcmVuY2UgY29udGVudCBmcm9tIHRoZSBkaXNwbGF5IHRy ZWUpLiAKKworICAgICAgICAqIGxheW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5UnVuLmg6CisgICAg ICAgIChXZWJDb3JlOjpEaXNwbGF5OjpSdW46OlRleHRDb250ZXh0OjpUZXh0Q29udGV4dCk6Cisg ICAgICAgIChXZWJDb3JlOjpEaXNwbGF5OjpSdW46OlRleHRDb250ZXh0Ojpjb250ZW50IGNvbnN0 KToKKyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXk6OlJ1bjo6VGV4dENvbnRleHQ6OmV4cGFuZCk6 CisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmU6OlJ1bjo6ZXhwYW5kKToKKyAgICAgICAgKFdlYkNv cmU6OkxheW91dDo6TGluZTo6YXBwZW5kVGV4dENvbnRlbnQpOgorCiAyMDE5LTExLTE5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBBc3NpZ24g aW5saW5lQ2FwYWNpdHkgdG8gdmFyaW91cyBpbmxpbmUgcnVuIHZlY3RvcnMuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlzcGxheXRyZWUvRGlzcGxheVJ1bi5oIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2Rpc3BsYXl0cmVlL0Rpc3BsYXlSdW4uaAppbmRleCAwOTljNDgwMzRl YWFmYTg0MGNlMjAzNTA3ZmRlMWYzNDkxZTdkYThhLi4yMDI5MWM5YzRhNzEwZThlNTNmN2VmODI0 OGUxYjQ2ZjQyZmJiNTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlzcGxh eXRyZWUvRGlzcGxheVJ1bi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9kaXNwbGF5dHJl ZS9EaXNwbGF5UnVuLmgKQEAgLTQ0LDEyICs0NCwxMiBAQCBzdHJ1Y3QgUnVuIHsKICAgICAgICAg V1RGX01BS0VfU1RSVUNUX0ZBU1RfQUxMT0NBVEVEOwogICAgIHB1YmxpYzoKICAgICAgICAgc3Ry dWN0IEV4cGFuc2lvbkNvbnRleHQ7Ci0gICAgICAgIFRleHRDb250ZXh0KHVuc2lnbmVkIHBvc2l0 aW9uLCB1bnNpZ25lZCBsZW5ndGgsIFN0cmluZyBjb250ZW50LCBPcHRpb25hbDxFeHBhbnNpb25D b250ZXh0PiA9IHsgfSk7CisgICAgICAgIFRleHRDb250ZXh0KHVuc2lnbmVkIHBvc2l0aW9uLCB1 bnNpZ25lZCBsZW5ndGgsIFN0cmluZ1ZpZXcgY29udGVudCwgT3B0aW9uYWw8RXhwYW5zaW9uQ29u dGV4dD4gPSB7IH0pOwogCiAgICAgICAgIHVuc2lnbmVkIHN0YXJ0KCkgY29uc3QgeyByZXR1cm4g bV9zdGFydDsgfQogICAgICAgICB1bnNpZ25lZCBlbmQoKSBjb25zdCB7IHJldHVybiBzdGFydCgp ICsgbGVuZ3RoKCk7IH0KICAgICAgICAgdW5zaWduZWQgbGVuZ3RoKCkgY29uc3QgeyByZXR1cm4g bV9sZW5ndGg7IH0KLSAgICAgICAgU3RyaW5nIGNvbnRlbnQoKSBjb25zdCB7IHJldHVybiBtX2Nv bnRlbnQ7IH0KKyAgICAgICAgU3RyaW5nVmlldyBjb250ZW50KCkgY29uc3QgeyByZXR1cm4gbV9j b250ZW50OyB9CiAKICAgICAgICAgc3RydWN0IEV4cGFuc2lvbkNvbnRleHQgewogICAgICAgICAg ICAgRXhwYW5zaW9uQmVoYXZpb3IgYmVoYXZpb3I7CkBAIC01OCwxNCArNTgsMTQgQEAgc3RydWN0 IFJ1biB7CiAgICAgICAgIHZvaWQgc2V0RXhwYW5zaW9uKEV4cGFuc2lvbkNvbnRleHQgZXhwYW5z aW9uQ29udGV4dCkgeyBtX2V4cGFuc2lvbkNvbnRleHQgPSBleHBhbnNpb25Db250ZXh0OyB9CiAg ICAgICAgIE9wdGlvbmFsPEV4cGFuc2lvbkNvbnRleHQ+IGV4cGFuc2lvbigpIGNvbnN0IHsgcmV0 dXJuIG1fZXhwYW5zaW9uQ29udGV4dDsgfQogCi0gICAgICAgIHZvaWQgZXhwYW5kKGNvbnN0IFRl eHRDb250ZXh0JiBvdGhlcik7CisgICAgICAgIHZvaWQgZXhwYW5kKFN0cmluZ1ZpZXcsIHVuc2ln bmVkIGV4cGFuZGVkTGVuZ3RoKTsKIAogICAgIHByaXZhdGU6CiAgICAgICAgIHVuc2lnbmVkIG1f c3RhcnQgeyAwIH07CiAgICAgICAgIHVuc2lnbmVkIG1fbGVuZ3RoIHsgMCB9OwogICAgICAgICBP cHRpb25hbDxFeHBhbnNpb25Db250ZXh0PiBtX2V4cGFuc2lvbkNvbnRleHQ7CiAgICAgICAgIC8v IEZJWE1FOiBUaGlzIGlzIHRlbXBvcmFyeS4gV2Ugc2hvdWxkIGhhdmUgc29tZSBtYXBwaW5nIHNl dHVwIHRvIGlkZW50aWZ5IGFzc29jaWF0ZWQgdGV4dCBjb250ZW50IGluc3RlYWQuCi0gICAgICAg IFN0cmluZyBtX2NvbnRlbnQ7CisgICAgICAgIFN0cmluZ1ZpZXcgbV9jb250ZW50OwogICAgIH07 CiAKICAgICBSdW4oY29uc3QgUmVuZGVyU3R5bGUmLCBjb25zdCBSZWN0JiBsb2dpY2FsUmVjdCwg T3B0aW9uYWw8VGV4dENvbnRleHQ+ID0gV1RGOjpudWxsb3B0KTsKQEAgLTExNCw3ICsxMTQsNyBA QCBpbmxpbmUgUnVuOjpSdW4oY29uc3QgUmVuZGVyU3R5bGUmIHN0eWxlLCBjb25zdCBSZWN0JiBs b2dpY2FsUmVjdCwgT3B0aW9uYWw8VGV4dAogewogfQogCi1pbmxpbmUgUnVuOjpUZXh0Q29udGV4 dDo6VGV4dENvbnRleHQodW5zaWduZWQgc3RhcnQsIHVuc2lnbmVkIGxlbmd0aCwgU3RyaW5nIGNv bnRlbnQsIE9wdGlvbmFsPEV4cGFuc2lvbkNvbnRleHQ+IGV4cGFuc2lvbkNvbnRleHQpCitpbmxp bmUgUnVuOjpUZXh0Q29udGV4dDo6VGV4dENvbnRleHQodW5zaWduZWQgc3RhcnQsIHVuc2lnbmVk IGxlbmd0aCwgU3RyaW5nVmlldyBjb250ZW50LCBPcHRpb25hbDxFeHBhbnNpb25Db250ZXh0PiBl eHBhbnNpb25Db250ZXh0KQogICAgIDogbV9zdGFydChzdGFydCkKICAgICAsIG1fbGVuZ3RoKGxl bmd0aCkKICAgICAsIG1fZXhwYW5zaW9uQ29udGV4dChleHBhbnNpb25Db250ZXh0KQpAQCAtMTIy LDEwICsxMjIsMTAgQEAgaW5saW5lIFJ1bjo6VGV4dENvbnRleHQ6OlRleHRDb250ZXh0KHVuc2ln bmVkIHN0YXJ0LCB1bnNpZ25lZCBsZW5ndGgsIFN0cmluZyBjb24KIHsKIH0KIAotaW5saW5lIHZv aWQgUnVuOjpUZXh0Q29udGV4dDo6ZXhwYW5kKGNvbnN0IFRleHRDb250ZXh0JiBvdGhlcikKK2lu bGluZSB2b2lkIFJ1bjo6VGV4dENvbnRleHQ6OmV4cGFuZChTdHJpbmdWaWV3IHRleHQsIHVuc2ln bmVkIGV4cGFuZGVkTGVuZ3RoKQogewotICAgIG1fY29udGVudC5hcHBlbmQob3RoZXIuY29udGVu dCgpKTsKLSAgICBtX2xlbmd0aCArPSBvdGhlci5sZW5ndGgoKTsKKyAgICBtX2xlbmd0aCA9IGV4 cGFuZGVkTGVuZ3RoOworICAgIG1fY29udGVudCA9IHRleHQ7CiB9CiAKIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuY3BwIGIv U291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKaW5k ZXggY2Q3OTkyZGE5OTVlODk2MzcyYTkwNjM5ODlkNTEzMmMwNWVjYjNjMy4uMjFlODAxNzM5OTU4 MzhmZTg4M2QzNzNkZWE0YjgwMGJlYjMyNTc2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKQEAgLTEzMCw3ICsxMzAs OCBAQCB2b2lkIExpbmU6OlJ1bjo6ZXhwYW5kKGNvbnN0IElubGluZUl0ZW1SdW4mIG5leHRSdW4p CiAgICAgQVNTRVJUKCFpc0NvbGxhcHNlZFRvVmlzdWFsbHlFbXB0eSgpKTsKIAogICAgIG1fbG9n aWNhbFJlY3QuZXhwYW5kSG9yaXpvbnRhbGx5KG5leHRSdW4ubG9naWNhbFJlY3QoKS53aWR0aCgp KTsKLSAgICBtX3RleHRDb250ZXh0LT5leHBhbmQoKm5leHRSdW4udGV4dENvbnRleHQoKSk7Cisg ICAgYXV0byBleHBhbmRlZExlbmd0aCA9IG1fdGV4dENvbnRleHQtPmxlbmd0aCgpICsgbmV4dFJ1 bi50ZXh0Q29udGV4dCgpLT5sZW5ndGgoKTsKKyAgICBtX3RleHRDb250ZXh0LT5leHBhbmQoU3Ry aW5nVmlldyhtX2xheW91dEJveC50ZXh0Q29udGVudCgpKS5zdWJzdHJpbmcobV90ZXh0Q29udGV4 dC0+c3RhcnQoKSwgZXhwYW5kZWRMZW5ndGgpLCBleHBhbmRlZExlbmd0aCk7CiAKICAgICAvLyBG SVhNRTogVGhpcyBpcyBhIHZlcnkgc2ltcGxlIGV4cGFuc2lvbiBtZXJnZS4gV2Ugc2hvdWxkIGV2 ZW50dWFsbHkgc3dpdGNoIG92ZXIgdG8gRm9udENhc2NhZGU6OmV4cGFuc2lvbk9wcG9ydHVuaXR5 Q291bnQuIAogICAgIGlmIChoYXNFeHBhbnNpb25PcHBvcnR1bml0eSgpICYmIG5leHRSdW4uaGFz RXhwYW5zaW9uT3Bwb3J0dW5pdHkoKSkgewpAQCAtNTQ4LDggKzU0OSw3IEBAIHZvaWQgTGluZTo6 YXBwZW5kVGV4dENvbnRlbnQoY29uc3QgSW5saW5lVGV4dEl0ZW0mIGlubGluZUl0ZW0sIExheW91 dFVuaXQgbG9naWNhCiAgICAgYXV0byBjb2xsYXBzZWRSdW4gPSBpbmxpbmVJdGVtLmlzQ29sbGFw c2libGUoKSAmJiBpbmxpbmVJdGVtLmxlbmd0aCgpID4gMTsKICAgICBhdXRvIGNvbnRlbnRTdGFy dCA9IGlubGluZUl0ZW0uc3RhcnQoKTsKICAgICBhdXRvIGNvbnRlbnRMZW5ndGggPSAgY29sbGFw c2VkUnVuID8gMSA6IGlubGluZUl0ZW0ubGVuZ3RoKCk7Ci0gICAgYXV0byB0ZXh0Q29udGVudCA9 IGlubGluZUl0ZW0ubGF5b3V0Qm94KCkudGV4dENvbnRlbnQoKS5zdWJzdHJpbmcoY29udGVudFN0 YXJ0LCBjb250ZW50TGVuZ3RoKTsKLSAgICBhdXRvIGxpbmVSdW4gPSBtYWtlVW5pcXVlPElubGlu ZUl0ZW1SdW4+KGlubGluZUl0ZW0sIGxvZ2ljYWxSZWN0LCBEaXNwbGF5OjpSdW46OlRleHRDb250 ZXh0IHsgY29udGVudFN0YXJ0LCBjb250ZW50TGVuZ3RoLCB0ZXh0Q29udGVudCB9KTsKKyAgICBh dXRvIGxpbmVSdW4gPSBtYWtlVW5pcXVlPElubGluZUl0ZW1SdW4+KGlubGluZUl0ZW0sIGxvZ2lj YWxSZWN0LCBEaXNwbGF5OjpSdW46OlRleHRDb250ZXh0IHsgY29udGVudFN0YXJ0LCBjb250ZW50 TGVuZ3RoLCBTdHJpbmdWaWV3KGlubGluZUl0ZW0ubGF5b3V0Qm94KCkudGV4dENvbnRlbnQoKSku c3Vic3RyaW5nKGNvbnRlbnRTdGFydCwgY29udGVudExlbmd0aCkgfSk7CiAKICAgICBhdXRvIGNv bGxhcHNlc1RvWmVyb0FkdmFuY2VXaWR0aCA9IHdpbGxDb2xsYXBzZUNvbXBsZXRlbHkoKTsKICAg ICBpZiAoY29sbGFwc2VzVG9aZXJvQWR2YW5jZVdpZHRoKQo= 383887 2019-11-19 11:16:11 -0800 2019-11-19 12:00:35 -0800 Patch bug-204356-20191119111611.patch text/plain 5720 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODU2OGFjZTE5YjFhMTdh ZTU5MDdmMGE2MmUzMTFjODIyN2UyZjgwYy4uYjQ5ZGZkZjM1NjNmMmY5YTUzNmZkYzJhZjAwZDlh OWJlYmJlNzIxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTExLTE5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBEaXNwbGF5 OjpSdW46VGV4dENvbnRleHQgc2hvdWxkIHVzZSBTdHJpbmdWaWV3CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQzNTYKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzU3MzIzNjk1PgorCisgICAgICAgIFJldmlld2VkIGJ5IEFudHRpIEtvaXZpc3RvLgor CisgICAgICAgIFdlIGNvdWxkIGp1c3QgdXNlIFN0cmluZ1ZpZXcgaW5zdGVhZCBvZiBTdHJpbmcg aGVyZSAodGhvdWdoIHRoaXMgaXMgYWxsIHRlbXBvcmFyeSB1bnRpbCBXZSBmaWd1cmUgb3V0IHRo ZSByZWxhdGlvbnNoaXAKKyAgICAgICAgYmV0d2VlbiB0aGUgbGF5b3V0IGFuZCB0aGUgZGlzcGxh eSB0cmVlcyBlLmcuIGhvdyB0byByZWZlcmVuY2UgY29udGVudCBmcm9tIHRoZSBkaXNwbGF5IHRy ZWUpLiAKKworICAgICAgICAqIGxheW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5UnVuLmg6CisgICAg ICAgIChXZWJDb3JlOjpEaXNwbGF5OjpSdW46OlRleHRDb250ZXh0OjpUZXh0Q29udGV4dCk6Cisg ICAgICAgIChXZWJDb3JlOjpEaXNwbGF5OjpSdW46OlRleHRDb250ZXh0Ojpjb250ZW50IGNvbnN0 KToKKyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXk6OlJ1bjo6VGV4dENvbnRleHQ6OmV4cGFuZCk6 CisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmU6OlJ1bjo6ZXhwYW5kKToKKyAgICAgICAgKFdlYkNv cmU6OkxheW91dDo6TGluZTo6YXBwZW5kVGV4dENvbnRlbnQpOgorCiAyMDE5LTExLTE5ICBBbnR0 aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgQ1NTRGVmYXVs dFN0eWxlU2hlZXRzIHRvIFVzZXJBZ2VudFN0eWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvZGlzcGxheXRyZWUvRGlzcGxheVJ1bi5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2Rpc3BsYXl0cmVlL0Rpc3BsYXlSdW4uaAppbmRleCAwOTljNDgwMzRlYWFmYTg0MGNlMjAzNTA3 ZmRlMWYzNDkxZTdkYThhLi4yMDI5MWM5YzRhNzEwZThlNTNmN2VmODI0OGUxYjQ2ZjQyZmJiNTc4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlzcGxheXRyZWUvRGlzcGxheVJ1 bi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5UnVuLmgK QEAgLTQ0LDEyICs0NCwxMiBAQCBzdHJ1Y3QgUnVuIHsKICAgICAgICAgV1RGX01BS0VfU1RSVUNU X0ZBU1RfQUxMT0NBVEVEOwogICAgIHB1YmxpYzoKICAgICAgICAgc3RydWN0IEV4cGFuc2lvbkNv bnRleHQ7Ci0gICAgICAgIFRleHRDb250ZXh0KHVuc2lnbmVkIHBvc2l0aW9uLCB1bnNpZ25lZCBs ZW5ndGgsIFN0cmluZyBjb250ZW50LCBPcHRpb25hbDxFeHBhbnNpb25Db250ZXh0PiA9IHsgfSk7 CisgICAgICAgIFRleHRDb250ZXh0KHVuc2lnbmVkIHBvc2l0aW9uLCB1bnNpZ25lZCBsZW5ndGgs IFN0cmluZ1ZpZXcgY29udGVudCwgT3B0aW9uYWw8RXhwYW5zaW9uQ29udGV4dD4gPSB7IH0pOwog CiAgICAgICAgIHVuc2lnbmVkIHN0YXJ0KCkgY29uc3QgeyByZXR1cm4gbV9zdGFydDsgfQogICAg ICAgICB1bnNpZ25lZCBlbmQoKSBjb25zdCB7IHJldHVybiBzdGFydCgpICsgbGVuZ3RoKCk7IH0K ICAgICAgICAgdW5zaWduZWQgbGVuZ3RoKCkgY29uc3QgeyByZXR1cm4gbV9sZW5ndGg7IH0KLSAg ICAgICAgU3RyaW5nIGNvbnRlbnQoKSBjb25zdCB7IHJldHVybiBtX2NvbnRlbnQ7IH0KKyAgICAg ICAgU3RyaW5nVmlldyBjb250ZW50KCkgY29uc3QgeyByZXR1cm4gbV9jb250ZW50OyB9CiAKICAg ICAgICAgc3RydWN0IEV4cGFuc2lvbkNvbnRleHQgewogICAgICAgICAgICAgRXhwYW5zaW9uQmVo YXZpb3IgYmVoYXZpb3I7CkBAIC01OCwxNCArNTgsMTQgQEAgc3RydWN0IFJ1biB7CiAgICAgICAg IHZvaWQgc2V0RXhwYW5zaW9uKEV4cGFuc2lvbkNvbnRleHQgZXhwYW5zaW9uQ29udGV4dCkgeyBt X2V4cGFuc2lvbkNvbnRleHQgPSBleHBhbnNpb25Db250ZXh0OyB9CiAgICAgICAgIE9wdGlvbmFs PEV4cGFuc2lvbkNvbnRleHQ+IGV4cGFuc2lvbigpIGNvbnN0IHsgcmV0dXJuIG1fZXhwYW5zaW9u Q29udGV4dDsgfQogCi0gICAgICAgIHZvaWQgZXhwYW5kKGNvbnN0IFRleHRDb250ZXh0JiBvdGhl cik7CisgICAgICAgIHZvaWQgZXhwYW5kKFN0cmluZ1ZpZXcsIHVuc2lnbmVkIGV4cGFuZGVkTGVu Z3RoKTsKIAogICAgIHByaXZhdGU6CiAgICAgICAgIHVuc2lnbmVkIG1fc3RhcnQgeyAwIH07CiAg ICAgICAgIHVuc2lnbmVkIG1fbGVuZ3RoIHsgMCB9OwogICAgICAgICBPcHRpb25hbDxFeHBhbnNp b25Db250ZXh0PiBtX2V4cGFuc2lvbkNvbnRleHQ7CiAgICAgICAgIC8vIEZJWE1FOiBUaGlzIGlz IHRlbXBvcmFyeS4gV2Ugc2hvdWxkIGhhdmUgc29tZSBtYXBwaW5nIHNldHVwIHRvIGlkZW50aWZ5 IGFzc29jaWF0ZWQgdGV4dCBjb250ZW50IGluc3RlYWQuCi0gICAgICAgIFN0cmluZyBtX2NvbnRl bnQ7CisgICAgICAgIFN0cmluZ1ZpZXcgbV9jb250ZW50OwogICAgIH07CiAKICAgICBSdW4oY29u c3QgUmVuZGVyU3R5bGUmLCBjb25zdCBSZWN0JiBsb2dpY2FsUmVjdCwgT3B0aW9uYWw8VGV4dENv bnRleHQ+ID0gV1RGOjpudWxsb3B0KTsKQEAgLTExNCw3ICsxMTQsNyBAQCBpbmxpbmUgUnVuOjpS dW4oY29uc3QgUmVuZGVyU3R5bGUmIHN0eWxlLCBjb25zdCBSZWN0JiBsb2dpY2FsUmVjdCwgT3B0 aW9uYWw8VGV4dAogewogfQogCi1pbmxpbmUgUnVuOjpUZXh0Q29udGV4dDo6VGV4dENvbnRleHQo dW5zaWduZWQgc3RhcnQsIHVuc2lnbmVkIGxlbmd0aCwgU3RyaW5nIGNvbnRlbnQsIE9wdGlvbmFs PEV4cGFuc2lvbkNvbnRleHQ+IGV4cGFuc2lvbkNvbnRleHQpCitpbmxpbmUgUnVuOjpUZXh0Q29u dGV4dDo6VGV4dENvbnRleHQodW5zaWduZWQgc3RhcnQsIHVuc2lnbmVkIGxlbmd0aCwgU3RyaW5n VmlldyBjb250ZW50LCBPcHRpb25hbDxFeHBhbnNpb25Db250ZXh0PiBleHBhbnNpb25Db250ZXh0 KQogICAgIDogbV9zdGFydChzdGFydCkKICAgICAsIG1fbGVuZ3RoKGxlbmd0aCkKICAgICAsIG1f ZXhwYW5zaW9uQ29udGV4dChleHBhbnNpb25Db250ZXh0KQpAQCAtMTIyLDEwICsxMjIsMTAgQEAg aW5saW5lIFJ1bjo6VGV4dENvbnRleHQ6OlRleHRDb250ZXh0KHVuc2lnbmVkIHN0YXJ0LCB1bnNp Z25lZCBsZW5ndGgsIFN0cmluZyBjb24KIHsKIH0KIAotaW5saW5lIHZvaWQgUnVuOjpUZXh0Q29u dGV4dDo6ZXhwYW5kKGNvbnN0IFRleHRDb250ZXh0JiBvdGhlcikKK2lubGluZSB2b2lkIFJ1bjo6 VGV4dENvbnRleHQ6OmV4cGFuZChTdHJpbmdWaWV3IHRleHQsIHVuc2lnbmVkIGV4cGFuZGVkTGVu Z3RoKQogewotICAgIG1fY29udGVudC5hcHBlbmQob3RoZXIuY29udGVudCgpKTsKLSAgICBtX2xl bmd0aCArPSBvdGhlci5sZW5ndGgoKTsKKyAgICBtX2xlbmd0aCA9IGV4cGFuZGVkTGVuZ3RoOwor ICAgIG1fY29udGVudCA9IHRleHQ7CiB9CiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUv bGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKaW5kZXggZjdmOTU5NjBkNDVl MmQ0MzU3MjVhNzQwMGI5N2FjMDVlYjJiYzExMS4uNjg3NzNkMzNhODM1MjhjY2RmNzM2MjIxYTkx ZmQxNzZiYzBkNzk0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZv cm1hdHRpbmcvSW5saW5lTGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGlu ZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKQEAgLTEzMCw3ICsxMzAsOCBAQCB2b2lkIExpbmU6 OlJ1bjo6ZXhwYW5kKGNvbnN0IElubGluZUl0ZW1SdW4mIG5leHRSdW4pCiAgICAgQVNTRVJUKCFp c0NvbGxhcHNlZFRvVmlzdWFsbHlFbXB0eSgpKTsKIAogICAgIG1fbG9naWNhbFJlY3QuZXhwYW5k SG9yaXpvbnRhbGx5KG5leHRSdW4ubG9naWNhbFJlY3QoKS53aWR0aCgpKTsKLSAgICBtX3RleHRD b250ZXh0LT5leHBhbmQoKm5leHRSdW4udGV4dENvbnRleHQoKSk7CisgICAgYXV0byBleHBhbmRl ZExlbmd0aCA9IG1fdGV4dENvbnRleHQtPmxlbmd0aCgpICsgbmV4dFJ1bi50ZXh0Q29udGV4dCgp LT5sZW5ndGgoKTsKKyAgICBtX3RleHRDb250ZXh0LT5leHBhbmQoU3RyaW5nVmlldyhsYXlvdXRC b3goKS50ZXh0Q29udGVudCgpKS5zdWJzdHJpbmcobV90ZXh0Q29udGV4dC0+c3RhcnQoKSwgZXhw YW5kZWRMZW5ndGgpLCBleHBhbmRlZExlbmd0aCk7CiAKICAgICAvLyBGSVhNRTogVGhpcyBpcyBh IHZlcnkgc2ltcGxlIGV4cGFuc2lvbiBtZXJnZS4gV2Ugc2hvdWxkIGV2ZW50dWFsbHkgc3dpdGNo IG92ZXIgdG8gRm9udENhc2NhZGU6OmV4cGFuc2lvbk9wcG9ydHVuaXR5Q291bnQuIAogICAgIGlm IChoYXNFeHBhbnNpb25PcHBvcnR1bml0eSgpICYmIG5leHRSdW4uaGFzRXhwYW5zaW9uT3Bwb3J0 dW5pdHkoKSkgewpAQCAtNTQ4LDggKzU0OSw3IEBAIHZvaWQgTGluZTo6YXBwZW5kVGV4dENvbnRl bnQoY29uc3QgSW5saW5lVGV4dEl0ZW0mIGlubGluZUl0ZW0sIExheW91dFVuaXQgbG9naWNhCiAg ICAgYXV0byBjb2xsYXBzZWRSdW4gPSBpbmxpbmVJdGVtLmlzQ29sbGFwc2libGUoKSAmJiBpbmxp bmVJdGVtLmxlbmd0aCgpID4gMTsKICAgICBhdXRvIGNvbnRlbnRTdGFydCA9IGlubGluZUl0ZW0u c3RhcnQoKTsKICAgICBhdXRvIGNvbnRlbnRMZW5ndGggPSAgY29sbGFwc2VkUnVuID8gMSA6IGlu bGluZUl0ZW0ubGVuZ3RoKCk7Ci0gICAgYXV0byB0ZXh0Q29udGVudCA9IGlubGluZUl0ZW0ubGF5 b3V0Qm94KCkudGV4dENvbnRlbnQoKS5zdWJzdHJpbmcoY29udGVudFN0YXJ0LCBjb250ZW50TGVu Z3RoKTsKLSAgICBhdXRvIGxpbmVSdW4gPSBtYWtlVW5pcXVlPElubGluZUl0ZW1SdW4+KGlubGlu ZUl0ZW0sIGxvZ2ljYWxSZWN0LCBEaXNwbGF5OjpSdW46OlRleHRDb250ZXh0IHsgY29udGVudFN0 YXJ0LCBjb250ZW50TGVuZ3RoLCB0ZXh0Q29udGVudCB9KTsKKyAgICBhdXRvIGxpbmVSdW4gPSBt YWtlVW5pcXVlPElubGluZUl0ZW1SdW4+KGlubGluZUl0ZW0sIGxvZ2ljYWxSZWN0LCBEaXNwbGF5 OjpSdW46OlRleHRDb250ZXh0IHsgY29udGVudFN0YXJ0LCBjb250ZW50TGVuZ3RoLCBTdHJpbmdW aWV3KGlubGluZUl0ZW0ubGF5b3V0Qm94KCkudGV4dENvbnRlbnQoKSkuc3Vic3RyaW5nKGNvbnRl bnRTdGFydCwgY29udGVudExlbmd0aCkgfSk7CiAKICAgICBhdXRvIGNvbGxhcHNlc1RvWmVyb0Fk dmFuY2VXaWR0aCA9IHdpbGxDb2xsYXBzZUNvbXBsZXRlbHkoKTsKICAgICBpZiAoY29sbGFwc2Vz VG9aZXJvQWR2YW5jZVdpZHRoKQo=