204350 2019-11-19 04:10:26 -0800 [JSC] DisallowVMReentry and DeferGC should use WTF::ThreadSpecific instead of using WTF::threadSpecificKeyCreate directly 2019-11-19 18:11:18 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii don.olmstead ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1591492 0 fujii 2019-11-19 04:10:26 -0800 WTF provides two thread specific storages, ThreadSpecific and threadSpecificKeyCreate. Only DisallowVMReentry and DeferGC are using threadSpecificKeyCreate. WTF::ThreadSpecific should be used because it is a useful wrapper. 1591493 1 383860 fujii 2019-11-19 04:13:58 -0800 Created attachment 383860 Patch 1591681 2 383860 ysuzuki 2019-11-19 13:58:57 -0800 Comment on attachment 383860 Patch r=me 1591815 3 fujii 2019-11-19 18:10:05 -0800 Committed r252671: <https://trac.webkit.org/changeset/252671> 1591818 4 webkit-bug-importer 2019-11-19 18:11:18 -0800 <rdar://problem/57344999> 383860 2019-11-19 04:13:58 -0800 2019-11-19 13:58:57 -0800 Patch bug-204350-20191119211357.patch text/plain 5248 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi NGExNmVlYzMxNDQ4ODc5OTYwNDMxYWM4YTQ4NGUxZWQzMDBkNTFjLi4xNmU2ZGU1NDI3NjY1OWNh ZTYwNDAyOTMzN2Q5ZGYzOGMyMjM2ODBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxOS0xMS0xOSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBbSlNDXSBEaXNhbGxvd1ZNUmVlbnRyeSBhbmQgRGVmZXJHQyBz aG91bGQgdXNlIFdURjo6VGhyZWFkU3BlY2lmaWMgaW5zdGVhZCBvZiB1c2luZyBXVEY6OnRocmVh ZFNwZWNpZmljS2V5Q3JlYXRlIGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQzNTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXVEYgcHJvdmlkZXMgdHdvIHRocmVhZCBzcGVjaWZpYyBzdG9y YWdlcywgVGhyZWFkU3BlY2lmaWMgYW5kCisgICAgICAgIHRocmVhZFNwZWNpZmljS2V5Q3JlYXRl LiBPbmx5IERpc2FsbG93Vk1SZWVudHJ5IGFuZCBEZWZlckdDIGFyZQorICAgICAgICB1c2luZyB0 aGUgbGF0dGVyLiBXVEY6OlRocmVhZFNwZWNpZmljIHNob3VsZCBiZSB1c2VkIGJlY2F1c2UgaXQg aXMKKyAgICAgICAgYSB1c2VmdWwgdHlwZS1zYWZlIHdyYXBwZXIgY2xhc3MuCisKKyAgICAgICAg KiBoZWFwL0RlZmVyR0MuY3BwOgorICAgICAgICAqIGhlYXAvRGVmZXJHQy5oOgorICAgICAgICAo SlNDOjpEaXNhbGxvd0dDOjppbml0aWFsaXplKToKKyAgICAgICAgKEpTQzo6RGlzYWxsb3dHQzo6 c2NvcGVSZWVudHJ5Q291bnQpOgorICAgICAgICAoSlNDOjpEaXNhbGxvd0dDOjpzZXRTY29wZVJl ZW50cnlDb3VudCk6CisgICAgICAgICogcnVudGltZS9EaXNhbGxvd1ZNUmVlbnRyeS5jcHA6Cisg ICAgICAgICogcnVudGltZS9EaXNhbGxvd1ZNUmVlbnRyeS5oOgorICAgICAgICAoSlNDOjpEaXNh bGxvd1ZNUmVlbnRyeTo6aW5pdGlhbGl6ZSk6CisgICAgICAgIChKU0M6OkRpc2FsbG93Vk1SZWVu dHJ5OjpzY29wZVJlZW50cnlDb3VudCk6CisgICAgICAgIChKU0M6OkRpc2FsbG93Vk1SZWVudHJ5 OjpzZXRTY29wZVJlZW50cnlDb3VudCk6CisKIDIwMTktMTEtMTggIE1hcmsgTGFtICA8bWFyay5s YW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFsd2F5cyBlbmFibGUgT3B0aW9uYWw8T3B0aW9uc1N0 b3JhZ2U6OlNpemU+IHBhcnNlKGNvbnN0IGNoYXIqIHN0cmluZykgZm9yIE9TKERBUldJTikuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9EZWZlckdDLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0RlZmVyR0MuY3BwCmluZGV4IDExZTg5NDlkZjg2OGYyNjY2 MGMyMmUxNTc3MjQxYzI0ZTlkNTEyZTEuLmYyMjQ1NjExZmNmM2MzNGI1ZTVlYjM2MjkxMjNjN2Ix NjM2YzZmY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0RlZmVyR0Mu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0RlZmVyR0MuY3BwCkBAIC0zMSw3 ICszMSw3IEBACiBuYW1lc3BhY2UgSlNDIHsKIAogI2lmbmRlZiBOREVCVUcKLVdURjo6VGhyZWFk U3BlY2lmaWNLZXkgRGlzYWxsb3dHQzo6c19zY29wZVJlZW50cnlDb3VudCA9IDA7CitMYXp5TmV2 ZXJEZXN0cm95ZWQ8VGhyZWFkU3BlY2lmaWM8dW5zaWduZWQsIFdURjo6Q2FuQmVHQ1RocmVhZDo6 VHJ1ZT4+IERpc2FsbG93R0M6OnNfc2NvcGVSZWVudHJ5Q291bnQ7CiAjZW5kaWYKIAogfSAvLyBu YW1lc3BhY2UgSlNDCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9EZWZl ckdDLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9EZWZlckdDLmgKaW5kZXggY2EyOGUy NzcyMzg1MjM0NzQwNzJiYjU3OGNlZmJiYWE2OTU5Y2UwOS4uMjIzMTlmNTIwZDk1MWJhM2IyYTZk Yjk3Mjk4NDU2YjUzMGJhZmYzMiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvRGVmZXJHQy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0RlZmVyR0MuaApA QCAtMjcsNiArMjcsNyBAQAogCiAjaW5jbHVkZSAiRGlzYWxsb3dTY29wZS5oIgogI2luY2x1ZGUg IkhlYXAuaCIKKyNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KICNpbmNsdWRlIDx3dGYv VGhyZWFkU3BlY2lmaWMuaD4KIAogbmFtZXNwYWNlIEpTQyB7CkBAIC04OSwyMCArOTAsMjAgQEAg cHVibGljOgogCiAgICAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZSgpCiAgICAgewotICAgICAgICBX VEY6OnRocmVhZFNwZWNpZmljS2V5Q3JlYXRlKCZzX3Njb3BlUmVlbnRyeUNvdW50LCAwKTsKKyAg ICAgICAgc19zY29wZVJlZW50cnlDb3VudC5jb25zdHJ1Y3QoKTsKICAgICB9CiAKIHByaXZhdGU6 Ci0gICAgc3RhdGljIHVpbnRwdHJfdCBzY29wZVJlZW50cnlDb3VudCgpCisgICAgc3RhdGljIHVu c2lnbmVkIHNjb3BlUmVlbnRyeUNvdW50KCkKICAgICB7Ci0gICAgICAgIHJldHVybiByZWludGVy cHJldF9jYXN0PHVpbnRwdHJfdD4oV1RGOjp0aHJlYWRTcGVjaWZpY0dldChzX3Njb3BlUmVlbnRy eUNvdW50KSk7CisgICAgICAgIHJldHVybiAqc19zY29wZVJlZW50cnlDb3VudC5nZXQoKTsKICAg ICB9Ci0gICAgc3RhdGljIHZvaWQgc2V0U2NvcGVSZWVudHJ5Q291bnQodWludHB0cl90IHZhbHVl KQorICAgIHN0YXRpYyB2b2lkIHNldFNjb3BlUmVlbnRyeUNvdW50KHVuc2lnbmVkIHZhbHVlKQog ICAgIHsKLSAgICAgICAgV1RGOjp0aHJlYWRTcGVjaWZpY1NldChzX3Njb3BlUmVlbnRyeUNvdW50 LCByZWludGVycHJldF9jYXN0PHZvaWQqPih2YWx1ZSkpOworICAgICAgICAqc19zY29wZVJlZW50 cnlDb3VudC5nZXQoKSA9IHZhbHVlOwogICAgIH0KICAgICAKLSAgICBKU19FWFBPUlRfUFJJVkFU RSBzdGF0aWMgV1RGOjpUaHJlYWRTcGVjaWZpY0tleSBzX3Njb3BlUmVlbnRyeUNvdW50OworICAg IEpTX0VYUE9SVF9QUklWQVRFIHN0YXRpYyBMYXp5TmV2ZXJEZXN0cm95ZWQ8VGhyZWFkU3BlY2lm aWM8dW5zaWduZWQsIFdURjo6Q2FuQmVHQ1RocmVhZDo6VHJ1ZT4+IHNfc2NvcGVSZWVudHJ5Q291 bnQ7CiAKICNlbmRpZiAvLyBOREVCVUcKICAgICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0Rpc2FsbG93Vk1SZWVudHJ5LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0Rpc2FsbG93Vk1SZWVudHJ5LmNwcAppbmRleCA3MjhlMDljZTg4MGJjZDE4 YTQ3YmEzZDQyNjhmNzRiOGRiOGYyOGRhLi40ODllOTJjNzVmZjBiMWNmODI3YzIwM2Y5NTcxZjYx NDE2MjBjYTJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9EaXNh bGxvd1ZNUmVlbnRyeS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGlz YWxsb3dWTVJlZW50cnkuY3BwCkBAIC0zMSw3ICszMSw3IEBACiBuYW1lc3BhY2UgSlNDIHsKICAg ICAKICNpZm5kZWYgTkRFQlVHCi1XVEY6OlRocmVhZFNwZWNpZmljS2V5IERpc2FsbG93Vk1SZWVu dHJ5OjpzX3Njb3BlUmVlbnRyeUNvdW50ID0gMDsKK0xhenlOZXZlckRlc3Ryb3llZDxUaHJlYWRT cGVjaWZpYzx1bnNpZ25lZCwgV1RGOjpDYW5CZUdDVGhyZWFkOjpUcnVlPj4gRGlzYWxsb3dWTVJl ZW50cnk6OnNfc2NvcGVSZWVudHJ5Q291bnQ7CiAjZW5kaWYKICAgICAKIH0gLy8gbmFtZXNwYWNl IEpTQwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGlzYWxsb3dW TVJlZW50cnkuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Rpc2FsbG93Vk1SZWVu dHJ5LmgKaW5kZXggZWJlNWU3ZWM5Y2QzNTk0ODliNzEwMGYzZTc4NWU0NmI1ZTllMTZlZC4uMWI5 NWZiMWMxZTg3Zjc1MGYxMzhiOTFkMzVhMDNjOWQ5MTRiNjVjYyAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGlzYWxsb3dWTVJlZW50cnkuaAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9EaXNhbGxvd1ZNUmVlbnRyeS5oCkBAIC0yNiw2ICsyNiw3 IEBACiAjcHJhZ21hIG9uY2UKIAogI2luY2x1ZGUgIkRpc2FsbG93U2NvcGUuaCIKKyNpbmNsdWRl IDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KICNpbmNsdWRlIDx3dGYvVGhyZWFkU3BlY2lmaWMuaD4K IAogbmFtZXNwYWNlIEpTQyB7CkBAIC00NywyMCArNDgsMjAgQEAgcHVibGljOgogCiAgICAgc3Rh dGljIHZvaWQgaW5pdGlhbGl6ZSgpCiAgICAgewotICAgICAgICBXVEY6OnRocmVhZFNwZWNpZmlj S2V5Q3JlYXRlKCZzX3Njb3BlUmVlbnRyeUNvdW50LCAwKTsKKyAgICAgICAgc19zY29wZVJlZW50 cnlDb3VudC5jb25zdHJ1Y3QoKTsKICAgICB9CiAKIHByaXZhdGU6Ci0gICAgc3RhdGljIHVpbnRw dHJfdCBzY29wZVJlZW50cnlDb3VudCgpCisgICAgc3RhdGljIHVuc2lnbmVkIHNjb3BlUmVlbnRy eUNvdW50KCkKICAgICB7Ci0gICAgICAgIHJldHVybiByZWludGVycHJldF9jYXN0PHVpbnRwdHJf dD4oV1RGOjp0aHJlYWRTcGVjaWZpY0dldChzX3Njb3BlUmVlbnRyeUNvdW50KSk7CisgICAgICAg IHJldHVybiAqc19zY29wZVJlZW50cnlDb3VudC5nZXQoKTsKICAgICB9Ci0gICAgc3RhdGljIHZv aWQgc2V0U2NvcGVSZWVudHJ5Q291bnQodWludHB0cl90IHZhbHVlKQorICAgIHN0YXRpYyB2b2lk IHNldFNjb3BlUmVlbnRyeUNvdW50KHVuc2lnbmVkIHZhbHVlKQogICAgIHsKLSAgICAgICAgV1RG Ojp0aHJlYWRTcGVjaWZpY1NldChzX3Njb3BlUmVlbnRyeUNvdW50LCByZWludGVycHJldF9jYXN0 PHZvaWQqPih2YWx1ZSkpOworICAgICAgICAqc19zY29wZVJlZW50cnlDb3VudC5nZXQoKSA9IHZh bHVlOwogICAgIH0KIAotICAgIEpTX0VYUE9SVF9QUklWQVRFIHN0YXRpYyBXVEY6OlRocmVhZFNw ZWNpZmljS2V5IHNfc2NvcGVSZWVudHJ5Q291bnQ7CisgICAgSlNfRVhQT1JUX1BSSVZBVEUgc3Rh dGljIExhenlOZXZlckRlc3Ryb3llZDxUaHJlYWRTcGVjaWZpYzx1bnNpZ25lZCwgV1RGOjpDYW5C ZUdDVGhyZWFkOjpUcnVlPj4gc19zY29wZVJlZW50cnlDb3VudDsKIAogI2VuZGlmIC8vIE5ERUJV RwogCg==