204333 2019-11-18 17:18:37 -0800 Always enable Optional<OptionsStorage::Size> parse(const char* string) for OS(DARWIN). 2019-11-18 18:50:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller krollin msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1591344 0 mark.lam 2019-11-18 17:18:37 -0800 <rdar://problem/57303785> 1591350 1 383815 mark.lam 2019-11-18 17:24:40 -0800 Created attachment 383815 proposed patch. Let's try this on the EWS. 1591366 2 mark.lam 2019-11-18 17:36:38 -0800 Sadly, it looks the static_assert trick does not solve this problem. I'll investigate alternate solutions. 1591397 3 383832 mark.lam 2019-11-18 18:30:54 -0800 Created attachment 383832 proposed patch. 1591402 4 383832 ysuzuki 2019-11-18 18:39:44 -0800 Comment on attachment 383832 proposed patch. r=me. BTW, how about replacing size_t with uint64_t (or uint32_t) completely? 1591403 5 mark.lam 2019-11-18 18:43:57 -0800 Thanks for the reviewer. (In reply to Yusuke Suzuki from comment #4) > Comment on attachment 383832 [details] > proposed patch. > > r=me. BTW, how about replacing size_t with uint64_t (or uint32_t) completely? I kinda like it as it is because it's clearer this way that the parse() functions map to each option storage type. 1591405 6 mark.lam 2019-11-18 18:49:17 -0800 Landed in r252618: <http://trac.webkit.org/r252618>. 383815 2019-11-18 17:24:40 -0800 2019-11-18 18:30:54 -0800 proposed patch. bug-204333.patch text/plain 1866 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUyNjEzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE5LTExLTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBF bmFibGUgT3B0aW9uYWw8T3B0aW9uc1N0b3JhZ2U6OlNpemU+IHBhcnNlKGNvbnN0IGNoYXIqIHN0 cmluZykgd2hlbiAhc3RkOjppc19zYW1lPE9wdGlvbnNTdG9yYWdlOjpTaXplLCBPcHRpb25zU3Rv cmFnZTo6VW5zaWduZWQ+Ojp2YWx1ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNDMzMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTczMDM3ODU+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UnbGwg dXNlIGEgc3RhdGljX2Fzc2VydCBpbiB0aGUgdGVtcGxhdGUgdG8gZW5hYmxlIHRoZSBPcHRpb25z U3RvcmFnZTo6U2l6ZQorICAgICAgICB2ZXJzaW9uIG9mIHRoZSBvcHRpb25zIHBhcnNlKCkgZnVu Y3Rpb24gaWYgdGhlIGNvbXBpbGVyIGRvZXMgbm90IGNvbnNpZGVyCisgICAgICAgIE9wdGlvbnNT dG9yYWdlOjpTaXplIGFuZCBPcHRpb25zU3RvcmFnZTo6VW5zaWduZWQgdG8gYmUgdGhlIHNhbWUg dHlwZS4KKworICAgICAgICBPbiBzb21lIHBsYXRmb3JtcyAvIHRvb2xjaGFpbnMsIE9wdGlvbnNT dG9yYWdlOjpTaXplIGFuZCBPcHRpb25zU3RvcmFnZTo6VW5zaWduZWQKKyAgICAgICAgYXJlIG5v dCBjb25zaWRlcmVkIHRvIGJlIHRoZSBzYW1lIHR5cGUgZXZlbiB3aGVuIHRoZWlyIHNpemVzIGFy ZSB0aGUgc2FtZS4KKworICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5jcHA6CisgICAgICAgIChK U0M6OnBhcnNlKToKKwogMjAxOS0xMS0xOCAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5j b20+CiAKICAgICAgICAgTW92ZSBqc2MgZnJvbSBSZXNvdXJjZXMgdG8gSGVscGVycwpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAJKHJldmlzaW9uIDI1MjYw NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC04OCwxNiArODgsMTUgQEAgT3B0aW9uYWw8T3B0aW9uc1N0b3JhZ2U6OlVuc2ln bmVkPiBwYXJzZQogICAgIHJldHVybiBXVEY6Om51bGxvcHQ7CiB9CiAKLSNpZiBDUFUoQUREUkVT UzY0KQogdGVtcGxhdGU8PgogT3B0aW9uYWw8T3B0aW9uc1N0b3JhZ2U6OlNpemU+IHBhcnNlKGNv bnN0IGNoYXIqIHN0cmluZykKIHsKKyAgICBzdGF0aWNfYXNzZXJ0KCFzdGQ6OmlzX3NhbWU8T3B0 aW9uc1N0b3JhZ2U6OlNpemUsIE9wdGlvbnNTdG9yYWdlOjpVbnNpZ25lZD46OnZhbHVlKTsKICAg ICBzaXplX3QgdmFsdWU7CiAgICAgaWYgKHNzY2FuZihzdHJpbmcsICIlenUiLCAmdmFsdWUpID09 IDEpCiAgICAgICAgIHJldHVybiB2YWx1ZTsKICAgICByZXR1cm4gV1RGOjpudWxsb3B0OwogfQot I2VuZGlmIC8vIENQVShBRERSRVNTNjQpCiAKIHRlbXBsYXRlPD4KIE9wdGlvbmFsPE9wdGlvbnNT dG9yYWdlOjpEb3VibGU+IHBhcnNlKGNvbnN0IGNoYXIqIHN0cmluZykK 383832 2019-11-18 18:30:54 -0800 2019-11-18 18:39:44 -0800 proposed patch. bug-204333.patch text/plain 1592 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUyNjEzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE5LTExLTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB bHdheXMgZW5hYmxlIE9wdGlvbmFsPE9wdGlvbnNTdG9yYWdlOjpTaXplPiBwYXJzZShjb25zdCBj aGFyKiBzdHJpbmcpIGZvciBPUyhEQVJXSU4pLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MzMzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NzMw Mzc4NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBP biBPUyhEQVJXSU4pLCB0aGUgY29tcGlsZXIgZG9lcyBub3QgY29uc2lkZXIgc2l6ZV90IGFuZCB1 bnNpZ25lZCB0byBiZSB0aGUgc2FtZQorICAgICAgICB0eXBlLCBldmVuIGZvciAzMi1iaXQgdGFy Z2V0cy4gIEhlbmNlLCB3ZSBuZWVkIHRoZSBzaXplX3QgdmVyc2lvbiBvZiB0aGUgZnVuY3Rpb24K KyAgICAgICAgaW4gYWRkaXRpb24gdG8gdGhlIHVuc2lnbmVkIHZlcnNpb24uCisKKyAgICAgICAg KiBydW50aW1lL09wdGlvbnMuY3BwOgorICAgICAgICAoSlNDOjpwYXJzZSk6CisKIDIwMTktMTEt MTggIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUganNj IGZyb20gUmVzb3VyY2VzIHRvIEhlbHBlcnMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL09wdGlvbnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL09wdGlvbnMuY3BwCShyZXZpc2lvbiAyNTI2MDUpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9PcHRpb25zLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODgsNyArODgsNyBA QCBPcHRpb25hbDxPcHRpb25zU3RvcmFnZTo6VW5zaWduZWQ+IHBhcnNlCiAgICAgcmV0dXJuIFdU Rjo6bnVsbG9wdDsKIH0KIAotI2lmIENQVShBRERSRVNTNjQpCisjaWYgQ1BVKEFERFJFU1M2NCkg fHwgT1MoREFSV0lOKQogdGVtcGxhdGU8PgogT3B0aW9uYWw8T3B0aW9uc1N0b3JhZ2U6OlNpemU+ IHBhcnNlKGNvbnN0IGNoYXIqIHN0cmluZykKIHsKQEAgLTk3LDcgKzk3LDcgQEAgT3B0aW9uYWw8 T3B0aW9uc1N0b3JhZ2U6OlNpemU+IHBhcnNlKGNvbgogICAgICAgICByZXR1cm4gdmFsdWU7CiAg ICAgcmV0dXJuIFdURjo6bnVsbG9wdDsKIH0KLSNlbmRpZiAvLyBDUFUoQUREUkVTUzY0KQorI2Vu ZGlmIC8vIENQVShBRERSRVNTNjQpIHx8IE9TKERBUldJTikKIAogdGVtcGxhdGU8PgogT3B0aW9u YWw8T3B0aW9uc1N0b3JhZ2U6OkRvdWJsZT4gcGFyc2UoY29uc3QgY2hhciogc3RyaW5nKQo=