204326 2019-11-18 15:24:45 -0800 Fix load<16> on ARM64 2019-11-20 12:07:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=202832 InRadar P2 Normal --- 1 rmorisset rmorisset commit-queue ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1591277 0 rmorisset 2019-11-18 15:24:45 -0800 It was introduced in https://bugs.webkit.org/show_bug.cgi?id=202832, and Daniel Bates notified me of a bug in it. More precisely, it calls ldr<16>, which calls CHECK_DATASIZE which in turns does an ASSERT(16 == 32 || 16 == 64); I am still trying to see if I can just remove the assert (which looks plain wrong), or if there is a more serious problem here. <rdar://problem/57297184> REGRESSION (r252422) CHECK_DATASIZE() fails loading docs.google.com 1591303 1 383802 rmorisset 2019-11-18 16:13:18 -0800 Created attachment 383802 Patch 1591307 2 383803 rmorisset 2019-11-18 16:21:36 -0800 Created attachment 383803 Patch 1591309 3 383805 rmorisset 2019-11-18 16:29:38 -0800 Created attachment 383805 Patch 1591317 4 383805 mark.lam 2019-11-18 16:46:13 -0800 Comment on attachment 383805 Patch r=me 1592092 5 383805 commit-queue 2019-11-20 12:06:59 -0800 Comment on attachment 383805 Patch Clearing flags on attachment: 383805 Committed r252699: <https://trac.webkit.org/changeset/252699> 1592093 6 commit-queue 2019-11-20 12:07:01 -0800 All reviewed patches have been landed. Closing bug. 1592096 7 webkit-bug-importer 2019-11-20 12:07:21 -0800 <rdar://problem/57368165> 383802 2019-11-18 16:13:18 -0800 2019-11-18 16:21:36 -0800 Patch patch204326 text/plain 1768 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDVlM2U1M2NjYTIyLi5hOTY1MDhkNmE0NCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMTEtMTggIFJvYmlu IE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggbG9hZDwxNj4g b24gQVJNNjQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwNDMyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE9uIEFSTTY0IEkgdXNlZCBsb2FkPDE2PiBpbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjAyODMyLgorICAgICAgICBVbmZvcnR1bmF0ZWx5IGl0IHR1cm5zIG91dCB0 byBjYWxsIGxkcjwxNj4sIGFuZCBsZHI8bj4gYXNzZXJ0cyB0aGF0IG4gaXMgZWl0aGVyIDMyIG9y IDY0LgorICAgICAgICBUaGlzIGZpeCBzaW1wbHkgY2FsbHMgbGRyaC9zdHJoIGRpcmVjdGx5Lgor CisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaDoKKyAgICAgICAgKEpT Qzo6TWFjcm9Bc3NlbWJsZXJBUk02NDo6bG9hZDE2KToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3Nl bWJsZXJBUk02NDo6c3RvcmUxNik6CisKIDIwMTktMTEtMTMgIFJvYmluIE1vcmlzc2V0ICA8cm1v cmlzc2V0QGFwcGxlLmNvbT4KIAogICAgICAgICBbRVNOZXh0XVtCaWdJbnRdIEFkZCBzdXBwb3J0 IGZvciBvcF9pbmMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv TWFjcm9Bc3NlbWJsZXJBUk02NC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlckFSTTY0LmgKaW5kZXggMjA2OTBlNDE0MjUuLmM2NmZmMGZlMjExIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJN NjQuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy QVJNNjQuaApAQCAtMTI1NCw3ICsxMjU0LDggQEAgcHVibGljOgogCiAgICAgdm9pZCBsb2FkMTYo Y29uc3Qgdm9pZCogYWRkcmVzcywgUmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKLSAgICAgICAgbG9h ZDwxNj4oYWRkcmVzcywgZGVzdCk7CisgICAgICAgIG1vdmUoVHJ1c3RlZEltbVB0cihhZGRyZXNz KSwgZGF0YVRlbXBSZWdpc3Rlcik7CisgICAgICAgIG1fYXNzZW1ibGVyLmxkcmgoZGVzdCwgZGF0 YVRlbXBSZWdpc3RlciwgMCk7CiAgICAgfQogCiAgICAgdm9pZCBsb2FkMTZVbmFsaWduZWQoSW1w bGljaXRBZGRyZXNzIGFkZHJlc3MsIFJlZ2lzdGVySUQgZGVzdCkKQEAgLTE1NjcsNyArMTU2OCw4 IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc3RvcmUxNihSZWdpc3RlcklEIHNyYywgY29uc3Qgdm9p ZCogYWRkcmVzcykKICAgICB7Ci0gICAgICAgIHN0b3JlPDE2PihzcmMsIGFkZHJlc3MpOworICAg ICAgICBtb3ZlKFRydXN0ZWRJbW1QdHIoYWRkcmVzcyksIGRhdGFUZW1wUmVnaXN0ZXIpOworICAg ICAgICBtX2Fzc2VtYmxlci5zdHJoKHNyYywgZGF0YVRlbXBSZWdpc3RlciwgMCk7CiAgICAgfQog CiAgICAgdm9pZCBzdG9yZTE2KFRydXN0ZWRJbW0zMiBpbW0sIGNvbnN0IHZvaWQqIGFkZHJlc3Mp Cg== 383803 2019-11-18 16:21:36 -0800 2019-11-18 16:29:38 -0800 Patch patch204326 text/plain 1828 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDVlM2U1M2NjYTIyLi5hOTY1MDhkNmE0NCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMTEtMTggIFJvYmlu IE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggbG9hZDwxNj4g b24gQVJNNjQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwNDMyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE9uIEFSTTY0IEkgdXNlZCBsb2FkPDE2PiBpbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjAyODMyLgorICAgICAgICBVbmZvcnR1bmF0ZWx5IGl0IHR1cm5zIG91dCB0 byBjYWxsIGxkcjwxNj4sIGFuZCBsZHI8bj4gYXNzZXJ0cyB0aGF0IG4gaXMgZWl0aGVyIDMyIG9y IDY0LgorICAgICAgICBUaGlzIGZpeCBzaW1wbHkgY2FsbHMgbGRyaC9zdHJoIGRpcmVjdGx5Lgor CisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaDoKKyAgICAgICAgKEpT Qzo6TWFjcm9Bc3NlbWJsZXJBUk02NDo6bG9hZDE2KToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3Nl bWJsZXJBUk02NDo6c3RvcmUxNik6CisKIDIwMTktMTEtMTMgIFJvYmluIE1vcmlzc2V0ICA8cm1v cmlzc2V0QGFwcGxlLmNvbT4KIAogICAgICAgICBbRVNOZXh0XVtCaWdJbnRdIEFkZCBzdXBwb3J0 IGZvciBvcF9pbmMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv TWFjcm9Bc3NlbWJsZXJBUk02NC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlckFSTTY0LmgKaW5kZXggMjA2OTBlNDE0MjUuLmJiZTVjNjYwZDExIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJN NjQuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy QVJNNjQuaApAQCAtMTI1NCw3ICsxMjU0LDggQEAgcHVibGljOgogCiAgICAgdm9pZCBsb2FkMTYo Y29uc3Qgdm9pZCogYWRkcmVzcywgUmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKLSAgICAgICAgbG9h ZDwxNj4oYWRkcmVzcywgZGVzdCk7CisgICAgICAgIG1vdmUoVHJ1c3RlZEltbVB0cihhZGRyZXNz KSwgZ2V0Q2FjaGVkTWVtb3J5VGVtcFJlZ2lzdGVySURBbmRJbnZhbGlkYXRlKCkpOworICAgICAg ICBtX2Fzc2VtYmxlci5sZHJoKGRlc3QsIG1lbW9yeVRlbXBSZWdpc3RlciwgMCk7CiAgICAgfQog CiAgICAgdm9pZCBsb2FkMTZVbmFsaWduZWQoSW1wbGljaXRBZGRyZXNzIGFkZHJlc3MsIFJlZ2lz dGVySUQgZGVzdCkKQEAgLTE1NjcsNyArMTU2OCw4IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc3Rv cmUxNihSZWdpc3RlcklEIHNyYywgY29uc3Qgdm9pZCogYWRkcmVzcykKICAgICB7Ci0gICAgICAg IHN0b3JlPDE2PihzcmMsIGFkZHJlc3MpOworICAgICAgICBtb3ZlKFRydXN0ZWRJbW1QdHIoYWRk cmVzcyksIGdldENhY2hlZE1lbW9yeVRlbXBSZWdpc3RlcklEQW5kSW52YWxpZGF0ZSgpKTsKKyAg ICAgICAgbV9hc3NlbWJsZXIuc3RyaChzcmMsIG1lbW9yeVRlbXBSZWdpc3RlciwgMCk7CiAgICAg fQogCiAgICAgdm9pZCBzdG9yZTE2KFRydXN0ZWRJbW0zMiBpbW0sIGNvbnN0IHZvaWQqIGFkZHJl c3MpCg== 383805 2019-11-18 16:29:38 -0800 2019-11-20 12:06:59 -0800 Patch patch204326 text/plain 1814 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDVlM2U1M2NjYTIyLi5hOTY1MDhkNmE0NCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMTEtMTggIFJvYmlu IE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggbG9hZDwxNj4g b24gQVJNNjQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwNDMyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE9uIEFSTTY0IEkgdXNlZCBsb2FkPDE2PiBpbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjAyODMyLgorICAgICAgICBVbmZvcnR1bmF0ZWx5IGl0IHR1cm5zIG91dCB0 byBjYWxsIGxkcjwxNj4sIGFuZCBsZHI8bj4gYXNzZXJ0cyB0aGF0IG4gaXMgZWl0aGVyIDMyIG9y IDY0LgorICAgICAgICBUaGlzIGZpeCBzaW1wbHkgY2FsbHMgbGRyaC9zdHJoIGRpcmVjdGx5Lgor CisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaDoKKyAgICAgICAgKEpT Qzo6TWFjcm9Bc3NlbWJsZXJBUk02NDo6bG9hZDE2KToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3Nl bWJsZXJBUk02NDo6c3RvcmUxNik6CisKIDIwMTktMTEtMTMgIFJvYmluIE1vcmlzc2V0ICA8cm1v cmlzc2V0QGFwcGxlLmNvbT4KIAogICAgICAgICBbRVNOZXh0XVtCaWdJbnRdIEFkZCBzdXBwb3J0 IGZvciBvcF9pbmMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv TWFjcm9Bc3NlbWJsZXJBUk02NC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlckFSTTY0LmgKaW5kZXggMjA2OTBlNDE0MjUuLmRiZmYyZDcxNzYxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJN NjQuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy QVJNNjQuaApAQCAtMTI1NCw3ICsxMjU0LDggQEAgcHVibGljOgogCiAgICAgdm9pZCBsb2FkMTYo Y29uc3Qgdm9pZCogYWRkcmVzcywgUmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKLSAgICAgICAgbG9h ZDwxNj4oYWRkcmVzcywgZGVzdCk7CisgICAgICAgIG1vdmVUb0NhY2hlZFJlZyhUcnVzdGVkSW1t UHRyKGFkZHJlc3MpLCBjYWNoZWRNZW1vcnlUZW1wUmVnaXN0ZXIoKSk7CisgICAgICAgIG1fYXNz ZW1ibGVyLmxkcmgoZGVzdCwgbWVtb3J5VGVtcFJlZ2lzdGVyLCAwKTsKICAgICB9CiAKICAgICB2 b2lkIGxvYWQxNlVuYWxpZ25lZChJbXBsaWNpdEFkZHJlc3MgYWRkcmVzcywgUmVnaXN0ZXJJRCBk ZXN0KQpAQCAtMTU2Nyw3ICsxNTY4LDggQEAgcHVibGljOgogCiAgICAgdm9pZCBzdG9yZTE2KFJl Z2lzdGVySUQgc3JjLCBjb25zdCB2b2lkKiBhZGRyZXNzKQogICAgIHsKLSAgICAgICAgc3RvcmU8 MTY+KHNyYywgYWRkcmVzcyk7CisgICAgICAgIG1vdmVUb0NhY2hlZFJlZyhUcnVzdGVkSW1tUHRy KGFkZHJlc3MpLCBjYWNoZWRNZW1vcnlUZW1wUmVnaXN0ZXIoKSk7CisgICAgICAgIG1fYXNzZW1i bGVyLnN0cmgoc3JjLCBtZW1vcnlUZW1wUmVnaXN0ZXIsIDApOwogICAgIH0KIAogICAgIHZvaWQg c3RvcmUxNihUcnVzdGVkSW1tMzIgaW1tLCBjb25zdCB2b2lkKiBhZGRyZXNzKQo=