204315 2019-11-18 13:34:43 -0800 results.webkit.org: Uncollapsed failures shouldn't include runs with no failures 2019-11-18 16:54:21 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue webkit-bug-importer oldest_to_newest 1591215 0 jbedard 2019-11-18 13:34:43 -0800 If a test run does not contain failures, when the user requests uncollapsed failures, we still include references to test runs with no failures. 1591218 1 383785 jbedard 2019-11-18 13:42:59 -0800 Created attachment 383785 Patch 1591221 2 jbedard 2019-11-18 13:45:01 -0800 Looking to avoid something like this: https://results.webkit.org/api/failures/webkitpy-tests?id=252557&collapsed=False 1591293 3 383785 aakash_jain 2019-11-18 15:57:28 -0800 Comment on attachment 383785 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383785&action=review rs=me > Tools/resultsdbpy/resultsdbpy/model/failure_context.py:190 > + if len(unpacked) > 2: why 2? should we add a comment here indicating significance of 2 here. 1591301 4 383801 jbedard 2019-11-18 16:09:31 -0800 Created attachment 383801 Patch for landing 1591302 5 383785 jbedard 2019-11-18 16:09:59 -0800 Comment on attachment 383785 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383785&action=review >> Tools/resultsdbpy/resultsdbpy/model/failure_context.py:190 >> + if len(unpacked) > 2: > > why 2? should we add a comment here indicating significance of 2 here. Because our unpacked objects will always contain the keys uuid and start_time, even if there are no tests. 1591323 6 383801 commit-queue 2019-11-18 16:53:10 -0800 Comment on attachment 383801 Patch for landing Clearing flags on attachment: 383801 Committed r252606: <https://trac.webkit.org/changeset/252606> 1591324 7 commit-queue 2019-11-18 16:53:12 -0800 All reviewed patches have been landed. Closing bug. 1591325 8 webkit-bug-importer 2019-11-18 16:54:21 -0800 <rdar://problem/57304858> 383785 2019-11-18 13:42:59 -0800 2019-11-18 16:09:28 -0800 Patch bug-204315-20191118134258.patch text/plain 3044 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MjU2MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTExLTE4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IFVuY29sbGFwc2VkIGZhaWx1cmVzIHNo b3VsZG4ndCBpbmNsdWRlIHJ1bnMgd2l0aCBubyBmYWlsdXJlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MzE1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZXN1bHRzZGJweS9yZXN1bHRzZGJweS9t b2RlbC9mYWlsdXJlX2NvbnRleHQucHk6CisgICAgICAgIChGYWlsdXJlQ29udGV4dCk6IERvIG5v dCBpbmNsdWRlIHRlc3QgcnVucyB3aGljaCBoYXZlIG5vIGZhaWxlZCB0ZXN0cy4KKyAgICAgICAg KiByZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC9mYWlsdXJlX2NvbnRleHRfdW5pdHRlc3Qu cHk6CisgICAgICAgIChGYWlsdXJlQ29udGV4dFRlc3QpOgorICAgICAgICAoRmFpbHVyZUNvbnRl eHRUZXN0LnRlc3Rfbm9fZmFpbHVyZXMpOgorCiAyMDE5LTExLTE4ICBKb25hdGhhbiBCZWRhcmQg IDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBQeXRob24gMzogQWRkIHN1cHBvcnQgaW4g d2Via2l0cHkubGF5b3V0X3Rlc3RzLnZpZXdzCkluZGV4OiBUb29scy9yZXN1bHRzZGJweS9yZXN1 bHRzZGJweS9tb2RlbC9mYWlsdXJlX2NvbnRleHQucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvcmVz dWx0c2RicHkvcmVzdWx0c2RicHkvbW9kZWwvZmFpbHVyZV9jb250ZXh0LnB5CShyZXZpc2lvbiAy NTI1NTYpCisrKyBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC9mYWlsdXJlX2Nv bnRleHQucHkJKHdvcmtpbmcgY29weSkKQEAgLTE4NCw3ICsxODQsMTMgQEAgY2xhc3MgRmFpbHVy ZUNvbnRleHQoVXBsb2FkQ2FsbGJhY2tDb250ZQogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBpZiB0ZXN0IG5vdCBpbiBbJ3V1aWQnLCAnc3RhcnRfdGltZSddOgogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgcmVzdWx0LmFkZCh0ZXN0KQogICAgICAgICAgICAgICAg ICAgICBlbHNlOgotICAgICAgICAgICAgICAgICAgICAgICAgcmVzdWx0LnVwZGF0ZSh7Y29uZmln OiBbdmFsdWUudW5wYWNrKCkgZm9yIHZhbHVlIGluIHZhbHVlc119KQorICAgICAgICAgICAgICAg ICAgICAgICAgcnVucyA9IFtdCisgICAgICAgICAgICAgICAgICAgICAgICBmb3IgdmFsdWUgaW4g dmFsdWVzOgorICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVucGFja2VkID0gdmFsdWUudW5w YWNrKCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiBsZW4odW5wYWNrZWQpID4gMjoK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcnVucy5hcHBlbmQodW5wYWNrZWQpCisg ICAgICAgICAgICAgICAgICAgICAgICBpZiBydW5zOgorICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHJlc3VsdC51cGRhdGUoe2NvbmZpZzogcnVuc30pCiAKICAgICAgICAgICAgIHJldHVybiBy ZXN1bHQKIApJbmRleDogVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvbW9kZWwvZmFpbHVy ZV9jb250ZXh0X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL3Jlc3VsdHNkYnB5L3Jl c3VsdHNkYnB5L21vZGVsL2ZhaWx1cmVfY29udGV4dF91bml0dGVzdC5weQkocmV2aXNpb24gMjUy NTU2KQorKysgVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvbW9kZWwvZmFpbHVyZV9jb250 ZXh0X3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMDksMyArMTA5LDE1IEBAIGNsYXNz IEZhaWx1cmVDb250ZXh0VGVzdChXYWl0Rm9yRG9ja2VyVGUKICAgICAgICAgICAgICdzdGFydF90 aW1lJzogbGlzdChyZXN1bHRzLnZhbHVlcygpKVswXVswXVsnc3RhcnRfdGltZSddLAogICAgICAg ICAgICAgJ3V1aWQnOiAxNTM4MDI5NDc5MDAKICAgICAgICAgfSkKKworICAgIEBXYWl0Rm9yRG9j a2VyVGVzdENhc2UubW9ja19pZl9ub19kb2NrZXIobW9ja19yZWRpcz1GYWtlU3RyaWN0UmVkaXMs IG1vY2tfY2Fzc2FuZHJhPU1vY2tDYXNzYW5kcmFDb250ZXh0KQorICAgIGRlZiB0ZXN0X25vX2Zh aWx1cmVzKHNlbGYsIHJlZGlzPVN0cmljdFJlZGlzLCBjYXNzYW5kcmE9Q2Fzc2FuZHJhQ29udGV4 dCk6CisgICAgICAgIGNhc3NhbmRyYS5kcm9wX2tleXNwYWNlKGtleXNwYWNlPXNlbGYuS0VZU1BB Q0UpCisgICAgICAgIHNlbGYubW9kZWwgPSBNb2NrTW9kZWxGYWN0b3J5LmNyZWF0ZShyZWRpcz1y ZWRpcygpLCBjYXNzYW5kcmE9Y2Fzc2FuZHJhKGtleXNwYWNlPXNlbGYuS0VZU1BBQ0UsIGNyZWF0 ZV9rZXlzcGFjZT1UcnVlKSkKKyAgICAgICAgTW9ja01vZGVsRmFjdG9yeS5hZGRfbW9ja19yZXN1 bHRzKHNlbGYubW9kZWwpCisgICAgICAgIE1vY2tNb2RlbEZhY3RvcnkucHJvY2Vzc19yZXN1bHRz KHNlbGYubW9kZWwpCisgICAgICAgIHJlc3VsdHMgPSBzZWxmLm1vZGVsLmZhaWx1cmVfY29udGV4 dC5mYWlsdXJlc19ieV9jb21taXQoCisgICAgICAgICAgICBjb25maWd1cmF0aW9ucz1bQ29uZmln dXJhdGlvbihwbGF0Zm9ybT0nTWFjJywgc3R5bGU9J1JlbGVhc2UnLCBmbGF2b3I9J3drMScpXSwK KyAgICAgICAgICAgIHN1aXRlPSdsYXlvdXQtdGVzdHMnLCByZWNlbnQ9VHJ1ZSwgY29sbGFwc2Vk PUZhbHNlLCB1bmV4cGVjdGVkPUZhbHNlLAorICAgICAgICApCisgICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWwobGVuKHJlc3VsdHMpLCAwKQo= 383801 2019-11-18 16:09:31 -0800 2019-11-18 16:53:10 -0800 Patch for landing bug-204315-20191118160929.patch text/plain 3135 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MjYwNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTExLTE4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IFVuY29sbGFwc2VkIGZhaWx1cmVzIHNo b3VsZG4ndCBpbmNsdWRlIHJ1bnMgd2l0aCBubyBmYWlsdXJlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MzE1CisKKyAgICAgICAgUnViYmVyLXN0 YW1wZWQgYnkgQWFrYXNoIEphaW4uCisKKyAgICAgICAgKiByZXN1bHRzZGJweS9yZXN1bHRzZGJw eS9tb2RlbC9mYWlsdXJlX2NvbnRleHQucHk6CisgICAgICAgIChGYWlsdXJlQ29udGV4dCk6IERv IG5vdCBpbmNsdWRlIHRlc3QgcnVucyB3aGljaCBoYXZlIG5vIGZhaWxlZCB0ZXN0cy4KKyAgICAg ICAgKiByZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC9mYWlsdXJlX2NvbnRleHRfdW5pdHRl c3QucHk6CisgICAgICAgIChGYWlsdXJlQ29udGV4dFRlc3QpOgorICAgICAgICAoRmFpbHVyZUNv bnRleHRUZXN0LnRlc3Rfbm9fZmFpbHVyZXMpOgorCiAyMDE5LTExLTE4ICBBYWthc2ggSmFpbiAg PGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBEZWRpY2F0ZSBld3MxMTYgdG8gbWFj T1MtSGlnaC1TaWVycmEtRGVidWctQnVpbGQtRVdTIHF1ZXVlCkluZGV4OiBUb29scy9yZXN1bHRz ZGJweS9yZXN1bHRzZGJweS9tb2RlbC9mYWlsdXJlX2NvbnRleHQucHkKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvbW9kZWwvZmFpbHVyZV9jb250ZXh0LnB5CShy ZXZpc2lvbiAyNTI2MDUpCisrKyBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC9m YWlsdXJlX2NvbnRleHQucHkJKHdvcmtpbmcgY29weSkKQEAgLTE4NCw3ICsxODQsMTQgQEAgY2xh c3MgRmFpbHVyZUNvbnRleHQoVXBsb2FkQ2FsbGJhY2tDb250ZQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBpZiB0ZXN0IG5vdCBpbiBbJ3V1aWQnLCAnc3RhcnRfdGltZSddOgogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVzdWx0LmFkZCh0ZXN0KQogICAgICAg ICAgICAgICAgICAgICBlbHNlOgotICAgICAgICAgICAgICAgICAgICAgICAgcmVzdWx0LnVwZGF0 ZSh7Y29uZmlnOiBbdmFsdWUudW5wYWNrKCkgZm9yIHZhbHVlIGluIHZhbHVlc119KQorICAgICAg ICAgICAgICAgICAgICAgICAgcnVucyA9IFtdCisgICAgICAgICAgICAgICAgICAgICAgICBmb3Ig dmFsdWUgaW4gdmFsdWVzOgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICMgdXVpZCBhbmQg c3RhcnRfdGltZSBhcmUgbm90IGluIHRoZSB1bnBhY2tlZCB2YWx1ZXMKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICB1bnBhY2tlZCA9IHZhbHVlLnVucGFjaygpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgaWYgbGVuKHVucGFja2VkKSA+IDI6CisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHJ1bnMuYXBwZW5kKHVucGFja2VkKQorICAgICAgICAgICAgICAgICAgICAgICAg aWYgcnVuczoKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXN1bHQudXBkYXRlKHtjb25m aWc6IHJ1bnN9KQogCiAgICAgICAgICAgICByZXR1cm4gcmVzdWx0CiAKSW5kZXg6IFRvb2xzL3Jl c3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL2ZhaWx1cmVfY29udGV4dF91bml0dGVzdC5weQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC9mYWlsdXJl X2NvbnRleHRfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI1MjYwNSkKKysrIFRvb2xzL3Jlc3VsdHNk YnB5L3Jlc3VsdHNkYnB5L21vZGVsL2ZhaWx1cmVfY29udGV4dF91bml0dGVzdC5weQkod29ya2lu ZyBjb3B5KQpAQCAtMTA5LDMgKzEwOSwxNSBAQCBjbGFzcyBGYWlsdXJlQ29udGV4dFRlc3QoV2Fp dEZvckRvY2tlclRlCiAgICAgICAgICAgICAnc3RhcnRfdGltZSc6IGxpc3QocmVzdWx0cy52YWx1 ZXMoKSlbMF1bMF1bJ3N0YXJ0X3RpbWUnXSwKICAgICAgICAgICAgICd1dWlkJzogMTUzODAyOTQ3 OTAwCiAgICAgICAgIH0pCisKKyAgICBAV2FpdEZvckRvY2tlclRlc3RDYXNlLm1vY2tfaWZfbm9f ZG9ja2VyKG1vY2tfcmVkaXM9RmFrZVN0cmljdFJlZGlzLCBtb2NrX2Nhc3NhbmRyYT1Nb2NrQ2Fz c2FuZHJhQ29udGV4dCkKKyAgICBkZWYgdGVzdF9ub19mYWlsdXJlcyhzZWxmLCByZWRpcz1TdHJp Y3RSZWRpcywgY2Fzc2FuZHJhPUNhc3NhbmRyYUNvbnRleHQpOgorICAgICAgICBjYXNzYW5kcmEu ZHJvcF9rZXlzcGFjZShrZXlzcGFjZT1zZWxmLktFWVNQQUNFKQorICAgICAgICBzZWxmLm1vZGVs ID0gTW9ja01vZGVsRmFjdG9yeS5jcmVhdGUocmVkaXM9cmVkaXMoKSwgY2Fzc2FuZHJhPWNhc3Nh bmRyYShrZXlzcGFjZT1zZWxmLktFWVNQQUNFLCBjcmVhdGVfa2V5c3BhY2U9VHJ1ZSkpCisgICAg ICAgIE1vY2tNb2RlbEZhY3RvcnkuYWRkX21vY2tfcmVzdWx0cyhzZWxmLm1vZGVsKQorICAgICAg ICBNb2NrTW9kZWxGYWN0b3J5LnByb2Nlc3NfcmVzdWx0cyhzZWxmLm1vZGVsKQorICAgICAgICBy ZXN1bHRzID0gc2VsZi5tb2RlbC5mYWlsdXJlX2NvbnRleHQuZmFpbHVyZXNfYnlfY29tbWl0KAor ICAgICAgICAgICAgY29uZmlndXJhdGlvbnM9W0NvbmZpZ3VyYXRpb24ocGxhdGZvcm09J01hYycs IHN0eWxlPSdSZWxlYXNlJywgZmxhdm9yPSd3azEnKV0sCisgICAgICAgICAgICBzdWl0ZT0nbGF5 b3V0LXRlc3RzJywgcmVjZW50PVRydWUsIGNvbGxhcHNlZD1GYWxzZSwgdW5leHBlY3RlZD1GYWxz ZSwKKyAgICAgICAgKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGxlbihyZXN1bHRzKSwgMCkK