204309 2019-11-18 12:15:29 -0800 Clarify that OptionRange::operator=() is only used for initializing to 0 (i.e. state Uninitialized). 2019-11-18 12:38:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam saam webkit-bug-importer oldest_to_newest 1591167 0 mark.lam 2019-11-18 12:15:29 -0800 ... 1591171 1 383776 mark.lam 2019-11-18 12:19:22 -0800 Created attachment 383776 proposed patch. 1591175 2 383776 mark.lam 2019-11-18 12:22:14 -0800 Comment on attachment 383776 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=383776&action=review > Source/JavaScriptCore/ChangeLog:3 > + Clarify that OptionRange::operator=() is only used for initialized to 0 (i.e. state Uninitialized). Will replace /initialized/initializing/. 1591176 3 383776 saam 2019-11-18 12:22:31 -0800 Comment on attachment 383776 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=383776&action=review > Source/JavaScriptCore/runtime/OptionsList.h:554 > + OptionRange& operator= (int value) no space 1591178 4 mark.lam 2019-11-18 12:37:04 -0800 Thanks for the review. (In reply to Saam Barati from comment #3) > > Source/JavaScriptCore/runtime/OptionsList.h:554 > > + OptionRange& operator= (int value) > > no space Fixed. Landed in r252558: <http://trac.webkit.org/r252558>. 1591179 5 webkit-bug-importer 2019-11-18 12:38:16 -0800 <rdar://problem/57293275> 383776 2019-11-18 12:19:22 -0800 2019-11-18 12:22:31 -0800 proposed patch. bug-204309.patch text/plain 1801 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUyNTU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE5LTExLTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD bGFyaWZ5IHRoYXQgT3B0aW9uUmFuZ2U6Om9wZXJhdG9yPSgpIGlzIG9ubHkgdXNlZCBmb3IgaW5p dGlhbGl6ZWQgdG8gMCAoaS5lLiBzdGF0ZSBVbmluaXRpYWxpemVkKS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDMwOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGEgUkVMRUFTRV9BU1NFUlQg aW4gT3B0aW9uUmFuZ2U6Om9wZXJhdG9yPSgpIHRvIGVuZm9yY2UgdGhhdCBpdCBzaG91bGQKKyAg ICAgICAgbmV2ZXIgYmUgY2FsbGVkIHdpdGggYW55IHZhbHVlIG90aGVyIHRoYW4gMC4KKworICAg ICAgICAqIHJ1bnRpbWUvT3B0aW9uc0xpc3QuaDoKKyAgICAgICAgKEpTQzo6T3B0aW9uUmFuZ2U6 Om9wZXJhdG9yPSApOgorCiAyMDE5LTExLTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KIAogICAgICAgICBSZWR1Y2UgdGhlIGFtb3VudCBvZiBtZW1vcnkgbmVlZGVkIHRvIHN0b3Jl IE9wdGlvbnMuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zTGlz dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnNM aXN0LmgJKHJldmlzaW9uIDI1MjU1NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L09wdGlvbnNMaXN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTU1MSwxNCArNTUxLDE2IEBAIGNsYXNz IE9wdGlvblJhbmdlIHsKIHByaXZhdGU6CiAgICAgZW51bSBSYW5nZVN0YXRlIHsgVW5pbml0aWFs aXplZCwgSW5pdEVycm9yLCBOb3JtYWwsIEludmVydGVkIH07CiBwdWJsaWM6Ci0gICAgT3B0aW9u UmFuZ2UmIG9wZXJhdG9yPSAoY29uc3QgaW50JiByaHMpCi0gICAgeyAvLyBPbmx5IG5lZWRlZCBm b3IgaW5pdGlhbGl6YXRpb24KLSAgICAgICAgaWYgKCFyaHMpIHsKLSAgICAgICAgICAgIG1fc3Rh dGUgPSBVbmluaXRpYWxpemVkOwotICAgICAgICAgICAgbV9yYW5nZVN0cmluZyA9IDA7Ci0gICAg ICAgICAgICBtX2xvd0xpbWl0ID0gMDsKLSAgICAgICAgICAgIG1faGlnaExpbWl0ID0gMDsKLSAg ICAgICAgfQorICAgIE9wdGlvblJhbmdlJiBvcGVyYXRvcj0gKGludCB2YWx1ZSkKKyAgICB7Cisg ICAgICAgIC8vIE9ubHkgdXNlZCBmb3IgaW5pdGlhbGl6YXRpb24gdG8gc3RhdGUgVW5pbml0aWFs aXplZC4KKyAgICAgICAgLy8gT3B0aW9uc0xpc3Qgc3BlY2lmaWVzIE9wdGlvblJhbmdlIG9wdGlv bnMgd2l0aCBkZWZhdWx0IHZhbHVlIDAuCisgICAgICAgIFJFTEVBU0VfQVNTRVJUKCF2YWx1ZSk7 CisKKyAgICAgICAgbV9zdGF0ZSA9IFVuaW5pdGlhbGl6ZWQ7CisgICAgICAgIG1fcmFuZ2VTdHJp bmcgPSAwOworICAgICAgICBtX2xvd0xpbWl0ID0gMDsKKyAgICAgICAgbV9oaWdoTGltaXQgPSAw OwogICAgICAgICByZXR1cm4gKnRoaXM7CiAgICAgfQogCg==