204308 2019-11-18 12:06:36 -0800 Enable Nullish operators by default 2019-11-19 19:22:57 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue saam webkit-bug-importer ysuzuki oldest_to_newest 1591160 0 keith_miller 2019-11-18 12:06:36 -0800 Enable Nullish operators by default 1591162 1 383773 keith_miller 2019-11-18 12:08:21 -0800 Created attachment 383773 Patch 1591165 2 383773 ysuzuki 2019-11-18 12:09:19 -0800 Comment on attachment 383773 Patch r=me 1591185 3 383773 commit-queue 2019-11-18 12:53:14 -0800 Comment on attachment 383773 Patch Clearing flags on attachment: 383773 Committed r252559: <https://trac.webkit.org/changeset/252559> 1591186 4 commit-queue 2019-11-18 12:53:15 -0800 All reviewed patches have been landed. Closing bug. 1591190 5 webkit-bug-importer 2019-11-18 12:54:19 -0800 <rdar://problem/57293820> 1591842 6 saam 2019-11-19 19:15:59 -0800 You forgot to remove it from being included inside run-jsc-stress-tests 1591843 7 saam 2019-11-19 19:17:19 -0800 you should just get rid of runNullishAwareOperatorsEnabled 1591846 8 saam 2019-11-19 19:22:57 -0800 (In reply to Saam Barati from comment #7) > you should just get rid of runNullishAwareOperatorsEnabled removed in: https://trac.webkit.org/changeset/252679/webkit 383773 2019-11-18 12:08:21 -0800 2019-11-18 12:53:14 -0800 Patch bug-204308-20191118120820.patch text/plain 4067 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 MWUyNTFmYjlkODY4NDg1Y2NlZmM2Y2JiODU5MjdkMTA2ZWIyNzNjLi4wYTc5NjJjNmE5OGZkN2Y1 NmRiOGIxMDRkNDk5ODMxOTFiZjdlNTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0xMS0xOCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBFbmFibGUgTnVsbGlzaCBvcGVyYXRvcnMgYnkgZGVmYXVsdAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MzA4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG51bGxpc2gg b3BlcmF0b3JzIGA/P2AgYW5kIGA/LmAgYXJlIGxpa2VseSBnb2luZyB0byBzdGFnZSA0IGF0Cisg ICAgICAgIHRoZSBEZWNlbWJlciBUQy0zOSBtZWV0aW5nIHNvIHdlIHNob3VsZCBwcm9iYWJseSBq dXN0IGVuYWJsZSB0aGVtCisgICAgICAgIGJ5IGRlZmF1bHQuCisKKyAgICAgICAgKiBwYXJzZXIv TGV4ZXIuY3BwOgorICAgICAgICAoSlNDOjpMZXhlcjxUPjo6bGV4V2l0aG91dENsZWFyaW5nTGlu ZVRlcm1pbmF0b3IpOgorICAgICAgICAqIHJ1bnRpbWUvT3B0aW9uc0xpc3QuaDoKKwogMjAxOS0x MS0xOCAgQ2hyaXMgUG9sY3luICA8Y3BvbGN5bkBhcHBsZS5jb20+CiAKICAgICAgICAgUHVibGlz aCBKYXZhU2NyaXB0Q29yZSBhcyBDbGFuZyBtb2R1bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNl ci9MZXhlci5jcHAKaW5kZXggYWQwYTVlMzRiZTc0YjZlNzk0MDY1MmY1ZGU0OWJkNzRjMjQxNDNm YS4uYzY5MWRhY2ZiYTRiMjdkNDEwYzgxN2Q3MDZiNTJkYzBjMWY5MDVmZiAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9MZXhlci5jcHAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3BhcnNlci9MZXhlci5jcHAKQEAgLTIxMzcsMTcgKzIxMzcsMTUgQEAgc3RhcnQ6 CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgQ2hhcmFjdGVyUXVlc3Rpb246CiAgICAgICAgIHNo aWZ0KCk7Ci0gICAgICAgIGlmIChPcHRpb25zOjp1c2VOdWxsaXNoQXdhcmVPcGVyYXRvcnMoKSkg ewotICAgICAgICAgICAgaWYgKG1fY3VycmVudCA9PSAnPycpIHsKLSAgICAgICAgICAgICAgICBz aGlmdCgpOwotICAgICAgICAgICAgICAgIHRva2VuID0gQ09BTEVTQ0U7Ci0gICAgICAgICAgICAg ICAgYnJlYWs7Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgICBpZiAobV9jdXJyZW50ID09ICcu JyAmJiAhaXNBU0NJSURpZ2l0KHBlZWsoMSkpKSB7Ci0gICAgICAgICAgICAgICAgc2hpZnQoKTsK LSAgICAgICAgICAgICAgICB0b2tlbiA9IFFVRVNUSU9ORE9UOwotICAgICAgICAgICAgICAgIGJy ZWFrOwotICAgICAgICAgICAgfQorICAgICAgICBpZiAobV9jdXJyZW50ID09ICc/JykgeworICAg ICAgICAgICAgc2hpZnQoKTsKKyAgICAgICAgICAgIHRva2VuID0gQ09BTEVTQ0U7CisgICAgICAg ICAgICBicmVhazsKKyAgICAgICAgfQorICAgICAgICBpZiAobV9jdXJyZW50ID09ICcuJyAmJiAh aXNBU0NJSURpZ2l0KHBlZWsoMSkpKSB7CisgICAgICAgICAgICBzaGlmdCgpOworICAgICAgICAg ICAgdG9rZW4gPSBRVUVTVElPTkRPVDsKKyAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAg ICAgICAgIHRva2VuID0gUVVFU1RJT047CiAgICAgICAgIGJyZWFrOwpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9uc0xpc3QuaCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL09wdGlvbnNMaXN0LmgKaW5kZXggY2YxNDVmMWViZjU3NjdhYjkyYzk5 ODU2NjFjNmU5YjA2MTBkMDVhYi4uMGYyODc3ZjMwMzFkZjBkYmQ5MGRkZjBiOGFiNGQyZTJiMTZk NGFiMiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9uc0xp c3QuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zTGlzdC5oCkBA IC00NTMsNyArNDUzLDYgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgdihCb29sLCB1c2VXZWJBc3Nl bWJseU11bHRpVmFsdWVzLCB0cnVlLCBOb3JtYWwsICJBbGxvdyB0eXBlcyBmcm9tIHRoZSB3YXNt IG11bGl0LXZhbHVlcyBzcGVjLiIpIFwKICAgICB2KEJvb2wsIHVzZVdlYWtSZWZzLCBmYWxzZSwg Tm9ybWFsLCAiRXhwb3NlIHRoZSBXZWFrUmVmIGNvbnN0cnVjdG9yLiIpIFwKICAgICB2KEJvb2ws IHVzZUJpZ0ludCwgZmFsc2UsIE5vcm1hbCwgIklmIHRydWUsIHdlIHdpbGwgZW5hYmxlIEJpZ0lu dCBzdXBwb3J0LiIpIFwKLSAgICB2KEJvb2wsIHVzZU51bGxpc2hBd2FyZU9wZXJhdG9ycywgZmFs c2UsIE5vcm1hbCwgIkVuYWJsZSBzdXBwb3J0IGZvciA/LiBhbmQgPz8gb3BlcmF0b3JzLiIpIFwK ICAgICB2KEJvb2wsIHVzZUFycmF5QWxsb2NhdGlvblByb2ZpbGluZywgdHJ1ZSwgTm9ybWFsLCAi SWYgdHJ1ZSwgd2Ugd2lsbCB1c2Ugb3VyIG5vcm1hbCBhcnJheSBhbGxvY2F0aW9uIHByb2ZpbGlu Zy4gSWYgZmFsc2UsIHRoZSBhbGxvY2F0aW9uIHByb2ZpbGUgd2lsbCBhbHdheXMgY2xhaW0gdG8g YmUgdW5kZWNpZGVkLiIpIFwKICAgICB2KEJvb2wsIGZvcmNlUG9seVByb3RvLCBmYWxzZSwgTm9y bWFsLCAiSWYgdHJ1ZSwgY3JlYXRlX3RoaXMgd2lsbCBhbHdheXMgY3JlYXRlIGFuIG9iamVjdCB3 aXRoIGEgcG9seSBwcm90byBzdHJ1Y3R1cmUuIikgXAogICAgIHYoQm9vbCwgZm9yY2VNaW5pVk1N b2RlLCBmYWxzZSwgTm9ybWFsLCAiSWYgdHJ1ZSwgaXQgd2lsbCBmb3JjZSBtaW5pIFZNIG1vZGUg b24uIikgXApkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxv ZwppbmRleCA4OThmNTBhOTQzZmU5NWU1MGIxYzI0OGVmMmU1NjYwMDA3MjA2NDdkLi5kZGFkYjY1 ZDE1ZDA0YjM0OTA2ZjZmNDdkMjVhY2U3YjIwYTg0NGJiIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0No YW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTEx LTE4ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgorCisgICAgICAgIEVu YWJsZSBOdWxsaXNoIG9wZXJhdG9ycyBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQzMDgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgZmVhdHVyZSAtPiBvcHRpb24gbWFwLgor CisgICAgICAgICogdGVzdDI2Mi9jb25maWcueWFtbDoKKwogMjAxOS0xMS0xOCAgQ2FpbyBMaW1h ICA8dGljYWlvbGltYUBnbWFpbC5jb20+CiAKICAgICAgICAgU2tpcHBpbmcgd2FzbS1lcnJvci1t ZXNzYWdlLWNyb3NzLXRocmVhZHMuanMgb24gYXJjaGl0ZWN0dXJlcyB3aXRob3V0IFdBU00gc3Vw cG9ydApkaWZmIC0tZ2l0IGEvSlNUZXN0cy90ZXN0MjYyL2NvbmZpZy55YW1sIGIvSlNUZXN0cy90 ZXN0MjYyL2NvbmZpZy55YW1sCmluZGV4IGJmYjJlMWMwM2U4MDhmMTFmZmQ0ZTAyZTIxODg3ZjYy YTU1YWI2MDAuLjBhZTNhNWJjYTNjNzk0ZDMxOTE2NDBiZDRiNDVkN2Q1YmYxM2UxOTggMTAwNjQ0 Ci0tLSBhL0pTVGVzdHMvdGVzdDI2Mi9jb25maWcueWFtbAorKysgYi9KU1Rlc3RzL3Rlc3QyNjIv Y29uZmlnLnlhbWwKQEAgLTEsOCArMSw2IEBACiAKIC0tLQogZmxhZ3M6Ci0gIGNvYWxlc2NlLWV4 cHJlc3Npb246IHVzZU51bGxpc2hBd2FyZU9wZXJhdG9ycwotICBvcHRpb25hbC1jaGFpbmluZzog dXNlTnVsbGlzaEF3YXJlT3BlcmF0b3JzCiAgIEJpZ0ludDogdXNlQmlnSW50CiAgIFdlYWtSZWY6 IHVzZVdlYWtSZWZzCiBza2lwOgo=