204298 2019-11-18 09:17:34 -0800 Promote main thread assertions related to sendWithAsyncReply() to be release assertions 2019-11-18 16:00:20 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen commit-queue ggaren webkit-bug-importer wenson_hsieh youennf oldest_to_newest 1591075 0 cdumez 2019-11-18 09:17:34 -0800 Promote main thread assertions related to sendWithAsyncReply() to be release assertions, to help identify threading bugs such as <rdar://problem/57231170>. 1591076 1 383753 cdumez 2019-11-18 09:20:29 -0800 Created attachment 383753 Patch 1591081 2 383753 wenson_hsieh 2019-11-18 09:25:10 -0800 Comment on attachment 383753 Patch r=mews 1591294 3 383753 commit-queue 2019-11-18 15:59:26 -0800 Comment on attachment 383753 Patch Clearing flags on attachment: 383753 Committed r252605: <https://trac.webkit.org/changeset/252605> 1591295 4 commit-queue 2019-11-18 15:59:30 -0800 All reviewed patches have been landed. Closing bug. 1591296 5 webkit-bug-importer 2019-11-18 16:00:20 -0800 <rdar://problem/57302825> 383753 2019-11-18 09:20:29 -0800 2019-11-18 15:59:26 -0800 Patch bug-204298-20191118092028.patch text/plain 2617 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYwMTJjZTcxYWQ3ZWNkZTBj NmU2NjdiNjI5YjU1MWI0ODU3NGI4NjguLjg1N2ViN2RjYzI3MjUyMTUyYjhlNTI2NjY0YWFlOWEz MGE5MGMwNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMTEtMTggIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBQcm9tb3RlIG1haW4gdGhyZWFkIGFz c2VydGlvbnMgcmVsYXRlZCB0byBzZW5kV2l0aEFzeW5jUmVwbHkoKSB0byBiZSByZWxlYXNlIGFz c2VydGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwNDI5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFByb21vdGUgbWFpbiB0aHJlYWQgYXNzZXJ0aW9ucyByZWxhdGVkIHRvIHNlbmRXaXRoQXN5bmNS ZXBseSgpIHRvIGJlIHJlbGVhc2UgYXNzZXJ0aW9ucywgdG8gaGVscCBpZGVudGlmeQorICAgICAg ICB0aHJlYWRpbmcgYnVncyBzdWNoIGFzIDxyZGFyOi8vcHJvYmxlbS81NzIzMTE3MD4uCisKKyAg ICAgICAgKiBQbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5jcHA6CisgICAgICAgIChJUEM6OmFkZEFz eW5jUmVwbHlIYW5kbGVyKToKKyAgICAgICAgKElQQzo6Y2xlYXJBc3luY1JlcGx5SGFuZGxlcnMp OgorICAgICAgICAoSVBDOjpDb21wbGV0aW9uSGFuZGxlcjx2b2lkKToKKwogMjAxOS0xMS0xOCAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgQXV0 b21hdGlvbjogc2Nyb2xsSW50b1ZpZXcgc2hvdWxkIGRvIG5vdGhpbmcgaWYgZWxlbWVudCBpcyB2 aXNpYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9Db25uZWN0aW9u LmNwcCBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uY3BwCmluZGV4IDQ4 Y2NhODRhZmQ3M2VjZTRiNTcyNDQ1MTI3NWEzNDI5NjA1MTE3MzIuLjU3NDFhNGQwYWZlZGY4YmQz NjU4ZTNiYjcxNjUwMWU3ZWU3OWQ5YmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZv cm0vSVBDL0Nvbm5lY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0Nv bm5lY3Rpb24uY3BwCkBAIC0xMTI1LDcgKzExMjUsNyBAQCB1aW50NjRfdCBuZXh0QXN5bmNSZXBs eUhhbmRsZXJJRCgpCiAKIHZvaWQgYWRkQXN5bmNSZXBseUhhbmRsZXIoQ29ubmVjdGlvbiYgY29u bmVjdGlvbiwgdWludDY0X3QgaWRlbnRpZmllciwgQ29tcGxldGlvbkhhbmRsZXI8dm9pZChEZWNv ZGVyKik+JiYgY29tcGxldGlvbkhhbmRsZXIpCiB7Ci0gICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFp bigpKTsKKyAgICBSRUxFQVNFX0FTU0VSVChSdW5Mb29wOjppc01haW4oKSk7CiAgICAgYXV0byBy ZXN1bHQgPSBhc3luY1JlcGx5SGFuZGxlck1hcCgpLmVuc3VyZShyZWludGVycHJldF9jYXN0PHVp bnRwdHJfdD4oJmNvbm5lY3Rpb24pLCBbXSB7CiAgICAgICAgIHJldHVybiBIYXNoTWFwPHVpbnQ2 NF90LCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKERlY29kZXIqKT4+KCk7CiAgICAgfSkuaXRlcmF0 b3ItPnZhbHVlLmFkZChpZGVudGlmaWVyLCBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CkBA IC0xMTM0LDcgKzExMzQsNyBAQCB2b2lkIGFkZEFzeW5jUmVwbHlIYW5kbGVyKENvbm5lY3Rpb24m IGNvbm5lY3Rpb24sIHVpbnQ2NF90IGlkZW50aWZpZXIsIENvbXBsZXRpbwogCiB2b2lkIGNsZWFy QXN5bmNSZXBseUhhbmRsZXJzKGNvbnN0IENvbm5lY3Rpb24mIGNvbm5lY3Rpb24pCiB7Ci0gICAg QVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKKyAgICBSRUxFQVNFX0FTU0VSVChSdW5Mb29wOjpp c01haW4oKSk7CiAgICAgYXV0byBtYXAgPSBhc3luY1JlcGx5SGFuZGxlck1hcCgpLnRha2UocmVp bnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KCZjb25uZWN0aW9uKSk7CiAgICAgZm9yIChhdXRvJiBo YW5kbGVyIDogbWFwLnZhbHVlcygpKSB7CiAgICAgICAgIGlmIChoYW5kbGVyKQpAQCAtMTE0NCw3 ICsxMTQ0LDcgQEAgdm9pZCBjbGVhckFzeW5jUmVwbHlIYW5kbGVycyhjb25zdCBDb25uZWN0aW9u JiBjb25uZWN0aW9uKQogCiBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKERlY29kZXIqKT4gdGFrZUFz eW5jUmVwbHlIYW5kbGVyKENvbm5lY3Rpb24mIGNvbm5lY3Rpb24sIHVpbnQ2NF90IGlkZW50aWZp ZXIpCiB7Ci0gICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKKyAgICBSRUxFQVNFX0FTU0VS VChSdW5Mb29wOjppc01haW4oKSk7CiAgICAgYXV0byBpdGVyYXRvciA9IGFzeW5jUmVwbHlIYW5k bGVyTWFwKCkuZmluZChyZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4oJmNvbm5lY3Rpb24pKTsK ICAgICBpZiAoaXRlcmF0b3IgIT0gYXN5bmNSZXBseUhhbmRsZXJNYXAoKS5lbmQoKSkgewogICAg ICAgICBpZiAoIWl0ZXJhdG9yLT52YWx1ZS5pc1ZhbGlkS2V5KGlkZW50aWZpZXIpKSB7Cg==