204295 2019-11-18 08:08:21 -0800 [LFC][Invalidation] Force rebuild layout tree on tree mutation 2019-11-18 09:14:59 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1591047 0 zalan 2019-11-18 08:08:21 -0800 for now. 1591048 1 webkit-bug-importer 2019-11-18 08:08:33 -0800 <rdar://problem/57283650> 1591049 2 383747 zalan 2019-11-18 08:11:32 -0800 Created attachment 383747 Patch 1591054 3 383747 koivisto 2019-11-18 08:19:20 -0800 Comment on attachment 383747 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383747&action=review > Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:300 > - if (!m_document.view() || m_document.view()->layoutContext().layoutFormattingState()) > + if (!m_document.view() || !m_document.view()->layoutContext().layoutFormattingState()) lol 1591057 4 zalan 2019-11-18 08:29:32 -0800 (In reply to Antti Koivisto from comment #3) > Comment on attachment 383747 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383747&action=review > > > Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:300 > > - if (!m_document.view() || m_document.view()->layoutContext().layoutFormattingState()) > > + if (!m_document.view() || !m_document.view()->layoutContext().layoutFormattingState()) > > lol let's just pretend it was a typo. 1591058 5 koivisto 2019-11-18 08:30:53 -0800 > let's just pretend it was a typo. Yeah, quietly. 1591072 6 383747 commit-queue 2019-11-18 09:14:57 -0800 Comment on attachment 383747 Patch Clearing flags on attachment: 383747 Committed r252544: <https://trac.webkit.org/changeset/252544> 1591073 7 commit-queue 2019-11-18 09:14:59 -0800 All reviewed patches have been landed. Closing bug. 383747 2019-11-18 08:11:32 -0800 2019-11-18 09:14:57 -0800 Patch bug-204295-20191118081113.patch text/plain 3992 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2U2MTQzZjY1OTBhYzIz YzQwNWYwYWU3NjUyODM1NGY4YWVkNzcwNy4uYzkxMDVmN2QxYzFhNjMyNmZhMDJmYzc3OWZkOTk1 Y2I5NGUzOTNkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTExLTE4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSW52YWxpZGF0aW9u XSBGb3JjZSByZWJ1aWxkIGxheW91dCB0cmVlIG9uIHRyZWUgbXV0YXRpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDI5NQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNTcyODM2NTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBzaG91bGQgZXZvbHZlIGludG8gYSBmaW5lIGdyYWluZWQgdHJl ZSBpbnZhbGlkYXRpb24uIAorCisgICAgICAgICogcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRy ZWVCdWlsZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRyZWVCdWlsZGVyOjphdHRh Y2hUb1JlbmRlckVsZW1lbnRJbnRlcm5hbCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUcmVl QnVpbGRlcjo6ZGV0YWNoRnJvbVJlbmRlckVsZW1lbnQpOgorICAgICAgICAqIHJlbmRlcmluZy91 cGRhdGluZy9SZW5kZXJUcmVlVXBkYXRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJU cmVlVXBkYXRlcjo6dXBkYXRlUmVuZGVyZXJTdHlsZSk6CisKIDIwMTktMTEtMTcgIFphbGFuIEJ1 anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXSBNb3ZlIGxheW91dCBzdGF0 ZSBpbml0aWFsaXphdGlvbiBvdXQgb2YgTGF5b3V0Q29udGV4dApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5jcHAKaW5kZXgg ZWNhZjAwNjBkZTc4NTkxMDVkOTdjNmJjMTZiYjY2Mzk0ZjFjMzdkYi4uMTQ3MDJkMmI4NmFkY2I0 ZjQ4MmVjMDM2OTc2MTQ1NWZhNmNmYjBjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwCkBAIC02Myw2ICs2Mywx MSBAQAogI2luY2x1ZGUgIlJlbmRlclRyZWVCdWlsZGVyUnVieS5oIgogI2luY2x1ZGUgIlJlbmRl clRyZWVCdWlsZGVyU1ZHLmgiCiAjaW5jbHVkZSAiUmVuZGVyVHJlZUJ1aWxkZXJUYWJsZS5oIgor I2lmIEVOQUJMRShMQVlPVVRfRk9STUFUVElOR19DT05URVhUKQorI2luY2x1ZGUgIkZyYW1lVmll dy5oIgorI2luY2x1ZGUgIkZyYW1lVmlld0xheW91dENvbnRleHQuaCIKKyNpbmNsdWRlICJSdW50 aW1lRW5hYmxlZEZlYXR1cmVzLmgiCisjZW5kaWYKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBA IC00MzYsNiArNDQxLDEzIEBAIHZvaWQgUmVuZGVyVHJlZUJ1aWxkZXI6OmF0dGFjaFRvUmVuZGVy RWxlbWVudEludGVybmFsKFJlbmRlckVsZW1lbnQmIHBhcmVudCwgUmVuCiAgICAgICAgIGRvd25j YXN0PFJlbmRlckJsb2NrRmxvdz4ocGFyZW50KS5pbnZhbGlkYXRlTGluZUxheW91dFBhdGgoKTsK ICAgICBpZiAocGFyZW50Lmhhc091dGxpbmVBdXRvQW5jZXN0b3IoKSB8fCBwYXJlbnQub3V0bGlu ZVN0eWxlRm9yUmVwYWludCgpLm91dGxpbmVTdHlsZUlzQXV0bygpID09IE91dGxpbmVJc0F1dG86 Ok9uKQogICAgICAgICBuZXdDaGlsZC0+c2V0SGFzT3V0bGluZUF1dG9BbmNlc3RvcigpOworI2lm IEVOQUJMRShMQVlPVVRfRk9STUFUVElOR19DT05URVhUKQorICAgIGlmIChSdW50aW1lRW5hYmxl ZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygpLmxheW91dEZvcm1hdHRpbmdDb250ZXh0RW5hYmxl ZCgpKSB7CisgICAgICAgIGlmIChwYXJlbnQuZG9jdW1lbnQoKS52aWV3KCkpCisgICAgICAgICAg ICBwYXJlbnQuZG9jdW1lbnQoKS52aWV3KCktPmxheW91dENvbnRleHQoKS5pbnZhbGlkYXRlTGF5 b3V0VHJlZUNvbnRlbnQoKTsKKworICAgIH0KKyNlbmRpZgogfQogCiB2b2lkIFJlbmRlclRyZWVC dWlsZGVyOjptb3ZlKFJlbmRlckJveE1vZGVsT2JqZWN0JiBmcm9tLCBSZW5kZXJCb3hNb2RlbE9i amVjdCYgdG8sIFJlbmRlck9iamVjdCYgY2hpbGQsIFJlbmRlck9iamVjdCogYmVmb3JlQ2hpbGQs IE5vcm1hbGl6ZUFmdGVySW5zZXJ0aW9uIG5vcm1hbGl6ZUFmdGVySW5zZXJ0aW9uKQpAQCAtODUz LDcgKzg2NSwxMyBAQCBSZW5kZXJQdHI8UmVuZGVyT2JqZWN0PiBSZW5kZXJUcmVlQnVpbGRlcjo6 ZGV0YWNoRnJvbVJlbmRlckVsZW1lbnQoUmVuZGVyRWxlbWVudAogICAgICAgICBpZiAoQVhPYmpl Y3RDYWNoZSogY2FjaGUgPSBwYXJlbnQuZG9jdW1lbnQoKS5leGlzdGluZ0FYT2JqZWN0Q2FjaGUo KSkKICAgICAgICAgICAgIGNhY2hlLT5jaGlsZHJlbkNoYW5nZWQoJnBhcmVudCk7CiAgICAgfQor I2lmIEVOQUJMRShMQVlPVVRfRk9STUFUVElOR19DT05URVhUKQorICAgIGlmIChSdW50aW1lRW5h YmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygpLmxheW91dEZvcm1hdHRpbmdDb250ZXh0RW5h YmxlZCgpKSB7CisgICAgICAgIGlmIChwYXJlbnQuZG9jdW1lbnQoKS52aWV3KCkpCisgICAgICAg ICAgICBwYXJlbnQuZG9jdW1lbnQoKS52aWV3KCktPmxheW91dENvbnRleHQoKS5pbnZhbGlkYXRl TGF5b3V0VHJlZUNvbnRlbnQoKTsKIAorICAgIH0KKyNlbmRpZgogICAgIHJldHVybiBjaGlsZFRv VGFrZTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5n L1JlbmRlclRyZWVVcGRhdGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGlu Zy9SZW5kZXJUcmVlVXBkYXRlci5jcHAKaW5kZXggNmQ1MTMxZmViNzk5NzZjN2M0NWY0NmNjM2Iy MDVlOWU5NTYwM2I4Zi4uNDNlNmVjZjY1YWI4ZjkyMjEzYTNhZmY0ZWE3NWNhZjRmNzEwMzg4ZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVV cGRhdGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVy VHJlZVVwZGF0ZXIuY3BwCkBAIC0yOTcsNyArMjk3LDcgQEAgdm9pZCBSZW5kZXJUcmVlVXBkYXRl cjo6dXBkYXRlUmVuZGVyZXJTdHlsZShSZW5kZXJFbGVtZW50JiByZW5kZXJlciwgUmVuZGVyU3R5 bGUKICAgICBtX2J1aWxkZXIubm9ybWFsaXplVHJlZUFmdGVyU3R5bGVDaGFuZ2UocmVuZGVyZXIs IG9sZFN0eWxlKTsKICNpZiBFTkFCTEUoTEFZT1VUX0ZPUk1BVFRJTkdfQ09OVEVYVCkKICAgICBp ZiAoUnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKS5sYXlvdXRGb3JtYXR0 aW5nQ29udGV4dEVuYWJsZWQoKSkgewotICAgICAgICBpZiAoIW1fZG9jdW1lbnQudmlldygpIHx8 IG1fZG9jdW1lbnQudmlldygpLT5sYXlvdXRDb250ZXh0KCkubGF5b3V0Rm9ybWF0dGluZ1N0YXRl KCkpCisgICAgICAgIGlmICghbV9kb2N1bWVudC52aWV3KCkgfHwgIW1fZG9jdW1lbnQudmlldygp LT5sYXlvdXRDb250ZXh0KCkubGF5b3V0Rm9ybWF0dGluZ1N0YXRlKCkpCiAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgIGlmIChhdXRvKiBsYXlvdXRCb3ggPSBtX2RvY3VtZW50LnZpZXcoKS0+ bGF5b3V0Q29udGV4dCgpLmxheW91dFRyZWVDb250ZW50KCktPmxheW91dEJveEZvclJlbmRlcmVy KHJlbmRlcmVyKSkKICAgICAgICAgICAgIGxheW91dEJveC0+dXBkYXRlU3R5bGUobmV3U3R5bGUp Owo=