204280 2019-11-16 16:56:58 -0800 REGRESSION (r243606): Interacting with date and time pickers hangs the UI process on watchOS 2019-11-16 20:04:23 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes bdakin cdumez commit-queue dbates thorton webkit-bug-importer oldest_to_newest 1590916 0 wenson_hsieh 2019-11-16 16:56:58 -0800 <rdar://problem/49718359> 1590917 1 wenson_hsieh 2019-11-16 16:57:41 -0800 This is also responsible for fast/forms/watchos/time-picker-value-change.html timing out. 1590919 2 383710 wenson_hsieh 2019-11-16 18:45:51 -0800 Created attachment 383710 Patch 1590923 3 383710 commit-queue 2019-11-16 20:04:22 -0800 Comment on attachment 383710 Patch Clearing flags on attachment: 383710 Committed r252529: <https://trac.webkit.org/changeset/252529> 1590924 4 commit-queue 2019-11-16 20:04:23 -0800 All reviewed patches have been landed. Closing bug. 383710 2019-11-16 18:45:51 -0800 2019-11-16 20:04:22 -0800 Patch bug-204280-20191116184550.patch text/plain 6421 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFkODcyOTRlZTU4ZThhZDlh ZDVlZmVmNGM0MzJjN2EyNzE5MDQ4NjQuLmMwYmI3Yzc5NGJmZmNkYTMxYTc2OTAxYWY1NzM4MWRm NmI4YzdlNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTktMTEtMTYgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI0 MzYwNik6IEludGVyYWN0aW5nIHdpdGggZGF0ZSBhbmQgdGltZSBwaWNrZXJzIGhhbmdzIHRoZSBV SSBwcm9jZXNzIG9uIHdhdGNoT1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwNDI4MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk3MTgzNTk+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWZ0ZXIgcjI0 MzYwNiwgaW50ZXJhY3Rpbmcgd2l0aCBkYXRlIGFuZCB0aW1lIGlucHV0cyBvbiB3YXRjaE9TIGhh bmdzIHRoZSBVSSBwcm9jZXNzIGluZGVmaW5pdGVseSB3aGlsZQorICAgICAgICBhdHRlbXB0aW5n IHRvIGNyZWF0ZSBhbiBpbnB1dCBwZXJpcGhlcmFsIChXS0Zvcm1JbnB1dENvbnRyb2wpIGZvciB0 aGUgZGF0ZSBvciB0aW1lIHBpY2tlci4gVGhpcyBpcyBiZWNhdXNlLCBpbgorICAgICAgICB0aGUg cHJvY2VzcyBvZiBzZXR0aW5nIHVwIGEgbmV3IFdLRGF0ZVRpbWVQaWNrZXIsIHdlIGNhbGwgaW50 byArW1VJS2V5Ym9hcmQgZGVmYXVsdFNpemVGb3JJbnRlcmZhY2VPcmllbnRhdGlvbjpdCisgICAg ICAgIHdoaWNoIGhhbmdzIHdoZW4gYXR0ZW1wdGluZyB0byBmZXRjaCB0aGUgY3VycmVudCBVSUtp dCBrZXlib2FyZCBsYXlvdXQgdHlwZS4KKworICAgICAgICBUbyBhZGRyZXNzIHRoaXMsIHdlIHNp bXBseSBhdm9pZCBzZXR0aW5nIF9pbnB1dFBlcmlwaGVyYWwgb24gd2F0Y2hPUywgYXMgd2UgZGlk IHByaW9yIHRvIHIyNDM2MDYuIENvdmVyZWQgYnkgdGhlCisgICAgICAgIGV4aXN0aW5nIGxheW91 dCB0ZXN0IGZhc3QvZm9ybXMvd2F0Y2hvcy90aW1lLXBpY2tlci12YWx1ZS1jaGFuZ2UuaHRtbCwg d2hpY2ggY3VycmVudGx5IHRpbWVzIG91dC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoY3JlYXRlSW5wdXRQZXJpcGhlcmFs V2l0aFZpZXcpOgorCiAyMDE5LTExLTE1ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBw bGUuY29tPgogCiAgICAgICAgIERvbid0IHVzZSBBVkNhcHR1cmUgb24gd2F0Y2hPUyBhbmQgdHZP UwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KaW5kZXggMmQwM2ZjMDcxY2JhOTY3YWY5YjYxY2YyMzkzN2E2ODQwMDdl ODYwNC4uYjFjMzY4NmQ4YjkxMTQ4YzdhMjNkNTU5MmE0NmNiZWVkZGY5MTQ5YyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tCkBAIC01NDYzLDE2ICs1NDYzLDIyIEBAIHN0YXRpYyBXZWJDb3JlOjpGbG9hdFJlY3Qg cmVjdFRvUmV2ZWFsV2hlblpvb21pbmdUb0ZvY3VzZWRFbGVtZW50KGNvbnN0IFdlYktpdDo6CiAK IHN0YXRpYyBSZXRhaW5QdHI8TlNPYmplY3QgPFdLRm9ybVBlcmlwaGVyYWw+PiBjcmVhdGVJbnB1 dFBlcmlwaGVyYWxXaXRoVmlldyhXZWJLaXQ6OklucHV0VHlwZSB0eXBlLCBXS0NvbnRlbnRWaWV3 ICp2aWV3KQogeworI2lmIFBMQVRGT1JNKFdBVENIT1MpCisgICAgVU5VU0VEX1BBUkFNKHR5cGUp OworICAgIFVOVVNFRF9QQVJBTSh2aWV3KTsKKyAgICByZXR1cm4gbmlsOworI2Vsc2UKICAgICBz d2l0Y2ggKHR5cGUpIHsKICAgICBjYXNlIFdlYktpdDo6SW5wdXRUeXBlOjpTZWxlY3Q6CiAgICAg ICAgIHJldHVybiBhZG9wdE5TKFtbV0tGb3JtU2VsZWN0Q29udHJvbCBhbGxvY10gaW5pdFdpdGhW aWV3OnZpZXddKTsKICNpZiBFTkFCTEUoSU5QVVRfVFlQRV9DT0xPUikKICAgICBjYXNlIFdlYktp dDo6SW5wdXRUeXBlOjpDb2xvcjoKICAgICAgICAgcmV0dXJuIGFkb3B0TlMoW1tXS0Zvcm1Db2xv ckNvbnRyb2wgYWxsb2NdIGluaXRXaXRoVmlldzp2aWV3XSk7Ci0jZW5kaWYKKyNlbmRpZiAvLyBF TkFCTEUoSU5QVVRfVFlQRV9DT0xPUikKICAgICBkZWZhdWx0OgogICAgICAgICByZXR1cm4gYWRv cHROUyhbW1dLRm9ybUlucHV0Q29udHJvbCBhbGxvY10gaW5pdFdpdGhWaWV3OnZpZXddKTsKICAg ICB9CisjZW5kaWYKIH0KIAogLSAodm9pZClfZWxlbWVudERpZEZvY3VzOihjb25zdCBXZWJLaXQ6 OkZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24mKWluZm9ybWF0aW9uIHVzZXJJc0ludGVyYWN0aW5n OihCT09MKXVzZXJJc0ludGVyYWN0aW5nIGJsdXJQcmV2aW91c05vZGU6KEJPT0wpYmx1clByZXZp b3VzTm9kZSBhY3Rpdml0eVN0YXRlQ2hhbmdlczooT3B0aW9uU2V0PFdlYkNvcmU6OkFjdGl2aXR5 U3RhdGU6OkZsYWc+KWFjdGl2aXR5U3RhdGVDaGFuZ2VzIHVzZXJPYmplY3Q6KE5TT2JqZWN0IDxO U1NlY3VyZUNvZGluZz4gKil1c2VyT2JqZWN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWRkMjhkMWUyYjNkMmZkOWU5ZjA5 YTcyMTYyOTI2N2NjOTZhYjYzYy4uNTc5ODdiYjZhMDRiNTBiZTA3YjU3MjcyM2MwMmNhZmNkZTdm NDJkNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTExLTE2ICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNDM2MDYpOiBJ bnRlcmFjdGluZyB3aXRoIGRhdGUgYW5kIHRpbWUgcGlja2VycyBoYW5ncyB0aGUgVUkgcHJvY2Vz cyBvbiB3YXRjaE9TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDQyODAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5NzE4MzU5PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENsZWFuIHVwIGEgZmV3IGRl dGFpbHMgaW4gdGhlIGxheW91dCB0ZXN0LgorCisgICAgICAgICogZmFzdC9mb3Jtcy93YXRjaG9z L3RpbWUtcGlja2VyLXZhbHVlLWNoYW5nZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9m b3Jtcy93YXRjaG9zL3RpbWUtcGlja2VyLXZhbHVlLWNoYW5nZS5odG1sOgorCisgICAgICAgIFR3 ZWFrIHRoZSB0ZXN0IGRlc2NyaXB0aW9uLCBhbmQgc2ltcGxpZnkgbG9naWMgZm9yIGNvbXBsZXRp bmcgdGhlIGxheW91dCB0ZXN0LgorCiAyMDE5LTExLTE2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5v cm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjUy NTI2LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy93YXRjaG9zL3RpbWUtcGlj a2VyLXZhbHVlLWNoYW5nZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3dh dGNob3MvdGltZS1waWNrZXItdmFsdWUtY2hhbmdlLWV4cGVjdGVkLnR4dAppbmRleCBhYmMxNGNk YTBiZDkzNWIwYjliZTAxMzA4MTdhOGM0MjliZGFlMmRjLi5iN2M2N2Q0NjdlMmE0N2Y1MjVhOTVj OWFmNTY2NzU3Zjc2YTJjOTIxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3dh dGNob3MvdGltZS1waWNrZXItdmFsdWUtY2hhbmdlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2Zvcm1zL3dhdGNob3MvdGltZS1waWNrZXItdmFsdWUtY2hhbmdlLWV4cGVjdGVk LnR4dApAQCAtMSwzICsxLDEwIEBACitUaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCB0aGUgdGltZSBw aWNrZXIgaXMgcHJlc2VudGVkIGFuZCBjYW4gYmUgdXNlZCB0byBjaG9vc2UgYSB0aW1lLiBUbyBt YW51YWxseSBydW4gdGhlIHRlc3QsIHRhcCB0aGUgdGltZSBpbnB1dCB0byBzaG93IHRoZSB0aW1l IHBpY2tlciwgYW5kIHRoZW4gc2VsZWN0ICc5OjQxIGFtJy4KKworT24gc3VjY2VzcywgeW91IHdp bGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09N UExFVEUiLgorCisKK1BBU1MgSGFuZGxlZCBjaGFuZ2UgZXZlbnQKK1BBU1MgSGFuZGxlZCBibHVy IGV2ZW50CiBQQVNTIHRpbWUudmFsdWUgaXMgJzA5OjQxJwogUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3dhdGNob3Mv dGltZS1waWNrZXItdmFsdWUtY2hhbmdlLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3dh dGNob3MvdGltZS1waWNrZXItdmFsdWUtY2hhbmdlLmh0bWwKaW5kZXggM2ZmZTRlOTBlYmY4OGU2 NDZjNDZkYTU3YzhkNzRiMjk5ZTFkM2NiMS4uODMxYjg2MDdhMjljYzY5YjQxZTUwMGY4NmMzZWQx ZTY3MGZhYTcyNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy93YXRjaG9zL3Rp bWUtcGlja2VyLXZhbHVlLWNoYW5nZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMv d2F0Y2hvcy90aW1lLXBpY2tlci12YWx1ZS1jaGFuZ2UuaHRtbApAQCAtNSwzNCArNSwyNyBAQAog PHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LmpzIj48L3NjcmlwdD4KIDxz Y3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvdWktaGVscGVyLmpzIj48L3NjcmlwdD4KIDxz Y3JpcHQ+Ci1kb25lQ291bnQgPSAwOwoganNUZXN0SXNBc3luYyA9IHRydWU7CiAKIGFzeW5jIGZ1 bmN0aW9uIHJ1blRlc3QoKSB7Ci0gICAgaWYgKCF3aW5kb3cudGVzdFJ1bm5lcikgewotICAgICAg ICBkZXNjcmlwdGlvbihgVGhpcyB0ZXN0IHJlcXVpcmVzIFdlYktpdFRlc3RSdW5uZXIuYCk7Ci0g ICAgICAgIHJldHVybjsKLSAgICB9CisgICAgZGVzY3JpcHRpb24oYFRoaXMgdGVzdCB2ZXJpZmll cyB0aGF0IHRoZSB0aW1lIHBpY2tlciBpcyBwcmVzZW50ZWQgYW5kIGNhbiBiZSB1c2VkIHRvIGNo b29zZSBhIHRpbWUuIFRvIG1hbnVhbGx5IHJ1biB0aGUgdGVzdCwgdGFwIHRoZSB0aW1lIGlucHV0 IHRvIHNob3cgdGhlIHRpbWUgcGlja2VyLCBhbmQgdGhlbiBzZWxlY3QgJzk6NDEgYW0nLmApOwog CiAgICAgdGltZSA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoImlucHV0Iik7Ci0gICAgdGltZS5h ZGRFdmVudExpc3RlbmVyKCJjaGFuZ2UiLCBjaGVja0RvbmUpOwotICAgIHRpbWUuYWRkRXZlbnRM aXN0ZW5lcigiYmx1ciIsIGNoZWNrRG9uZSk7Ci0KLSAgICBhd2FpdCBVSUhlbHBlci5hY3RpdmF0 ZUFuZFdhaXRGb3JJbnB1dFNlc3Npb25BdCg3NSwgNzUpOwotICAgIFVJSGVscGVyLndhaXRGb3JL ZXlib2FyZFRvSGlkZSgpLnRoZW4oY2hlY2tEb25lKQotICAgIFVJSGVscGVyLnNldFRpbWVQaWNr ZXJWYWx1ZSg5LCA0MSk7Ci19CisgICAgdGltZS5hZGRFdmVudExpc3RlbmVyKCJjaGFuZ2UiLCAo KSA9PiB0ZXN0UGFzc2VkKCJIYW5kbGVkIGNoYW5nZSBldmVudCIpKTsKKyAgICB0aW1lLmFkZEV2 ZW50TGlzdGVuZXIoImJsdXIiLCAoKSA9PiB0ZXN0UGFzc2VkKCJIYW5kbGVkIGJsdXIgZXZlbnQi KSk7CiAKLWZ1bmN0aW9uIGNoZWNrRG9uZSgpIHsKLSAgICBpZiAoKytkb25lQ291bnQgPCAzKQor ICAgIGlmICghd2luZG93LnRlc3RSdW5uZXIpCiAgICAgICAgIHJldHVybjsKIAorICAgIGF3YWl0 IFVJSGVscGVyLmFjdGl2YXRlRWxlbWVudEFuZFdhaXRGb3JJbnB1dFNlc3Npb24odGltZSk7Cisg ICAgYXdhaXQgVUlIZWxwZXIuc2V0VGltZVBpY2tlclZhbHVlKDksIDQxKTsKKyAgICBhd2FpdCBV SUhlbHBlci53YWl0Rm9yS2V5Ym9hcmRUb0hpZGUoKTsKICAgICBzaG91bGRCZSgidGltZS52YWx1 ZSIsICInMDk6NDEnIik7CiAgICAgZmluaXNoSlNUZXN0KCk7CiB9CiA8L3NjcmlwdD4KIDwvaGVh ZD4KIDxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KLTxpbnB1dCB0eXBlPSJ0aW1lIiB2YWx1ZT0i MDQ6MDEiIHN0eWxlPSJ3aWR0aDogMzIwcHg7IGhlaWdodDogNTY4cHg7Ij48L2lucHV0PgorPGlu cHV0IHR5cGU9InRpbWUiIHZhbHVlPSIwNDowMSIgc3R5bGU9IndpZHRoOiAzMjBweDsgaGVpZ2h0 OiAxMDBweDsiPjwvaW5wdXQ+CiA8L2JvZHk+CiA8L2h0bWw+Cg==