204266 2019-11-15 17:13:03 -0800 Web Inspector: Elements: copying multiple DOM nodes should copy more than just the last selected node 2019-11-18 17:36:18 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1590766 0 hi 2019-11-15 17:13:03 -0800 # STEPS TO REPRODUCE: 1. inspect any page 2. select more than one node in the Elements Tab 3. copy => only the last selected node is copied to the clipboard 1590768 1 383673 hi 2019-11-15 17:22:15 -0800 Created attachment 383673 Patch 1591290 2 383673 bburg 2019-11-18 15:49:36 -0800 Comment on attachment 383673 Patch r=me I wish we could test this. 1591362 3 383673 commit-queue 2019-11-18 17:35:36 -0800 Comment on attachment 383673 Patch Clearing flags on attachment: 383673 Committed r252615: <https://trac.webkit.org/changeset/252615> 1591363 4 commit-queue 2019-11-18 17:35:37 -0800 All reviewed patches have been landed. Closing bug. 1591365 5 webkit-bug-importer 2019-11-18 17:36:18 -0800 <rdar://problem/57306174> 383673 2019-11-15 17:22:15 -0800 2019-11-18 17:35:36 -0800 Patch bug-204266-20191115172214.patch text/plain 5155 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY5NWRmZjEwMmM4Nzc2MmE2YmIxY2Q1ZDk0ZTc0 MmM3YmNjYzRmMzAuLmU5ZTczMWQ3NjllNzE0MGZkMTcyMDg1ZjkxNTc0YzQ0OTdkMjdiOGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE5LTExLTE1ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBF bGVtZW50czogY29weWluZyBtdWx0aXBsZSBET00gbm9kZXMgc2hvdWxkIGNvcHkgbW9yZSB0aGFu IGp1c3QgdGhlIGxhc3Qgc2VsZWN0ZWQgbm9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MjY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVDb250ZW50 Vmlldy5qczoKKyAgICAgICAgKFdJLkRPTVRyZWVDb250ZW50Vmlldy5wcm90b3R5cGUuYXN5bmMg aGFuZGxlQ29weUV2ZW50KTogQWRkZWQuCisgICAgICAgIChXSS5ET01UcmVlQ29udGVudFZpZXcu cHJvdG90eXBlLmhhbmRsZUNvcHlFdmVudCk6IERlbGV0ZWQuCisgICAgICAgIENhbGwgYERPTS5n ZXRPdXRlckhUTUxgIGZvciBlYWNoIHNlbGVjdGVkIERPTSBub2RlIGFuZCBqb2luIHRoZSByZXN1 bHRzIHdpdGggbmV3bGluZXMuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9ET01O b2RlLmpzOgorICAgICAgICAoV0kuRE9NTm9kZS5wcm90b3R5cGUuZ2V0T3V0ZXJIVE1MKToKKyAg ICAgICAgKFdJLkRPTU5vZGUucHJvdG90eXBlLmNvcHlOb2RlKTogRGVsZXRlZC4KKyAgICAgICAg KFdJLkRPTU5vZGUucHJvdG90eXBlLmNvcHlOb2RlLmNvcHkpOiBEZWxldGVkLgorICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanM6CisgICAgICAgIChXSS5ET01U cmVlRWxlbWVudC5wcm90b3R5cGUucG9wdWxhdGVET01Ob2RlQ29udGV4dE1lbnUpOgorICAgICAg ICAoV0kuRE9NVHJlZUVsZW1lbnQucHJvdG90eXBlLl9jb3B5SFRNTCk6IERlbGV0ZWQuCisgICAg ICAgIFNpbXBsaWZ5IEFQSSBzdXJmYWNlLgorCiAyMDE5LTExLTEyICBEZXZpbiBSb3Vzc28gIDxk cm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBMb2NhbCBPdmVycmlk ZXM6IGRyb3Agem9uZSBvdmVybGF5IGRvZXNuJ3QgdGFrZSB1cCB0aGUgZnVsbCBjb250ZW50IGFy ZWEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVs cy9ET01Ob2RlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxz L0RPTU5vZGUuanMKaW5kZXggYTI3ZTFkOTFhYTBhYzU2NWQ5ODE4MTEyZjAwODQwYzIzOTM0ODk0 Zi4uZGQzYzJhNTU5Y2Y0N2Q1OGZmZDRiNjM4ZWFjOWQxYTljMTAzMTY4ZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGUuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGUuanMK QEAgLTU0OSw3ICs1NDksMTAgQEAgV0kuRE9NTm9kZSA9IGNsYXNzIERPTU5vZGUgZXh0ZW5kcyBX SS5PYmplY3QKICAgICBnZXRPdXRlckhUTUwoY2FsbGJhY2spCiAgICAgewogICAgICAgICBsZXQg dGFyZ2V0ID0gV0kuYXNzdW1pbmdNYWluVGFyZ2V0KCk7Ci0gICAgICAgIHRhcmdldC5ET01BZ2Vu dC5nZXRPdXRlckhUTUwodGhpcy5pZCwgY2FsbGJhY2spOworICAgICAgICBpZiAodHlwZW9mIGNh bGxiYWNrID09PSAiZnVuY3Rpb24iKQorICAgICAgICAgICAgdGFyZ2V0LkRPTUFnZW50LmdldE91 dGVySFRNTCh0aGlzLmlkLCBjYWxsYmFjayk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHJl dHVybiB0YXJnZXQuRE9NQWdlbnQuZ2V0T3V0ZXJIVE1MKHRoaXMuaWQpLnRoZW4oKHtvdXRlckhU TUx9KSA9PiBvdXRlckhUTUwpOwogICAgIH0KIAogICAgIHNldE91dGVySFRNTChodG1sLCBjYWxs YmFjaykKQEAgLTU4NywxOCArNTkwLDYgQEAgV0kuRE9NTm9kZSA9IGNsYXNzIERPTU5vZGUgZXh0 ZW5kcyBXSS5PYmplY3QKICAgICAgICAgdGFyZ2V0LkRPTUFnZW50LnJlbW92ZU5vZGUodGhpcy5p ZCwgdGhpcy5fbWFrZVVuZG9hYmxlQ2FsbGJhY2soY2FsbGJhY2spKTsKICAgICB9CiAKLSAgICBj b3B5Tm9kZSgpCi0gICAgewotICAgICAgICBmdW5jdGlvbiBjb3B5KGVycm9yLCB0ZXh0KQotICAg ICAgICB7Ci0gICAgICAgICAgICBpZiAoIWVycm9yKQotICAgICAgICAgICAgICAgIEluc3BlY3Rv ckZyb250ZW5kSG9zdC5jb3B5VGV4dCh0ZXh0KTsKLSAgICAgICAgfQotCi0gICAgICAgIGxldCB0 YXJnZXQgPSBXSS5hc3N1bWluZ01haW5UYXJnZXQoKTsKLSAgICAgICAgdGFyZ2V0LkRPTUFnZW50 LmdldE91dGVySFRNTCh0aGlzLmlkLCBjb3B5KTsKLSAgICB9Ci0KICAgICBnZXRFdmVudExpc3Rl bmVycyhjYWxsYmFjaykKICAgICB7CiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KFdJLmRvbU1hbmFn ZXIuaW5zcGVjdGVkTm9kZSA9PT0gdGhpcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlQ29udGVudFZpZXcuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlQ29udGVudFZpZXcuanMK aW5kZXggOGI2OWVkMWUzZjBlYjU0ODc3MTBiMjg2MDQyOWYyMmIyMTU2ZmZmNC4uNWRlYzdkNDBi ZThkYTMxODQ3ZjIzOGQxZmEzYzhjNmMwZGUwY2Q4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUNvbnRlbnRWaWV3LmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVDb250ZW50 Vmlldy5qcwpAQCAtMjE5LDE2ICsyMTksMjMgQEAgV0kuRE9NVHJlZUNvbnRlbnRWaWV3ID0gY2xh c3MgRE9NVHJlZUNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZXcKICAgICAgICAgdGhp cy5fZG9tVHJlZU91dGxpbmUuc2VsZWN0RE9NTm9kZShkb21Ob2RlLCAhcHJldmVudEZvY3VzQ2hh bmdlKTsKICAgICB9CiAKLSAgICBoYW5kbGVDb3B5RXZlbnQoZXZlbnQpCisgICAgYXN5bmMgaGFu ZGxlQ29weUV2ZW50KGV2ZW50KQogICAgIHsKLSAgICAgICAgdmFyIHNlbGVjdGVkRE9NTm9kZSA9 IHRoaXMuX2RvbVRyZWVPdXRsaW5lLnNlbGVjdGVkRE9NTm9kZSgpOwotICAgICAgICBpZiAoIXNl bGVjdGVkRE9NTm9kZSkKKyAgICAgICAgbGV0IHByb21pc2VzID0gW107CisKKyAgICAgICAgZm9y IChsZXQgdHJlZUVsZW1lbnQgb2YgdGhpcy5fZG9tVHJlZU91dGxpbmUuc2VsZWN0ZWRUcmVlRWxl bWVudHMpIHsKKyAgICAgICAgICAgIGlmICh0cmVlRWxlbWVudC5yZXByZXNlbnRlZE9iamVjdCBp bnN0YW5jZW9mIFdJLkRPTU5vZGUpCisgICAgICAgICAgICAgICAgcHJvbWlzZXMucHVzaCh0cmVl RWxlbWVudC5yZXByZXNlbnRlZE9iamVjdC5nZXRPdXRlckhUTUwoKSk7CisgICAgICAgIH0KKwor ICAgICAgICBpZiAoIXByb21pc2VzLmxlbmd0aCkKICAgICAgICAgICAgIHJldHVybjsKIAogICAg ICAgICBldmVudC5jbGlwYm9hcmREYXRhLmNsZWFyRGF0YSgpOwogICAgICAgICBldmVudC5wcmV2 ZW50RGVmYXVsdCgpOwogCi0gICAgICAgIHNlbGVjdGVkRE9NTm9kZS5jb3B5Tm9kZSgpOworICAg ICAgICBsZXQgb3V0ZXJIVE1McyA9IGF3YWl0IFByb21pc2UuYWxsKHByb21pc2VzKTsKKyAgICAg ICAgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNvcHlUZXh0KG91dGVySFRNTHMuam9pbigiXG4iKSk7 CiAgICAgfQogCiAgICAgaGFuZGxlUGFzdGVFdmVudChldmVudCkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50LmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQu anMKaW5kZXggMGNmMTZkMjU3M2NjYjcxM2U4NDgwM2M5NGRiYjFhMWUzMDI0ZDhmMS4uODU1MmRk ZjQxZmI4Mzg2MGUzZTU1ODU0ODYyNzAxNjJkOWIyZWQ1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQu anMKQEAgLTgzMiw3ICs4MzIsMTAgQEAgV0kuRE9NVHJlZUVsZW1lbnQgPSBjbGFzcyBET01UcmVl RWxlbWVudCBleHRlbmRzIFdJLlRyZWVFbGVtZW50CiAKICAgICAgICAgaWYgKCF0aGlzLnJlcHJl c2VudGVkT2JqZWN0LmlzUHNldWRvRWxlbWVudCgpKSB7CiAgICAgICAgICAgICBzdWJNZW51cy5j b3B5LmFwcGVuZEl0ZW0oV0kuVUlTdHJpbmcoIkhUTUwiKSwgKCkgPT4gewotICAgICAgICAgICAg ICAgIHRoaXMuX2NvcHlIVE1MKCk7CisgICAgICAgICAgICAgICAgdGhpcy5yZXByZXNlbnRlZE9i amVjdC5nZXRPdXRlckhUTUwoKQorICAgICAgICAgICAgICAgIC50aGVuKChvdXRlckhUTUwpID0+ IHsKKyAgICAgICAgICAgICAgICAgICAgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNvcHlUZXh0KG91 dGVySFRNTCk7CisgICAgICAgICAgICAgICAgfSk7CiAgICAgICAgICAgICB9KTsKICAgICAgICAg fQogCkBAIC0xNzkyLDExICsxNzk1LDYgQEAgV0kuRE9NVHJlZUVsZW1lbnQgPSBjbGFzcyBET01U cmVlRWxlbWVudCBleHRlbmRzIFdJLlRyZWVFbGVtZW50CiAgICAgICAgIH0pOwogICAgIH0KIAot ICAgIF9jb3B5SFRNTCgpCi0gICAgewotICAgICAgICB0aGlzLnJlcHJlc2VudGVkT2JqZWN0LmNv cHlOb2RlKCk7Ci0gICAgfQotCiAgICAgX2hpZ2hsaWdodFNlYXJjaFJlc3VsdHMoKQogICAgIHsK ICAgICAgICAgaWYgKCF0aGlzLnRpdGxlIHx8ICF0aGlzLl9zZWFyY2hRdWVyeSB8fCAhdGhpcy5f c2VhcmNoSGlnaGxpZ2h0c1Zpc2libGUpCg==