204264 2019-11-15 16:59:19 -0800 [JSC] DFG strength reduction should define "groups" for RegExp constant-folded result 2019-11-15 17:26:12 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 204067 1 ysuzuki ysuzuki msaboff ross.kirsling webkit-bug-importer oldest_to_newest 1590756 0 ysuzuki 2019-11-15 16:59:19 -0800 ... 1590757 1 ysuzuki 2019-11-15 16:59:57 -0800 After https://bugs.webkit.org/show_bug.cgi?id=204067, we are always defining "groups" property, but DFG strength reduction does not agree. 1590765 2 383671 ysuzuki 2019-11-15 17:12:16 -0800 Created attachment 383671 Patch 1590770 3 383671 msaboff 2019-11-15 17:22:56 -0800 Comment on attachment 383671 Patch r=me. Always creating "groups" including creating an undefined "groups" for str.match() results where there aren't any named capture groups is compliant with the ECMA-262 spec. 1590772 4 ysuzuki 2019-11-15 17:24:39 -0800 (In reply to Michael Saboff from comment #3) > Comment on attachment 383671 [details] > Patch > > r=me. Always creating "groups" including creating an undefined "groups" for > str.match() results where there aren't any named capture groups is compliant > with the ECMA-262 spec. Yes, now it is updated and defining undefined for "groups" if named capture groups do not exist is the spec compliant behavior :) 1590773 5 ysuzuki 2019-11-15 17:25:27 -0800 Committed r252514: <https://trac.webkit.org/changeset/252514> 1590776 6 ysuzuki 2019-11-15 17:26:12 -0800 <rdar://problem/57186234> 383671 2019-11-15 17:12:16 -0800 2019-11-15 17:22:56 -0800 Patch bug-204264-20191115171216.patch text/plain 5220 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ZWU4Njc1NDk5NjQwZTYzZDZlYWRlOGRmOTE3ZWJlYmExNzBiODQ4Li43NjhmNjAxZjA4YWNlY2Q1 ZGE3Y2I1NWQ4MDFjNDdkNzI4MjQ2OGI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOS0xMS0xNSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIERGRyBzdHJlbmd0aCByZWR1Y3Rpb24gc2hvdWxkIGRlZmluZSAi Z3JvdXBzIiBmb3IgUmVnRXhwIGNvbnN0YW50LWZvbGRlZCByZXN1bHQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDI2NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGFsd2F5cyBkZWZpbmUgImdyb3Vw cyIgcHJvcGVydHkgaW4gdGhlIHJlc3VsdCBvZiBSZWdFeHAgbWF0Y2hpbmcuCisgICAgICAgIEJ1 dCB3ZSBkbyBub3QgZGVmaW5lIGl0IHdoZW4gREZHIHBlcmZvcm1zIHN0cmVuZ3RoLXJlZHVjdGlv biBmb3IgdGhlIFJlZ0V4cCBtYXRjaGluZyBub2RlLgorICAgICAgICBUaGlzIHBhdGNoIGFkZHMg Imdyb3VwcyIgZmllbGQgY29ycmVjdGx5LgorCisgICAgICAgICogZGZnL0RGR1N0cmVuZ3RoUmVk dWN0aW9uUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlN0cmVuZ3RoUmVkdWN0aW9uUGhh c2U6OmhhbmRsZU5vZGUpOgorICAgICAgICAqIHJ1bnRpbWUvUmVnRXhwTWF0Y2hlc0FycmF5LmNw cDoKKyAgICAgICAgKEpTQzo6Y3JlYXRlRW1wdHlSZWdFeHBNYXRjaGVzQXJyYXkpOgorCiAyMDE5 LTExLTE1ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgV2Fz bSBlcnJvciBtZXNzYWdlIHNob3VsZCBiZSBjcm9zcy10aHJlYWQtY29waWVkCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1N0cmVuZ3RoUmVkdWN0aW9uUGhhc2UuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTdHJlbmd0aFJlZHVjdGlvblBoYXNlLmNw cAppbmRleCAxNDNlYjQ2MjQ0OTViZWMxNzc0MzA5MzIwYzBlOWZlODUzOTM5NTAxLi5lYjNkZGJk NzE4NDNkNDlmNjViMzJjZTk2MWZmOWEwNzEyYTFhMDUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1N0cmVuZ3RoUmVkdWN0aW9uUGhhc2UuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3RyZW5ndGhSZWR1Y3Rpb25QaGFzZS5jcHAKQEAgLTY2 OSw4ICs2NjksMTAgQEAgY2xhc3MgU3RyZW5ndGhSZWR1Y3Rpb25QaGFzZSA6IHB1YmxpYyBQaGFz ZSB7CiAKICAgICAgICAgICAgICAgICAgICAgICAgIFVuaXF1ZWRTdHJpbmdJbXBsKiBpbmRleFVJ RCA9IHZtKCkucHJvcGVydHlOYW1lcy0+aW5kZXguaW1wbCgpOwogICAgICAgICAgICAgICAgICAg ICAgICAgVW5pcXVlZFN0cmluZ0ltcGwqIGlucHV0VUlEID0gdm0oKS5wcm9wZXJ0eU5hbWVzLT5p bnB1dC5pbXBsKCk7CisgICAgICAgICAgICAgICAgICAgICAgICBVbmlxdWVkU3RyaW5nSW1wbCog Z3JvdXBzVUlEID0gdm0oKS5wcm9wZXJ0eU5hbWVzLT5ncm91cHMuaW1wbCgpOwogICAgICAgICAg ICAgICAgICAgICAgICAgdW5zaWduZWQgaW5kZXhJbmRleCA9IG1fZ3JhcGguaWRlbnRpZmllcnMo KS5lbnN1cmUoaW5kZXhVSUQpOwogICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW5w dXRJbmRleCA9IG1fZ3JhcGguaWRlbnRpZmllcnMoKS5lbnN1cmUoaW5wdXRVSUQpOworICAgICAg ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgZ3JvdXBzSW5kZXggPSBtX2dyYXBoLmlkZW50aWZp ZXJzKCkuZW5zdXJlKGdyb3Vwc1VJRCk7CiAKICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2ln bmVkIGZpcnN0Q2hpbGQgPSBtX2dyYXBoLm1fdmFyQXJnQ2hpbGRyZW4uc2l6ZSgpOwogICAgICAg ICAgICAgICAgICAgICAgICAgbV9ncmFwaC5tX3ZhckFyZ0NoaWxkcmVuLmFwcGVuZCgKQEAgLTY5 OCw2ICs3MDAsMTQgQEAgY2xhc3MgU3RyZW5ndGhSZWR1Y3Rpb25QaGFzZSA6IHB1YmxpYyBQaGFz ZSB7CiAgICAgICAgICAgICAgICAgICAgICAgICBkYXRhLT5tX3Byb3BlcnRpZXMuYXBwZW5kKAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFByb21vdGVkTG9jYXRpb25EZXNjcmlwdG9yKE5h bWVkUHJvcGVydHlQTG9jLCBpbnB1dEluZGV4KSk7CiAKKyAgICAgICAgICAgICAgICAgICAgICAg IC8vIEZJWE1FOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NDY0 CisgICAgICAgICAgICAgICAgICAgICAgICAvLyBJbXBsZW1lbnQgc3RyZW5ndGggcmVkdWN0aW9u IG9wdGltaXphdGlvbiBmb3IgbmFtZWQgY2FwdHVyZSBncm91cHMuCisgICAgICAgICAgICAgICAg ICAgICAgICBtX2dyYXBoLm1fdmFyQXJnQ2hpbGRyZW4uYXBwZW5kKAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgIG1faW5zZXJ0aW9uU2V0Lmluc2VydENvbnN0YW50Rm9yVXNlKAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBtX25vZGVJbmRleCwgb3JpZ2luLCBqc1VuZGVmaW5l ZCgpLCBVbnR5cGVkVXNlKSk7CisgICAgICAgICAgICAgICAgICAgICAgICBkYXRhLT5tX3Byb3Bl cnRpZXMuYXBwZW5kKAorICAgICAgICAgICAgICAgICAgICAgICAgICAgIFByb21vdGVkTG9jYXRp b25EZXNjcmlwdG9yKE5hbWVkUHJvcGVydHlQTG9jLCBncm91cHNJbmRleCkpOworCiAgICAgICAg ICAgICAgICAgICAgICAgICBhdXRvIG1hdGVyaWFsaXplU3RyaW5nID0gWyZdIChjb25zdCBTdHJp bmcmIHN0cmluZykgLT4gTm9kZSogewogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChz dHJpbmcuaXNOdWxsKCkpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBu dWxscHRyOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhw TWF0Y2hlc0FycmF5LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cE1h dGNoZXNBcnJheS5jcHAKaW5kZXggZmU3NmMwMGI5OTk5MTBjMTczM2Q1NTc5YWQ1MzFjMGZjYTFm ZTVkOS4uZGY1ZTg0MGNmNmNmMGU2MWEyODQ2NjM1NWQ1YmJhNmU5M2FkMjRlNCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwTWF0Y2hlc0FycmF5LmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBNYXRjaGVzQXJyYXkuY3Bw CkBAIC02Nyw2ICs2Nyw3IEBAIEpTQXJyYXkqIGNyZWF0ZUVtcHR5UmVnRXhwTWF0Y2hlc0FycmF5 KEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIEpTU3RyaW5nKiBpCiAKICAgICBhcnJheS0+ cHV0RGlyZWN0V2l0aG91dEJhcnJpZXIoUmVnRXhwTWF0Y2hlc0FycmF5SW5kZXhQcm9wZXJ0eU9m ZnNldCwganNOdW1iZXIoLTEpKTsKICAgICBhcnJheS0+cHV0RGlyZWN0V2l0aG91dEJhcnJpZXIo UmVnRXhwTWF0Y2hlc0FycmF5SW5wdXRQcm9wZXJ0eU9mZnNldCwgaW5wdXQpOworICAgIGFycmF5 LT5wdXREaXJlY3RXaXRob3V0QmFycmllcihSZWdFeHBNYXRjaGVzQXJyYXlHcm91cHNQcm9wZXJ0 eU9mZnNldCwganNVbmRlZmluZWQoKSk7CiAgICAgcmV0dXJuIGFycmF5OwogfQogCmRpZmYgLS1n aXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDkzNzI0MjY1 MGU3MzBhN2M5MjVkNDJkYTkwNWQxZDRkZmMyOWNhN2EuLjNmMzY3NGNmOGU2YzRmY2RlNGRmMWQz MGI3ZTdhMGYwMTE2YmM0YzQgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pT VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMTEtMTUgIFl1c3VrZSBTdXp1 a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBbSlNDXSBERkcgc3RyZW5ndGggcmVk dWN0aW9uIHNob3VsZCBkZWZpbmUgImdyb3VwcyIgZm9yIFJlZ0V4cCBjb25zdGFudC1mb2xkZWQg cmVzdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDQyNjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHN0cmVzcy9kZmctc3RyZW5ndGgtcmVkdWN0aW9uLWZvci1yZWdleHAtc2hvdWxkLWluY2x1ZGUt Z3JvdXBzLXByb3BlcnR5LmpzOiBBZGRlZC4KKyAgICAgICAgKHNob3VsZEJlKToKKyAgICAgICAg KHRlc3QpOgorCiAyMDE5LTExLTE1ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+ CiAKICAgICAgICAgV2FzbSBlcnJvciBtZXNzYWdlIHNob3VsZCBiZSBjcm9zcy10aHJlYWQtY29w aWVkCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9kZmctc3RyZW5ndGgtcmVkdWN0aW9uLWZv ci1yZWdleHAtc2hvdWxkLWluY2x1ZGUtZ3JvdXBzLXByb3BlcnR5LmpzIGIvSlNUZXN0cy9zdHJl c3MvZGZnLXN0cmVuZ3RoLXJlZHVjdGlvbi1mb3ItcmVnZXhwLXNob3VsZC1pbmNsdWRlLWdyb3Vw cy1wcm9wZXJ0eS5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40YmMxY2UxNzY1MzJmMjcwOGE5NGJjNGFmNzhlNjY4 MmYyOGU4Nzg3Ci0tLSAvZGV2L251bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvZGZnLXN0cmVuZ3Ro LXJlZHVjdGlvbi1mb3ItcmVnZXhwLXNob3VsZC1pbmNsdWRlLWdyb3Vwcy1wcm9wZXJ0eS5qcwpA QCAtMCwwICsxLDE0IEBACitmdW5jdGlvbiBzaG91bGRCZShhY3R1YWwsIGV4cGVjdGVkKSB7Cisg ICAgaWYgKGFjdHVhbCAhPT0gZXhwZWN0ZWQpCisgICAgICAgIHRocm93IG5ldyBFcnJvcignYmFk IHZhbHVlOiAnICsgYWN0dWFsKTsKK30KK25vSW5saW5lKHNob3VsZEJlKTsKKworZnVuY3Rpb24g dGVzdCgpCit7CisgICAgdGhpcy54ID0gJ2EnLm1hdGNoKC9hLylbJ2dyb3VwcyddOworICAgIHNo b3VsZEJlKHRoaXMueCwgdW5kZWZpbmVkKTsKK30KK25vSW5saW5lKHRlc3QpOworZm9yIChsZXQg aT0wOyBpPDEwMDAwMDsgaSsrKQorICAgIHRlc3QoKTsK