204259 2019-11-15 15:56:37 -0800 [LFC][IFC] Optimize Line::isVisuallyEmpty for the most common inline content. 2019-11-17 12:01:42 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1590722 0 zalan 2019-11-15 15:56:37 -0800 move text check in front. 1590723 1 webkit-bug-importer 2019-11-15 15:56:51 -0800 <rdar://problem/57243610> 1590725 2 zalan 2019-11-15 16:02:27 -0800 (In reply to zalan from comment #0) > move text check in front. to the front even. 1590727 3 webkit-bug-importer 2019-11-15 16:02:44 -0800 <rdar://problem/57243816> 1590731 4 383660 zalan 2019-11-15 16:05:10 -0800 Created attachment 383660 Patch 1590925 5 383714 zalan 2019-11-16 21:29:19 -0800 Created attachment 383714 Patch 1590948 6 383714 commit-queue 2019-11-17 12:01:40 -0800 Comment on attachment 383714 Patch Clearing flags on attachment: 383714 Committed r252530: <https://trac.webkit.org/changeset/252530> 1590949 7 commit-queue 2019-11-17 12:01:42 -0800 All reviewed patches have been landed. Closing bug. 383660 2019-11-15 16:05:10 -0800 2019-11-16 21:29:17 -0800 Patch bug-204259-20191115160452.patch text/plain 2560 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTUxODg2YzhmZThmMDJi MDBmNWEwNWQ4ZTgxYzViYWU4MDBmMTk5Yi4uNmRjN2Q5MDRkZmY3NDg5ZWFmOWU1N2M5MmI4MzMx NTlkNzIwMzg2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTExLTE1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBPcHRpbWl6 ZSBMaW5lOjppc1Zpc3VhbGx5RW1wdHkgZm9yIHRoZSBtb3N0IGNvbW1vbiBpbmxpbmUgY29udGVu dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDI1 OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTcyNDM2MTA+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSB0aGUgY2hlY2sgb24gdGV4dCBjb250 ZW50IHRvIHRoZSBmcm9udC4KKworICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lu bGluZUxpbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lOjppc1Zpc3VhbGx5 RW1wdHkgY29uc3QpOgorCiAyMDE5LTExLTE1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5j b20+CiAKICAgICAgICAgW0xGQ11bSW52YWxpZGF0aW9uXSBSZXVzZSBGcmFtZVZpZXdMYXlvdXRD b250ZXh0OjptX2xheW91dFN0YXRlIGZvciBpbmNyZW1lbnRhbCBsYXlvdXQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuY3BwIGIv U291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKaW5k ZXggODFmYTI0MDMxYzI1NzhlYTMwYzQ0ZmNjMTBhODNmNGQ0YWI3YTRhNi4uODkxZGYxMTBjOGUw YTdhNWM4Yzc3NWMwYjE2ZWM5MzE2M2Q5YzlkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKQEAgLTE5MywxNCArMTkz LDE5IEBAIGJvb2wgTGluZTo6aXNWaXN1YWxseUVtcHR5KCkgY29uc3QKICAgICAvLyBSZXR1cm4g dHJ1ZSBmb3IgZW1wdHkgaW5saW5lIGNvbnRhaW5lcnMgbGlrZSA8c3Bhbj48L3NwYW4+LgogICAg IGF1dG8mIGZvcm1hdHRpbmdDb250ZXh0ID0gdGhpcy0+Zm9ybWF0dGluZ0NvbnRleHQoKTsKICAg ICBmb3IgKGF1dG8mIHJ1biA6IG1faW5saW5lSXRlbVJ1bnMpIHsKLSAgICAgICAgaWYgKHJ1bi0+ aXNDb250YWluZXJTdGFydCgpKSB7Ci0gICAgICAgICAgICBpZiAoIWlzSW5saW5lQ29udGFpbmVy Q29uc2lkZXJlZEVtcHR5KGZvcm1hdHRpbmdDb250ZXh0LCBydW4tPmxheW91dEJveCgpKSkKKyAg ICAgICAgaWYgKHJ1bi0+aXNUZXh0KCkpIHsKKyAgICAgICAgICAgIGlmICghcnVuLT5pc0NvbGxh cHNlZFRvWmVyb0FkdmFuY2VXaWR0aCgpKQogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK ICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICB9Ci0gICAgICAgIGlmIChydW4tPmlzQ29u dGFpbmVyRW5kKCkpCisgICAgICAgIGlmIChydW4tPmlzQ29udGFpbmVyU3RhcnQoKSB8fCBydW4t PmlzQ29udGFpbmVyRW5kKCkpIHsKKyAgICAgICAgICAgIGlmICghaXNJbmxpbmVDb250YWluZXJD b25zaWRlcmVkRW1wdHkoZm9ybWF0dGluZ0NvbnRleHQsIHJ1bi0+bGF5b3V0Qm94KCkpKQorICAg ICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAg ICBpZiAocnVuLT5sYXlvdXRCb3goKS5lc3RhYmxpc2hlc0Zvcm1hdHRpbmdDb250ZXh0KCkpIHsK KyAgICAgICAgfQorICAgICAgICBpZiAocnVuLT5pc0JveCgpKSB7CisgICAgICAgICAgICBpZiAo IXJ1bi0+bGF5b3V0Qm94KCkuZXN0YWJsaXNoZXNGb3JtYXR0aW5nQ29udGV4dCgpKQorICAgICAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgICAgIEFTU0VSVChydW4tPmxheW91dEJv eCgpLmlzSW5saW5lQmxvY2tCb3goKSk7CiAgICAgICAgICAgICBhdXRvJiBib3hHZW9tZXRyeSA9 IGZvcm1hdHRpbmdDb250ZXh0Lmdlb21ldHJ5Rm9yQm94KHJ1bi0+bGF5b3V0Qm94KCkpOwogICAg ICAgICAgICAgaWYgKCFib3hHZW9tZXRyeS53aWR0aCgpKQpAQCAtMjA5LDggKzIxNCw2IEBAIGJv b2wgTGluZTo6aXNWaXN1YWxseUVtcHR5KCkgY29uc3QKICAgICAgICAgICAgICAgICByZXR1cm4g ZmFsc2U7CiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgfQotICAgICAgICBpZiAoIXJ1 bi0+aXNUZXh0KCkgfHwgIXJ1bi0+aXNDb2xsYXBzZWRUb1plcm9BZHZhbmNlV2lkdGgoKSkKLSAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAgICAgcmV0dXJuIHRydWU7CiB9Cg== 383714 2019-11-16 21:29:19 -0800 2019-11-17 12:01:40 -0800 Patch bug-204259-20191116212900.patch text/plain 2936 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTUxODg2YzhmZThmMDJi MDBmNWEwNWQ4ZTgxYzViYWU4MDBmMTk5Yi4uNmRjN2Q5MDRkZmY3NDg5ZWFmOWU1N2M5MmI4MzMx NTlkNzIwMzg2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTExLTE1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBPcHRpbWl6 ZSBMaW5lOjppc1Zpc3VhbGx5RW1wdHkgZm9yIHRoZSBtb3N0IGNvbW1vbiBpbmxpbmUgY29udGVu dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDI1 OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTcyNDM2MTA+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSB0aGUgY2hlY2sgb24gdGV4dCBjb250 ZW50IHRvIHRoZSBmcm9udC4KKworICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lu bGluZUxpbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lOjppc1Zpc3VhbGx5 RW1wdHkgY29uc3QpOgorCiAyMDE5LTExLTE1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5j b20+CiAKICAgICAgICAgW0xGQ11bSW52YWxpZGF0aW9uXSBSZXVzZSBGcmFtZVZpZXdMYXlvdXRD b250ZXh0OjptX2xheW91dFN0YXRlIGZvciBpbmNyZW1lbnRhbCBsYXlvdXQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuY3BwIGIv U291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKaW5k ZXggODFmYTI0MDMxYzI1NzhlYTMwYzQ0ZmNjMTBhODNmNGQ0YWI3YTRhNi4uY2Q3OTkyZGE5OTVl ODk2MzcyYTkwNjM5ODlkNTEzMmMwNWVjYjNjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKQEAgLTUwLDYgKzUwLDcg QEAgcHVibGljOgogICAgIGJvb2wgaXNCb3goKSBjb25zdCB7IHJldHVybiBtX2lubGluZUl0ZW0u aXNCb3goKTsgfQogICAgIGJvb2wgaXNDb250YWluZXJTdGFydCgpIGNvbnN0IHsgcmV0dXJuIG1f aW5saW5lSXRlbS5pc0NvbnRhaW5lclN0YXJ0KCk7IH0KICAgICBib29sIGlzQ29udGFpbmVyRW5k KCkgY29uc3QgeyByZXR1cm4gbV9pbmxpbmVJdGVtLmlzQ29udGFpbmVyRW5kKCk7IH0KKyAgICBi b29sIGlzRm9yY2VkTGluZUJyZWFrKCkgY29uc3QgeyByZXR1cm4gbV9pbmxpbmVJdGVtLmlzRm9y Y2VkTGluZUJyZWFrKCk7IH0KICAgICBJbmxpbmVJdGVtOjpUeXBlIHR5cGUoKSBjb25zdCB7IHJl dHVybiBtX2lubGluZUl0ZW0udHlwZSgpOyB9CiAKICAgICB2b2lkIHNldElzQ29sbGFwc2VkKCkg eyBtX2lzQ29sbGFwc2VkID0gdHJ1ZTsgfQpAQCAtMTkzLDYgKzE5NCwxMSBAQCBib29sIExpbmU6 OmlzVmlzdWFsbHlFbXB0eSgpIGNvbnN0CiAgICAgLy8gUmV0dXJuIHRydWUgZm9yIGVtcHR5IGlu bGluZSBjb250YWluZXJzIGxpa2UgPHNwYW4+PC9zcGFuPi4KICAgICBhdXRvJiBmb3JtYXR0aW5n Q29udGV4dCA9IHRoaXMtPmZvcm1hdHRpbmdDb250ZXh0KCk7CiAgICAgZm9yIChhdXRvJiBydW4g OiBtX2lubGluZUl0ZW1SdW5zKSB7CisgICAgICAgIGlmIChydW4tPmlzVGV4dCgpKSB7CisgICAg ICAgICAgICBpZiAoIXJ1bi0+aXNDb2xsYXBzZWRUb1plcm9BZHZhbmNlV2lkdGgoKSkKKyAgICAg ICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAg fQogICAgICAgICBpZiAocnVuLT5pc0NvbnRhaW5lclN0YXJ0KCkpIHsKICAgICAgICAgICAgIGlm ICghaXNJbmxpbmVDb250YWluZXJDb25zaWRlcmVkRW1wdHkoZm9ybWF0dGluZ0NvbnRleHQsIHJ1 bi0+bGF5b3V0Qm94KCkpKQogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTIwMCw3 ICsyMDYsOSBAQCBib29sIExpbmU6OmlzVmlzdWFsbHlFbXB0eSgpIGNvbnN0CiAgICAgICAgIH0K ICAgICAgICAgaWYgKHJ1bi0+aXNDb250YWluZXJFbmQoKSkKICAgICAgICAgICAgIGNvbnRpbnVl OwotICAgICAgICBpZiAocnVuLT5sYXlvdXRCb3goKS5lc3RhYmxpc2hlc0Zvcm1hdHRpbmdDb250 ZXh0KCkpIHsKKyAgICAgICAgaWYgKHJ1bi0+aXNCb3goKSkgeworICAgICAgICAgICAgaWYgKCFy dW4tPmxheW91dEJveCgpLmVzdGFibGlzaGVzRm9ybWF0dGluZ0NvbnRleHQoKSkKKyAgICAgICAg ICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgICAgICBBU1NFUlQocnVuLT5sYXlvdXRCb3go KS5pc0lubGluZUJsb2NrQm94KCkpOwogICAgICAgICAgICAgYXV0byYgYm94R2VvbWV0cnkgPSBm b3JtYXR0aW5nQ29udGV4dC5nZW9tZXRyeUZvckJveChydW4tPmxheW91dEJveCgpKTsKICAgICAg ICAgICAgIGlmICghYm94R2VvbWV0cnkud2lkdGgoKSkKQEAgLTIwOSw3ICsyMTcsNyBAQCBib29s IExpbmU6OmlzVmlzdWFsbHlFbXB0eSgpIGNvbnN0CiAgICAgICAgICAgICAgICAgcmV0dXJuIGZh bHNlOwogICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgIH0KLSAgICAgICAgaWYgKCFydW4t PmlzVGV4dCgpIHx8ICFydW4tPmlzQ29sbGFwc2VkVG9aZXJvQWR2YW5jZVdpZHRoKCkpCisgICAg ICAgIGlmIChydW4tPmlzRm9yY2VkTGluZUJyZWFrKCkpCiAgICAgICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgfQogICAgIHJldHVybiB0cnVlOwo=